IRC log for #evergreen, 2025-02-24

All times shown according to the server's local time.

Time	Nick	Message
07:21		redavis joined #evergreen
07:38		collum joined #evergreen
08:31		sandbergja joined #evergreen
08:39		mmorgan joined #evergreen
09:02		mmorgan1 joined #evergreen
09:17		dguarrac joined #evergreen
09:23		Dyrcona joined #evergreen
10:48		Christineb joined #evergreen
12:02		jihpringle joined #evergreen
12:37	Dyrcona	@decide rename branch or leave it alone
12:37	pinesol	Dyrcona: go with leave it alone
12:38	Dyrcona	pinesol: Coolio.
12:38	pinesol	Dyrcona: SYSTEM CONTROL RESTART OPEN SURF
12:49	csharp_	we have been seeing hold targeter failures since moving to 3.14.3 - the HoldTargeter.pm changes were causing the process to die off
12:50	csharp_	I created a patch that just reverses the "unless" logic and checks for truthiness of the variables before trying to use them https://git.evergreen-ils.org/?p=evergreen/pines.git;a=commit;h=fa4ee6c1c7493984b54afb858d546e812658337e
12:50	csharp_	probably a better way to do it but if others face the same issue, it might help
12:52	berick	csharp_: a suggestion, mixing \|\|'s with &&'s can be confusing to mentally parse. some parens may help.
12:52	csharp_	yeah, it's confusing anyway :-/
12:52	berick	csharp_: but more to the point, are you saying your patch fixed your issues or that you are going to test and see if it fixes the issues?
12:53	csharp_	I don't have a good 30K foot view of what the feature is doing so I was just trying to preserve what was there
12:53	berick	yeah i agree the existing code could be more clearly laid out
12:53	csharp_	yeah it's working for us
12:53	csharp_	targeter is trucking along
12:53	berick	interesting
12:54	berick	+1 to fixing the undef warnings for sure
12:54	csharp_	Hold processing exited with error: Exception: OpenSRF::DomainObject::oilsMethodException 2025-02-24T10:32:55 main /openils/bin/hold_targeter.pl:170 <500> *** Call to [open-ils.hold-targeter.target] failed for session
12:54	csharp_	+[1740411002.188431256213.66729653], thread trace [3]:
12:54	csharp_	Can't call method "current_copy" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/HoldTargeter.pm line 114.
12:54	csharp_	that was the message it was dying on
12:55	berick	ah yes that's def a bug.
12:55	csharp_	(for the logs for the logs)
12:55	csharp_	I can file the bug and I'll link to my monkey patch
12:55	berick	if you LP it, i'll add my $0.02
12:55	csharp_	yep
13:01	csharp_	berick: bug 2099920
13:01	pinesol	Launchpad bug 2099920 in Evergreen "Hold Targeter fails with undefined value errors" [High,New] https://launchpad.net/bugs/2099920
13:06		ejk joined #evergreen
13:18	berick	csharp_++
14:39		jonadab joined #evergreen
15:03	berick	@ana git remote add pines
15:03	pinesol	berick: Impeding to dearest
15:17		jihpringle joined #evergreen
15:36	berick	@isitdown https://bugs.launchpad.net/
15:36	pinesol	berick: http://images.cryhavok.org/d/1291-1/Computer+Rage.gif
15:36	berick	heh
15:36	berick	and... it's back
15:42	Dyrcona	That is definitely the proper response to @isitdown. :)
15:43	Dyrcona	Even better.....
15:43	Dyrcona	:)
15:53	pinesol	News from commits: LP2097009 OPAC thaw dates and expire dates not saving <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=05fa4a84f5acaacfb3f305ae739fe25bd185a834>
17:01		mmorgan left #evergreen
17:54	pinesol	News from commits: LP2098995: Add release note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a97bbdc701b55da599bd1bdfb77122af8fec6545>
17:54	pinesol	News from commits: LP2098995: Rename reporter's default lockfile <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=92413dd4157c53b80b04fbd8e90bb69231ef918e>
17:54	pinesol	News from commits: LP2098995: Delete reporter lockfile on exit <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=13f142e515d429c27d8f206bce52143270a7a24d>