| Time |
Nick |
Message |
| 07:16 |
|
collum joined #evergreen |
| 08:10 |
|
redavis joined #evergreen |
| 08:23 |
pinesol |
News from commits: LP#2097622: stamp upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0b1b70cc0d2521ad5308e05ea76bbd173063ab4d> |
| 08:23 |
pinesol |
News from commits: LP#2097622: prevent hold reset entries from blocking hold aging and user merges/purges <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0eabef80d3f6cc9aa080377245105aba1a9d82c7> |
| 08:48 |
|
mmorgan joined #evergreen |
| 09:01 |
|
Dyrcona joined #evergreen |
| 09:12 |
Dyrcona |
How does one make the photo url field go away in patron registration/edit? I set the show, suggest, and required settings all to false, but it still show up with Suggested or All fields. |
| 09:13 |
Dyrcona |
I hope I don't have to hack the JavaScript, but that's what it looks like. |
| 09:16 |
Dyrcona |
I reloaded services, restarted apache, cleared my cache in the browser, and now it shows up for all 3! The settings are meaningless. |
| 09:18 |
|
jvwoolf joined #evergreen |
| 09:21 |
* Dyrcona |
grumbles. |
| 09:24 |
Dyrcona |
I suppose that I could delete the field from our IDL. |
| 09:29 |
Dyrcona |
I see: regctl.js just looks if the setting exists. It doesn't care about the value. So there's no way to actually hide a field. |
| 09:35 |
Dyrcona |
I suppose I'll have to hack regctl.js to return 0 for the photo_url field. I think this warrants Lp bug. |
| 09:43 |
Dyrcona |
Well that apparently doesn't work, either. |
| 09:44 |
Dyrcona |
I get plenty of errors... Maybe I should actually build the AngularJS client rather than just copying the js file? |
| 09:47 |
Dyrcona |
configure: error: Could not find osrf_config. # Uh, no. OpenSRF is installed. |
| 09:48 |
Dyrcona |
Guess I had to run make before make install.... |
| 09:48 |
* Dyrcona |
wonders why autoconf decided to reconfigure. |
| 09:49 |
Dyrcona |
autotools-- |
| 09:54 |
Dyrcona |
Nope. Still doesn't work. I guess the show_field's comments lie, and returning false gives a default visibility. |
| 09:55 |
Dyrcona |
All right. I'll try setting the visibility to 0, but I don't think that's gonna work, either. |
| 09:56 |
|
mmorgan joined #evergreen |
| 10:00 |
Dyrcona |
Nope. Photo URL still shows up. |
| 10:03 |
Dyrcona |
OK. It helps to the field key correct. It includes the object's class id: au.photo_url. |
| 10:03 |
Dyrcona |
This still needs a LP bug. |
| 10:11 |
|
Christineb joined #evergreen |
| 10:16 |
Dyrcona |
Lp 2098386 |
| 10:16 |
pinesol |
Launchpad bug 2098386 in Evergreen "Cannot Hide Patron Registration/Edit Fields without Hackery" [Undecided,New] https://launchpad.net/bugs/2098386 |
| 10:22 |
Dyrcona |
Hmm... I should write a patch for that bug and use that instead of the hack I just made. |
| 10:24 |
Dyrcona |
I suppose the experimental Angular code will need a patch for that, too. |
| 10:29 |
Dyrcona |
Think it will require some refactoring of the function to do it well. |
| 10:29 |
Dyrcona |
Not gonna do it today. |
| 10:30 |
Dyrcona |
It will need to check if the field is required by default as well and not allow the user to override that. |
| 11:27 |
Dyrcona |
Oh! After getting the field key correct, just copying regctl.js into place works. |
| 11:37 |
|
jvwoolf joined #evergreen |
| 11:50 |
|
sandbergja joined #evergreen |
| 11:54 |
|
jihpringle joined #evergreen |
| 12:17 |
|
sandbergja joined #evergreen |
| 12:27 |
Dyrcona |
jihpringle++ |
| 12:28 |
Dyrcona |
I "knew" that there was already a bug for that, but didn't bother looking. |
| 12:29 |
Dyrcona |
Today me thinks that the patch from the older bug is too simple. |
| 12:35 |
Dyrcona |
And past me thinks the situation is more complex than present me realizes. |
| 12:48 |
|
redavis joined #evergreen |
| 13:46 |
|
jvwoolf left #evergreen |
| 13:46 |
Dyrcona |
Hmm. Looks like the org settings lookup is failing for me, or it's not going up the tree. |
| 13:47 |
Dyrcona |
$scope.org_settings['ui.patron.edit.au.photo_url.show'] comes up null when I've set the setting at the root of the org tree. |
| 13:49 |
Dyrcona |
I set it false, and the code jumps to the field_visibility being undefined.... I would say a.bellenir's patch doesn't work, but the settings lookup appears to be not working. Unless I need to empty more than the cache for this. |
| 13:49 |
Dyrcona |
Oh, right. I probably have to log out don't I. |
| 13:51 |
Dyrcona |
Whew! That was it. I think I just need to add some code to make sure that DB-required fields cannot be hidden. |
| 13:52 |
redavis |
Dyrcona++ |
| 14:05 |
Dyrcona |
Yeah, that works. It's a shame it took this long for this to get really looked at. |
| 14:05 |
Dyrcona |
I'll have to check the experimental Angular Circ code, next. |
| 14:18 |
Dyrcona |
I'll push what I've got now. I don't thinks these 2 commits will change much. |
| 14:19 |
Dyrcona |
Apparently I don't types either. :) |
| 14:24 |
Dyrcona |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1815950-hide-fields-patron-registration-edit |
| 14:25 |
mmorgan |
Dyrcona++ |
| 14:34 |
Dyrcona |
Ha! Almost exactly 6 years later.... |
| 15:23 |
Dyrcona |
Nah. The Angular Circ client is something else. I'm not including that in this branch. |
| 16:04 |
Dyrcona |
Anyone seen something like this before: XMLENT XML Parse Error: mismatched tag at line 12: parsing /openils/var/web/reports/6150/134493/299401/report-data.html |
| 16:05 |
Dyrcona |
It's from the syslog. |
| 16:05 |
Dyrcona |
Trying to access that report results in a 500 internal server error. |
| 16:06 |
Dyrcona |
Oh, I bet it's the <meta> tag that isn't closed for XML, but would be OK at HTML. |
| 16:08 |
Dyrcona |
Yeah, and all of the report output is like that. |
| 16:11 |
|
jihpringle joined #evergreen |
| 16:59 |
|
mmorgan joined #evergreen |
| 17:00 |
|
mmorgan left #evergreen |
| 17:41 |
|
jihpringle joined #evergreen |
| 17:51 |
|
jihpringle joined #evergreen |
| 18:23 |
|
stephengwills left #evergreen |
| 19:49 |
|
jihpringle joined #evergreen |
