| Time |
Nick |
Message |
| 01:39 |
|
rlefaive joined #evergreen |
| 04:42 |
|
rlefaive joined #evergreen |
| 06:43 |
|
rlefaive joined #evergreen |
| 07:29 |
|
kworstell-isl joined #evergreen |
| 07:47 |
|
sleary joined #evergreen |
| 07:48 |
|
redavis joined #evergreen |
| 07:58 |
|
cbrown-isl joined #evergreen |
| 08:16 |
|
mantis1 joined #evergreen |
| 08:25 |
|
mantis1 joined #evergreen |
| 08:41 |
|
collum joined #evergreen |
| 09:05 |
|
Dyrcona joined #evergreen |
| 09:21 |
|
mmorgan joined #evergreen |
| 09:40 |
|
rlefaive joined #evergreen |
| 09:48 |
|
cbrown-isl joined #evergreen |
| 09:59 |
|
sleary joined #evergreen |
| 10:38 |
sleary |
Has Git taken the day off? |
| 10:40 |
JBoyer |
I was just able to pull from git.evergreen-ils.org |
| 10:40 |
mmorgan |
I can't reach the website, but was able to earlier this morning. |
| 10:44 |
Dyrcona |
out of memory for Apache. I'll have it back up in a few ticks. |
| 10:45 |
sleary |
Dyrcona++ |
| 10:45 |
Dyrcona |
I'm going to reboot it while I'm at it. |
| 10:45 |
Bmagic |
Dyrcona++ |
| 10:45 |
Bmagic |
darn it, just when I needed it to prepare for a meeting |
| 10:46 |
mmorgan |
Dyrcona++ |
| 10:46 |
JBoyer |
oops, forgot to check the frontend. |
| 10:46 |
Dyrcona |
Bmagic: Only takes a couple of minutes. |
| 10:46 |
JBoyer |
Dyrcona++ |
| 10:49 |
Dyrcona |
It's back. |
| 10:52 |
Dyrcona |
@blame claudebot |
| 10:52 |
pinesol |
Dyrcona: claudebot was monkeying around too much on the prod servers! |
| 10:59 |
pinesol |
News from commits: LP#2063496 Patron Search Profile Dropdown Partially Obscured <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e70dad7fd67ba2120fa9f114775dd1558a741a7d> |
| 10:59 |
pinesol |
News from commits: LP#2065195 Patron Search: Enter key no longer submits form <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=155251587e0a185f262f4c81cd9d3de9eb07ef6c> |
| 11:00 |
|
cbrown-isl joined #evergreen |
| 11:39 |
|
cbrown-isl joined #evergreen |
| 11:42 |
|
cbrown_isl joined #evergreen |
| 11:45 |
|
cbrown-isl joined #evergreen |
| 11:47 |
|
jihpringle joined #evergreen |
| 12:06 |
|
Christineb joined #evergreen |
| 12:35 |
|
collum joined #evergreen |
| 12:49 |
|
rlefaive joined #evergreen |
| 12:53 |
|
jihpringle joined #evergreen |
| 13:17 |
JBoyer |
Stompro, do you have examples of RS LookupUser requests that have a username? Is the AuthenticationInputType always barcode that you've seen or can it be something else? |
| 13:18 |
JBoyer |
(I'm looking into the username != barcode = no login thing) |
| 13:20 |
Stompro |
JBoyer, the issue was that if a evergreen user had changed their username to not equal their barcode, then the reshare lookupuser request was failing. |
| 13:20 |
Stompro |
We were not trying to support username based logins, at least not at this time. |
| 13:20 |
Stompro |
Just have it not break when a barcode is used. |
| 13:21 |
Dyrcona |
JBoyer || Stompro: That's because NCIPServer only looks up users by barcode at the moment. It would be not exactly trivial to add usrname lookup, but not exactly had. |
| 13:21 |
JBoyer |
Ah, ok. |
| 13:21 |
Stompro |
Dyrcona's change fixed it for us. |
| 13:22 |
JBoyer |
Dyrcona++ It sounded like that barcode -> identifier change was enough, but I may have misunderstood what else needs to change. |
| 13:22 |
Dyrcona |
FTL: My change fixed the authentication bit. It would still fail to lookup a user by usrname. |
| 13:22 |
Stompro |
Historically MNLINK in MN has never supported anything other than barcodes... because they used the barcode prefix to know which system to send the sip2 auth request to. |
| 13:23 |
Stompro |
It doesn't work like that with Reshare, users have to select their library system at logon. So we haven't promised username logins to anyone as far as I know. |
| 13:24 |
Dyrcona |
The user lookup after authentication uses open-ils.actor.user.fleshed.retrieve_by_barcode. |
| 13:27 |
* Dyrcona |
looks at that function again. It might be easier than I think to fix. |
| 13:30 |
Dyrcona |
We might be able to use open-ils.storage.actor.user.crazy_search and then retrieve the user, not exactly trivial... |
| 13:32 |
JBoyer |
I was going to see if there's something we could use and got distracted, if nothing else I suppose there may be a .direct. storage method or maybe a pcrud call that wouldn't be too onerous. |
| 13:32 |
* JBoyer |
says, having not looked into either of those yet |
| 13:34 |
Dyrcona |
A PCRUD search could work, but I wonder if we'd have to do two: 1 for barcode and 1 for usrname. A CStore JSON query could do it in 1 go, but I'm trying to avoid CStore in NCIPServer. |
| 13:35 |
* Dyrcona |
checks to see if that has succeeded. |
| 13:35 |
Dyrcona |
I suppose storage should be avoided for the same reasons as cstore.... |
| 13:36 |
Dyrcona |
I wanted it to be possible to run NCIPServer on a machine that doesn't have direct access to unprotected services. |
| 13:38 |
JBoyer |
Hah, here's a hack; open-ils.actor.username.exists returns the id of the undeleted user with the given usrname. |
| 13:39 |
JBoyer |
kind of roundabout, but gets the job done eventually perhaps. |
| 13:40 |
Dyrcona |
So, we could do that first, and if nothing comes back, do a PCRUD search for the barcode, then retrieve the user by id. |
| 13:43 |
JBoyer |
Well, if we do that first we could just fallback to retrieve_by_barcode because it'll either work or there's no one here by that identifier. |
| 13:43 |
Dyrcona |
True. There's also open-ils.actor.barcode.exists for the sake of symmetry. :) |
| 13:44 |
JBoyer |
oh, I think I misunderstood. You mean if there's a match lookup their card number and then use by barcode all the time? |
| 13:44 |
Dyrcona |
No. I meant what I think you understood: look the id up by username, then retrive by id, if the username failed, look the id up by barcode, then retrieve. |
| 13:45 |
JBoyer |
ok, I thnk I |
| 13:45 |
JBoyer |
get it now. |
| 13:45 |
Dyrcona |
But, I think I like where you're going: look the id up by username, if found retrieve by id, if not round retrieve the user by barcode. It's less to change, and could be done by just adding a function for the username part. |
| 13:47 |
JBoyer |
+1, by our powers combined, etc. |
| 13:47 |
Dyrcona |
heh. |
| 13:49 |
Dyrcona |
We already have a wrapper for open-ils.actor.user.fleshed.retrieve in NCIPServer. |
| 13:50 |
Dyrcona |
So basically, open-ils.actor.username.exists. if (id) $self->retrieve_user_by_id($id); else ... what we do now. |
| 13:55 |
Dyrcona |
I think I made a note to open Lp for this last week but never got around to it. |
| 14:04 |
|
kworstell_isl joined #evergreen |
| 14:19 |
|
terranm joined #evergreen |
| 14:20 |
terranm |
Claiming 1409 |
| 14:59 |
sleary |
the acq branch that went in yesterday introduced a lot of lint errors. :( Linting anything on main is going to be difficult until one of us cleans that up. (I am not able to tackle it today, alas.) |
| 15:00 |
pinesol |
News from commits: LP#1949109 Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f947b23f96a2246599f1144d3aa8b80e6a9c3e39> |
| 15:00 |
pinesol |
News from commits: LP#1949109: Release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ca7dc46254e3373dfb9b4040f325ca4af8b49ceb> |
| 15:00 |
pinesol |
News from commits: LP#1949109: Make Shelving Location Groups optional <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=383bd622abf2a60f69a7f4b9ef0a6eee2b284536> |
| 15:00 |
pinesol |
News from commits: LP#1949109: Advanced filter UI improvement <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e707f81b85b1a6e167459441bbca2b209055cc65> |
| 15:00 |
pinesol |
News from commits: LP#1949109: Library and Location groups <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=90ef6bbedd27a02ed91ea5c77832f2a8e8d85e2e> |
| 15:17 |
|
mantis1 left #evergreen |
| 15:30 |
sleary |
Bmagic thanks for writing up the results of our testing! |
| 15:35 |
Bmagic |
sleary++ # thanks for all your time today |
| 15:35 |
Bmagic |
shula++ # thanks for all your time today |
| 15:45 |
eeevil |
terranm++ |
| 15:48 |
eeevil |
hrm... so, I'll commit to doing as much as I can to lint main during freeze (I am not confident enough to say I'll /successfully fix/ all linting issues...) |
| 15:50 |
eeevil |
however, I /did/ fold an `ng lint --fix` run into the main ACQ commit in the branch I merged yesterday. It was the one from Bmagic, f57c3301dc6eb3cb6f06f9225add5456046ee2ac |
| 15:52 |
Bmagic |
weird, git doesn't know that hash |
| 15:52 |
eeevil |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=f57c3301dc6eb3cb6f06f9225add5456046ee2ac |
| 15:53 |
eeevil |
it's not in main |
| 15:53 |
Bmagic |
gotcha, yes, I remember running that and pushing it to working |
| 15:53 |
eeevil |
it's squashed into the main acq commit |
| 15:53 |
Bmagic |
and that is causing an issue? |
| 15:54 |
eeevil |
I would think that would /fix/ lint issues |
| 15:54 |
Bmagic |
me too :) |
| 15:55 |
Bmagic |
why would the linter convert this: @Input() public hideFooter: boolean = false; to: @Input() public hideFooter = false; |
| 15:55 |
Bmagic |
and not convert all of the other ones above and below those lines? |
| 15:55 |
eeevil |
and looking at the first file in the lint commit, core.module.ts, the effects of your commit are represented in main |
| 15:56 |
eeevil |
Bmagic: see, I said the same thing to myself. "why is it stripping explicit types?" |
| 15:57 |
eeevil |
I got an answer that easily derived types should be omitted. |
| 15:57 |
Bmagic |
ok then, I guess that's "OK" |
| 15:57 |
eeevil |
but I haven't been involved in the design of the linting rules at all. so *shrug* |
| 15:58 |
eeevil |
I don't personally care what rules we follow, as long as running `ng lint --fix` actually does what we think we told it to |
| 15:58 |
sleary |
I do not love that rule and would not mind at all if we took it out. (I did not get involved much in the syntax rules, either. Just the accessibility ones.) |
| 15:59 |
eeevil |
(I mean, I have some Opinions(tm), such as not being a fan of single-line cuddling of {}s around standalone if blocks. but that's just, like, my opinion, man) |
| 16:00 |
Dyrcona |
:) |
| 16:01 |
sleary |
I have looked at bug 1895695 a couple of times but I just don't feel qualified to review Perl changes, alas. |
| 16:01 |
pinesol |
Launchpad bug 1895695 in Evergreen "Wishlist: add a link tracker for the course materials module" [Wishlist,New] https://launchpad.net/bugs/1895695 - Assigned to Terran McCanna (tmccanna) |
| 16:01 |
sleary |
... and I totally missed that terranm is looking at it! |
| 16:04 |
mmorgan |
Claiming 1410 |
| 16:30 |
pinesol |
News from commits: LP2035396 - Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=dafb8c6ef0ca1039e9bde0754a207ca8c22c6222> |
| 16:30 |
pinesol |
News from commits: LP#2035396 Default and SMS Phone Example and Regex <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=09bd1b72175d466dad27df71e8cda909f615473f> |
| 17:03 |
Dyrcona |
It's that time, and I still didn't manage to open that NCIPServer bug on Lp.... |
| 17:03 |
|
mmorgan left #evergreen |
| 17:04 |
Dyrcona |
Think I'll do it anyway. |
| 19:04 |
|
book` joined #evergreen |
| 19:13 |
|
sleary joined #evergreen |
| 19:17 |
|
sleary_ joined #evergreen |
| 20:56 |
|
sleary joined #evergreen |
| 22:31 |
pinesol |
News from commits: LP1615781 Follow-up: Set compiler target to ES2021 <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=41fc6f4a49d6b30a9bedb3181aef13668bfaafb0> |
| 22:31 |
pinesol |
News from commits: LP1615781 Correct indentation in holdings editor <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=248d596515824c107bfd81470a7531ee377a8bc6> |
| 22:31 |
pinesol |
News from commits: LP1615781 remove obsolete flex inputs from columns <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9f3bb71feb86a490f62c09bf8bf9bf3e151346e1> |
| 22:31 |
pinesol |
News from commits: LP1615781 eg-grid table markup and IDL-based styles <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3e73c033a56352cb8371667f9d1c4634260bfab5> |
| 22:52 |
sleary |
Bmagic++ |
| 23:01 |
pinesol |
News from commits: LP2017034 Skip nav for Angular staff interfaces <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b3bde85f4de3cf45d7544f2f4a5e61b21f6beef5> |
| 23:01 |
pinesol |
News from commits: LP2017034 Skip nav for AngularJS staff interfaces <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=dbbdbb6625a01f023665c610420269bb10a9b914> |
