| Time |
Nick |
Message |
| 07:19 |
|
collum joined #evergreen |
| 07:51 |
|
redavis joined #evergreen |
| 07:59 |
|
BDorsey joined #evergreen |
| 08:37 |
|
sandbergja joined #evergreen |
| 08:46 |
|
dguarrac joined #evergreen |
| 08:49 |
|
mmorgan joined #evergreen |
| 09:02 |
|
mmorgan1 joined #evergreen |
| 09:03 |
|
kmlussier joined #evergreen |
| 09:04 |
|
kmlussier1 joined #evergreen |
| 09:17 |
|
Dyrcona joined #evergreen |
| 09:21 |
|
smayo joined #evergreen |
| 09:28 |
|
NIngalls joined #evergreen |
| 09:29 |
|
BDorsey joined #evergreen |
| 10:28 |
|
kmlussier joined #evergreen |
| 10:32 |
|
mmorgan1 left #evergreen |
| 10:33 |
|
mmorgan1 joined #evergreen |
| 10:45 |
|
sleary joined #evergreen |
| 10:52 |
mmorgan1 |
comcast-- |
| 11:02 |
|
briank joined #evergreen |
| 11:12 |
kmlussier |
@karma comcast |
| 11:12 |
pinesol |
kmlussier: Karma for "comcast" has been increased 0 times and decreased 1 time for a total karma of -1. |
| 11:13 |
sleary |
that seems generous |
| 11:21 |
kmlussier |
sleary: Only because we wipe out karma every year. It's all-time karma score up until the last EG conference is -91. |
| 11:22 |
kmlussier |
comcast-- # Let's push it past 100 by the next conference. |
| 11:22 |
Bmagic |
comcast-- |
| 11:22 |
sleary |
comcast-- |
| 11:23 |
smayo |
comcast-- |
| 11:23 |
Bmagic |
and then find a way to get pinesol to post on comcast's feedback form |
| 11:23 |
sleary |
optimum-- # while we're disparaging cable companies, mine deserves some vitriol |
| 11:24 |
abneiman |
jeffdavis: have you had a chance to review bug 2038472? would be nice to sneak that into 3.12-rc if possible |
| 11:24 |
pinesol |
Launchpad bug 2038472 in Evergreen 3.12 "Search suggestions can make searches very slow in 3.11" [High,Confirmed] https://launchpad.net/bugs/2038472 |
| 11:38 |
csharp_ |
comcast-- |
| 11:39 |
kmlussier |
@karma |
| 11:39 |
pinesol |
kmlussier: Highest karma: "Dyrcona" (120), "Bmagic" (100), "berick" (75), "mmorgan" (68), and "sandbergja" (67). Lowest karma: "comcast" (-6), "typos" (-5), "oclc" (-3), "ubuntu" (-2), and "<<--" (-1). You (kmlussier) are ranked 16 out of 114. |
| 11:39 |
csharp_ |
@who is trying to sneak commits into 3.12-rc? |
| 11:39 |
pinesol |
JBoyer is trying to sneak commits into 3.12-rc. |
| 11:40 |
berick |
@who told [band] to play at the 3.12 release party? |
| 11:40 |
pinesol |
told Fleshing Children to play at the 3.12 release party. |
| 11:40 |
berick |
you crazy |
| 11:40 |
csharp_ |
speaking of 3.12 - lots of OPAC changes (yay!) means nearly every PINES customization is causing merge conflicts (boo!) |
| 11:40 |
csharp_ |
aw girl |
| 11:42 |
csharp_ |
more conflict pain is directly proportional to the number of OPAC accessibility improvements, eh sleary ? |
| 11:43 |
csharp_ |
megacommit: c76e4ad6c2aba1a918992659686bb6b50bfea79c comes to mind |
| 11:43 |
csharp_ |
bug 2000482 |
| 11:43 |
pinesol |
Launchpad bug 2000482 in Evergreen "Angular 15 + Bootstrap 5 Upgrade" [Medium,Fix released] https://launchpad.net/bugs/2000482 |
| 11:44 |
csharp_ |
gonna hafta talk to terranm about it, but she's away today |
| 11:44 |
csharp_ |
@monologue |
| 11:44 |
pinesol |
csharp_: Your current monologue is at least 7 lines long. |
| 11:45 |
Bmagic |
"at least" - lol |
| 11:45 |
|
jihpringle joined #evergreen |
| 11:46 |
berick |
2000482 worries me to. about to start our 3.11 build. |
| 11:53 |
sleary |
csharp_ alas, lots of nitpicky changes to the HTML are the name of my game |
| 11:58 |
|
sleary_ joined #evergreen |
| 12:01 |
csharp_ |
sleary++ |
| 12:01 |
sleary_ |
I think I left this somewhere in the comments on that bug, but I made a spreadsheet of the Bootstrap class changes: https://docs.google.com/spreadsheets/d/1NFx09zghDW_sGcbPnM8iED0_7S2XyISwCnWNuOMhLK4/edit |
| 12:01 |
|
Christineb joined #evergreen |
| 12:02 |
JBoyer |
And I would have gotten away with it if it weren't for you meggling kids! |
| 12:02 |
berick |
sleary_++ |
| 12:02 |
JBoyer |
meggling. what even. |
| 12:03 |
sleary_ |
the big things to watch for: input groups, left/right changing to start/end on margins and padding, and buttons that are direct children of a .row without being in a .col-* suddenly turning into block level (i.e. 100% width) elements. (Put them inside a .col.) |
| 12:36 |
|
sleary joined #evergreen |
| 12:44 |
|
sandbergja joined #evergreen |
| 12:48 |
sandbergja |
I spent an embarassing amount of time troubleshooting why every request I made to the open-ils.serials service returned an error. Fun fact: the service is actually called open-ils-serial. |
| 12:49 |
sandbergja |
^ open-ils.serial, rather |
| 12:52 |
|
mantis1 joined #evergreen |
| 13:03 |
jeffdavis |
abneiman: thanks for the reminder about the DYM-related search slowness bug - our testing results weren't as definitive as I would like but I believe the fix works, I'll make a signoff branch and update 2038472 |
| 13:04 |
jeffdavis |
I guess there's already a signoff branch, I'll just add a signoff via LP |
| 13:07 |
|
Stompro joined #evergreen |
| 13:08 |
abneiman |
jeffdavis++ |
| 13:08 |
abneiman |
thank you! |
| 13:15 |
jeffdavis |
More specifically, our test environment remained somewhat slow after applying the fix, but I believe the remaining slowness was for other reasons. We decided not to enable DYM so we effectively stopped testing the fix at a certain point; it's possible that it introduces other issues, but no point in delaying the fix over such hypotheticals. |
| 13:16 |
jeffdavis |
"other reasons" = slower hardware + that unrelated bug that required disabling a PG "optimization" |
| 13:41 |
Dyrcona |
jeffdavis: I have not experienced the issue that "requires" disabling jit. |
| 13:42 |
Dyrcona |
I'm using Pg 15 for quite a bit of testing. Of course, the VPN to where that server is just went down, so..... |
| 13:42 |
jeffdavis |
required it on our test server, that is - we haven't seen it in production |
| 13:43 |
Dyrcona |
I was in the middle of installing updates.... I'll have to check when I get access again. I might have disabled JIT after you reported the issue, but I also wanted to test your queries with JIT enabled. |
| 13:44 |
pinesol |
News from commits: LP#2038472: stamp DB update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=10527ec78952a27d447f675a93d13e2846fa7ae6> |
| 13:44 |
pinesol |
News from commits: LP#2038472: Revive DYM optimizations <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7f72e22bc23ae887fefd98074a7415e852fcb4c0> |
| 13:44 |
Dyrcona |
I knew that I should have just started my test program in a tmux session and installed updates after. |
| 13:45 |
Dyrcona |
The test was not related to JIT, but to checking in and deleting copies from a spreadsheet. |
| 13:51 |
Dyrcona |
VPN is definitely down. Wonder if the site also lost Internet? |
| 13:53 |
Dyrcona |
I suppose I could test the changes to command line options on a local vm. |
| 14:11 |
|
jihpringle joined #evergreen |
| 14:12 |
Dyrcona |
Well, that looks like it will work. Guess I can test it on the training server. |
| 14:16 |
csharp_ |
@decide open-ils.serial or open-ils.cereal |
| 14:16 |
pinesol |
csharp_: go with open-ils.cereal |
| 14:16 |
csharp_ |
a nutritious part of this complete breakfast! |
| 14:18 |
Dyrcona |
:) |
| 14:22 |
|
Rogan joined #evergreen |
| 14:22 |
Dyrcona |
This is a general question though probably more applicable to JBoyer and/or Bmagic. I want to add libspreadsheet-read-perl to an Evergreen instance built from Ansible. It looks like I just need to add two lines: |
| 14:23 |
Dyrcona |
-name: Install libspreadsheet-read-perl |
| 14:23 |
Dyrcona |
apt: libspreadsheet-read-perl |
| 14:24 |
Dyrcona |
csharp_: open-isl.cereal, The Breakfast of Librarians! |
| 14:25 |
csharp_ |
@dessert add open-ils.cereal |
| 14:25 |
pinesol |
csharp_: The operation succeeded. Dessert #67 added. |
| 14:25 |
Dyrcona |
:) |
| 14:26 |
Dyrcona |
I suppose the follow up question is where do I want to add this: Evergreen prerequisites, before or after Evergreen is installed? Probably after. |
| 14:26 |
Bmagic |
Dyrcona: that looks right |
| 14:26 |
Bmagic |
and yes, I'd add it after Evergreen performed it's make installation omnibus |
| 14:26 |
Dyrcona |
Bmagic: I think I'll add right after the Evergreen installation, so if we ever have to rebuild the utility VM it will be there. |
| 14:27 |
Dyrcona |
Bmagic++ |
| 14:29 |
Dyrcona |
Hm. Doesn't look like we're installing fop or other prereqs for the notices. Maybe I'm looking the wrong file? |
| 14:29 |
Bmagic |
probably evergreen_restart_services |
| 14:30 |
Dyrcona |
Yeah. It's there. I should put this near that. It's a similar sort of thing. |
| 14:32 |
JBoyer |
Dyrcona, I think it may need to be apt: on one line, and then name: libspreadsheet-read-perl indented under it. |
| 14:32 |
JBoyer |
(I'd probably also use the pkg: or pakage: alias for name because it's more explicit what that line is doing) |
| 14:33 |
Dyrcona |
OK. Also, the file Bmagic mentions uses package: .... and present: ... Does that install it if it is missing or just check if it is there? |
| 14:33 |
Bmagic |
installs it if it's missing |
| 14:33 |
Dyrcona |
JBoyer++ I think you answered my question while I was typiing. |
| 14:33 |
JBoyer |
the default is state: present, though I do like to always use it. this will help: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_module.html |
| 14:34 |
Bmagic |
and https://docs.ansible.com/ansible/latest/collections/ansible/builtin/package_module.html#ansible-collections-ansible-builtin-package-module |
| 14:36 |
Dyrcona |
Cool. Thanks to both of you. I basically copied what's being done for fop, etc. |
| 14:51 |
|
jihpringle joined #evergreen |
| 14:58 |
Dyrcona |
There's probably a better way to handle Evergreen credentials, but if they're stored on the server, certain others will be able to see them anyway. |
| 15:00 |
|
kmlussier1 joined #evergreen |
| 15:07 |
jeffdavis |
JBoyer: wondering if you're able to take a look at my follow-up commit for bug 1999823 in time for 3.12 RC? It changes a lot of lines of code but always the same changes (renaming C funcs as suggested). We've been running all those fixes for awhile, no problems so far. |
| 15:07 |
pinesol |
Launchpad bug 1999823 in OpenSRF "Name collision causes apache gateway modules to fail when mod_shib is installed" [Medium,Confirmed] https://launchpad.net/bugs/1999823 |
| 15:11 |
JBoyer |
I doubt it'll make 3.12 currently because it would require a not-yet-released OpenSRF branch but I can check into it. |
| 15:12 |
Dyrcona |
Ah, and here I was gonna bug JBoyer with an Aspen thing. :) |
| 15:12 |
Dyrcona |
https://github.com/mdnoble73/aspen-discovery/compare/23.12.00...Dyrcona:aspen-discovery:evergreen-opac-renewals |
| 15:14 |
pinesol |
News from commits: LP#2044051: fix item alerts dialog in various interfaces <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=60c49db28d0bd0adb635b9ad470e775f2968b441> |
| 15:14 |
pinesol |
News from commits: LP2044273: Assume authoritative PCRUD mode <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3b94955e64139c1ee1fc552a5985c8b6d067200b> |
| 15:14 |
pinesol |
News from commits: LP2044273 Store use-authoritative as Login Session Item <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=42889a1f91e5604f834cdc9cccfefc4a391cd4f4> |
| 15:14 |
JBoyer |
Since that's Mark's personal account the most I could do is say "yeah, that looks good" or similar. I can try to find time to do that though, because I can tell just by looking that the lines being removed are probably no good. |
| 15:20 |
Dyrcona |
Is there a more official repository for Aspen? |
| 15:21 |
Dyrcona |
yeah, the lines removed would break the renewal attempt if they're not commented out. I'm 99% sure the opac_renewal option is correct. I've just never done it through the gateways before. |
| 16:07 |
JBoyer |
Mark's repo is as official as anything is for Aspen. |
| 16:16 |
JBoyer |
And I deeply dislike any pattern ends up resulting in a do_everything() method that has to puzzle out how to perform the function you actually called. I'm not actually sure what you're supposed to send that API, I *think* it may actually be a circ object but can't wrap my head around that yet today. |
| 16:17 |
Dyrcona |
JBoyer: No, you send it a hash of options. It is a do_everything API for the most part: checkout, checkin, renewal, all share similar options. |
| 16:17 |
Dyrcona |
Anyway, Mark approved and merged the commit to 23.12.00. |
| 16:19 |
JBoyer |
Dyrcona++ |
| 16:21 |
JBoyer |
and jeffdavis, I'm told that an OpenSRF 3.3.0 (or similar) release may appear yet this week since that'll be required for that shibboleth fix to make it into 3.12. (And will beceom the minimum required OSRF installation) |
| 16:21 |
JBoyer |
So that patch should make it in soon. |
| 16:22 |
Dyrcona |
jeffdavis++ JBoyer++ |
| 16:22 |
Dyrcona |
I think I intended to look at that bug but other stuff came up. |
| 16:22 |
Dyrcona |
The Shibboleth bug that is. |
| 16:22 |
Dyrcona |
Swimming pools and single sign on. |
| 16:26 |
jeffdavis |
That would be great! |
| 16:41 |
Dyrcona |
Hmmm. I've been adding a couple of functions to my Perl code that uses Cronscript.pm and I think those functions or variations of them may already exist in the TestUtil version of Cronscript. I'll have to check tomorrow. |
| 16:41 |
Dyrcona |
I was just thinking that I should add these functions to a Perl module that I can use at runtime. |
| 16:42 |
Dyrcona |
no, the functions in TestUtils are different, but still useful along the same lines. |
| 16:43 |
Dyrcona |
My function is basically a combination of TestUtils::find_or_register_workstation, plus a login. |
| 16:46 |
Dyrcona |
All right. That's enough for today. Catch everyone again on Wednesday. |
| 16:58 |
|
mantis1 left #evergreen |
| 17:05 |
|
mmorgan left #evergreen |
| 17:07 |
|
jihpringle joined #evergreen |
| 17:30 |
kmlussier1 |
@coin |
| 17:30 |
pinesol |
kmlussier1: tails |
| 18:07 |
|
Rogan joined #evergreen |
| 18:12 |
|
kmlussier1 left #evergreen |
| 19:37 |
|
jihpringle joined #evergreen |
