| Time |
Nick |
Message |
| 07:29 |
|
kworstell-isl joined #evergreen |
| 07:43 |
|
Christineb joined #evergreen |
| 07:52 |
|
BDorsey joined #evergreen |
| 08:24 |
|
rfrasur joined #evergreen |
| 09:07 |
|
Dyrcona joined #evergreen |
| 09:23 |
|
tlittle joined #evergreen |
| 09:27 |
tlittle |
Good morning all. I'm looking at bug 1995418 and I think I found the problem in item-location-select.component.ts. If you don't explicitly do a [loadAsync]=false when you reference the selector, the dropdown doesn't dropdown, which tracks with the comment on line 71. But...why wouldn't we want loadAsync to default to false in the first place? |
| 09:27 |
tlittle |
Wouldn't we always want it to be clickable, with non-clickable being the outlier? |
| 09:27 |
pinesol |
Launchpad bug 1995418 in Evergreen "Angular Shelving Location selector broken in multiple interfaces" [High,Confirmed] https://launchpad.net/bugs/1995418 |
| 09:27 |
tlittle |
Obviously I think I can fix that pretty easily, but I guess I want to be sure I'm not missing some reason it's like that in the first place |
| 09:29 |
Dyrcona |
Is loadAsync set to true or is it a default and it isn't explicitly set on the page/widget in question? |
| 09:30 |
tlittle |
It's an input, with the default as true, and isn't explicitly set in the pages |
| 09:32 |
Dyrcona |
I guess it doesn't matter if it's a default or not. You can always share a branch and see what others think. I think it's OK, but I don't know the web stuff as well as I do the back end. |
| 09:33 |
Dyrcona |
Async load is usually a responsiveness thing, but in this case it seems like the opposite is true. |
| 09:33 |
tlittle |
OK thanks! I'm still feeling my way through the "correct" way to do things since I'm just learning on the fly, so I appreciate it |
| 09:34 |
tlittle |
Dyrcona++ |
| 09:55 |
|
dguarrac joined #evergreen |
| 11:38 |
|
dguarrac_ joined #evergreen |
