| Time |
Nick |
Message |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:28 |
|
rjackson_isl_hom joined #evergreen |
| 07:41 |
|
collum joined #evergreen |
| 08:38 |
|
mmorgan joined #evergreen |
| 08:43 |
|
mantis joined #evergreen |
| 09:03 |
|
Dyrcona joined #evergreen |
| 09:21 |
* Dyrcona |
searches for the minutes of the meeting where we voted on the web staff client. |
| 09:29 |
Dyrcona |
OK. I found it, but the vote wasn't recorded: https://wiki.evergreen-ils.org/doku.php?id=dev:hackfest:hackaway-2013 (I remember that it was unanimous.) |
| 09:31 |
Dyrcona |
Also, some notes of the discussion are available for those interested in history: https://docs.google.com/document/d/1QALWLD-vAjDV8HseQyE5j0Yc-93Nrl-1B00xeP_npak/edit#heading=h.qkhgf919wj2j |
| 09:41 |
|
rfrasur joined #evergreen |
| 09:46 |
Bmagic |
Dyrcona: that was a fun read |
| 09:57 |
|
jvwoolf joined #evergreen |
| 10:34 |
mantis |
What does the "error -1" status mean in Patron > Holds? |
| 10:36 |
Dyrcona |
mantis: It usually means the hold cannot possibly be filled under current circumstances. Perhaps all available copies were deleted, etc. |
| 10:37 |
mantis |
Dyrcona++ |
| 10:37 |
Dyrcona |
Basically, the code to set the hold status went through all of its conditions and nothing matched. |
| 10:43 |
pastebot |
"Dyrcona" at 168.25.130.30 pasted "Hold status" (12 lines) at http://paste.evergreen-ils.org/14435 |
| 10:44 |
Dyrcona |
mantis ^^ |
| 10:45 |
mantis |
Thanks! |
| 10:46 |
|
jvwoolf joined #evergreen |
| 10:49 |
Dyrcona |
Looking at the code, I'd say the most likely culprit is that the hold has a current copy plus the capture time is set but the current copy does not have a status of in transit nor on the hold shelf. |
| 10:50 |
Dyrcona |
So, somebody messed up handling the copy/hold. |
| 10:52 |
Dyrcona |
I'm not sure what happens if a permission or other error occurs while looking up the status. I'd expect the staff client to pop up a dialog, but I didn't check that code. |
| 11:16 |
mmorgan |
mantis: bug 1526605 |
| 11:16 |
pinesol |
Launchpad bug 1526605 in Evergreen "Holds can get stuck with a hold status of -1" [Undecided,New] https://launchpad.net/bugs/1526605 |
| 11:16 |
mmorgan |
Also bug 1469287 |
| 11:16 |
pinesol |
Launchpad bug 1469287 in Evergreen "Retargeting a cancelled hold can cause problems with uncancelled captured holds" [Medium,Invalid] https://launchpad.net/bugs/1469287 |
| 11:16 |
berick |
-1 means "something ain't right" |
| 11:17 |
* mmorgan |
hasn't looked at those in awhile. |
| 11:21 |
abneiman |
oh, that 1526605 - I have heard rumors of it from many sources, but never able to reproduce it myself. mantis if you can shed any light on that one it would be helpful! |
| 11:23 |
* mmorgan |
's theory is that the status of the item gets changed by some other process to a status that doesn't fit with the state of the hold |
| 11:28 |
mantis |
Unfortunately I don't have much information on the item hold but I'll let you all know if I get a response from the library that reported |
| 11:29 |
mmorgan |
mantis: Retargeting the hold should fix it so it can capture another item |
| 11:57 |
csharp_ |
mantis: if you're comfortable reading perl, checkout open-ils.circ.hold.status.retrieve around line 1503 or so in Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm |
| 11:58 |
csharp_ |
it goes through several checks and if fails all of them, it returns the -1 status |
| 11:59 |
csharp_ |
the bug would be whatever is resulting in not landing on one of the other statuses |
| 12:00 |
|
jihpringle joined #evergreen |
| 12:34 |
|
collum joined #evergreen |
| 12:59 |
|
jihpringle joined #evergreen |
| 13:11 |
|
collum joined #evergreen |
| 16:22 |
|
jihpringle joined #evergreen |
| 16:45 |
|
jvwoolf left #evergreen |
| 17:12 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
