Evergreen ILS Website

IRC log for #evergreen, 2021-09-14

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:32 rjackson_isl_hom joined #evergreen
08:17 mantis joined #evergreen
08:22 collum joined #evergreen
08:34 mmorgan joined #evergreen
08:48 rfrasur joined #evergreen
08:52 Dyrcona joined #evergreen
09:48 jvwoolf joined #evergreen
09:59 Stompro joined #evergreen
10:49 jihpringle joined #evergreen
11:29 Stompro joined #evergreen
12:34 collum joined #evergreen
12:35 Dyrcona So, marc_steam_importer doesn't seem to be working with OCLC Connexion. I can see the CONNECT TCP messages in the logs, but nothing gets uploaded and I'm told the user gets "The local system has closed the connection, retries exceeded" and the 3 messages telling me the TCP/IP connection has been closed by the remote host.
12:40 Dyrcona It looks like the settings calls fails....
12:52 Dyrcona Except when I do the exact same settings call from a short Perl script, it works. I'm expecting to /openils/var/tmp for the temp directory and that's what I get when I make the call. However, I see an empty file in /tmp created at about the time that staff tried to use the stream importer from Connexion.
12:54 berick Dyrcona: it should pull from settings, but you can also override with --tempdir
12:54 collum joined #evergreen
13:01 Dyrcona berick: I see that, and I'm not sure that's my problem. The file in /tmp may or may not be related. It could be some Net::Server thing.
13:04 Dyrcona Yeah, the 0 byte file in /tmp seems to get dropped when I kill the marc stream importer and then shows up when I start it.
13:05 Dyrcona I think I remembered reading in the Net::Server docs somewhere that something required Socket::Linux, so I've installed that module via apt packages. We'll see if that makes a difference.
13:09 Dyrcona ah ha. Maybe this is the problem: opensrf.settings.host_config.get training.cwmars.org,
13:14 mixo joined #evergreen
13:14 mixo hello
13:14 mixo I had problem with internet browser
13:15 mixo I have ubuntu desktop and it was my browser problem
13:16 mixo I've delete ~/.config/google-chrome directory and problem solved
13:16 mixo thank you for help
13:18 Dyrcona So, that opensrf.setting.host_config.get call seems to be coming from SettingsClient, but the subsequent opensrf.settings.default_config.get call does not appear to be logged, so I don't think getting the settings is the problem.
13:18 Dyrcona mixo: On behalf of those who helped you, "You're most welcome!"
13:22 Dyrcona berick: Can I just throw a binary marc file at the port to test it? (It looks like it, but thought I'd ask.)
13:33 Dyrcona Well, i tried lobbing  a MARC record at it using netcat and nothing happened.
13:36 Dyrcona Interesting, it actually got something in my case: Sep 14 13:27:23 training /openils/bin/marc_stream_importer.pl: [INFO:5664:marc_stream_impor​ter.pl:449:163163899556641] stream parser read 1603 bytes
13:37 Dyrcona Whatever happens after that, I don't see authentication nor vandelay calls in the logs, and yes, I'm using syslog for everything.
13:48 Dyrcona So, it is failing to create the temp file, but that failure is not logged. That's what it looks like right now.
13:54 Dyrcona All right, so I traced that issue down to $0 in the tempfile name. If the stream importer is started as /openils/bin/marc_stream_importer.pl, then $0 contains the directory and it fails to create the tempfile.
13:55 nfBurton joined #evergreen
14:03 Guest8532 joined #evergreen
14:06 Dyrcona The bib queue was deleted....
14:08 Dyrcona And there's not log entry of it having been deleted, either.
14:09 JonHGeorg24 joined #evergreen
14:09 JonHGeorg joined #evergreen
14:10 Dyrcona Oh.... I'm stupid.... I made a vandelay.queue, not vandelay.bib_queue. Table inheritance for the loss.
14:13 Dyrcona I'm still going to submit a patch for the temp file name.
14:14 JonHGeorg Greetings, I'm looking for SQL assistance for how to forgive fines for a specific library for a specific time frame. I'm looking through the archive now but so far do not see anything. Thanks.
14:22 Dyrcona JonHGeorg: https://github.com/Dyrcona/evergreen2019-preco​nference/blob/master/examples/forgive_bills.pl
14:22 Dyrcona berick: Do we need to have a match bucket for the queue?
14:24 mmorgan JonHGeorg: I have used an sql to insert forgive_payments based on balance owed, copy.circ_lib, and billing_type. I'll share that momentarily.
14:26 berick Dyrcona: you don't need a match_bucket
14:27 berick our Connexion queue has no item_attr_def, match_set, or match_bucket
14:28 Dyrcona berick: Thanks! I finally had a successful import.
14:29 Dyrcona I'm not using match_bucket, but I set match_set and item_attr_def.
14:29 berick cool
14:30 Dyrcona JonHGeorg: That example I pasted is not exactly what you're looking for, but it does show how to make forgive payments from Perl, and it wouldn't be too hard to look for open bills for a given library and apply the payments to those bills.
14:31 JBoyer 30 minutes to dev meeting, get any last-minute agenda changes in
14:32 Dyrcona berick: It overlaid an existing record, which is what I expected. (I was using something I had hanging around from a Lp bug.)
14:33 pastebot "mmorgan" at 168.25.130.30 pasted "Insert Forgive Payments SQL example" (13 lines) at http://paste.evergreen-ils.org/14431
14:33 mmorgan JonHGeorg: ^^ I'd strongly recommend breaking the transactions up into batches to avoid swamping the db
14:39 Dyrcona Modifying programs in the bin directory on the server..... :)
14:40 JonHGeorg Thank you. I'll take a closer look at this, had gotten pulled away from my desk for a moment.
14:52 shulabear joined #evergreen
14:54 terranm joined #evergreen
14:59 Lew24 joined #evergreen
15:02 JBoyer Ding, ding, ding, it's 3pm(-ish) eastern.
15:02 JBoyer #startmeeting 2021-09-14 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/do​ku.php?id=dev:meetings:2021-09-14
15:02 pinesol Meeting started Tue Sep 14 15:02:26 2021 US/Eastern.  The chair is JBoyer. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:02 pinesol Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:02 pinesol The meeting name has been set to '2021_09_14___developer_meeting__agenda_​available_at_https___wiki_evergreen_ils_​org_doku_php_id_dev_meetings_2021_09_14'
15:02 JBoyer #topic Introductions
15:02 JBoyer new meeting, who dis?
15:02 terranm #info terranm is Terran McCanna, PINES
15:02 JBoyer #info JBoyer = Jason Boyer, EOLI
15:03 dluch #info dluch = Debbie Luchenbill, MOBIUS
15:03 mmorgan #info mmorgan = Michele Morgan, NOBLE
15:03 shulabear #info shulabear is Shula Link, GCHRL/PINES
15:03 gmcharlt #info gmcharlt = Galen Charton
15:03 rfrasur #info rfrasur = Ruth Frasur, Evergreen Indiana/ECDI
15:03 abneiman #info abneiman = Andrea Buntz Neiman, EOLI
15:03 berick #info berick = Bill Erickson, KCLS
15:04 jeff #info jeff = Jeff Godin, Traverse Area District Libra│······
15:04 jeff ry (TADL)
15:04 jeff hah!
15:04 jeff #info jeff = Jeff Godin, Traverse Area District Library (TADL)
15:04 JBoyer Ok, anyone joining later feel free to throw an #info out.
15:05 JBoyer #topic Action Items from Last Meeting
15:05 JBoyer JBoyer will exercise the staff client in a current release of Edge, and JBoyer will look at adding Edge on Windows support to the Hatch installer
15:05 JBoyer Edge testing not being especially high on my list I have not made time to properly put it through its paces.
15:05 JBoyer berick has shown though that it can be done without much trouble, so hatch installer changes shouldn't be too bad.
15:05 JBoyer If anyone else would like to look into this please let me know, lest I action again.
15:06 JBoyer (or rather, #act yourself.)
15:06 csharp_ #info csharp = Chris Sharp
15:06 Dyrcona #info Dyrcona = Jason Stephenson, CW MARS
15:07 JBoyer That "It" I was referring to above was adding Edge support to the Hatch installer, even with a prepared script that came out weirdly.
15:07 * JBoyer kicks a can down the road
15:07 JBoyer #action JBoyer will exercise the staff client in a current release of Edge
15:07 JBoyer #action JBoyer will look at adding Edge on Windows support to the Hatch installer
15:08 JBoyer Ok, seeing no OpenSRF topics on the agenda we move on to
15:08 JBoyer #topic Evergreen Release Updates
15:08 JBoyer An adjusted 3.8 release schedule has been sent to the dev lists, does anyone have anything they'd like to add?
15:09 jeff Were there some specific features in mind with the "In order to allow a little more time to get some features in" part of the update?
15:09 jeff Or just a general "more time = more features make it"?
15:10 gmcharlt jeff: some specific ones are bug 1207533
15:10 gmcharlt bug 1905028
15:10 pinesol Launchpad bug 1207533 in Evergreen "Triggered event log times out for large-data sites" [Medium,Confirmed] https://launchpad.net/bugs/1207533
15:10 pinesol Launchpad bug 1905028 in Evergreen "Wishlist: Option to have lost items be charged the Acquisitions Cost" [Wishlist,Confirmed] https://launchpad.net/bugs/1905028
15:10 JBoyer A little of both, though I'd like to specifically get the mmpbt bug closed.
15:10 gmcharlt bug 1904593
15:10 gmcharlt Edit
15:10 gmcharlt Course materials
15:10 pinesol Launchpad bug 1904593 in Evergreen "yaous for my account url" [Wishlist,Confirmed] https://launchpad.net/bugs/1904593 - Assigned to Rogan Hamby (rogan-hamby)
15:10 csharp_ gmcharlt: we'll be testing bug 1207533 on a PINES-ish server next week if I can get it done
15:11 csharp_ also notes re-do
15:11 abneiman csharp_++
15:12 terranm I think the pullrequest had been removed from the notes consolidation - that would be nice if it is ready to test and we can test it next week though
15:12 JBoyer To give a minor teaser for those not looking at the agenda, the more of the 60 signed off bugs we can get committed the better. :)
15:12 terranm +1
15:12 mmorgan +1
15:12 shulabear +1
15:13 JBoyer Any other Evergreen release discussion before moving on?
15:13 abneiman I added Patron Notes to the agenda for later discussion since it's a little big & invasive. With the longer timeline we should be able to have that rebased & re-pullrequested though.
15:13 terranm A lot of the remaining open pullrequests are things that can't be easily tested and require sys admins and/or developers to look more deeply
15:14 abneiman yes, what terranm said :)
15:14 terranm abneiman++
15:15 JBoyer Yeah, there are a number of things that are likely not terribly difficult to test, but they are backend things. The "don't specifically require the opensrf user" is certainly one of those.
15:15 terranm Note also that Bill has been working on redoing the patron interfaces, so a number of things like notes consolidation will need to have updates done to his new branch at some point too
15:15 JBoyer (being quite difficult to test during a bug squashing week)
15:17 Guest8574 joined #evergreen
15:18 JBoyer SO, If you're able to put in some time next week with a local test server, please check out the SysAdmin and Developer Review sections of Terran's bug squashing week spreadsheet.
15:18 JBoyer moving on
15:18 JBoyer #topic Documentation Updates
15:18 JBoyer DIG is preparing to do a comprehensive docs review to catch out of date or missing docs and fill in the blanks.
15:19 dluch Yep, and we need help!
15:19 JBoyer They'd like volunteers from the various interest groups, including developers. If you have any questions or would like to volunteer please reach out to the documentation list. Anything you'd like to add, jweston or abneiman?
15:19 JBoyer or dluch, or whoever, that's about all I have handy about it. :D
15:19 dluch Well, I can add that, for developers, all the sysadmin and setup instructions would be an excellent place to start
15:20 dluch Thanks in advance! :-)
15:20 abneiman agreed with dluch. A super-easy way to inform DIG about out-of-date pages is to use the "report feedback" link at the bottom of each docs page, because that will automatically include which page you're on
15:21 dluch Also, the next DIG meeting is October 7, 2 pm ET, on Zoom where we'll have a presentation from alynn26 and jihpringle on how to contribute already-created documentation
15:21 dluch Agenda here: https://wiki.evergreen-ils.org/doku.php?id=​evergreen-docs:dig_meetings:20211007-agenda
15:22 JBoyer dluch++
15:22 JBoyer abneiman++
15:22 abneiman oh! and two bugs that would help DIG & need dev eyes are bug 1930099 and bug 1903476
15:22 pinesol Launchpad bug 1930099 in Evergreen "generate_docs.pl should be able to run on Windows" [Medium,Confirmed] https://launchpad.net/bugs/1930099
15:22 pinesol Launchpad bug 1903476 in Evergreen "Generate previews of documentation when documenters open a pull request on Github" [Wishlist,Confirmed] https://launchpad.net/bugs/1903476
15:24 terranm Here's the link to the bug squashing week spreadsheet for next week: https://docs.google.com/spreadsheets/d/1SE5A​G1MgrXq2zHBY6qYcHNGVuIdzsihpfL2ZIIrE45s/edit - see the Open Pull Requests tab for things that need to be tested on local systems by sysadmins/developers
15:24 JBoyer terranm++
15:24 mmorgan terranm++
15:25 terranm "Test Group" categorizations are my own and some may involve additional groups
15:25 dluch terranm++
15:25 JBoyer Hopefully some time can be carved out for those two DIG bugs abneiman mentioned next week also, they look very helpful.
15:25 JBoyer ... Next up is
15:25 JBoyer #topic Launchpad Status as of 2021-09-14T12:00:00-ish
15:25 JBoyer Shapshot numbers: 2594 open bugs, 95 PR, and 60 signedoff
15:26 JBoyer Since the last meeting: 59 new bugs, 22 new PRs, 45 new signoffs, and 47 fixes committed.
15:26 csharp_ Thu, Sep 9, 4:21 AM (5 days ago)
15:26 * Dyrcona added a pullrequest since.
15:26 csharp_ oops!
15:26 jihpringle joined #evergreen
15:27 JBoyer Dyrcona++ (literally!)
15:27 Dyrcona pullrequest++
15:27 JBoyer This month we have several pieces of
15:27 JBoyer #topic New Business
15:27 JBoyer Review / discussion of Consolidated Patron Notes (lp 1846354) from abneiman
15:27 pinesol Launchpad bug 1846354 in Evergreen "wishlist: Consolidate patron notes, alerts, and messages" [Wishlist,New] https://launchpad.net/bugs/1846354 - Assigned to Jason Etheridge (phasefx)
15:28 abneiman yes - phasefx can't be at this meeting, but I wanted to get a sense of where the community is on that one. It's a little big & hairy and I know berick is working in a similar space.
15:29 abneiman but it has also languished for a while, so, are there specific things that it needs? just more testing and review?
15:29 abneiman (gmcharlt please feel free to add anything I've forgotten)
15:30 terranm I think the last time we tested the conversion went well but there was some code cleanup needed
15:30 abneiman anyway, since it's a big staff-facing change, I just wanted to see what else we can do to get this one over the hump
15:31 gmcharlt yeah, echoing abneiman
15:31 terranm +1
15:31 berick is there a reason it's not tagged as a pullrequest?
15:31 berick i what terranm said..
15:31 JBoyer The last couple of comments from Jason on that bug looks like he's still working on it and the latest one removed the PR, so I'm not sure what's up with that.
15:31 gmcharlt yeah, current roadblock is ironing some bits about the offline internface
15:31 abneiman berick: it's awaitng a rebase and the noted cleanups
15:32 berick abneiman: *nod*
15:32 terranm I would really love to get that one into 3.8
15:32 mmorgan +1
15:33 abneiman ok, if it's just the rebase and a few small wrinkles, I'm pretty confident that can be PR'd in time to test next week
15:33 terranm abneiman++\
15:34 abneiman because I, too, would love to get this into 3.8 :)
15:34 terranm oops abneiman++
15:34 JBoyer terranm, csharp_ do you think that's soon enough to also throw at a PINES-sized test system?
15:34 JBoyer Because it works *pretty* well on concerto. ;)
15:35 abneiman yes, scale testing is key here
15:35 JBoyer Anyone else with a large-ish test system that is able to try it out would also be extremely welcome.
15:35 mmorgan Are there concerns other than migration with a large data set?
15:36 terranm (I defer to csharp_ on that)
15:36 abneiman mmorgan: part of it is the way larger systems might leverage some of the features like notes-scoping in more complex ways
15:36 terranm Migration was the biggie, but that seemed to be resolved pretty well
15:36 abneiman but yes, def migration
15:37 * mmorgan nods.
15:37 terranm PINES is *not* doing anything fancy with scoping as we want everyone to see all the notes
15:38 mmorgan NOBLE has tried to do some notes/messages scoping, but it's unweildy with the current way it works.
15:38 terranm I think the new interface will make that much easier to manage
15:38 mmorgan Indeed.
15:39 mmorgan We might have some data that we could try and migrate.
15:39 abneiman mmorgan++
15:39 terranm mmorgan++
15:39 JBoyer mmorgan++
15:40 JBoyer Any further discussion re: patron note / alert consolidation?
15:40 abneiman thanks, everyone
15:40 JBoyer abneiman++
15:40 JBoyer Thoughts on lp 1942467 (identifier field mapping and search), mmorgan?
15:40 pinesol Launchpad bug 1942467 in Evergreen "Search: Identifier Field Virtual Index Mappings not working" [Undecided,New] https://launchpad.net/bugs/1942467
15:41 mmorgan I was just hoping to get some input on this and if it's as much of an issue for other sites as ours.
15:41 mmorgan The 10/13 isbn searchability specifically is a big problem for us.
15:41 JBoyer Is one of the symptoms of this searching for a 13 digit ISBN and not finding the records that only have the 10, and vice-versa?
15:41 JBoyer ah, apparently so. :)
15:41 mmorgan JBoyer: Yes
15:41 mmorgan :)
15:42 miker I should be able to look at that early next week, mmorgan
15:42 mmorgan miker++
15:42 mmorgan That would be awesome!
15:42 JBoyer miker++
15:42 terranm miker++
15:42 gmcharlt miker++
15:43 * mmorgan had donned hipwaders and tried to slog through the code, but the waders aren't high enough:)
15:43 JBoyer That brings us to another issue raised by mmorgan,
15:43 JBoyer Approaches to address lp 1883171 (asset.latest_inventory duplicate copies)
15:43 pinesol Launchpad bug 1883171 in Evergreen "duplicate entries for a copy in asset.latest_inventory table" [Undecided,Confirmed] https://launchpad.net/bugs/1883171
15:43 dluch mmorgan++
15:44 mmorgan So this has made the inventory function not useful for us
15:45 mmorgan Does this look like a parallel requests issue?
15:45 JBoyer Everyone's favorite issue, a 1:1 table that is actually 1:M
15:46 rfrasur hah
15:46 mmorgan "There wasn't an entry already there when I came in!"
15:46 jeff one concept for inventory was storing all of the inventory dates and giving a view that would output only the most recent.
15:46 JBoyer I would have thought so from the description, but I'm really confused how you get 2 entries months apart but only 1 id separate.
15:47 jeff mmorgan: can you explain why the duplicate entries make the feature not useful? is it because the UI displays "any" date and not the most recent, or something else?
15:47 mmorgan JBoyer: So the two entries are created at the same time, and later one of them gets updated when an inventory is performed
15:47 jeff (or are you reporting on "all" of the dates?)
15:47 JBoyer Hah, yeah, that would be the obvious explanation.
15:48 * JBoyer needs to be more creative in how to break things.
15:48 mmorgan jeff: It's a combination of this issue with the the one where other libraries can set inventory dates on my items.
15:49 mmorgan JBoyer: Having a big, active system and logs helps to see the breakage :)
15:49 mmorgan bug 1940663 is the other problematic one
15:49 pinesol Launchpad bug 1940663 in Evergreen "Inventory: Staff users can update inventory dates on non-owned items" [Undecided,Confirmed] https://launchpad.net/bugs/1940663
15:49 jeff mmorgan: what impact does the duplicate rows bug have for you?
15:50 mmorgan A few we've noticed - in the client, it's not always the most recent row in the inventory table that displays for an item.
15:51 mmorgan It's difficult to get accurate reports between this and the non-owned items bug
15:52 JBoyer Since I'm guessing the code doesn't specify any ordering (because *latest*) I can see postgres sometimes throwing you 1 row and sometimes the other.
15:52 mmorgan A library can be doing a careful inventory where date is important, but the item is checked in at another library that is using the checkin modifier, and the owning library's date is lost.
15:54 mmorgan So does an approach come to mind to solve the duplicate issue?
15:54 JBoyer While jeff has a good point about some workflows saving all inventory-type scans I'd say that doesn't make sense with a table named latest_anything and it should be a simple matter of duplicate removal and a proper constraint being put in. That should be relatively simple.
15:54 terranm I guess we haven't encountered that problem because we're mainly doing inventories to identify lost items, so we're basing our reports on items with null inventory dates or last inventory dates prior to the current inventory scanning period
15:55 jeff terranm: depending on your logic, that second one could run into this.
15:56 terranm Not for our purposes, because if it was checked in somewhere else, it means it's not missing
15:56 Dyrcona Might as well just add the columns to asset.copy and drop the table.
15:56 mmorgan We had some libraries doing lots of inventory activities when they were closed, when items started moving around again, we became aware of the non-owned issue because some libraries have chosen to have the checkin modifier on all the time.
15:56 jeff sorry, i should have been more specific. "second one" meaning "last inventory dates prior to the current inventory scanning period" :-)
15:58 mmorgan There was lots of discussion of where to store the data back in the original Launchpad ticket.
15:59 mmorgan bug 1777675
15:59 pinesol Launchpad bug 1777675 in Evergreen "Support for inventory date" [Wishlist,Fix released] https://launchpad.net/bugs/1777675
15:59 JBoyer I can see not wanting it on the item if you don't want a large amount of auditor churn for just scanning inventory.
15:59 jeff I can take a look at the bugs in the next week or two if you're looking for ideas.
15:59 JBoyer I would have expected the unique constraint to have been added in the beginning.
16:00 mmorgan jeff++
16:00 JBoyer jeff++
16:00 mmorgan JBoyer: Yes, I wondered about that.
16:00 * mmorgan encourages folks to weigh in on Launchpad for these bugs.
16:01 Dyrcona If you're going to add a unique contraint on copy, then might as well move the two inventory fields to asset.copy and drop the table.
16:01 JBoyer One of these changes is small and one of these changes is (potentially) very, very large.
16:02 JBoyer Also, if / when inventory is fleshed out asset.latest_inventory will likely be a useful view
16:02 mmorgan The small one being to add the uniqueness constraint, I assume?
16:02 JBoyer you bet
16:03 * miker will weigh in on LP...
16:03 Dyrcona The big change would be better in the long run.
16:03 Dyrcona Seems to me, though, that there is also some utility in having multiple entries.
16:03 JBoyer only if inventory never gains any more features and asset.latest_inventory is the only inventory-related table ever used.
16:04 JBoyer but yes, there is utility in a table that lists all inventory scans for an item. "This item was scanned in 2021, 2022, and 2023, but not 2024 or 2025, and now it's back in 2026?"
16:06 JBoyer But there isn't currently any use in this table backed by this code having multiple entries.
16:06 Dyrcona I'll stop. I think the rest should go on Lp.
16:07 JBoyer discussion++
16:07 JBoyer lp+-
16:07 JBoyer heh
16:07 JBoyer Thanks for bringing those up abneiman and mmorgan
16:07 mmorgan discussion++
16:07 JBoyer abneiman++
16:07 JBoyer mmorgan++
16:07 JBoyer only a few minutes over the hour we come to
16:07 JBoyer #topic Announcements
16:07 JBoyer Next Meeting is October 12, 2021
16:08 JBoyer Anything else to share before I tell the bot to ignore us/
16:08 JBoyer bye, bot!
16:08 JBoyer #endmeeting
16:08 pinesol Meeting ended Tue Sep 14 16:08:31 2021 US/Eastern.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
16:08 pinesol Minutes:        http://evergreen-ils.org/meetings/evergr​een/2021/evergreen.2021-09-14-15.02.html
16:08 pinesol Minutes (text): http://evergreen-ils.org/meetings/evergr​een/2021/evergreen.2021-09-14-15.02.txt
16:08 pinesol Log:            http://evergreen-ils.org/meetings/evergree​n/2021/evergreen.2021-09-14-15.02.log.html
16:08 mmorgan JBoyer++
16:08 terranm JBoyer++
16:08 Dyrcona JBoyer++
16:08 abneiman JBoyer++
16:08 shulabear JBoyer++
16:08 dluch JBoyer++
16:11 Bmagic JBoyer++
16:11 miker JBoyer++
16:13 Bmagic is it me or is this function: authority.axis_authority_tags_refs not called by anything?
16:14 Dyrcona The cause of the duplicate inventory entries is around line 2725 of OpenILS::Application::Circ::Circulate. The cause of being able to update non-owned items is also in that vicinity.
16:14 mdriscoll joined #evergreen
16:15 Dyrcona Updating asset.copy multiple times during a checkin might also have something to do with it.
16:16 Bmagic seems that "simple_heading_search_rank" calls it, which is wrapped in "axis_search_rank_refs" for example, which doesn't get called by anything as far as I can tell
16:16 Dyrcona IDK. Sometimes I look at the Circ code and I want to work on something else. :)
16:17 JBoyer Dyrcona++
16:17 Dyrcona Bmagic: Are you only looking at the database code?
16:17 Bmagic grepping the repo
16:18 Bmagic grepping for "axis_search_rank_refs" yields only the creation statements
16:19 mmorgan Dyrcona++
16:19 Dyrcona Bmagic: Yes, looks like it may no longer be used.
16:22 Dyrcona Too bad one can't grep git for a function name.
16:22 Bmagic weird.... there must be something else then. Something akin to authority.browse_axis_authority_field_map, which maps the authority record tags over to metabib.browse_entry
16:23 jeff based on a glance at commit 52fc7f0, I wouldn't be so sure that it's not used. :-)
16:23 pinesol jeff: [evergreen|Mike Rylander] New in-db search and browse of authorities with non-filing-indicator support - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=52fc7f0>
16:25 Dyrcona Yeah, I was thinking it might be a generated function in the Perl code.
17:01 mmorgan left #evergreen
17:45 Bmagic upteen hours later. It's an insert into  authority.control_set_bib_field_metabib_field_map that did the trick
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:04 nfBurton joined #evergreen
18:26 Stompro joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat