| Time |
Nick |
Message |
| 02:01 |
|
khuckins joined #evergreen |
| 06:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:22 |
|
khuckins_ joined #evergreen |
| 07:16 |
|
rjackson_isl_hom joined #evergreen |
| 08:28 |
|
mantis1 joined #evergreen |
| 08:31 |
|
mmorgan joined #evergreen |
| 08:57 |
|
Dyrcona joined #evergreen |
| 09:25 |
|
rfrasur joined #evergreen |
| 09:55 |
|
mantis1 left #evergreen |
| 09:57 |
|
mantis1 joined #evergreen |
| 10:35 |
miker |
Bmagic: for future you (and future permission spelunkers in this channel), any time you see the global_required="true" attribute on a permission in fm_IDL.xml for a class, such as for vandelay.bib_queue (class id="vbq") the permission must be granted at the top of the org type tree, definitionally. |
| 10:36 |
miker |
now, for those in particular, we could probably use owner as a context org for the permission instead of global_required, and then you could grant it at system or branch or whatever, but ... that's not how those particular perms work today |
| 10:39 |
miker |
and (for future permission hunters) fm_IDL.xml is a great place to start looking for permissions attached to object that are presented in a relatively direct way in the UI, because those objects are probably being pulled via open-ils.pcrud, which uses the perms listed in the IDL to do authz checks |
| 10:43 |
Bmagic |
miker++ |
| 11:10 |
|
nfBurton joined #evergreen |
| 11:30 |
|
tlittle joined #evergreen |
| 11:57 |
|
cesardv joined #evergreen |
| 11:58 |
|
khuckins joined #evergreen |
| 12:00 |
|
jihpringle joined #evergreen |
| 12:06 |
|
cesardv joined #evergreen |
| 12:31 |
|
Christineb joined #evergreen |
| 12:43 |
|
collum joined #evergreen |
| 14:02 |
|
sandbergja joined #evergreen |
| 14:05 |
terranm |
JBoyer: I'm trying to test the two LocalAdmin patches on pattypan, but neither of them are loading - can you verify? |
| 14:07 |
JBoyer |
terranm, will do. |
| 14:17 |
JBoyer |
terranm, both were applied; I rebuilt things just in case it helps. |
| 14:17 |
terranm |
Thanks, will check again in a moment |
| 14:18 |
JBoyer |
I'll check the OU dropdown one right now; since admin workstations default to CONS it's not always easy to remember to re-register |
| 14:23 |
JBoyer |
Mmm. :/ Looks like 1844169 works fine, but you have to manually change the /eg/ to /eg2/ because there's a change missing to update it in the Local Admin page. |
| 14:23 |
|
dbwells joined #evergreen |
| 14:26 |
terranm |
Yeah, 1873322 isn't working for me - cleared cache and registered a brand new workstation but all the selectors are still defaulting to CONS |
| 14:27 |
JBoyer |
I'm curious if the home_ou is more important than it looks |
| 14:28 |
mmorgan |
terranm: JBoyer: I've gotten 1873322 working on a test server, at least logged in as admin |
| 14:28 |
* mmorgan |
was going to use that as an example at the newdevs meeting today. |
| 14:28 |
terranm |
Let me try on pattypan with another account |
| 14:32 |
JBoyer |
I just made admin's home ou BR1 and that didn't help either. Highly annoyed. |
| 14:32 |
JBoyer |
(with BR1 WS also) |
| 14:32 |
terranm |
I tried with a different staff account and it didn't work for that either |
| 14:32 |
mmorgan |
On my test server, the dropdown defaulted to the login workstation. |
| 14:33 |
terranm |
mmorgan++ |
| 14:33 |
terranm |
Could there be something else on pattypan that is conflicting with it? |
| 14:35 |
JBoyer |
I wouldn't think so; nothing else touches that file. :/ |
| 14:35 |
terranm |
mmorgan: since you have it working on yours and we'll be looking at it in the new devs group, I don't think there's worth spending more time on it on pattypan |
| 14:36 |
terranm |
I'll move on to testing 1844169 |
| 14:37 |
JBoyer |
I can try to get it working later unless one of you is signing off on it later today |
| 14:38 |
terranm |
We'll probably be able to sign off on 1873322 this afternoon |
| 14:39 |
JBoyer |
terranm++ |
| 14:39 |
mmorgan |
JBoyer: terranm: I think it will likely be signed off later today. I deleted my local branch where it was working, but plan to create a new one at the meeting. |
| 14:39 |
terranm |
mmorgan++ |
| 14:39 |
JBoyer |
if the missing bit of 1844169 gets pushed I can add that so it works as expected. |
| 14:40 |
JBoyer |
Well, maybe it's not missing... taking another look, but it's just not showing up. :/ |
| 14:45 |
terranm |
It looks like the local admin splash page update is in the patch |
| 14:47 |
JBoyer |
yeah, different format than I expected, but things just refuse to change. I threw away all of /openils/var/web/eg2/ and am building fresh because this isn't cool. |
| 14:51 |
Dyrcona |
Is the code full loaded on the test server? If its multiple commits, a commit or two may have been missed. |
| 14:52 |
JBoyer |
Checked both multiple times, 1 commit each. :/ |
| 14:53 |
JBoyer |
ok, here's something building eg2: ERROR in src/app/staff/admin/local/search-filter/query-dialog.component.ts:55:64 - error TS2367: This condition will always return 'true' since the types 'string' and 'number' have no overlap. |
| 14:53 |
JBoyer |
so I'm guessing it's dying after building part of the big pile of JS. |
| 14:58 |
csharp |
@ana big pile of JS |
| 14:58 |
pinesol |
csharp: Flies pig job |
| 14:59 |
|
malexander joined #evergreen |
| 15:02 |
|
collum_ joined #evergreen |
| 15:04 |
|
LlewellynV joined #evergreen |
| 15:09 |
JBoyer |
Aha, yeah, changing some_string != 0 to some_string != '0' and everything builds as exopected. |
| 15:12 |
JBoyer |
yeah, everything working as expected now. |
| 15:12 |
JBoyer |
terranm++ |
| 15:48 |
|
mantis2 joined #evergreen |
| 15:54 |
jeffdavis |
bug 1919502 <- finally opened a Launchpad bug for this |
| 15:54 |
pinesol |
Launchpad bug 1919502 in OpenSRF "C request backlog needs to chill out" [Undecided,New] https://launchpad.net/bugs/1919502 |
| 15:54 |
jeffdavis |
^ re too many "Could not launch a new child" warnings |
| 16:13 |
|
mantis2 left #evergreen |
| 16:19 |
terranm |
JBoyer - great, looks like things are working now! |
| 16:19 |
Dyrcona |
oops! Wondered why legacy acq was broken on this vm. Looks I forgot to reinstall dojo after wiping out /openils..... |
| 16:32 |
|
dbwells joined #evergreen |
| 16:43 |
Dyrcona |
It seems that we have 1 user who is able to get acquisitions to search for all lineitems via the general search, but no matter what I try, I can't reproduce it. Most of the time, I end up with invalid queries. |
| 16:46 |
Dyrcona |
Oh well. The VPN kicked me out, and it's time to clock out anyway. |
| 17:08 |
|
sandbergja joined #evergreen |
| 17:11 |
|
dbwells joined #evergreen |
| 17:13 |
|
mmorgan left #evergreen |
| 17:20 |
|
dbwells joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:09 |
|
sandbergja joined #evergreen |
| 20:11 |
|
malexander joined #evergreen |
