| Time |
Nick |
Message |
| 07:03 |
|
Dyrcona joined #evergreen |
| 07:12 |
|
rjackson_isl joined #evergreen |
| 07:31 |
|
tlittle joined #evergreen |
| 07:43 |
|
jvwoolf joined #evergreen |
| 07:47 |
|
bos20k joined #evergreen |
| 07:49 |
|
Dyrcona joined #evergreen |
| 08:13 |
|
jvwoolf1 joined #evergreen |
| 08:14 |
|
mdriscoll joined #evergreen |
| 08:20 |
|
agoben joined #evergreen |
| 08:32 |
|
jvwoolf1 left #evergreen |
| 08:41 |
|
EVGHack-a-way joined #evergreen |
| 08:46 |
|
sandbergja joined #evergreen |
| 08:55 |
|
tlittle87 joined #evergreen |
| 09:00 |
csharp |
@band add Failed Vegetarians |
| 09:00 |
pinesol |
csharp: Band 'Failed Vegetarians' added to list |
| 09:08 |
|
abowling joined #evergreen |
| 09:15 |
jeff |
@ana inexplicably redacted watermelon |
| 09:15 |
pinesol |
jeff: Error: I tried to send you an empty message. |
| 09:15 |
berick |
@band add Successful Omnivores |
| 09:15 |
pinesol |
berick: Band 'Successful Omnivores' added to list |
| 09:15 |
jeff |
apropos. |
| 09:16 |
berick |
heh |
| 09:16 |
JBoyer |
jeff++ |
| 09:16 |
jeff |
inexplicably redacted watermelon is from yesterday: https://twitter.com/adielkaplan/status/1186301745238085633 |
| 09:16 |
* JBoyer |
also saw that suspicious melon |
| 09:17 |
jeff |
it is entirely possible that i saw it thanks to you seeing it, but twitter's difficult with the "why did i see this thing" after the fact. |
| 09:19 |
|
lstratton joined #evergreen |
| 09:28 |
JBoyer |
miker: lp 1825403 |
| 09:28 |
pinesol |
Launchpad bug 1825403 in Evergreen "copy tags are being created with the a library short name in the label" [High,Confirmed] https://launchpad.net/bugs/1825403 |
| 09:29 |
abneiman |
JBoyer |
| 09:29 |
abneiman |
oops - JBoyer++ is what that was supposed to be |
| 09:30 |
|
yboston joined #evergreen |
| 09:31 |
pinesol |
[evergreen|Remington Steed] Docs: Fix image syntax in Authority Browse infrastructure docs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cc44e81> |
| 09:31 |
Dyrcona |
@band add Redacted Watermelon |
| 09:31 |
pinesol |
Dyrcona: Band 'Redacted Watermelon' added to list |
| 09:32 |
Dyrcona |
@who watches Redacted Tonight |
| 09:32 |
pinesol |
jlamos watches Redacted Tonight. |
| 09:33 |
pinesol |
[evergreen|Jason Boyer] LP1825403: Do not Include Tag Owner in Tag - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=65ee0cb> |
| 09:41 |
Bmagic |
Posting EG 3.4.0 and 3.3.4 to docker hub |
| 09:53 |
Bmagic |
https://hub.docker.com/r/mobiusoffice/evergreen-ils/tags?page=1&ordering=last_updated |
| 10:22 |
|
nfBurton joined #evergreen |
| 10:28 |
|
sandbergja joined #evergreen |
| 10:32 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-10-22T10:04:33,122124693-0400 -0> |
| 10:32 |
pinesol |
News from qatests: Failed Log Output: osrfsys.log <http://testing.evergreen-ils.org/~live/test.76.html#2019-10-22T10:04:33,164852976-0400 -2> |
| 10:37 |
|
yboston joined #evergreen |
| 10:54 |
|
abowling_ joined #evergreen |
| 10:57 |
|
tlittle joined #evergreen |
| 11:09 |
|
sandbergja joined #evergreen |
| 11:17 |
|
alynn26 joined #evergreen |
| 11:31 |
|
alynn26_away joined #evergreen |
| 11:42 |
berick |
sandbergja: question about org-family-select.component.spec.ts .. were the "fixture.whenStable().then(() ... " checks solving a specific problem? i ask because those are causing the (naive) linter to throw erros |
| 11:42 |
berick |
sandbergja: see http://testing.evergreen-ils.org/~live/test.29.html#2019-10-22T10:04:33,122124693-0400%20-0 |
| 11:43 |
berick |
i have tried commenting out the if block and the tests continue to work |
| 11:43 |
berick |
i'm wondering if we can just remove those checks |
| 11:44 |
berick |
test runner, i mean, not linter |
| 11:52 |
gmcharlt |
link to the slides for my presentation: https://bit.ly/evghack19leap |
| 11:55 |
* dbs |
is intrigued by the slides, but they leave out the destination of the leap! |
| 11:58 |
Dyrcona |
:) |
| 11:59 |
|
jihpringle joined #evergreen |
| 11:59 |
Dyrcona |
Guess we'll find out in an hour. I plan to attend. |
| 12:00 |
pastebot |
"phasefx" at 168.25.130.30 pasted "how fix? :D" (22 lines) at http://paste.evergreen-ils.org/10088 |
| 12:00 |
* Dyrcona |
has OpenSRF working on Devuan Beowulf, with a real patch for Devuan, this time. |
| 12:01 |
Dyrcona |
phasefx: ng build --prod report the same? |
| 12:01 |
phasefx |
Dyrcona: it does |
| 12:02 |
Dyrcona |
You could try rm -rf nod_modules and try again. |
| 12:02 |
Dyrcona |
s/nod/node/ |
| 12:03 |
Dyrcona |
No, that's not right.... |
| 12:03 |
* Dyrcona |
decides it is lunch time. |
| 12:03 |
|
mdriscoll joined #evergreen |
| 12:08 |
phasefx |
I did try removing that directory and doing npm install afterwords |
| 12:08 |
* phasefx |
just renamed it to .old instead of actually deleting it; paranoid |
| 12:10 |
Dyrcona |
Maybe node/npm are temporarily busted? |
| 12:18 |
|
khuckins joined #evergreen |
| 12:28 |
* dbs |
hears Billy Bragg singing "Waiting for the great leap forward" in his head |
| 12:31 |
* Dyrcona |
needs to ban the manufacture and/or importation of cookies in my house. I have gained a kilo since chocolate chip cookies were made this past weekend. |
| 12:35 |
Dyrcona |
@band add 14 Stone |
| 12:35 |
pinesol |
Dyrcona: Band '14 Stone' added to list |
| 12:36 |
Dyrcona |
Because I just realized I am 14 stone and that's 1 stone, square, or if you lay me out flat: 1 square stone. :) |
| 12:36 |
Dyrcona |
And, I'm done with the nonsense. |
| 12:40 |
dbs |
Hmm. Shouldn't 'git checkout -b test_3_4_merge upstream/rel_3_3 && git pull upstream rel_3_4' result in a clean merge? |
| 12:41 |
Dyrcona |
Not necessarily. You're merging with rel_3_3. |
| 12:41 |
Dyrcona |
dbs++ # He saved you all from another few lines of nonsense about stone and rounding errors. :) |
| 12:41 |
dbs |
All of the conflicts I'm seeing are in TypeScript files |
| 12:42 |
Dyrcona |
dbs: Why would you want to merge rel_3_3 with rel_3_4? |
| 12:42 |
dbs |
well, and some Angular html - I guess because of the Angular 8 changes |
| 12:43 |
dbs |
Dyrcona: maybe I'm really forgetting my git, but the workflow I'm intending is: 1. Checkout a clean rel_3_3 branch 2. Merge the rel_3_4 branch on top of it |
| 12:43 |
Dyrcona |
dbs: Why? |
| 12:43 |
Dyrcona |
Just checkout rel_3_4. |
| 12:43 |
dbs |
Testing the upgrade path from rel_3_3 to rel_3_4 for those who install from git |
| 12:44 |
Dyrcona |
That's not how you upgrade. |
| 12:44 |
Dyrcona |
Well, now how I upgrade. |
| 12:44 |
dbs |
Funny, that's how I've upgraded ever since we moved to git |
| 12:44 |
Dyrcona |
First... You have about half a dozen custom feature branches..... |
| 12:44 |
Dyrcona |
dbs: git merge -X theirs |
| 12:46 |
Dyrcona |
I've always used rebase for my local branches when going to something new, and the -X theirs option works well there, too. |
| 12:46 |
|
jvwoolf joined #evergreen |
| 12:47 |
csharp |
@band add X Theirs |
| 12:47 |
pinesol |
csharp: Band 'X Theirs' added to list |
| 12:47 |
csharp |
an X cover band, obvs |
| 12:49 |
* dbs |
just finished reading Under the Big Black Sun, on that note |
| 12:49 |
|
jvwoolf1 joined #evergreen |
| 12:49 |
Dyrcona |
A propos the upcoming presentation.... zoom urls don't seem to work in Chromium. |
| 12:50 |
csharp |
dbs: oooh - I'll have to take a look at that |
| 12:50 |
csharp |
dbs: just read Trouble Boys about the Replacements - excellent read |
| 12:50 |
dbs |
Dyrcona++ # 'git merge -X theirs upstream/rel_3_4' seems to work pretty nicely, thank you |
| 12:52 |
Dyrcona |
I prefer rebase over merge if I have local commits in the branch because it keeps those custom commits at the "top." |
| 12:52 |
Dyrcona |
^for the logs |
| 12:52 |
agoben |
Dyrcona: the page won't load? |
| 12:53 |
Dyrcona |
agoben: The page loads, I get a dialog asking me to run xdg-open, then nothing. It works with Firefox, so no real problem. I use Ubuntu on the desktop, so ... |
| 12:53 |
agoben |
Huh. |
| 12:54 |
agoben |
Glad you can still get on, but frustrating news. |
| 12:54 |
Dyrcona |
It's probably a configuration in Chromium thing. |
| 12:54 |
agoben |
mmhmm |
| 12:56 |
sandbergja |
berick: I think that the whenStable() business might have been autogenerated. I don't believe they serve any purpose |
| 12:57 |
sandbergja |
I'd been fiddling with an angular unit test auto-generator at the time, so the timing is suspicious. :-) |
| 12:57 |
Dyrcona |
hurrah for looking at diffs before committing... I found a "bug" in my README changes. |
| 13:05 |
|
_bott_ joined #evergreen |
| 13:05 |
berick |
sandbergja: ok, cool, i'll push a patch to remove them, for now anyway, so we can un-break the test server |
| 13:05 |
csharp |
berick: https://pastebin.com/i2Q4Hfme |
| 13:06 |
sandbergja |
berick++ |
| 13:07 |
csharp |
berick: https://bugs.launchpad.net/evergreen/+bug/1712861 |
| 13:07 |
pinesol |
Launchpad bug 1712861 in Evergreen "web client: notices column picker option not available in holds interfaces" [Medium,Confirmed] |
| 13:10 |
Dyrcona |
csharp: I thought that was fixed recently... Maybe it was something else? |
| 13:12 |
sandbergja |
Oh man! I also want to know what the leap at the end of gmcharlt's presentation was! |
| 13:12 |
berick |
csharp: try this: |
| 13:12 |
berick |
- for my $rkey (keys %$restrictions{$r}) { |
| 13:12 |
berick |
+ for my $rkey (keys %{$restrictions->{$r}}) { |
| 13:14 |
|
sandbergja_ joined #evergreen |
| 13:16 |
jeff |
Has the 1 PM discussion been re-scheduled? |
| 13:16 |
Dyrcona |
It hasn't started is all I know. |
| 13:17 |
agoben |
Galen presented at 11 this morning. |
| 13:17 |
Dyrcona |
Well, that's a bummer. |
| 13:17 |
agoben |
I've got the recording, and I'll get that converted for posting ASAP |
| 13:18 |
sandbergja |
agoben++ |
| 13:18 |
Dyrcona |
eady || jonadab: bug 1849364 |
| 13:18 |
pinesol |
Launchpad bug 1849364 in OpenSRF "Add Installation Support For Devuan" [Wishlist,In progress] https://launchpad.net/bugs/1849364 |
| 13:19 |
jeff |
Aha! That explains it. |
| 13:19 |
jeff |
agoben++ looking forward to it |
| 13:19 |
* jeff |
updates calendar |
| 13:20 |
jeff |
Is the 2 PM discussion still likely to take place at 2 PM? |
| 13:22 |
agoben |
Yes. |
| 13:22 |
agoben |
Everything is staged for that one :) |
| 13:26 |
|
yboston joined #evergreen |
| 13:43 |
phasefx |
Dyrcona: did seem temporary, working for me now :D thanks! |
| 13:43 |
sandbergja |
BMagic: devted: when I try to run `antora site.yml`, I get the error `Start page specified for site not found: docs::index` |
| 13:43 |
sandbergja |
I can remove that line from site.yml, but then all that gets generated is a 404 page |
| 13:43 |
jonadab |
Dyrcona: Thanks. |
| 13:43 |
sandbergja |
Any troubleshooting tips? |
| 13:43 |
berick |
JBoyer: https://bugs.launchpad.net/evergreen/+bug/1830973/comments/4 |
| 13:43 |
pinesol |
Launchpad bug 1830973 in Evergreen "Update to Angular version 8" [Wishlist,Fix committed] |
| 13:43 |
sandbergja |
...or is it just supposed to be a stub at this point anyway? |
| 13:43 |
Dyrcona |
Well, Devuan Beowulf forces things on the Pg front. There's only a Pg 11 package available. |
| 13:43 |
Bmagic |
sandbergja: it's supposed* to work |
| 13:43 |
Bmagic |
I got that error once.... not sure how I solved it |
| 13:43 |
sandbergja |
I can keep fiddling with it! |
| 13:43 |
Bmagic |
I believe it's a relative path issue |
| 13:45 |
Bmagic |
do you have this flie: docs/modules/ROOT/pages/index.adoc ? |
| 13:46 |
devted |
sandbergja: We've seen that before but i"m not sure now. Checkout: https://gitlab.com/antora/antora/issues/282 |
| 13:46 |
Bmagic |
oh! |
| 13:46 |
Bmagic |
sandbergja: you have to name your local branch exactly the same as what's mentioned in the site.yml |
| 13:48 |
sandbergja |
Bmagic: Aha! |
| 13:48 |
Bmagic |
antora "privately" opens the git repo and switches to the branch that is mentioned in site.yml |
| 13:48 |
Bmagic |
regardless of what branch you are on when you run the antora command |
| 13:49 |
sandbergja |
Bmagic: winner winner chicken dinner! |
| 13:49 |
Bmagic |
I should have mentioned that in the README! |
| 13:49 |
sandbergja |
I have an antora now! |
| 13:49 |
Bmagic |
yes! |
| 13:49 |
sandbergja |
Bmagic++ |
| 13:49 |
Bmagic |
sandbergja++ |
| 13:51 |
alynn26 |
bmagic++ sandbergja++ |
| 13:57 |
phasefx |
Dyrcona: broke again :D :D |
| 13:57 |
berick |
phasefx: sandbergja: fix for test server errors: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830973-ang8-test-spec-repair |
| 13:57 |
phasefx |
berick++ |
| 14:00 |
Dyrcona |
I wonder if we really need the different numbered versions of 000.english.pg94.fts-config.sql. It hasn't changed since Pg 9.4. |
| 14:00 |
|
terranm joined #evergreen |
| 14:00 |
pinesol |
[evergreen|Tiffany Little] LP #1765434 Browser refresh closes purchase order - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=87f01e7> |
| 14:10 |
jeff |
Antora appears to nicely handle "this page in other versions of your software". |
| 14:11 |
jeff |
You can also publish to GitHub pages (which isn't the wiki, but this is replacing docs and not the wiki, right?). |
| 14:11 |
dbs |
mmm. where's the zoom link for this afternoon's session? |
| 14:11 |
jeff |
https://zoom.us/j/641517053?pwd=d044ZlBzclZGMGFTaVBWMTJXdEpQZz09 |
| 14:11 |
jeff |
one link for all sessions today, i think. |
| 14:12 |
agoben |
Yes, just the one stream today |
| 14:12 |
dbs |
jeff++ |
| 14:13 |
jeff |
You can version and not-version components: https://docs.antora.org/antora/2.1/component-versions/ |
| 14:16 |
|
yboston joined #evergreen |
| 14:16 |
|
jvwoolf1 left #evergreen |
| 14:18 |
Dyrcona |
phasefx: I'm about to find out if it works for me or not. |
| 14:19 |
dbs |
we can always use asciidoctor to generate epub and pdf |
| 14:21 |
dbs |
(pdf is on the "unscheduled roadmap" https://gitlab.com/antora/antora/issues/349) |
| 14:21 |
* dbs |
claps |
| 14:22 |
jeff |
is anyone printing the current documentation and would miss being able to print documentation after a move to antora? |
| 14:23 |
* jeff |
waves |
| 14:23 |
tlittle |
I'm sure that people do print certain pages of it; not sure if anyone prints an entire manual or not. |
| 14:23 |
abneiman |
PDF is also handy to save the entire manual (or save functional chunks, like Circ) if that's needed |
| 14:24 |
jeff |
for the "saving" use case, the antora output is all offline-friendly, relative links, etc. |
| 14:24 |
* dbs |
abhors printing but works with people who like printed technical material |
| 14:25 |
jeff |
see "Offline first." at https://docs.antora.org/antora/2.0/features/#produce-a-site-from-a-simple-playbook |
| 14:25 |
abneiman |
jeff++ thanks |
| 14:25 |
|
nfBurton joined #evergreen |
| 14:27 |
jeff |
'welcome! |
| 14:41 |
|
EVGHack-A-Way joined #evergreen |
| 14:52 |
Dyrcona |
phasefx: I just did a fresh install of master with no issues. |
| 14:53 |
phasefx |
Dyrcona: must be my chaos powers; still happening for me, debian stretch |
| 14:54 |
Dyrcona |
phasefx: I installed on devuan bewoulf, i.e. debian buster. |
| 14:54 |
Dyrcona |
@blame systemd |
| 14:54 |
pinesol |
Dyrcona: I come to bury systemd, not to praise them. |
| 14:56 |
csharp |
@who buried systemd? |
| 14:56 |
pinesol |
dbwells_ buried systemd. |
| 15:06 |
berick |
@who super-loves systemd |
| 15:06 |
pinesol |
remingtron super-loves systemd. |
| 15:07 |
|
agoben joined #evergreen |
| 15:09 |
Dyrcona |
emacs++ |
| 15:11 |
abneiman |
berick: https://bugs.launchpad.net/evergreen/+bug/1849372 |
| 15:11 |
pinesol |
Launchpad bug 1849372 in Evergreen "angular: modals do not automatically close when navigating away from pages" [Undecided,New] |
| 15:19 |
berick |
abneiman++ |
| 15:21 |
bshum |
csharp: your branch for PG 10 is only doing the server target, not the client side too? Just asking cause I remember the system will install PG 9.6 client in the other prereqs in the main list |
| 15:29 |
* dbs |
ended up using tig to cherry-pick our actual changes on top of rel_3_4 - might be able to do clean rebases in the future (fingers crossed) |
| 15:29 |
Dyrcona |
dbs: I use -X theirs with rebases, too. |
| 15:30 |
dbs |
Dyrcona: thanks man! Never not learning |
| 15:32 |
dbs |
We used to put presentations in random, ages ago |
| 15:33 |
* berick |
still does |
| 15:34 |
Dyrcona |
We lost video on the zoom feed, still have audio. |
| 15:34 |
berick |
i think it's off now |
| 15:34 |
berick |
we're just huddled |
| 15:35 |
dbs |
berick++ |
| 15:36 |
dbs |
Maybe call it "shrinkage" to maintain Seinfeld references? |
| 15:36 |
Dyrcona |
devted: On the branch name, I usually put {user,collab}/username/.... on local branches if I'm going to push to random or working. |
| 15:37 |
Dyrcona |
You don't have to push with a different name. |
| 15:38 |
Dyrcona |
Well, I can hear the conversation... Maybe I'll dop off, now? |
| 15:40 |
csharp |
bshum: yeah, miker and I were discussing that earlier - we ended up kind of shrugging about it |
| 15:41 |
csharp |
bshum: the other approach would've been something like --with-pg-version-10 or POSTGRESQL_VERSION=10 that would allow more flexibility |
| 15:42 |
csharp |
I went with the approach meant to avoid rejiggering the entire infrastructure :-) |
| 15:43 |
agoben |
Sorry, the recording computer got unplugged. Am restarting |
| 15:43 |
csharp |
@who tried turning it off and back on again? |
| 15:43 |
pinesol |
jyorio tried turning it off and back on again. |
| 15:43 |
Dyrcona |
In my Devuan branch, I'm going with the version that comes native with that release, so Pg 9.6 on Ascii and Pg 10 on Beowulf. |
| 15:44 |
Dyrcona |
I think we should just install the native version of Pg, unless that distro comes with < 9.6. |
| 15:45 |
|
EVGHack-A-Way joined #evergreen |
| 15:45 |
csharp |
the other thing Bmagic and I were discussing was possibly being able to specify the version manually on the command line, falling back to 9.6 |
| 15:45 |
csharp |
I just didn't want to spend the rest of the hackaway slogging through GNU make docs :-) |
| 15:46 |
Dyrcona |
csharp: I'm going to have a look at your branch. |
| 15:47 |
csharp |
Dyrcona: thanks! |
| 15:52 |
Dyrcona |
Yeah, it could be specified with an environment variable on the command line: PGVERSION=10 make -f Makefile.install ubuntu-xenial |
| 15:53 |
pastebot |
"miker" at 168.25.130.30 pasted "hey, berick, does this look like a sane start? (not sure "this" works there...)" (19 lines) at http://paste.evergreen-ils.org/10089 |
| 15:54 |
devted |
Dyrcona: Thank you! |
| 15:54 |
devted |
I have pushed the Row Level Security examples.txt to shrink Evergreen DB to here: |
| 15:54 |
devted |
https://git.evergreen-ils.org/?p=working/random.git;a=shortlog;h=refs/heads/user/devted/pg_rls_shrink_evergreen |
| 15:55 |
Dyrcona |
devetd++ I'll take a look tomorrow. |
| 15:55 |
dbs |
devted++ |
| 15:56 |
devted |
dbs: Thanks! |
| 15:56 |
|
khuckins joined #evergreen |
| 15:56 |
Dyrcona |
heh. sorry for the typo. |
| 15:56 |
devted |
I only got through the 'money' schema alphabetically. |
| 15:56 |
Dyrcona |
devted++ |
| 15:57 |
devted |
vandelay and reporter are the only sizable schemas alphabetically after 'money' |
| 15:57 |
devted |
I'll push a revision once I finish getting all the schemas subsetted with RLS policies |
| 15:58 |
Dyrcona |
I'll have to read up on rls before I can make any useful comments or additions, but examples are always nice as a starting point. |
| 15:59 |
csharp |
devted++ |
| 16:01 |
Bmagic |
devted++ |
| 16:09 |
|
tlittle59 joined #evergreen |
| 16:10 |
sandbergja |
terran++ # accessibility work! |
| 16:14 |
dbs |
sandbergja: I'm looking at adding CAS authentication for our Evergreen instance in the December timeframe; might be worthwhile sharing the requirements even for those who aren't potential bidders to see what overlap there might be? |
| 16:14 |
phasefx |
Dyrcona: Galen pointed me in the right direction; I missed that lp1830973 had gone in |
| 16:15 |
* dbs |
vaguely remembers a Solr talk from the last EG Conf he attended, that was roughly "Solr is AWESOME" |
| 16:16 |
sandbergja |
dbs: how exciting! Here are the specs that equinox provided: https://yeti.esilibrary.com/dev/public/techspecs/sso_eg.pdf |
| 16:16 |
sandbergja |
And here are our original requirements: https://docs.google.com/document/d/13QLkD_ujeEWVhQ-3wt1VAmZDJgbvbaRHORfPQuIn6us/edit?usp=sharing |
| 16:16 |
sandbergja |
And I can share them with the email list as well. :-) |
| 16:17 |
dbs |
sandbergja++ |
| 16:19 |
dbs |
oh looks like the Solr pres I saw was back in 2013 - http://eg2013.evergreen-ils.org/schedule/session-descriptions/index.html#solr |
| 16:22 |
Dyrcona |
phasefx: Cool. Glad you got it sorted. |
| 16:23 |
Dyrcona |
csharp: The trick won't be getting the pg version from a variable, the trick will be making sure that the variable's value is valid and >= 9.6. Might need a make function, which pretty much limits us to GNU make, not that Evergreen builds without it, now. |
| 16:26 |
|
abowling_ joined #evergreen |
| 16:26 |
|
abowling__ joined #evergreen |
| 16:33 |
bshum |
csharp: I know that ultimately the PG client version doesn't have to match up the server. I just like tidy things. I see Dyrcona is looking though, so perhaps I'll let him ponder some more on it before I look too |
| 16:33 |
pinesol |
[evergreen|Jeff Davis] LP#1844720: avoid hard-coded paths in Apache config - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d0b801b> |
| 16:33 |
berick |
+1 to matching client / server PG versions |
| 16:33 |
|
agoben joined #evergreen |
| 16:34 |
Dyrcona |
Well, when they don't match, you get this message about some features not being available in psql, and some of the other tools, pg_dump, pg_restore, don't work correctly if the versions don't match the server. |
| 16:44 |
dbs |
hmm, installing node LTS and running npm install results in a warning about missing ajv 6 package that i must install myself; resolution seems to either be 'npm i -g npm' or to manually install ajv with 'npm i ajv6' |
| 16:44 |
dbs |
Is that something that should be added to https://evergreen-ils.org/documentation/install/README_3_4_0.html#install_files_for_web_staff_client ? |
| 16:46 |
|
jihpringle joined #evergreen |
| 16:46 |
Dyrcona |
dbs: I've not encountered that, and I've done a few installs recently, including 1 today and 1 yesterday. |
| 16:47 |
dbs |
Dyrcona: interesting, this is a rel_3_4 checkout, using Node 12.13.0 |
| 16:47 |
bshum |
That sounds pretty new... |
| 16:47 |
bshum |
I know our Node version we checkout is pretty ancient |
| 16:48 |
bshum |
For the makefile anyways |
| 16:48 |
bshum |
Too new and stuff tends to break |
| 16:48 |
dbs |
"npm build prod" was fine but "npm run test" fails due to PhantomJS (I seem to recall that being a known issue) |
| 16:48 |
dbs |
This in on Ubuntu Xenial. I'm just following the docs, which tell people to download and use Node LTS |
| 16:49 |
dbs |
(https://evergreen-ils.org/documentation/install/README_3_4_0.html#_install_dependencies_for_web_staff_client) |
| 16:50 |
bshum |
I guess that's a bad instruction :) |
| 16:50 |
bshum |
We put the specific Node version in the makefile prereqs awhile ago |
| 16:50 |
bshum |
Though we should have bumped that a few times ago |
| 16:51 |
gmcharlt |
miker: bug 1849372 is ready for you |
| 16:51 |
pinesol |
Launchpad bug 1849372 in Evergreen 3.4 "angular: modals do not automatically close when navigating away from pages" [Medium,Confirmed] https://launchpad.net/bugs/1849372 |
| 16:51 |
dbs |
ah the advantage of fresh eyes :) |
| 16:51 |
|
abowling joined #evergreen |
| 16:51 |
Dyrcona |
dbs: I almost never run the tests, and either do node programmers.:) |
| 16:52 |
bshum |
dbs: I probably just didn't notice because I ran the "optional developer additions" options during my read-through |
| 16:52 |
bshum |
And it tells me to skip that step if I do :D |
| 16:52 |
|
abowling joined #evergreen |
| 16:52 |
Dyrcona |
Oh, yeah: What bshum said. |
| 16:53 |
* bshum |
needs more newbies around to keep us honest |
| 16:53 |
Dyrcona |
The latest node lts is probably too new for us. |
| 16:53 |
bshum |
It definitely is |
| 16:53 |
JBoyer |
all of this talk about tests has me thinking about lp 1845693 |
| 16:53 |
pinesol |
Launchpad bug 1845693 in Evergreen "Replacement needed for PhantomJS" [Undecided,New] https://launchpad.net/bugs/1845693 |
| 16:54 |
bshum |
Or it was... |
| 16:54 |
bshum |
Hmm |
| 16:54 |
|
abowling joined #evergreen |
| 16:54 |
bshum |
I see you guys just bumped it up |
| 16:54 |
bshum |
From v8.11.4 to v12.13.0 |
| 16:54 |
bshum |
So.... maybe it's fine now |
| 16:55 |
Dyrcona |
Hmm... Part of the Angular 8 changes? |
| 16:55 |
JBoyer |
yeah |
| 16:55 |
bshum |
3429a244fbd918dead6cc03a1ea328d7971abc1d |
| 16:55 |
pinesol |
bshum: [evergreen|Bill Erickson] LP1830973 Node install v12.6.0 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3429a24> |
| 16:55 |
bshum |
Must be, yeah |
| 16:55 |
Dyrcona |
I installed that today, but didn't notice the node version. |
| 16:56 |
bshum |
"That's what you get for missing staff meetings, Doctor." |
| 16:56 |
Dyrcona |
:) |
| 16:56 |
dbs |
So I guess we should get rid of the docs that tell people to manually install node and run tests? |
| 16:56 |
Dyrcona |
I was at that meeying. |
| 16:56 |
Dyrcona |
dbs: Yes. |
| 16:57 |
|
abowling joined #evergreen |
| 16:58 |
|
abowling joined #evergreen |
| 17:00 |
|
abowling joined #evergreen |
| 17:01 |
bshum |
dbs++ # testing the docs |
| 17:02 |
Dyrcona |
dbs++ |
| 17:04 |
|
abowling joined #evergreen |
| 17:10 |
|
abowling_ joined #evergreen |
| 17:14 |
|
jihpringle joined #evergreen |
| 17:24 |
Dyrcona |
Just following up from node discussions earlier: I do have Node 12.13 installed. Looks like it works with the latest master. |
| 17:24 |
Dyrcona |
It is probably too new for 3.4 or earlier, though. I have seen that before where upgrading Node and/or npm breaks the installation. |
| 17:24 |
dbs |
Dyrcona++ |
| 17:25 |
Dyrcona |
So, to get the preferred Node for your release of Evergreen use the {distro}-developer prerequisite install step if you're installing from git. |
| 17:26 |
dbs |
Right - that's pretty much what I was cutting the branch down to |
| 17:27 |
dbs |
Weirdly, on 3.4 I seem to be able to run tests with PhantomJS on the /src/eg2/ dir but not on the /web/js/ui/default/staff/ dir |
| 17:35 |
dbs |
Took the minimalist step first to just remove the "install latest LTS node from source" instruction as I'm not 100% confident about the eg2 vs. web/js/ui test situation |
| 17:35 |
dbs |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/docs_remove_node_source |
| 17:36 |
Dyrcona |
dbs: PhantomJS is out of date and no loneger maintained. There are some recent JS constructs that it can't process, and I think one or two have slipped into the AngularJS code. |
| 17:37 |
Dyrcona |
I briefly considered taking over the project to update it, but after about half an hour of looking into it, I decided that it would be more work than I'm able to take on right now. |
| 17:41 |
dbs |
Right, I get that. I just hate taking out instructions to run tests if they work (which they seem to for /src/eg2/ for some reason) |
| 17:42 |
dbs |
But if everyone runs into test failures with /web/js/ui/default/staff then we should stop telling people to test. I just wasn't sure if that was the actual state of things. |
| 17:42 |
dbs |
I'll add another commit that removes the "npm run test" steps and related verbiage |
| 17:46 |
dbs |
Updated the branch accordingly |
| 20:54 |
|
sandbergja joined #evergreen |
| 21:26 |
|
sandbergja joined #evergreen |
| 21:40 |
|
sandbergja joined #evergreen |
| 23:03 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-10-22T23:00:56,173131253-0400 -0> |
| 23:03 |
pinesol |
News from qatests: Failed Log Output: osrfsys.log <http://testing.evergreen-ils.org/~live/test.76.html#2019-10-22T23:00:56,214485939-0400 -2> |
| 23:13 |
|
sandbergja joined #evergreen |
| 23:53 |
|
sandbergja joined #evergreen |
