| Time |
Nick |
Message |
| 04:26 |
|
yar joined #evergreen |
| 05:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:20 |
|
sandbergja joined #evergreen |
| 07:02 |
|
agoben joined #evergreen |
| 07:06 |
|
rjackson_isl joined #evergreen |
| 07:48 |
|
bos20k joined #evergreen |
| 08:25 |
|
sandbergja joined #evergreen |
| 08:34 |
|
sandbergja joined #evergreen |
| 08:38 |
|
mmorgan joined #evergreen |
| 09:08 |
|
Dyrcona joined #evergreen |
| 09:25 |
|
aabbee joined #evergreen |
| 09:26 |
|
sandbergja joined #evergreen |
| 09:42 |
pinesol |
[evergreen|Jane Sandberg] Docs: 3.1.13 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7fc139c> |
| 09:50 |
pinesol |
[evergreen|Jane Sandberg] Docs: Release notes for 3.2.7 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4396b67> |
| 09:52 |
pinesol |
[evergreen|Jane Sandberg] Docs: 3.3.2 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f313a5d> |
| 09:52 |
Dyrcona |
sandbergja++ |
| 09:53 |
sandbergja |
bug_fixes++ |
| 09:53 |
sandbergja |
It will be nice to have all those goodies from bug squashing week released |
| 09:53 |
Dyrcona |
Yes, indeed. |
| 10:03 |
berick |
sandbergja++ |
| 10:06 |
|
Dyrcona joined #evergreen |
| 10:07 |
|
gsams joined #evergreen |
| 10:17 |
sandbergja |
I'm running into some issues with an OpenSRF call: open-ils.storage.booking.reservation.resource_targeter |
| 10:17 |
sandbergja |
When I go to opensrf and run the following, everything works well: |
| 10:17 |
sandbergja |
request open-ils.storage open-ils.storage.booking.reservation.resource_targeter 499 |
| 10:18 |
sandbergja |
But when I run the following in the Angular client, it doesn't do any targeting: |
| 10:18 |
sandbergja |
this.net.request('open-ils.storage', 'open-ils.storage.booking.reservation.resource_targeter', 499) |
| 10:18 |
sandbergja |
And when I subscribe to that and try to get it to console.log something, opensrf.js gets mad and I get the following error in the console: |
| 10:18 |
sandbergja |
TypeError: payload.statusCode is not a function |
| 10:18 |
sandbergja |
Any thoughts on what I should try next? |
| 10:23 |
jeff |
open-ils.storage is a private OpenSRF service and isn't exposed via things like the gateway or translators. You can't directly make an open-ils.storage call from Angular. |
| 10:23 |
sandbergja |
jeff++ |
| 10:23 |
sandbergja |
That makes sense! |
| 10:23 |
jeff |
This is intentional, because open-ils.storage has no permission checks. It's meant to be called by other OpenSRF services. |
| 10:24 |
sandbergja |
I was wondering about the permission checks |
| 10:25 |
sandbergja |
It's all coming together |
| 10:25 |
sandbergja |
Thanks, jeff! |
| 10:25 |
jeff |
There's a section of opensrf_core.xml where services which register with the public router are listed, if you're curious to see which are which and know how the mechanics work. |
| 10:26 |
miker |
sandbergja: you may find it easiest to copy the open-ils.circ method that sits atop the hold targeter and checks perms. it should be in OpenILS/Application/Circ/Holds.pm |
| 10:26 |
miker |
and make a booking retargeter public method |
| 10:27 |
sandbergja |
that makes sense |
| 10:29 |
sandbergja |
I'm wondering: would it be possible/desirable to include a more descriptive error message when somebody tries to call a private OpenSRF service from within the Angular client? |
| 10:30 |
jeff |
It could be possible to add more error handling to detect when you're trying to call a service or method that doesn't exist on the public router. |
| 10:32 |
miker |
yeah, a low-level error is returned, and the egNet module could console.log() something |
| 10:33 |
sandbergja |
I'll think about that and get something on LP |
| 10:33 |
sandbergja |
jeff++ |
| 10:33 |
sandbergja |
miker++ |
| 10:37 |
jeff |
It looks like a non-existent service on the JSON gateway returns 200 OK with a body of {"payload":[],"status":200} |
| 10:37 |
jeff |
But the translator returns a 404. |
| 10:37 |
jeff |
(with an HTML body) |
| 10:42 |
berick |
sandbergja: https://bugs.launchpad.net/opensrf/+bug/1776510 |
| 10:42 |
berick |
what version of opensrf are you running? |
| 10:42 |
pinesol |
Launchpad bug 1776510 in OpenSRF 2.5 "Websockets JS fails to handle handle transport errors" [Medium,Fix committed] |
| 10:42 |
miker |
jeff: I think the websocket transport will return something more useful, though ... or, I hope. it should be returning a 404 (opensrf, not http) error from the router |
| 10:43 |
miker |
or, what berick said... nm me |
| 10:43 |
jeff |
looks like it does! |
| 10:43 |
sandbergja |
berick: Ahhh... I was using 3.0.1 |
| 10:58 |
|
khuckins joined #evergreen |
| 11:18 |
|
bos20k joined #evergreen |
| 11:20 |
|
collum joined #evergreen |
| 11:20 |
|
sandbergja joined #evergreen |
| 11:58 |
Dyrcona |
custom-template-directory-- |
| 11:59 |
berick |
sandbergja: bug 1823041 will need some rebasing and additions given recent master merges. let me know if/how I can assist. |
| 11:59 |
pinesol |
Launchpad bug 1823041 in Evergreen "Angular dialogs should limit promise rejections to error conditions" [Medium,Confirmed] https://launchpad.net/bugs/1823041 - Assigned to Jane Sandberg (sandbej) |
| 12:03 |
sandbergja |
berick: thanks! I'll try out the rebasing updating, if you would be so kind as to check my work once it is done. |
| 12:07 |
berick |
:thumbs-up: |
| 12:08 |
|
jihpringle joined #evergreen |
| 12:08 |
|
Christineb joined #evergreen |
| 12:39 |
Dyrcona |
emerge-files++ |
| 13:10 |
|
sandbergja joined #evergreen |
| 13:20 |
|
sandbergja joined #evergreen |
| 13:31 |
|
sandbergja joined #evergreen |
| 14:24 |
|
sandbergja joined #evergreen |
| 14:56 |
sandbergja |
berick: I pushed my Observable-ization working branch for bug 1823041. Your eyes would be much appreciated! |
| 14:56 |
pinesol |
Launchpad bug 1823041 in Evergreen "Angular dialogs should limit promise rejections to error conditions" [Medium,Confirmed] https://launchpad.net/bugs/1823041 |
| 14:57 |
berick |
sandbergja: thanks, reviewing |
| 15:04 |
|
khuckins joined #evergreen |
| 15:24 |
|
gsams joined #evergreen |
| 15:38 |
|
csharp joined #evergreen |
| 15:42 |
|
csharp joined #evergreen |
| 16:44 |
|
sandbergja joined #evergreen |
| 17:04 |
sandbergja |
berick++ |
| 17:09 |
|
mmorgan left #evergreen |
| 17:20 |
Bmagic |
Anyone familiar with a bug in the reporter in the situation where you have a "Deleted?" value setup for "In List" ? |
| 17:21 |
Bmagic |
when it's "In List" - you receive a dropdown menu with "True" and "False" and no matter which one you choose to add to the list: the list will always display "True" |
| 17:21 |
Bmagic |
but the report runs correctly. AKA if you chose "False" it looks for deleted? = 'f' in the SQL query. |
| 17:22 |
jihpringle |
Bmagic: possibly related to - https://bugs.launchpad.net/evergreen/+bug/1642337 |
| 17:22 |
pinesol |
Launchpad bug 1642337 in Evergreen 3.2 "Web Staff Client - Boolean Filters in Reporter" [Medium,Fix committed] |
| 17:23 |
Bmagic |
I saw that one. I don't think* so. As this report is a xul generated template |
| 17:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 17:31 |
dbwells |
Bmagic: Possibly this? https://bugs.launchpad.net/evergreen/+bug/1833080 |
| 17:31 |
pinesol |
Launchpad bug 1833080 in Evergreen "eg-bool is relentlessly positive" [Medium,New] |
| 17:32 |
dbwells |
Or is this all XUL? |
| 17:32 |
Bmagic |
reporter interface. Template in question was created with XUL |
| 17:32 |
dbwells |
And maybe not exactly that, but could be the same root cause. |
| 17:32 |
Bmagic |
it could be! |
| 17:33 |
|
sandbergja joined #evergreen |
| 18:07 |
miker |
Bmagic: in-list isn't really a useful operator for a boolean column since there are only 2 possible non-null values... what's the use case? (note: I'm running away, may not respond until tomorrow) |
| 19:21 |
|
sandbergja joined #evergreen |
| 19:52 |
|
Christineb joined #evergreen |
| 19:58 |
|
sandbergja joined #evergreen |
| 21:20 |
|
yar joined #evergreen |
| 21:42 |
|
sandbergja joined #evergreen |
