| Time |
Nick |
Message |
| 00:12 |
|
dbwells_ joined #evergreen |
| 00:12 |
|
remingtron joined #evergreen |
| 06:59 |
|
agoben joined #evergreen |
| 07:39 |
|
Dyrcona joined #evergreen |
| 08:23 |
|
bos20k joined #evergreen |
| 08:43 |
|
mmorgan joined #evergreen |
| 09:06 |
|
lsach joined #evergreen |
| 09:30 |
|
kmlussier joined #evergreen |
| 09:46 |
|
yboston joined #evergreen |
| 09:49 |
|
jvwoolf joined #evergreen |
| 09:52 |
kmlussier |
@coffee [someone] |
| 09:52 |
* pinesol |
brews and pours a cup of Romance by Paradise, and sends it sliding down the bar to dluch |
| 09:59 |
* mmorgan |
wonders what a cup of "Romance by Paradise" might taste like :-/ |
| 10:02 |
|
bdljohn joined #evergreen |
| 10:25 |
|
beanjammin joined #evergreen |
| 10:26 |
mmorgan |
I'm setting up a New User created Welcome notice action trigger with a custom filter that is supposed to filter by permission profile and home_ou. |
| 10:27 |
mmorgan |
It's filtering by home_ou, but not profile. |
| 10:28 |
pastebot |
"mmorgan" at 64.57.241.14 pasted "Custom au.created filter" (10 lines) at http://paste.evergreen-ils.org/14265 |
| 10:28 |
mmorgan |
Any ideas? I'm not a master at json queries :-/ |
| 10:32 |
|
sandbergja joined #evergreen |
| 10:32 |
berick |
mmorgan: not an answer to your question, but fyi you don't need the "-and" layers. {"active":"t", "deleted":"f", "profile": [...], ...} |
| 10:34 |
berick |
and actually the -and's are the problem |
| 10:34 |
berick |
because they are duplicate hash keys |
| 10:35 |
berick |
so some of the filters are getting clobbered |
| 10:36 |
mmorgan |
berick: Ah, ok. Let me try it without those -and's |
| 10:53 |
mmorgan |
So, first, removed all the -and's and it filtered on profile, but not home_ou. This seems to do the trick: |
| 10:53 |
pastebot |
"mmorgan" at 64.57.241.14 pasted "Fixed filter" (11 lines) at http://paste.evergreen-ils.org/14266 |
| 10:53 |
mmorgan |
berick++ |
| 11:13 |
pastebot |
"Dyrcona" at 64.57.241.14 pasted "mmorgan: This doesn't work?" (12 lines) at http://paste.evergreen-ils.org/14267 |
| 11:14 |
berick |
mmorgan: home_ou is special in this case, since it's used as the "context_org" -- it may be getting clobbered at run time by the code that goes looking for patrons to process. |
| 11:15 |
|
khuckins joined #evergreen |
| 11:15 |
berick |
i'm guessing you don't want to have to define a whole bunch of event-defs (one per org unit) |
| 11:15 |
berick |
so you'd rather filter by home_ou |
| 11:15 |
berick |
which makes sense |
| 11:16 |
berick |
but i'm not super surprised it may be funky, since it's duplicating a filter |
| 11:16 |
mmorgan |
Dyrcona: no that did not work. I got events for patrons with home_ou's that should have been excluded |
| 11:16 |
Dyrcona |
OK. Makes sense in light of what berick said after I pasted that. :) |
| 11:17 |
dbwells |
If home_ou is indeed getting clobbered as suggested, using "-and" here is a pretty handy workaround. |
| 11:17 |
berick |
yeah |
| 11:18 |
mmorgan |
berick: yes, this event is the one that applies to *most* patrons. There will be some for specific ous also. |
| 11:18 |
pastebot |
"miker" at 64.57.241.14 pasted "mmorgan: you might try..." (10 lines) at http://paste.evergreen-ils.org/14268 |
| 11:18 |
|
sandbergja joined #evergreen |
| 11:19 |
miker |
(or the -and suggestion, either should protect the home_ou filter from clobbering) |
| 11:26 |
mmorgan |
Thanks, miker, that filter works, too. |
| 11:27 |
* mmorgan |
has printed out the docs on json queries for bedtime reading ;-) |
| 11:37 |
kmlussier |
mmorgan: Those should help you get to sleep quickly! |
| 11:38 |
mmorgan |
Or they might keep me awake! |
| 11:51 |
|
beanjammin joined #evergreen |
| 11:58 |
|
jvwoolf joined #evergreen |
| 12:51 |
|
yboston joined #evergreen |
| 13:18 |
|
yboston joined #evergreen |
| 13:29 |
|
ohiojoe joined #evergreen |
| 13:46 |
ohiojoe |
DIG meeting in about 15 minutes |
| 13:50 |
|
jihpringle joined #evergreen |
| 14:00 |
ohiojoe |
#startmeeting 2018-11-01 – Documentation Interest Group Meeting |
| 14:00 |
pinesol |
Meeting started Thu Nov 1 14:00:26 2018 US/Eastern. The chair is ohiojoe. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 14:00 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 14:00 |
|
Topic for #evergreen is now (Meeting topic: 2018-11-01 – Documentation Interest Group Meeting) |
| 14:00 |
pinesol |
The meeting name has been set to '2018_11_01___documentation_interest_group_meeting' |
| 14:00 |
ohiojoe |
#topic agenda |
| 14:00 |
|
Topic for #evergreen is now agenda (Meeting topic: 2018-11-01 – Documentation Interest Group Meeting) |
| 14:00 |
ohiojoe |
#link https://wiki.evergreen-ils.org/doku.php?id=evergreen-docs:dig_meetings:20181101-agenda |
| 14:00 |
ohiojoe |
#topic Introductions: please paste "#info <username> is <name> <affiliation>" to identify who you are and what organization, if any, you represent |
| 14:00 |
|
Topic for #evergreen is now Introductions: please paste "#info <username> is <name> <affiliation>" to identify who you are and what organization, if any, you represent (Meeting topic: 2018-11-01 – Documentation Interest Group Meeting) |
| 14:03 |
sandbergja |
#info sandbergja is Jane Sandberg, Linn-Benton Community College |
| 14:04 |
jihpringle |
#info jihpringle is Jennifer Pringle, BC Libraries Cooperative (Sitka) |
| 14:04 |
ohiojoe |
#info ohiojoe is Joe Knueven, DIG Facilitator & Evergreen enthusiast |
| 14:04 |
|
yboston left #evergreen |
| 14:05 |
abneiman |
#info abneiman is Andrea Buntz Neiman, Equinox |
| 14:05 |
ohiojoe |
#topic Ongoing Business |
| 14:05 |
|
Topic for #evergreen is now Ongoing Business (Meeting topic: 2018-11-01 – Documentation Interest Group Meeting) |
| 14:05 |
ohiojoe |
#topic Progress on documenting new features in Evergreen 3.2 (and previous) |
| 14:05 |
|
Topic for #evergreen is now Progress on documenting new features in Evergreen 3.2 (and previous) (Meeting topic: 2018-11-01 – Documentation Interest Group Meeting) |
| 14:08 |
ohiojoe |
Do we have anything to talk about here today? |
| 14:09 |
abneiman |
I have a process question related to this, but I can wait for New Business |
| 14:09 |
ohiojoe |
well, in that case |
| 14:10 |
ohiojoe |
#topic New Business |
| 14:10 |
|
Topic for #evergreen is now New Business (Meeting topic: 2018-11-01 – Documentation Interest Group Meeting) |
| 14:10 |
abneiman |
heh |
| 14:10 |
ohiojoe |
take it away :) |
| 14:11 |
abneiman |
so, my question is about calling attention to pullrequests in github. The wiki page (https://wiki.evergreen-ils.org/doku.php?id=evergreen-docs:how-to-contribute-documentation) indicates that you just sfile your pullrequest in github and then it will be reviewed |
| 14:12 |
abneiman |
however, there's a few months' worth of docs PRs (back to June, it looks like) and I'm wondering -- based on Remington's email yesterday -- if we should be creating these in Launchpad as well |
| 14:12 |
abneiman |
and if so, I'm happy to modify the wiki page to add that instruction |
| 14:13 |
sandbergja |
abneiman: that's a really good question! |
| 14:14 |
sandbergja |
I think that adding to Launchpad seems like an extra step, and it would raise another barrier to folks contributing their docs |
| 14:14 |
sandbergja |
But at the same time, it would make pull requests more visible to potential reviewers |
| 14:15 |
abneiman |
that's a fair point about a barrier |
| 14:15 |
sandbergja |
I'm also not sure who all feels very confident about merging pull requests from GitHub |
| 14:15 |
sandbergja |
I don't (yet). I'm pretty sure remingtron has those skills! |
| 14:15 |
abneiman |
sandbergja: that is the real question, I guess -- who is merging from github? Is anyone? |
| 14:16 |
abneiman |
If that's a Remington questions, I can chat with him next week -- we'll both be at Hackaway |
| 14:17 |
sandbergja |
Remington would definitely know the most about it. If there were a documented process for docs committers to follow, it would help me a lot personally. |
| 14:18 |
abneiman |
sandbergja: same. If someone wants to tell me the process, I'm happy to write it up :) |
| 14:19 |
ohiojoe |
that sounds like a good question to raise with him next week.. especially given the back log you mentioned.. |
| 14:19 |
abneiman |
sure, will do |
| 14:19 |
sandbergja |
abneiman++ |
| 14:19 |
ohiojoe |
abneiman++ |
| 14:20 |
ohiojoe |
So, while we're here in new business, Remington posed a question about how we handle the terminology change in 3.2 |
| 14:22 |
abneiman |
can text be globally replaced? (though that has risks) I'm sure there's also legions of screenshots to replace. |
| 14:22 |
ohiojoe |
oye, I didn't think about the screenshots, though that's a good point too.. |
| 14:23 |
sandbergja |
abneiman: yes, but I suspect there would be so many false positives that it would be not really the route we want to take |
| 14:24 |
abneiman |
sandbergja: that's what I was afraid of |
| 14:24 |
sandbergja |
It seems like there have been so many things lately that affect large areas of the documentation! |
| 14:24 |
sandbergja |
Web client, docs reorg, etc. |
| 14:26 |
sandbergja |
It seems like -- as long as there were some good guidelines for when to change "copy" to "item" and when to change "volume" to "call number", one of our student workers might be able to help out. |
| 14:27 |
abneiman |
perhaps if specific chapters and/or pages were identified? |
| 14:28 |
ohiojoe |
I'd agree.. it's daunting because of the sheer volume of places where changes are likely wanted.. |
| 14:29 |
ohiojoe |
Identifying locations sounds like a rather easy task.. perhaps a good jumping off point to encourage folks into the docs circle..? |
| 14:29 |
abneiman |
*sheer call number of places ;-) |
| 14:29 |
sandbergja |
Just checked with our cataloger -- our student worker in technical services might have some time next week to work on this |
| 14:29 |
ohiojoe |
lol |
| 14:29 |
sandbergja |
hahahaha |
| 14:29 |
abneiman |
ohiojoe: I agree that it could be a good starting point for new docs people, especially those familiar with EG & cataloging |
| 14:30 |
kmlussier |
This comment has the most details on when the terminology was changed or not changed. https://bugs.launchpad.net/evergreen/+bug/1538691/comments/18 |
| 14:30 |
pinesol |
Launchpad bug 1538691 in Evergreen "webclient: Consistency for terminology in cataloging" [Wishlist,Fix released] |
| 14:30 |
kmlussier |
Almost all instances of copy were changed to item and volume to call number. There were very few exceptions, but I didn't touch Dojo interfaces. |
| 14:30 |
sandbergja |
I agree that it would be a good starting point for a new contributor, but I also don't want it to sit for too long waiting for somebody new to show up... |
| 14:31 |
sandbergja |
kmlussier++ |
| 14:31 |
kmlussier |
However, there are times when copy is used to refer to the action of copying. That's where you need to be careful. |
| 14:31 |
kmlussier |
In fact, I think I missed one of those instances and accidentally renamed it 'item.' |
| 14:32 |
ohiojoe |
yeah, it the copying instances are a big reason why we couldn't do a global change.. |
| 14:33 |
ohiojoe |
I agree about not waiting too long for a new volunteer to appear.. |
| 14:33 |
sandbergja |
I can definitely create a list of files that contain the terms "volume" or "copy" and might need manual review |
| 14:34 |
sandbergja |
docs files that is |
| 14:34 |
|
sandbergja_ joined #evergreen |
| 14:35 |
abneiman |
sandbergja: I think that would be a goof starting point |
| 14:35 |
ohiojoe |
perhaps we could put a call out on one or more of the lists asking folks to review those files for places to make the change? |
| 14:36 |
sandbergja |
51 occurences of "volume" in the docs -- a lot of them are "volume" as in "a large volume of X" |
| 14:37 |
sandbergja |
845 occurences of "copy" :-( :-( |
| 14:37 |
abneiman |
yikes |
| 14:38 |
abneiman |
well, it's a place to start, anyway |
| 14:38 |
ohiojoe |
and there are probably a very healthy number of both "copy" as in "item" and copy as in an action.. |
| 14:38 |
* kmlussier |
suddenly wonders why she wanted to change the terminology in the first place. ;) |
| 14:38 |
sandbergja |
kmlussier: I'm guessing permission names stayed the same, right (e.g. COPY_STATUS_LONG_OVERDUE.override is still the same, right?) |
| 14:38 |
kmlussier |
Yes, anything in the database stayed the same. |
| 14:39 |
sandbergja |
kmlussier: Because it's actually great and so so helpful for users! |
| 14:39 |
kmlussier |
As far as global find and replace, you can reduce the workload a bit by using it for things like 'copy location' or other two-word phrases that use copy or volume. |
| 14:39 |
kmlussier |
That's how I got a lot of the code changes done. |
| 14:40 |
sandbergja |
Oooh, that's good advice |
| 14:40 |
ohiojoe |
kmlussier: mm, that's a good idea.. I bet with a little review we could come up with one or two other examples like that that could be applied globally.. |
| 14:42 |
sandbergja |
I have a little time tomorrow. I can try to compile a list then. And our student worker can take a first pass at it next week, and then I can report back to y'all about how it worked out and what's left to do. |
| 14:42 |
sandbergja |
^first pass at making those changes |
| 14:43 |
ohiojoe |
that would be great if you can do that.. |
| 14:43 |
ohiojoe |
sandbergja++ |
| 14:44 |
abneiman |
sandbergja++ |
| 14:46 |
kmlussier |
sandbergja++ |
| 14:46 |
ohiojoe |
With that, we are actually past time on moving into the one on one and small group portion of our meeting.. |
| 14:47 |
sandbergja |
kmlussier: When you say that you didn't touch Dojo interfaces: are there still interfaces that still use the old terminology? If so, what should we do with those? |
| 14:47 |
sandbergja |
Proactively change the terminology so we don't have to worry about it later? |
| 14:48 |
kmlussier |
Actually, I may have lied. There were a couple of admin interfaces I changed because the main Admin interface was in AngularJS, and I wanted the link to match the name of the interface. |
| 14:48 |
kmlussier |
For the rest, I was just planning to wait until they were changed over to Angular. |
| 14:49 |
abneiman |
+1 on waiting for Angular for the remainder |
| 14:49 |
kmlussier |
We know acquisitions is moving to Angular soon. I don't know how many other Dojo interfaces there are that use those terms. |
| 14:51 |
jihpringle |
+1 to waiting for Angular, I could see it causing some confusion in acq to change the docs ahead |
| 14:51 |
sandbergja |
Okay, I'll just be sure to leave acquisitions out of my list-making. |
| 14:53 |
ohiojoe |
With that, we are approaching the top of the hour. Is there anything else we should try to discuss today? |
| 14:58 |
ohiojoe |
If not, thank you everyone and have a good day |
| 14:58 |
ohiojoe |
#endmeeting |
| 14:58 |
|
Topic for #evergreen is now Welcome to the #evergreen library system channel! | We are publicly logged: http://irc.evergreen-ils.org/evergreen | Large pastes at http://paste.evergreen-ils.org | Can't speak? Make sure your nickname is registered and that you are identified to freenode services: https://freenode.net/kb/answer/registration |
| 14:58 |
pinesol |
Meeting ended Thu Nov 1 14:58:06 2018 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 14:58 |
pinesol |
Minutes: http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-11-01-14.00.html |
| 14:58 |
pinesol |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-11-01-14.00.txt |
| 14:58 |
pinesol |
Log: http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-11-01-14.00.log.html |
| 15:00 |
remingtron |
abneiman: sandbergja: https://wiki.evergreen-ils.org/doku.php?id=evergreen-docs:github-workflow |
| 15:00 |
remingtron |
I'm sure it's not perfect, but that's roughly the steps I follow to test and push a GitHub pull request |
| 15:00 |
sandbergja |
remingtron++ |
| 15:00 |
abneiman |
remingtron++ |
| 15:00 |
sandbergja |
thanks so much! |
| 15:00 |
ohiojoe |
remingtron++ |
| 15:01 |
remingtron |
abneiman: and I'm happy to talk it over at the hack-a-way |
| 15:01 |
abneiman |
thanks remingtron! |
| 15:01 |
remingtron |
ohiojoe++ #leading the crew! |
| 15:03 |
remingtron |
kmlussier++ #for shedding light on the copy/item terminology change |
| 15:07 |
|
mmorgan1 joined #evergreen |
| 15:09 |
|
yboston joined #evergreen |
| 15:27 |
|
yboston joined #evergreen |
| 15:50 |
|
khuckins joined #evergreen |
| 17:00 |
|
jvwoolf left #evergreen |
| 17:02 |
pinesol |
[evergreen|abneiman] Docs: Emergency Closing Handler - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=902c112> |
| 17:07 |
|
mmorgan1 left #evergreen |
| 20:13 |
|
ningalls joined #evergreen |
| 20:45 |
bshum |
gmcharlt++ # PG10 notes |
