Time |
Nick |
Message |
00:10 |
|
yboston joined #evergreen |
01:33 |
|
beanjammin joined #evergreen |
06:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:05 |
|
agoben joined #evergreen |
07:13 |
|
rjackson_isl joined #evergreen |
07:40 |
|
bdljohn joined #evergreen |
07:42 |
|
collum joined #evergreen |
07:47 |
|
rlefaive joined #evergreen |
08:10 |
|
kmlussier joined #evergreen |
08:52 |
|
mmorgan joined #evergreen |
08:55 |
|
idjit joined #evergreen |
08:58 |
|
Dyrcona joined #evergreen |
08:59 |
|
bos20k joined #evergreen |
09:05 |
Dyrcona |
From a CW MARS internal ticket: "We have recently started circulating vinyl records..." |
09:06 |
Dyrcona |
That takes me back...I used to check out classical records from the library way back in the early '80s. |
09:08 |
rhamby |
Dyrcona: one of my first library jobs was shelf reading a vinyl collection .... was not fun |
09:18 |
|
terran joined #evergreen |
09:23 |
abneiman |
Dyrcona: rhamby: one of my first library jobs was cataloging classical & opera LPs! It was actually a lot of fun. |
09:24 |
Dyrcona |
Neat! |
09:28 |
rhamby |
I could see that as fun. |
09:34 |
|
lsach joined #evergreen |
09:40 |
mmorgan |
Dyrcona: We have a library that's starting a vinyl record collection, too! |
09:42 |
JBoyer |
If I ever get my systemd setup at home working I'll be cataloging CED discs, vinyl, and laserdiscs in the coming weeks. :) |
09:43 |
JBoyer |
That first bit though is making me want to launch things off a balcony. :/ |
09:43 |
|
jvwoolf joined #evergreen |
09:45 |
Dyrcona |
It seems odd to me that libraries would be starting vinyl record collections today, but I guess many libraries got rid of them in the '90s and '00s. |
09:47 |
mmorgan |
Everything old is new again! We were close to retiring the "record" circ modifier. |
09:48 |
rjackson_isl |
bringing back the "snap, crackle and pop" to your listening enjoyment! |
09:48 |
* idjit |
is reminded of this wallpaper https://i.imgur.com/cMn17t9.png |
09:49 |
rjackson_isl |
ah yes, 9 volt transister radios - those were the days... |
09:52 |
Dyrcona |
kmlussier: Do you want me to load the branch from bug 1741997 somewhere you can test it with our data? |
09:52 |
pinesol_green |
Launchpad bug 1741997 in Evergreen "additional browse improvements" [Medium,Confirmed] https://launchpad.net/bugs/1741997 |
09:53 |
* Dyrcona |
times his work with his music....When the Dire Straits collection finishes, it will be time to call in for the meeting. |
09:57 |
pinesol_green |
[evergreen|Bill Erickson] LP#1639022 Webstaff convert change to credit - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=835bac8> |
10:04 |
kmlussier |
Dyrcona: Yes, please. I'm having authority issues on my own VMS, and I'm not quite sure why. Since I know cross-references are displaying on your servers, I'm hoping the patch could just be applied and I could see if it fixes the specific bugs. |
10:04 |
Dyrcona |
Ok. I'll add it to testing.cwmars.org. |
10:05 |
Dyrcona |
Looks like it is currently at 3.0.3. |
10:13 |
* Dyrcona |
upgrades it to 3.0.7. |
10:14 |
|
jwoodard joined #evergreen |
10:16 |
|
beanjammin joined #evergreen |
10:18 |
Dyrcona |
kmlussier: Do you want me to do anything in particular after installing the branch, like running the linker or anything like that? |
10:19 |
kmlussier |
Dyrcona: I don't think the linking is required, but I'm not sure about an authority reingest. gmcharlt: do you know if a reingest is required to test bug 1741997? |
10:19 |
pinesol_green |
Launchpad bug 1741997 in Evergreen "additional browse improvements" [Medium,Confirmed] https://launchpad.net/bugs/1741997 |
10:20 |
kmlussier |
Well, the linking is required to show the cross-references. I should say I don't think re-linking is required. |
10:21 |
gmcharlt |
linking is required, yes, if it hasn't already been done; reingest should not be |
10:22 |
kmlussier |
gmcharlt++ #Thanks! |
10:23 |
Dyrcona |
authority to authority linking, bib authority linking, both? |
10:23 |
kmlussier |
gmcharlt: But if everything was linked before the code was added, do they have to do it again? |
10:23 |
gmcharlt |
no |
10:23 |
Dyrcona |
OK. So I should be OK without linking, then. |
10:28 |
|
Christineb joined #evergreen |
10:30 |
Dyrcona |
FYI: 3.0.3 to 3.0.7 is a quick upgrade. :) |
10:38 |
Bmagic |
Dyrcona++ |
10:39 |
Bmagic |
"novSelect" is not defined while in the staff client but works fine in the OPAC |
10:39 |
Bmagic |
greping the code, I only find it mentioned once in acjs.tt2 |
10:40 |
Bmagic |
Where does that variable get defined? Somewhere in novelist's code? Outside of our repo? |
10:49 |
berick |
Bmagic: pretty sure that's defined in the JS fetched from novelist |
10:49 |
Bmagic |
yeah, it would have to be I suppose. My problem is that the novelist stuff isn't loading in the staff client. The error is that variable isn't defined. It works just fine in the OPAC. |
10:50 |
Bmagic |
I guess that means that the novelist code isn't executing |
10:54 |
berick |
Bmagic: browser client? |
10:54 |
Bmagic |
xul and browser |
10:54 |
mmorgan |
Bmagic: terran had a similar issue with novelist working in the opac, but not in web client. I seem to remember a cause being found, but not sure of the details. |
10:55 |
terran |
Bmagic: novelist is working for us now in the web client - it was a bug on their end |
10:56 |
Bmagic |
terran: what about xul? |
10:56 |
terran |
Lemme check... |
10:56 |
berick |
feedback on https://bugs.launchpad.net/evergreen/+bug/1750894/comments/12 appreciated -- re: persisting grid settings on the server. |
10:56 |
pinesol_green |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,New] - Assigned to Bill Erickson (berick) |
10:56 |
Bmagic |
berick++ |
10:57 |
terran |
Bmagic: yes, it's working in xul for us now as well |
10:57 |
Bmagic |
terran: the solution came from novelist? |
10:58 |
terran |
Bmagic: Their code was looking for the presence of locg in the URL and when it wasn't there, it wasn't displaying anything. Once they added logic to handle it if it wasn't there, it worked fine. |
10:58 |
Bmagic |
it seems to me that if it works in the OPAC it should be able to work in the staff client |
10:58 |
kmlussier |
Bmagic: Around the same time terran had her problem, I seem to remember a couple of other people had trouble in the xul client because Novelist had added code that was only supported by recent browsers. |
10:59 |
kmlussier |
It then fixed itself a day or two later. |
10:59 |
Bmagic |
interesting |
10:59 |
terran |
Bmagic: It was actually broken in the OPAC too, but since the OPAC nearly always had locg in the url, the problem wasn't obvious |
10:59 |
kmlussier |
But if you're seeing it in the web client too, it's probably unrelated. |
10:59 |
terran |
Not sure if that's the same problem you are having though |
10:59 |
Bmagic |
the locg uri seems like it would be required because they need to know the context of the display right? Or do they use the login/pass for that? |
11:00 |
terran |
If locg isn't present, they should just display everything (instead of nothing) |
11:00 |
terran |
They don't use patron info at all as far as I know (at least, not for our implementation) |
11:02 |
Bmagic |
I'm referring to OILS_NOVELIST_PROFILE and OILS_NOVELIST_PASSWORD |
11:02 |
bshum |
Bmagic: Like https://bugs.launchpad.net/evergreen/+bug/1739029 ? |
11:02 |
pinesol_green |
Launchpad bug 1739029 in Evergreen 3.0 "novelist entry in eg_vhost.conf should include additional parameters" [Undecided,Fix committed] |
11:02 |
bshum |
They're apache variables |
11:03 |
terran |
Bmagic: Oh right, I guess we'd manually added those to our eg_vhost file before the patch was available |
11:04 |
Bmagic |
those are present and accounted for. Without them, it wouldn't work in the OPAC |
11:05 |
Bmagic |
I'm using the same URL for the hostname on the opac and the staff client |
11:05 |
Bmagic |
which should include the apache vars from the scoped hostname |
11:05 |
terran |
Yes, that's what we're doing too |
11:06 |
Bmagic |
Without those vars, I don't think I would get the "Loading....." |
11:08 |
terran |
Bmagic: Do you think your site is encountering the locg problem too, or something else? |
11:09 |
Bmagic |
I removed the locg from the URI on the OPAC and novelist still works |
11:09 |
terran |
Okay, they must have applied the fix they did for us across the board then |
11:10 |
Bmagic |
It must be something else. Some other thing that's not loading for staff but is loading for patrons on the OPAC |
11:11 |
terran |
Is this the same OILS_NOVELIST_URL you have set? https://imageserver.ebscohost.com/novelistselect/ns2init.js |
11:15 |
Bmagic |
that's the one :) |
11:17 |
terran |
Hrrm, so it's not an https problem them. |
11:18 |
Bmagic |
I thought that too, but I saw the code in the OPAC that changes it to https even if it's set to http |
11:24 |
rjackson_isl |
anyone able to review bug 1768022 ? |
11:24 |
pinesol_green |
Launchpad bug 1768022 in Evergreen "Webclient Holds Pull List Returns 0 Results" [Undecided,New] https://launchpad.net/bugs/1768022 |
11:24 |
rjackson_isl |
we are still seeing this locally with sites having 50+ holds on the pull list |
11:25 |
pinesol_green |
[evergreen|gcollum] LP1749994 Disable payment button pending payment amount - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4efaa63> |
11:29 |
berick |
rjackson_isl: are you seeing the same thing, where making the page size smaller allows it to render? |
11:30 |
rjackson_isl |
berick: right - it will eventually come back with first 24 as opposed to 25 and then allow for the next page. In this instance there are/were 53 holds total |
11:31 |
rjackson_isl |
(as confirmed by the legacy staff client) |
11:31 |
|
rlefaive joined #evergreen |
11:31 |
berick |
rjackson_isl: great, thanks. i have a potential theory, will post to LP. |
11:32 |
rjackson_isl |
berick++ - thanks for us this will be a pretty big issue in October |
11:45 |
|
lsach1 joined #evergreen |
11:45 |
|
lsach1 left #evergreen |
11:46 |
|
lsach joined #evergreen |
11:50 |
|
NFPL joined #evergreen |
12:04 |
|
rlefaive joined #evergreen |
12:17 |
|
rlefaive joined #evergreen |
12:22 |
|
rlefaive joined #evergreen |
12:24 |
|
jihpringle joined #evergreen |
12:34 |
|
rlefaive joined #evergreen |
12:41 |
csharp |
like most bugsquash weeks, this is proving to be one I just don't have time to really participate in, so I'll fix all the remaining bugs next week, is that ok? |
12:42 |
berick |
perpare the blood oath |
12:42 |
mmorgan |
csharp: as long as you promise to fix ALL of them ;-) |
12:43 |
JBoyer |
lp.net/evergreen/+batch_apply/WONTFIX-WORKSFORME |
12:44 |
Dyrcona |
heh. |
12:44 |
JBoyer |
Oops. didn't think about the fact that that would resolve to an actual site. Something baidu owns, maybe don't click it since that's not the joke. |
12:45 |
csharp |
ha! |
12:45 |
|
beanjammin joined #evergreen |
12:46 |
* csharp |
was hoping to exercise his newfound core commit power at some point |
12:46 |
csharp |
I'll still be able to do that next week :-D |
12:51 |
mmorgan |
csharp++ |
13:01 |
Dyrcona |
:) |
13:03 |
|
yboston joined #evergreen |
13:13 |
pinesol_green |
[evergreen|Kyle Huckins] lp1760997 Holds Pull List Blank Fields - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ce63236> |
13:50 |
pinesol_green |
[evergreen|Jeff Davis] LP#1749996: add option to remove floating in web client copy editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7b6e47b> |
13:51 |
Bmagic |
Is this a normal error? |
13:51 |
Bmagic |
Event reacting failed with Can't use string ("RPC::XML::Client::send_request: "...) as a HASH ref while "strict refs" in use at /usr/local/share/perl/5.22.1/OpenILS/Application/Trigger/Reactor/AstCall.pm line 256 |
13:52 |
Bmagic |
action_trigger.event_output has data=";noop no phone setting in aus 'opac.hold_notify'" |
13:53 |
|
terran joined #evergreen |
14:03 |
Bmagic |
It seems to me that RPC::XML::Client::send_request takes my ($self, $req, @args) = @_; and we are passing 'inject', $tmpl_output, $filename_fragment, 0. I suppose the arguments that we are passing are perlized into @args? |
14:05 |
berick |
Bmagic: yes, they all get bundled into @args. |
14:06 |
Bmagic |
ok, so the code is sound. It appears that $resp contains a string instead of the expected HASH when we parse the value from $resp->{code} |
14:14 |
jeffdavis |
vis_attr_vector is not being set properly on our system |
14:15 |
jeffdavis |
I have many records where vis_attr_vector = '{}' but biblio.calculate_bib_visibility_attribute_set returns something like '{13,39}' |
14:25 |
jeffdavis |
ah, maybe not *many* |
14:26 |
pinesol_green |
[evergreen|Kyle Huckins] lp1759327 Populate Copy Templates Floating Dropdown - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ebe1167> |
14:26 |
Dyrcona |
jeffdavis: Have you tried updating those records? |
14:27 |
|
terran_ joined #evergreen |
14:28 |
jeffdavis |
this is an affected record: https://bcrek.bc.catalogue.libraries.coop/eg/opac/record/119859705 - I tried modifying the contents of 856$u and saving (which should trigger a vis_attr_vector update via asset.call_number), but vis_attr_vector is still {} |
14:29 |
Dyrcona |
Ah.... |
14:31 |
Dyrcona |
That's a bug, fixed in 3.0.3, IIRC. |
14:32 |
Dyrcona |
Check out the bottom of the 3.0.2 to 3.0.3 upgrade script. |
14:33 |
Dyrcona |
jeffdavis: Also Lp 1730758 |
14:33 |
pinesol_green |
Launchpad bug 1730758 in Evergreen "biblio.record_entry.vis_attr_vector not updated upon adding a locate URI" [Medium,Fix released] https://launchpad.net/bugs/1730758 |
14:39 |
jeffdavis |
aha! |
14:40 |
jeffdavis |
we have ingest.reingest.force_on_same_marc set to true, which Mike notes in that bug can cause problems |
14:40 |
jeffdavis |
setting it to false and then updating the record sets vis_attr_vector properly |
14:45 |
Dyrcona |
jeffdavis: Good to know. |
14:45 |
jeffdavis |
Dyrcona++ |
14:47 |
Dyrcona |
bshum++ # For throwing the bug # at me while I was searching for it. |
15:14 |
* Dyrcona |
has one more tested branch to commit. |
15:18 |
pinesol_green |
[evergreen|Mike Rylander] LP#1770478: Offline org unit tree can break - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0a8b5ae> |
15:26 |
miker |
jeffdavis: for the record, the reason we skip attr update is that it creates a loop of bib updates which will eventually blow out the stack. the function that updates the attr vector does not have access to NEW (though it is called from within the trigger) so it has to update the table, which triggers another update, and force-on-same fires the trigger again, etc |
15:40 |
|
bdljohn joined #evergreen |
15:56 |
|
lsach joined #evergreen |
15:58 |
|
jlundgren joined #evergreen |
16:01 |
|
bdljohn joined #evergreen |
16:35 |
miker |
dbwells++ # refactoring for justice! |
16:44 |
|
jlundgren left #evergreen |
16:44 |
pinesol_green |
[evergreen|Galen Charlton] LP#1765444: improve how MARC editor fetches fixed field metadata - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3adff7b> |
17:03 |
|
jvwoolf left #evergreen |
17:05 |
|
mmorgan left #evergreen |
18:23 |
jeffdavis |
we're seeing some open-ils.actor NOT CONNECTED TO THE NETWORK errors which I suspect are due to retrieving staff_client.copy_editor.templates in cat/volcopy/app.js |
18:23 |
jeffdavis |
open-ils.cstore open-ils.cstore.direct.actor.user_setting.search.atomic {"usr":<usrid>,"name":"staff_client.copy_editor.templates"} |
18:24 |
jeffdavis |
^ returns a chunked response, followed in the logs by the NOT CONNECTED errors |
18:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
18:50 |
pinesol_green |
[evergreen|Jane Sandberg] Docs: Adding to and reorganizing the 3.0.8 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=31c0b28> |
18:54 |
pinesol_green |
[evergreen|Jane Sandberg] Docs: Adding to and reorganizing the 3.1.2 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0901349> |
19:02 |
|
Dyrcona joined #evergreen |
19:02 |
Dyrcona |
sandbergja++ # More release notes |
19:58 |
csharp |
jeffdavis: can confirm the same thing happening in today's PINES logs |
19:58 |
csharp |
not a lot of it, but it's there |
20:01 |
csharp |
one instance, actually |
21:56 |
|
beanjammin joined #evergreen |