Time |
Nick |
Message |
00:00 |
|
acautley joined #evergreen |
01:00 |
|
acautley joined #evergreen |
02:00 |
|
acautley joined #evergreen |
03:00 |
|
acautley joined #evergreen |
04:00 |
|
acautley joined #evergreen |
05:00 |
|
acautley joined #evergreen |
06:00 |
|
acautley joined #evergreen |
06:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
07:00 |
|
acautley joined #evergreen |
08:00 |
|
acautley joined #evergreen |
08:25 |
|
eady joined #evergreen |
09:00 |
|
acautley joined #evergreen |
10:00 |
|
acautley joined #evergreen |
10:05 |
|
littlet joined #evergreen |
10:11 |
|
RBecker joined #evergreen |
10:24 |
|
RBecker joined #evergreen |
11:00 |
|
acautley joined #evergreen |
12:00 |
|
acautley joined #evergreen |
13:00 |
|
acautley joined #evergreen |
14:00 |
|
acautley joined #evergreen |
14:22 |
csharp |
comcastbusiness.net-- |
14:40 |
|
Dyrcona joined #evergreen |
14:47 |
* Dyrcona |
is likely gonna add a String.format to JS for something he's doing. |
14:49 |
Dyrcona |
Can we do translator comments for tt2 strings? |
14:50 |
Dyrcona |
I want to do a string with a {0} place holder for a number. |
14:50 |
Dyrcona |
And, I want to tell the translators that {0} will be replaced by a number. |
14:59 |
gmcharlt |
Dyrcona: alas, I don't think so |
14:59 |
gmcharlt |
getting the ability to do so is one reason why https://github.com/gflohr/Template-Plugin-Gettext has caught my eye |
15:00 |
Dyrcona |
OK. That is what I suspected. |
15:00 |
|
acautley joined #evergreen |
15:00 |
Dyrcona |
I put a comment in i18n_strings.tt2 anyway, and I put the code to add the format function to String in there, also. |
16:00 |
|
acautley joined #evergreen |
16:21 |
Dyrcona |
So, the web staff client looks like this for me in Firefox: https://photos.app.goo.gl/8FGBOCKRrYDNpmH13 |
16:23 |
Dyrcona |
Firefox 55.0.2 on Ubuntu 17.04. |
16:24 |
Dyrcona |
That's master with my current branch installed, but it looked like that with just master on the 25th. |
16:24 |
Dyrcona |
I mentioned it to bshum at the time and he built master and looked at it with Firefox 55 and his looked fine. |
16:28 |
Dyrcona |
This is what I see with Chromium 61.0.3163.79 running on Ubuntu 17.04: https://photos.app.goo.gl/BnTLn32wL04SS5wy2 |
16:29 |
Dyrcona |
Just throwing it out there before opening a Lp bug. |
16:45 |
* Dyrcona |
can't figure out why his confirmation dialog doesn't fire in the form validator from the staff client, when the other alert does.... |
16:51 |
Dyrcona |
document.getElementById is not working.... And Google/StakcOverflow has not been helpful. |
16:54 |
Dyrcona |
Must have something to do with the iframe.... |
16:54 |
Dyrcona |
iframe-- |
17:00 |
|
acautley joined #evergreen |
17:03 |
Dyrcona |
But, what I don't get is how the existing getElementsByClassName code works when getElementById in the same place does not. |
17:14 |
Dyrcona |
Guess I'll figure it out later. |
18:00 |
|
acautley joined #evergreen |
18:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
18:12 |
|
Dyrcona joined #evergreen |
18:13 |
Dyrcona |
For the logs: Fixed it. Trouble wasn't what I thought it was. I had a typo in the string constart for the confirm dialog. |
19:00 |
|
acautley joined #evergreen |
20:00 |
|
acautley joined #evergreen |
21:00 |
|
acautley joined #evergreen |
22:00 |
|
acautley joined #evergreen |
23:00 |
|
acautley joined #evergreen |