Time |
Nick |
Message |
01:57 |
|
dbwells joined #evergreen |
05:58 |
|
jeff joined #evergreen |
05:58 |
|
jeff joined #evergreen |
06:06 |
|
JBoyer joined #evergreen |
07:19 |
|
rjackson_isl joined #evergreen |
07:19 |
|
agoben joined #evergreen |
08:17 |
|
Dyrcona joined #evergreen |
08:22 |
|
collum joined #evergreen |
08:39 |
|
mmorgan joined #evergreen |
08:54 |
|
bos20k joined #evergreen |
09:05 |
|
kmlussier joined #evergreen |
09:06 |
kmlussier |
Good morning #evergreen! |
09:06 |
kmlussier |
@coffee [someone] |
09:06 |
* pinesol_green |
brews and pours a cup of Panama Hacienda La Esmeralda Gesha, and sends it sliding down the bar to mceraso_ |
09:06 |
kmlussier |
@tea [someone] |
09:06 |
* pinesol_green |
brews and pours a pot of Wild Snow Sprout Tea, and sends it sliding down the bar to csharp (http://ratetea.com/tea/wild-tea-qi/wild-snow-sprout-tea/6447/) |
09:12 |
|
yboston joined #evergreen |
09:13 |
|
bos20k joined #evergreen |
09:26 |
csharp |
kmlussier++ # mmm, tea |
09:27 |
* Dyrcona |
raises his organic iced tea to csharp and kmlussier. |
09:32 |
* Dyrcona |
mucks about with updating and merging the oils_sip.xml into local git as oils_sip.xml.example. |
09:36 |
Dyrcona |
It's fun trying to patch in the new config options into 53 intsitutions. :) |
09:38 |
jeff |
yeah, i was pretty sure the goal was to avoid needing to do that. |
09:39 |
Dyrcona |
Well, the oils_sip.xml here predates most of the changes and multiple institutions exist in some cases to differentiate one self-check from another. |
09:40 |
csharp |
wow |
09:40 |
* jeff |
nods |
09:40 |
jeff |
also, beware mixing multiplex and the new workstation support. |
09:40 |
csharp |
we still just have 1 institution defined and many many accounts |
09:40 |
Dyrcona |
We're not using multiplex. |
09:41 |
Dyrcona |
MVLC has 3 insitutions, IIRC. |
09:41 |
jeff |
Dyrcona: what reasons do you have for differentiating one sip client from another using institutions, and do those reasons still apply here? just for logging, or other things as well? |
09:42 |
Dyrcona |
jeff: I don't know. This configuration predates me. I'm just putting it into git right now. I'll work out those questions later with the people normally in charge of it. |
09:43 |
Dyrcona |
I think two institutions make a lot of sense if you want to differentiate between PC reservation type systems and self checks for what they're allowed to do. |
09:43 |
Dyrcona |
Maybe a 3rd for outside vendors. |
09:43 |
Dyrcona |
After that.... ;) |
09:44 |
Dyrcona |
@karma cssh |
09:44 |
pinesol_green |
Dyrcona: cssh has neutral karma. |
09:44 |
Dyrcona |
cssh++ |
09:45 |
Dyrcona |
bshum++ # for mentioning cssh to me. |
09:46 |
Dyrcona |
hmm. think I'll just commit what I've got and add the options later, maybe. :) |
09:47 |
Dyrcona |
1 file changed, 4203 insertions(+), 161 deletions(-) |
09:47 |
Dyrcona |
rewrite Open-ILS/examples/oils_sip.xml.example (96%) |
09:47 |
Dyrcona |
Kinda nuts.... |
09:51 |
Dyrcona |
I even deleted the legacy circ stuff that was still hanging around. |
10:06 |
|
mceraso joined #evergreen |
10:06 |
|
bshum joined #evergreen |
10:56 |
|
Christineb joined #evergreen |
10:59 |
kmlussier |
yboston++ #For being an outstanding DIG facilitator. |
11:03 |
berick |
yboston++ |
11:03 |
berick |
it's been too long since I typed that |
11:06 |
Dyrcona |
Was there a DIG hangout today, or something on the mailing list? |
11:06 |
kmlussier |
Dyrcona: No, I'm just belatedly giving yboston karma after an e-mail he sent yesterday. He's stepping down as DIG facilitator. |
11:07 |
Dyrcona |
OK. I don't subscribe to the DIG list. |
11:07 |
Dyrcona |
yboston++ # just 'cause. |
11:07 |
kmlussier |
Ah! You're right. I hadn't even seen that it was on the DIG list. I was thinking it was on the general list. |
11:12 |
csharp |
yboston++ |
11:12 |
|
brahmina joined #evergreen |
11:26 |
|
sandbergja joined #evergreen |
11:31 |
|
bmills joined #evergreen |
11:33 |
|
jihpringle joined #evergreen |
11:49 |
|
bmills joined #evergreen |
11:51 |
yboston |
¡Muchas gracias! |
12:34 |
|
JBoyer_alt joined #evergreen |
12:37 |
|
collum_ joined #evergreen |
12:37 |
|
bmills joined #evergreen |
12:37 |
|
yboston_ joined #evergreen |
12:44 |
|
serflog joined #evergreen |
12:44 |
|
Topic for #evergreen is now Welcome to the #evergreen library system channel! | We are publicly logged: http://irc.evergreen-ils.org/evergreen | Large pastes at http://paste.evergreen-ils.org |
12:44 |
|
rjackson_isl_ joined #evergreen |
12:44 |
|
yboston_ joined #evergreen |
12:45 |
|
jihpringle_ joined #evergreen |
12:46 |
|
collum joined #evergreen |
12:47 |
|
sandbergja joined #evergreen |
12:47 |
|
mceraso joined #evergreen |
12:48 |
|
Callender joined #evergreen |
12:48 |
|
bos20k joined #evergreen |
12:48 |
|
mnsri_away joined #evergreen |
12:48 |
|
jeff joined #evergreen |
12:48 |
|
jeff joined #evergreen |
12:48 |
|
Christineb joined #evergreen |
12:49 |
|
Bmagic joined #evergreen |
12:51 |
|
brahmina_ joined #evergreen |
12:52 |
|
kmlussier-web joined #evergreen |
12:53 |
|
ssieb joined #evergreen |
12:53 |
|
kmlussier joined #evergreen |
12:53 |
bshum |
Why, oh why Freenode has thou forsaken us? |
12:59 |
Dyrcona |
So, what am I supposed to do with a report that claims it is still running but actually isn't? |
13:05 |
mmorgan |
Dyrcona: update reporter.schedule.complete_time to now() That will allow clark to move on to another report. |
13:09 |
|
bos20k_ joined #evergreen |
13:11 |
|
Callender_ joined #evergreen |
13:11 |
|
sandbergja joined #evergreen |
13:11 |
|
mnsri_away joined #evergreen |
13:12 |
|
Dyrcona1 joined #evergreen |
13:12 |
|
phasefx__ joined #evergreen |
13:14 |
|
ssieb joined #evergreen |
13:21 |
|
Callender joined #evergreen |
13:21 |
|
jeff__ joined #evergreen |
13:22 |
|
rashma_away joined #evergreen |
13:22 |
|
b_bonner_ joined #evergreen |
13:22 |
|
mceraso joined #evergreen |
13:22 |
|
ssieb joined #evergreen |
13:22 |
|
mnsri_away joined #evergreen |
13:23 |
|
wsmoak joined #evergreen |
13:25 |
Dyrcona |
So, we've got the implementation config for an institution set to ascii encoding, but we're sending the client Unicode. |
13:27 |
* Dyrcona |
wonders if clean_text is being called everywhere it needs to be? |
13:27 |
jeff__ |
lead in to a potentially very basic Angular / ngRoute question: something like $location.path('/circ/patron/' + user_id + '/checkout'); uses a path that doesn't start with the usual /eg/staff -- but in the browser the full path is /eg/staff/circ/patron/id-here/checkout |
13:27 |
|
jeff__ joined #evergreen |
13:29 |
berick |
jeff: $location.path() is relative to the <base href="/eg/staff/"> declaration in the base template |
13:29 |
Dyrcona |
And, here's a relevant lp bug 1463943 from last year. |
13:29 |
pinesol_green |
Launchpad bug 1463943 in SIPServer "Non-ascii Unicode characters in messages cause client problems" [Undecided,New] https://launchpad.net/bugs/1463943 - Assigned to Jeff Godin (jgodin) |
13:30 |
|
eady joined #evergreen |
13:32 |
|
phasefx joined #evergreen |
13:32 |
jeff |
is ngRoute the thing making that work (contrary to what seems would happen in the $location service), or something else -- and is the /eg/staff prefix/root auto-detected or is there an explicit call somewhere where that's initialized? |
13:33 |
jeff |
berick: ah, there it is! thanks! |
13:33 |
|
mnsri_ joined #evergreen |
13:33 |
|
rashmaz joined #evergreen |
13:33 |
|
b_bonner joined #evergreen |
13:34 |
|
mceraso joined #evergreen |
13:34 |
Dyrcona |
Ah ha! clean_text needs to be used on AUTOLOAD fields. |
13:34 |
jeff |
yeah, i want to kill clean_text. |
13:39 |
Dyrcona |
Well, jeff, there's my branch on the above bug that is assigned to you that handles the encoding in SIPServer and not in Evergreen. |
13:40 |
Dyrcona |
I just told my boss, tspindler, that I'd invalidate my old bug and make a new fix for Evergreen that uses clean_text in the appropriate places, but if you think the SIPServer fix is better.... |
13:44 |
|
mnsri_away joined #evergreen |
13:46 |
Dyrcona |
So, which do you prefer, jeff? |
13:46 |
Dyrcona |
Or is it jeff____ with the long tail? ;) |
13:46 |
jeff |
netsplits-- |
13:47 |
Dyrcona |
Yeah. |
13:47 |
Dyrcona |
My branch could be changed to use the institution setting or the account setting whichever is set. |
13:48 |
Dyrcona |
But if you want to kill clean_text handling the encoding in SIPServer's write_msg seems like the logical place. |
13:48 |
berick |
https://twitter.com/freenodestaff/status/780813276733210629 |
13:49 |
Dyrcona |
Sorry to drag you away from your ngRoute discussion... |
13:50 |
jeff |
Dyrcona: that's probably the direction i'm going. i haven't looked at it (until now) in a few months. |
13:50 |
jeff |
Dyrcona: we don't use checksums, and use utf8 encoding for sip clients. |
13:51 |
Dyrcona |
Well, we've got one big client in particular that blows up on UTF-8, and it's always in an author or call number field. |
13:51 |
jeff |
Dyrcona: and we're on a recent version of Encode.pm, so the decode_utf8 call in OpenILS::SIP::clean_text kills things. We removed that locally. |
13:52 |
Dyrcona |
It's not called on AUTOLOAD fields in SIP::Item, apparently. |
13:53 |
jeff |
there's another bug closely related to this. |
13:53 |
|
wsmoak joined #evergreen |
13:53 |
Dyrcona |
So, that's an easy fix, but I think it would be better to just get rid of clean text and let SIPServer do the encoding. |
13:53 |
jeff |
ah, bug 1542495 |
13:53 |
pinesol_green |
Launchpad bug 1542495 in Evergreen "OpenILS::SIP::clean_text() can crash" [Undecided,Confirmed] https://launchpad.net/bugs/1542495 |
13:57 |
* jeff |
-> meeting |
14:03 |
|
sard joined #evergreen |
14:04 |
Dyrcona |
Hmm. That's bad, very bad. |
14:09 |
Dyrcona |
Ah wait a minute... A little research and I see it. |
14:11 |
|
JBoyer joined #evergreen |
14:13 |
|
b_bonner joined #evergreen |
14:14 |
Dyrcona |
And, it looks like someone has confused encode and decode.... |
14:15 |
|
b_bonner_ joined #evergreen |
14:21 |
JBoyer |
I haven't been keeping up that much with the SIPServer discussion, but I have this thought to offer: If all network traffic is routed through write_msg and it calculates the checksum for those clients that use it (or if it's easy to insert there...) I'd say absolutely go for the fix-it-in-one-place |
14:21 |
JBoyer |
And then strip out any attempts to care whatsoever from OpenILS::SIP. |
14:21 |
JBoyer |
Better it plainly and intentionally send out pure UTF-8 than a mix of ASCII and UTF-8 depending on the message at hand. |
14:21 |
* JBoyer |
retreats to his cave... |
14:25 |
Dyrcona |
JBoyer: I'll quote you on that. ;) |
14:26 |
|
sard joined #evergreen |
14:30 |
|
b_bonner joined #evergreen |
14:30 |
JBoyer |
<politic_horror_show>"I never said that!"</politic_horror_show> |
14:30 |
|
mnsri_away joined #evergreen |
14:30 |
|
rashma_away joined #evergreen |
14:32 |
|
ldw joined #evergreen |
14:33 |
Dyrcona |
Is there ever "One last comment for today...?" |
14:33 |
* Dyrcona |
fights the temptation to comment again on the LP bug. |
14:34 |
Dyrcona |
I'm starting to wonder just what decode is for... |
14:36 |
Dyrcona |
Crazy... |
14:36 |
Dyrcona |
;) |
14:37 |
csharp |
@interrupt |
14:37 |
pinesol_green |
csharp: http://images.cryhavok.org/d/1291-1/Computer+Rage.gif |
14:40 |
Dyrcona |
I think the Perl documentation is gaslighting me. |
14:41 |
|
b_bonner- joined #evergreen |
14:41 |
dbs |
+1 to getting rid of clean_text if we can (I think our client had the same "malformed unicode in title kills the client" issue that Dyrcona was seeing) |
14:41 |
dbs |
But it seemed that the patron name info still needed clean_text, so... |
14:42 |
Dyrcona |
dbs: You likely have a lot more patrons with French names than we do. ;) |
14:45 |
dbs |
bien sur! |
14:48 |
|
b_bonner joined #evergreen |
15:02 |
|
b_bonner joined #evergreen |
15:05 |
|
mmorgan joined #evergreen |
15:14 |
|
b_bonner joined #evergreen |
15:23 |
|
JBoyer_alt joined #evergreen |
15:26 |
|
Bmagic_ joined #evergreen |
15:26 |
|
Christineb joined #evergreen |
15:27 |
|
Christineb joined #evergreen |
15:28 |
|
b_bonner joined #evergreen |
15:28 |
|
rashma_away joined #evergreen |
15:28 |
|
mceraso joined #evergreen |
15:30 |
|
b_bonner_ joined #evergreen |
15:32 |
|
Stompro joined #evergreen |
15:36 |
|
ssieb_ joined #evergreen |
15:36 |
|
mnsri_away joined #evergreen |
15:36 |
|
mceraso joined #evergreen |
15:36 |
|
Christineb joined #evergreen |
15:36 |
|
barbara_ joined #evergreen |
15:36 |
|
gmcharlt joined #evergreen |
15:36 |
|
graced joined #evergreen |
15:37 |
|
b_bonner_ joined #evergreen |
15:37 |
|
phasefx_ joined #evergreen |
15:38 |
|
jyorio joined #evergreen |
15:44 |
|
ericar joined #evergreen |
15:45 |
|
rashma_away joined #evergreen |
15:45 |
|
mceraso joined #evergreen |
15:46 |
|
sarabee joined #evergreen |
15:46 |
|
pastebot joined #evergreen |
15:46 |
|
graced joined #evergreen |
15:46 |
|
JBoyer joined #evergreen |
15:49 |
|
jeff joined #evergreen |
15:49 |
|
jeff joined #evergreen |
15:49 |
|
wsmoak joined #evergreen |
15:49 |
|
b_bonner joined #evergreen |
15:51 |
kmlussier |
@quote random |
15:51 |
pinesol_green |
kmlussier: Quote #74: "< Dyrcona> SIP2 is not a suitable means for anything." (added by csharp at 03:35 PM, January 13, 2014) |
15:51 |
kmlussier |
A timely quote |
15:51 |
Dyrcona |
Quite. |
15:51 |
Dyrcona |
I'm installing my patch for the above SIPServer Lp bug at the moment. |
15:53 |
Dyrcona |
After this, I'll work on expanding it a bit so it can also take the encoding configuration from the Institution. |
15:53 |
|
mnsri_away joined #evergreen |
16:05 |
|
sard joined #evergreen |
16:21 |
|
jihpringle_ joined #evergreen |
16:22 |
Dyrcona |
Ah well, days after updates are often like this. |
16:22 |
|
Christineb_away joined #evergreen |
16:23 |
|
Christineb_away joined #evergreen |
16:24 |
|
mceraso joined #evergreen |
16:24 |
|
mmorgan joined #evergreen |
16:26 |
|
rashma_away joined #evergreen |
16:33 |
|
Christineb_away joined #evergreen |
16:34 |
|
mceraso joined #evergreen |
16:34 |
Dyrcona |
Reading LP 1083290 and it's funny how opinions can change over time, but I'd be dead if I didn't change my opinions. |
16:34 |
pinesol_green |
Launchpad bug 1083290 in SIPServer "SIPServer should be packaged into releases" [Undecided,New] https://launchpad.net/bugs/1083290 |
16:35 |
|
rashma_away joined #evergreen |
16:37 |
|
mnsri joined #evergreen |
16:38 |
|
mmorgan joined #evergreen |
16:39 |
|
wsmoak joined #evergreen |
16:43 |
|
brahmina joined #evergreen |
16:43 |
jeff |
sometimes knowing the structure of your data can help you attain impressive compression ratios: |
16:43 |
|
StomproJ joined #evergreen |
16:43 |
jeff |
Strms Blocks Compressed Uncompressed Ratio Check Filename |
16:43 |
jeff |
177 177 378.0 MiB 84.8 GiB 0.004 CRC64 177 files |
16:45 |
|
Callender_ joined #evergreen |
16:46 |
|
barbara joined #evergreen |
16:46 |
|
phasefx_ joined #evergreen |
16:48 |
|
rashma_away joined #evergreen |
16:48 |
|
mceraso joined #evergreen |
16:49 |
|
mnsri_away joined #evergreen |
16:49 |
Dyrcona |
jeff: That's a lot of redundant data. |
16:50 |
Dyrcona |
So, I'm wondering if I can Sip.pm to figure out the encoding rather than doing it in the other Sip/modules. |
16:50 |
|
ldw joined #evergreen |
16:50 |
Dyrcona |
can ^get Sip.pm to^ |
16:52 |
Dyrcona |
Apparently not with changing the signature of write_msg again, so doesn't buy much. |
16:53 |
|
b_bonner joined #evergreen |
16:53 |
|
wsmoak joined #evergreen |
16:54 |
Dyrcona |
Ah, but! I can add a Sip::get_encoding func that takes the $server as an object and figures out the encoding. |
16:55 |
|
bmills joined #evergreen |
16:55 |
Dyrcona |
That would move the complication to a function shared by all of the objects and then instead of each caller to write_msg figuring out the encoding, they ask Sip::get_encoding to do that. |
16:56 |
Dyrcona |
In the inherited form of $self->get_encoding($server); |
16:58 |
Dyrcona |
Hmm. I could just put it in MsgType.pm, since that appears to be the only one that needs it. |
16:59 |
Dyrcona |
Just thinking in channel... Don't mind me. |
17:09 |
|
mmorgan left #evergreen |
17:18 |
Dyrcona |
Nope. Better idea.. Just stick it in $server->{encoding} in _load_ils_handler()? |
17:59 |
jeffdavis |
Is it normal to have hundreds of thousands of entries in metabib.browse_entry that are not in metabib.browse_entry_def_map? |
18:01 |
berick |
jeffdavis: yes |
18:01 |
berick |
jeffdavis: see also metabib.browse_entry_simple_heading_map |
18:02 |
berick |
jeffdavis: also, they are not cleaned up as bibs and auths are modified, so there can be zombie entries |
18:05 |
jeffdavis |
berick: phew, thanks! |
18:47 |
|
StomproJosh joined #evergreen |
18:51 |
|
dbwells_ joined #evergreen |
20:45 |
|
jonadab joined #evergreen |
22:49 |
|
bmills joined #evergreen |