Time |
Nick |
Message |
00:12 |
|
jvwoolf joined #evergreen |
07:38 |
|
JBoyer joined #evergreen |
07:40 |
|
mrpeters joined #evergreen |
08:05 |
|
ericar joined #evergreen |
08:06 |
|
kmlussier joined #evergreen |
08:21 |
|
gsams joined #evergreen |
08:43 |
|
maryj joined #evergreen |
08:44 |
|
mmorgan joined #evergreen |
08:59 |
kmlussier |
good morning #evergreen |
08:59 |
kmlussier |
@coffee [someone] |
08:59 |
* pinesol_green |
brews and pours a cup of El Salvador Pacamara Los Planes, and sends it sliding down the bar to ldw |
08:59 |
kmlussier |
@tea [someone] |
08:59 |
* pinesol_green |
brews and pours a pot of Dragon Pearl Jasmine, and sends it sliding down the bar to jeff (http://ratetea.com/tea/harney/dragon-pearl-jasmine/1320/) |
08:59 |
remingtron |
kmlussier: good morning! |
09:00 |
mmorgan |
Good morning! |
09:04 |
|
bos20k joined #evergreen |
09:19 |
|
jvwoolf joined #evergreen |
09:20 |
|
jvwoolf left #evergreen |
09:20 |
|
jvwoolf joined #evergreen |
09:40 |
|
yboston joined #evergreen |
09:50 |
Bmagic |
gootin morgan |
10:26 |
|
collum joined #evergreen |
10:28 |
_adb |
lol |
10:29 |
_adb |
oops. focus shouldfollow eyes. |
10:46 |
|
maryj_ joined #evergreen |
10:48 |
|
jeff_ joined #evergreen |
10:50 |
|
Christineb joined #evergreen |
10:55 |
|
ericar_ joined #evergreen |
11:32 |
|
bmills joined #evergreen |
11:35 |
|
brahmina joined #evergreen |
11:38 |
|
mrpeters1 joined #evergreen |
12:05 |
|
ericar_ joined #evergreen |
12:09 |
|
ericar_ joined #evergreen |
12:34 |
|
Bmagic joined #evergreen |
12:42 |
|
jihpringle joined #evergreen |
12:59 |
|
bmills joined #evergreen |
13:23 |
|
krvmga joined #evergreen |
13:55 |
|
ericar_ joined #evergreen |
14:04 |
jeffdavis |
berick, kmlussier: re bug 1589586, does it make sense for prorate to take into account both encumbered and disencumbered fund debits, now that handling of debits/encumbrances has changed in 2.10? |
14:04 |
pinesol_green |
Launchpad bug 1589586 in Evergreen master "Acquisitions: Cannot prorate charges on invoice" [Undecided,Confirmed] https://launchpad.net/bugs/1589586 |
14:06 |
* berick |
looks |
14:06 |
kmlussier |
jeffdavis: In the past, then, prorating worked because the lineitems were expended (encumbrance = false) as soon as the invoice was created? |
14:07 |
kmlussier |
It seems like it would make sense for prorating to take both encumbered and disencumbered fund debits into account, but I don't know if I'm missing any potential pitfalls. |
14:08 |
kmlussier |
jeffdavis: But I'll be happy to load that branch on a server to see if I can break it. :) |
14:08 |
jeffdavis |
ha, thanks :) |
14:10 |
jeffdavis |
I assume that it previously worked because the lineitems were already expended, but haven't actually checked that in a pre-2.10 environment. That would make sense with what I see in the code though. |
14:14 |
berick |
agreed it should be looking for all debits that are 'linked' (i.e. invoiced) regardless of whether they are encumbered or not. in practice, I imagine the debits will always be encumbered, since the invoice has to be closed for encumbrance to be false. |
14:15 |
berick |
i don't see any reason to force that, though. looking for all linked debits seems sane. |
14:15 |
jeffdavis |
excellent, thank you! |
14:15 |
berick |
jeffdavis++ |
14:15 |
berick |
kmlussier++ |
14:40 |
|
maryj joined #evergreen |
14:56 |
|
bos20k joined #evergreen |
15:01 |
|
mrpeters joined #evergreen |
15:05 |
|
mrpeters1 joined #evergreen |
15:26 |
|
ericar_ joined #evergreen |
16:14 |
|
bmills joined #evergreen |
16:22 |
gmcharlt |
heads up re 2.10 - I won't be cutting 2.10.6 today, as there've only been a few small docs changes in that branch |
16:22 |
gmcharlt |
however, over next few days I'll deal with relevant pullrequests and cut a release next week |
16:23 |
hbrennan |
gmcharlt++ |
16:26 |
JBoyer |
gmcharlt++ |
16:27 |
kmlussier |
gmcharlt++ |
17:10 |
|
mmorgan left #evergreen |
17:17 |
* kmlussier |
wonders if there's a specific reason we remove the "show more details" button from the grouped record results page. |
17:22 |
kmlussier |
Bmagic: I need to do more testing, but, so far, I'm getting much better results with bug 1403907. I'll continue poking at it tomorrow. |
17:22 |
pinesol_green |
Launchpad bug 1403907 in Evergreen "E-resources not included in ver 2.7.1 Group formats and editions search" [Medium,Confirmed] https://launchpad.net/bugs/1403907 |
17:23 |
kmlussier |
Bmagic++ |
17:23 |
jeffdavis |
kmlussier: AFAIK the OPAC isn't capable of amaglamating the holdings etc from multiple grouped records into a single display, so "show more details" in that context would have no effect anyhow |
17:24 |
kmlussier |
jeffdavis: But this is on the secondary page you reach in the metarecord search. The one that lists each record individually. |
17:26 |
kmlussier |
Anyway, I'm heading out. Have a nice night #evergreen! I'll see you same time, same place tomorrow. |
17:27 |
jeffdavis |
ah! |
19:21 |
|
bmills1 joined #evergreen |
19:21 |
|
bmills1 left #evergreen |
21:19 |
|
miker joined #evergreen |
21:19 |
|
Shae joined #evergreen |
21:19 |
|
graced joined #evergreen |
21:21 |
|
jyorio joined #evergreen |