Time |
Nick |
Message |
05:09 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
07:07 |
|
wsmoak joined #evergreen |
07:33 |
|
julialima joined #evergreen |
07:35 |
|
julialima left #evergreen |
07:41 |
|
phasefx joined #evergreen |
07:41 |
|
Callender joined #evergreen |
07:43 |
|
eeevil joined #evergreen |
07:43 |
|
dkyle joined #evergreen |
07:46 |
|
_bott_ joined #evergreen |
07:50 |
|
dkyle1 joined #evergreen |
07:50 |
|
_bott_1 joined #evergreen |
07:59 |
|
julialima joined #evergreen |
08:00 |
|
graced joined #evergreen |
08:03 |
|
rjackson-isl joined #evergreen |
08:05 |
|
collum joined #evergreen |
08:22 |
|
mtate joined #evergreen |
08:45 |
|
mmorgan joined #evergreen |
08:48 |
|
Dyrcona joined #evergreen |
08:49 |
Dyrcona |
@blame Ubuntu 10.04 to 12.04 upgrade |
08:49 |
pinesol_green |
Dyrcona: Ubuntu 10.04 to 12.04 upgrade caused the white screen of death! |
08:56 |
|
jwoodard joined #evergreen |
08:58 |
|
loocorez_ left #evergreen |
08:58 |
jeff |
i think 8.04 was current when the white screen of death was at its height :-) |
08:59 |
Dyrcona |
Meh. |
08:59 |
Dyrcona |
I'm starting to think Ubuntu is a sick joke. |
09:03 |
jcamins |
Dyrcona: you *upgraded* Ubuntu? |
09:04 |
|
ericar joined #evergreen |
09:05 |
Dyrcona |
jcamins: Technically, tsbere did, and it was some time ago. |
09:05 |
jcamins |
Oh, look. The new FF Yahoo search. |
09:06 |
jcamins |
Dyrcona: tsbere upgraded Ubuntu?!? |
09:06 |
Dyrcona |
jcamins: We're talking about servers here. |
09:06 |
* jcamins |
doesn't believe in upgrading. |
09:06 |
* Dyrcona |
doesn't believe in anything any more. |
09:07 |
jcamins |
Dyrcona: I know, I just set up a new server to avoid an upgrade. |
09:08 |
Dyrcona |
jcamins: Well, we're supposed to get new server, but we're waiting on some recommendations from someone else before we decide what to get. |
09:08 |
Dyrcona |
That server should be plural. |
09:08 |
|
maryj joined #evergreen |
09:09 |
jcamins |
Ah, just a temporary upgrade? That's good. |
09:09 |
Dyrcona |
If by temporary, you mean lasting over two years, then, sure..... |
09:10 |
jcamins |
Ugh. |
09:10 |
jcamins |
I feel like every time I upgrade a server, there's something wrong with either the kernel or a startup script. |
09:10 |
Dyrcona |
We have lots of issues that crop up on our production systems that don't happen anywhere else or to other Evergreen sites. |
09:10 |
Dyrcona |
Well, with Ubuntu, who knows what's wrong. |
09:11 |
Dyrcona |
Come to think of it, I've never had much luck upgrading anything other than Slackware, FreeBSD, and OpenBSD. |
09:12 |
* csharp |
usually swings his data onto external media and does a fresh install |
09:13 |
jcamins |
Other than needing to recompile X three times because it was a dependency for something idiotic, I will allow that my one FreeBSD upgrade was painless. |
09:14 |
Dyrcona |
OpenBSD upgrades basically amount to a fresh install when you see what it does. |
09:14 |
Dyrcona |
Of course, you have to delete the left over crud when you're done, but at least they provide a script you can download. ;) |
09:14 |
csharp |
that sounds better than Debian/Ubuntu/Fedora |
09:15 |
csharp |
1) upgrade all your installed packages, removing things for dependencies 2) find out what is utterly non-functional afterwards |
09:16 |
Dyrcona |
3) Reinstall packages that were removed for no damned good reason. |
09:16 |
csharp |
yep |
09:16 |
csharp |
of course, that also entails all the configs from the old packages that are no longer valid |
09:16 |
csharp |
upgrades-- |
09:18 |
csharp |
at least Debian/Ubuntu (I don't have enough experience with upgrading Fedora to know) let you know when there's a change in the config file and halts the upgrade until you approve the change |
09:18 |
Dyrcona |
With the BSDs, you usually end up going through a merge process on the configuration files. |
09:22 |
Dyrcona |
Sometimes, "harder" is better. :) |
09:22 |
|
kmlussier joined #evergreen |
09:25 |
|
akilsdonk_ joined #evergreen |
09:30 |
|
yboston joined #evergreen |
09:31 |
julialima |
Hello evergreeners!! I´m Julia from Argnetina. I was selected for the OPW internship and we will be working together over the next three months. I´m really happy with this opportunity :) |
09:32 |
graced |
Welcome julialima! |
09:32 |
Dyrcona |
Hello, julialima. Welcome to Evergreen! |
09:33 |
dbwells |
julialima: Welcome! I'm excited. This is going to be fun :) |
09:41 |
|
jl joined #evergreen |
09:52 |
maryj |
Welcome julialima! :D |
09:54 |
|
julialima left #evergreen |
09:56 |
|
julialima joined #evergreen |
09:56 |
kmlussier |
Welcome julialima! |
10:02 |
|
afterl joined #evergreen |
10:11 |
* kmlussier |
waves to afterl |
10:22 |
jeff |
julialima: greetings! |
10:28 |
* afterl |
waves back to kmlussier |
10:29 |
* afterl |
feels so welcome. kmlussier: thank you! |
10:30 |
csharp |
afterl: longtime nochat |
10:30 |
kmlussier |
afterl: I haven't seen you around in a while. I almost miss all that IRC conference planning we were doing last year. :) |
10:30 |
kmlussier |
Almost, but not really. |
10:31 |
* csharp |
wonders about the conference schedule planning group for 2015... |
10:31 |
|
mrpeters joined #evergreen |
10:32 |
kmlussier |
csharp: The planning committee has a meeting tomorrow. I'm hoping we can get an e-mail out after the meeting. |
10:32 |
csharp |
oh cool |
10:33 |
csharp |
I have some presentation ideas and was interested in the format |
10:36 |
csharp |
Fedora 21 is out! |
10:37 |
dbs |
csharp++ # yeah, been running fine on my laptop / home system for a few weeks now! |
10:39 |
Dyrcona |
Whee! Time to upgrade! :p |
11:01 |
|
RoganH joined #evergreen |
11:09 |
bshum |
dbs: Before I start merging upgrade script fixes, did you have a chance to see if I missed anything else from http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/fix_2.7_upgrade_scripts_in_master ? |
11:10 |
bshum |
Course now as I look at it with fresh eyes again, I'm wondering if I did something wrong :) |
11:10 |
bshum |
Yeah I think I did now that I look at it. |
11:10 |
bshum |
I need to put the drops ahead of the other stuff. |
11:10 |
* bshum |
tries again |
11:13 |
|
jihpringle joined #evergreen |
11:14 |
dbs |
bshum: sorry, head in many different places; I put each DROP right in front of the corresponding CREATE OR REPLACE line |
11:15 |
bshum |
dbs: Yep, I'm fixing that in mine again. I see what I did wrong in my commit now. |
11:16 |
bshum |
dbs++ # cool deal |
11:16 |
bshum |
I did a force push on my working branch with the correct fix this time for that DROP issue |
11:17 |
Dyrcona |
pgadmin-- # for deleting an entry in my .pgpass file. |
11:17 |
Dyrcona |
`chmod -w .pgpass` to the rescue. |
11:20 |
csharp |
Dyrcona: what did it delete? |
11:20 |
Dyrcona |
csharp: It deleted the entry for my main database server. I assume when I did not check the box for it to remember the password. |
11:21 |
Dyrcona |
Which begs the question of why it was asking for the password if it was already in .pgpass. |
11:21 |
csharp |
ah... |
11:21 |
Dyrcona |
I use both psql and pgadmin and use the former more often, actually. |
11:21 |
csharp |
seems like it shoudn't touch .pgpass at all since that's used by other PG clients |
11:22 |
csharp |
I use both too |
11:22 |
Dyrcona |
Yep. |
11:22 |
Dyrcona |
With it set to read only, I got prompted for the password. |
11:23 |
Dyrcona |
Then got, cannot open file .pgpass, permission denied. |
11:23 |
Dyrcona |
And it connected. |
11:24 |
bshum |
berick: eeevil: Was looking at https://bugs.launchpad.net/evergreen/+bug/1386347 and I'm wondering if maybe this should be considered a new feature for 2.next rather than a fix for backport? |
11:24 |
pinesol_green |
Launchpad bug 1386347 in Evergreen 2.6 "Speed up hold copy map deletion for clear shelf process, etc." (affected: 1, heat: 6) [Undecided,New] |
11:25 |
* bshum |
is reviewing bugs for next 2.7 maintenance |
11:25 |
berick |
heh, i was just adding something to that |
11:26 |
bshum |
Heh |
11:26 |
eeevil |
bshum: it's a toss-up in my mind, since it can cause user-level errors, but it's infrequent enough that I'm fine with holding off as well. |
11:28 |
bshum |
Ah I see, like timeouts. |
11:28 |
bshum |
Hmm |
11:29 |
bshum |
Yeah I guess it's a toss up. I guess I still lean towards cautiously not backporting things that sound too new :) |
11:29 |
bshum |
If berick is still adding stuff to it though, I'll hold off making changes to that bug for the moment. |
11:30 |
kmlussier |
bshum: I really need to spend some time developing that "bug or feature" plugin for pinesol_green. ;) |
11:33 |
bshum |
As a procedural issue |
11:33 |
bshum |
Not that we've decided on the last bug |
11:33 |
bshum |
But here's another one |
11:34 |
bshum |
https://bugs.launchpad.net/evergreen/+bug/1205072 has an upgrade note with it |
11:34 |
pinesol_green |
Launchpad bug 1205072 in Evergreen "Action trigger Granularity strings saving lable not value" (affected: 3, heat: 24) [Undecided,Confirmed] |
11:34 |
bshum |
Since we have not been running new release notes for maintenance point releases |
11:34 |
bshum |
Do we need something different to include that? |
11:34 |
bshum |
Or should I patch it into the main release notes? |
11:34 |
bshum |
Is it okay to just mention it in the maintenance blog post? |
11:35 |
|
sandbergja joined #evergreen |
11:35 |
kmlussier |
Is there any value to moving into the direction of running release notes for maintenance point releases? |
11:36 |
Dyrcona |
One thing that I think we do, which many other projects with databases do not do, is make database changes in "bug fix" releases. |
11:37 |
Dyrcona |
I recall Josh Berkus commenting on that in a conversation in Vancouver. |
11:38 |
bshum |
Yeah I always get nervous about DB changes in backports, especially given some of the trails of destruction that happen with our version-upgrade scripts |
11:38 |
* csharp |
agrees with Josh Berkus on that point |
11:39 |
bshum |
kmlussier: I think the thing I'd be wary of is that if we'd have to add infrastructure to the website downloads page to say, here's the current release note for this point release, here are all the others too |
11:39 |
bshum |
And that just adds more clutter to an already busy looking page |
11:39 |
bshum |
That and we'd have to make sure every release maintainer was paying attention to all those parts. |
11:39 |
bshum |
Which isn't bad, just something new |
11:40 |
kmlussier |
Yup. I only ask because I have had people ask me in the past what's bundled up in a point release. But we do have the ChangeLog there. |
11:40 |
Dyrcona |
I don't remember the conversation exactly, but he said something along the lines of we make a lot of database changes between .x releases, and way more than usual for .x.y releases. |
11:41 |
kmlussier |
It wouldn't necessarily be something that needs to be entirely on the release maintainers shoulders. I imagine it's something DIG could help with. |
11:41 |
Dyrcona |
He also mentioned that backporting database changes was also unusual. |
11:41 |
Dyrcona |
And, I could be misremembering, hallucination, or even out right lying. :) |
11:42 |
Dyrcona |
s/(hallucinati)on/\1ng/ |
11:42 |
kmlussier |
@eightball is Dyrcona misremembering, hallucinating or out right lying? |
11:42 |
pinesol_green |
kmlussier: Yes! |
11:42 |
Dyrcona |
@eightball never lies? |
11:42 |
pinesol_green |
Dyrcona: Maybe... |
11:43 |
Dyrcona |
I resolved my PgAdmin rumblings from before by manually editing .pgadmin3 to say StorePwd=true. |
11:43 |
Dyrcona |
It now does what I want it to do. |
11:51 |
kmlussier |
Remind me. With Standing Penalty Types, if you don't identify an org_depth, what's the default? 2? |
11:52 |
* mmorgan |
thinks kmlussier is correct. |
11:52 |
* kmlussier |
looks it up in Evergreen in Action. |
11:54 |
kmlussier |
Never mind. The question isn't answered there. |
11:56 |
mmorgan |
kmlussier: http://irc.evergreen-ils.org/evergreen/2013-10-25#i_42572 |
11:56 |
mmorgan |
jeff++ |
11:57 |
kmlussier |
mmorgan++ jeff++ |
12:06 |
|
bbqben joined #evergreen |
12:07 |
afterl |
kmlussier: anything you can share about the 2015 conference or is that still premature? |
12:10 |
|
bbqben_ joined #evergreen |
12:28 |
|
nhilton joined #evergreen |
12:50 |
RoganH |
afterl: kmlussier is on the committee but she's not the organizer. I don't know if any of the organizers are online right now, they might be better to ask. |
12:50 |
|
TaraC joined #evergreen |
12:51 |
kmlussier |
afterl: Sorry, I was on a call. It's scheduled for May 13-16. Right now, Tony is finishing up contract negotiations with the site. |
12:52 |
kmlussier |
afterl: I don't really have much information beyond that, other than the fact I'm working on a possible WordPress plugin to handle registrations instead of Eventbrite. Once I get the go-ahead to use it (hopefully tomorrow), I hope to have registrations up as soon as possible. |
12:52 |
kmlussier |
But, given my schedule, as soon as possible may not be this week. |
12:54 |
|
mtcarlsoz joined #evergreen |
12:54 |
RoganH |
kmlussier: see and here I was trying to give you an out. ;-P |
12:58 |
kmlussier |
RoganH: Nah, that's okay. |
12:58 |
* bshum |
wonders idly if the "hackfest" is Wednesday or Saturday on those dates. Or if there even is a Hackfest day. |
12:59 |
* bshum |
assumes Wednesday, but probably shouldn't assume anything anymore. |
12:59 |
kmlussier |
bshum: I don't know. |
13:00 |
kmlussier |
bshum: I may know after tomorrow. |
13:01 |
|
mnsri left #evergreen |
13:05 |
jeff |
mmorgan, kmlussier: glad you found the answer you were looking for :-) |
13:05 |
RoganH |
bshum: Can we have the hackfest water side? Or brewery side? |
13:07 |
bshum |
RoganH: Should pass that suggestion up to the planners :) |
13:07 |
bshum |
But I like this plan. |
13:07 |
|
mnsri joined #evergreen |
13:09 |
|
Shae joined #evergreen |
13:12 |
RoganH |
dear whoever is listening: we need the hackfest at a good microbrewery (with decent food too) |
13:14 |
Dyrcona |
@who is listening |
13:14 |
pinesol_green |
Callender is listening. |
13:14 |
Dyrcona |
Callender: While you're at it, can I have a pony? ;) |
13:18 |
RoganH |
Callendar: can you strap barrels to that pony? |
13:20 |
|
kitteh joined #evergreen |
13:20 |
|
BigRig_ joined #evergreen |
13:22 |
afterl |
kmlussier: thanks for the conference update! |
13:45 |
mrpeters |
checking out the new "Library Pages" in 2.7 -- anyone else think the formatting for the Mailing Address could be much better? |
13:46 |
bshum |
mrpeters: If memory serves, that's a debatable decision, depending on what country you live in? |
13:46 |
mrpeters |
STREET 1/ STREET 2 / CITY / STATE / COUNTRY / ZIP seems really long |
13:46 |
bshum |
But yes, I think it could look nicer for the US :) |
13:46 |
mrpeters |
im about to start hacking on making some links to google maps on this page |
13:47 |
bshum |
But I believe that is the reason why dbs made them the way they are was for international reasons. And figuring that sites could customize their page style to fit their regions more appropriately. |
13:47 |
bshum |
Google maps is a good idea, for sure ;) |
13:48 |
kmlussier |
bshum: Did Biblio customize theirs? |
13:48 |
mrpeters |
yeah, think I will just put a google maps icon on there, and if you click that, it will search the address |
13:48 |
mrpeters |
i was just like hmm....that is really strange to have 5 lines for the address, but i can understand where it would make sense elsewhere |
13:48 |
bshum |
kmlussier: I did once, but I think I must not have checked it into git cause I see it's back to the default styling |
13:51 |
bshum |
Yeah, I need to fix ours up again |
13:52 |
bshum |
I never liked those link backs going up the org tree :) |
13:52 |
bshum |
For the parent ou |
13:54 |
dbs |
mrpeters: I did have Google Maps integration in a branch, with the real javascript api and all. Could try and dig that up. |
13:55 |
dbs |
As for formatting / what to include / exclude, there's a reason we use template toolkit :) |
13:58 |
mrpeters |
yeah! its great |
14:06 |
csharp |
hoowee - nvdia proprietary drivers be all busted in F21 - might be rpmfusion lag |
14:06 |
* csharp |
is still figuring out systemd/journalctl, so doesn't have good log-fu |
14:09 |
* Dyrcona |
thinks he'll dust off the old DEC alpha with OSF/1..... |
14:10 |
* Dyrcona |
actually hasn't seen one since about 2001. |
14:12 |
dbs |
last two commits on http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/google_maps are handwavy, but connecting the geocoding to the static map won't be much work |
14:13 |
mrpeters |
nice! thanks dbs |
14:14 |
dbs |
mrpeters: it's pretty old stuff but would be nice to finish off properly (and have a config option, of course, for libraries that want to avoid google privacy concerns) |
14:14 |
mrpeters |
ill give it a look |
14:15 |
Dyrcona |
Privacy? What's that? |
14:15 |
jeff |
Dyrcona: i wonder how many things would smoke if i attempted to power on the old Personal DECstation in my garage... |
14:15 |
Dyrcona |
jeff: ha ha. |
14:16 |
Dyrcona |
I sometimes think of powering up the old Vic-20 in the attic and seeing if the tapes are still readable. |
14:19 |
|
rashma joined #evergreen |
14:19 |
jeff |
spoiler: they probably aren't. |
14:19 |
Dyrcona |
heh. |
14:19 |
Dyrcona |
Probably not for years. |
14:20 |
Dyrcona |
I'll have to type my space invaders clone in from memory then... ;) |
14:20 |
|
sbrylander joined #evergreen |
14:23 |
Dyrcona |
Heh. I could probably implement that in HTML 5, now. |
14:25 |
|
b_bonner_ joined #evergreen |
14:35 |
* dbs |
automatically hears the space invaders noises slowly increasing |
14:36 |
|
mtcarlson joined #evergreen |
14:41 |
phasefx |
berick: you ever have a websocket just close on you? |
14:41 |
* phasefx |
bets he has something misconfigured somewhere |
14:41 |
berick |
phasefx: the gateway will time out after a period of inactivity |
14:41 |
berick |
(which is configurable) |
14:42 |
phasefx |
berick: doesn't seem to be inactivity.. but I can't reproduce the issues on webby.. I can spam patron search, for example, tweaking the search params and get it to disconnect |
14:42 |
phasefx |
can also do it with checkins and checkouts and item status |
14:42 |
phasefx |
and once it happens, I have to reload the page |
14:43 |
berick |
phasefx: that i've never seen. |
14:43 |
berick |
suggest checking the apache-websocket error log |
14:43 |
phasefx |
nothing there |
14:44 |
kmlussier |
dbs: Thanks! Now I'm hearing the same noises too. |
14:45 |
phasefx |
berick: I am getting ssl errors in the regular apache log |
14:46 |
phasefx |
stuff like [Tue Dec 09 14:45:28 2014] [info] [client ::1] SSL library error 1 in handshake (server localhost:443) |
14:50 |
berick |
yeah, i often see SSL errors in apache (websockets or not) |
14:50 |
berick |
not sure what to make of those |
14:51 |
berick |
phasefx: chrome console shows nothing interesting? do API calls break or does it disconnect after a call? |
14:51 |
berick |
the broken API calls.. do they succeed on the server? |
14:51 |
phasefx |
they don't get to the server |
14:51 |
phasefx |
you see closing websocket int he console, preceded by the call |
14:53 |
phasefx |
I get one hit against osrf-websocket-translator in the apache logs, and one entry in gateway.log, a WS disconnect from IP address |
14:54 |
phasefx |
have it nice and reproducible at the moment. I'm tempted to try using just one apache for everything and see what happens |
14:58 |
phasefx |
thanks man; I'm going to keep poking |
15:20 |
mrpeters |
is mkurl() an Evergreen macro, or a standard template toolkit macro that is available? |
15:22 |
mrpeters |
thought being, could i make an mkurl statement to go to https://www.google.com/maps/place/[% ctx.mailing_address.street%] type of thing |
15:24 |
mrpeters |
since, awesomely, https://www.google.com/maps/place/123 Main Street Atlanta, GA works as an href |
15:24 |
mrpeters |
err, well https://www.google.com/maps/place/123%20Main%20Street%20Atlanta%20GA i guess |
15:29 |
berick |
mrpeters: it's a local macro, defined in opac/parts/header.tt2 |
15:29 |
berick |
you don't really need it to build links to external sites |
15:29 |
mrpeters |
berick: awesome, thank you -- wont travel down that road then :) |
15:29 |
berick |
i mean, you can, but it serves no purpose |
15:30 |
mrpeters |
yeah, it looks like i can do a regular a href and call those variables |
15:30 |
berick |
yeah |
15:30 |
mrpeters |
like street1, etc. |
15:30 |
mrpeters |
which is way cool |
15:30 |
mrpeters |
templateToolkit++ |
15:31 |
berick |
just be sure to |uri filter it |
15:32 |
mrpeters |
ok, ill research that |
15:36 |
Dyrcona |
@blame eeevil |
15:36 |
pinesol_green |
Dyrcona: eeevil wants the TRUTH?! eeevil CAN'T HANDLE THE TRUTH!! |
15:37 |
Dyrcona |
execute failed: ERROR: null value not allowed for hstore key at /openils/bin/clark-kent.pl line 217 |
15:43 |
csharp |
Dyrcona: is that the same issue as was affecting circ yesterday? |
15:44 |
Dyrcona |
We believe so, but we're looking. |
15:44 |
Dyrcona |
We suspect this report ran while it was till a problem. |
15:47 |
csharp |
hmm - alt+N keys aren't moving me from chat to chat in 'screen' in the new GNOME terminal in F21 |
15:49 |
|
nhilton_ joined #evergreen |
15:49 |
csharp |
had to disable the GNOME terminal shortcut key to make that work :-/ |
15:50 |
jeff |
that kind of thing is common. i haven't decided yet if i prefer Esc,n to Meta+n |
15:50 |
Dyrcona |
Yep, and we've run the report again. |
15:50 |
jeff |
(or where Meta differs from ... yeah) |
15:51 |
Dyrcona |
Yeah, term apps will eat your shortcuts.... |
15:51 |
Dyrcona |
And sometimes just Gnome does. |
15:51 |
csharp |
since I don't navigate between terminal tabs that way, it's no loss |
15:54 |
* Dyrcona |
just Alt+{number} in Pidgin. Is mildly surprised it works. |
15:55 |
Dyrcona |
@praise eeevil |
15:55 |
* pinesol_green |
eeevil is one of the few who deserves to be praised |
16:04 |
mrpeters |
for those who are interested -- http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters/customize_library_page_addr_format formats addresses a bit better for US formatting, and adds a link to the Google Map of the org unit. All within Google's TOS according to http://www.google.com/permissions/geoguidelines.html#maps-web |
16:05 |
mrpeters |
i can make a seperate branch with just the Google Map if anyone would like it |
16:16 |
bshum |
Hmm |
16:26 |
|
nhilton joined #evergreen |
16:32 |
dbs |
mrpeters: definitely separate out the formatting from the google map functionality if you want a chance of a merge :) |
16:33 |
mrpeters |
i wasn't really aiming for a merge, i didn't know that we would want that as a default |
16:33 |
mrpeters |
more just floating it out there in case someone likes it |
16:33 |
|
akilsdonk joined #evergreen |
16:37 |
|
nhilton_ joined #evergreen |
16:43 |
Dyrcona |
@blame The weather |
16:43 |
pinesol_green |
Dyrcona: everything was going great until The weather came along |
16:46 |
bshum |
mrpeters: I like to think code submissions should always be angled towards being merged as the end goal. |
16:46 |
bshum |
I mean, it's great to share, but it's nicer to have it become part of core and your awesomeness spread throughout Evergreen-dom. |
16:46 |
mrpeters |
i just thought a google map might be too specific to be accepted |
16:46 |
mrpeters |
maybe we dont want to endorse them, maybe someone likes yahoo maps better, etc. |
16:47 |
bshum |
mrpeters: Probably the best way to include it then is to make it something that can be toggled in config.tt2 and wrap the stuff in an IF block check for that variable. |
16:47 |
bshum |
Kind of like how we currently deploy Google Books |
16:47 |
mrpeters |
good point |
16:47 |
bshum |
Then if someone likes Yahoo maps better, they can write a block for that and make a variable for it :) |
16:48 |
Dyrcona |
yep |
16:49 |
mrpeters |
sounds like a good idea, ill resubmit |
16:51 |
bshum |
mrpeters++ |
16:51 |
Dyrcona |
mrpeters++ |
16:51 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
17:05 |
|
mmorgan left #evergreen |
17:06 |
|
kmlussier joined #evergreen |
17:15 |
dbs |
mrpeters++ # and maybe [% INCLUDE %] it as a separate .tt2 file entirely |
18:55 |
|
dcook joined #evergreen |
19:37 |
|
sarabee joined #evergreen |
22:22 |
|
akilsdonk_ joined #evergreen |