| Time |
Nick |
Message |
| 06:28 |
|
abneiman_ joined #evergreen |
| 09:32 |
|
collum joined #evergreen |
| 09:49 |
|
Dyrcona joined #evergreen |
| 10:15 |
|
mmorgan joined #evergreen |
| 10:39 |
|
sandbergja joined #evergreen |
| 10:58 |
pinesol |
News from commits: LP#1801146: Item Status fix Holds Count, Record Quality and add Mint Condition. <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=412d18b1a70b118c764fe74f70b1883e246f13fa> |
| 11:12 |
|
Rogan joined #evergreen |
| 12:07 |
|
jihpringle joined #evergreen |
| 12:26 |
|
terranm joined #evergreen |
| 12:28 |
pinesol |
News from commits: LP#2142482 Place hold enabled for staff user is loaded <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3faf1b8f7d6dde6247fdd451ee77ee7e256ecbd3> |
| 12:28 |
pinesol |
News from commits: LP#1999435: Address cellTextGenerator error that prevented download of CSV from Fundi... <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e849b61ca18bfeb035003ed61d6f45611a0afdfa> |
| 12:32 |
terranm |
Hi all, there are 101 LP bugs that have patches submitted but need additional work or rebasing so they have been lingering (some back as far as 2021), and they aren't currently assigned to anyone. Would anyone object to me assigning them back to the people who submitted the patches? (Assuming they are still working with Evergreen) |
| 12:34 |
terranm |
Big ugly URL listing them: https://bugs.launchpad.net/evergreen/+bugs?field.searchtext=&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=INPROGRESS&assignee_option=none&field.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.structural_subscriber=&field.tag=needsrebase%20needsreleasenote%20%20needst |
| 12:34 |
terranm |
estplan%20needswork&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_bl |
| 12:34 |
terranm |
ueprints=on&search=Search&orderby=date_last_updated&start=0 |
| 12:50 |
sandbergja |
For anybody who wants to get into automated tests, there is a free class on testing in Perl coming up on Thursday (https://luma.com/perl-maven) |
| 12:51 |
terranm |
sandbergja++ |
| 12:58 |
pinesol |
News from commits: LP#2100096: Do not show Fast Add checkbox on Acquisitions MARC Federated Search <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f9794a7db3912b5f24afcb8da2c11e08f0a57b7c> |
| 12:58 |
sandbergja |
I thought this was interesting: llvm (which is a very fundamental piece of software) allows anyone how has made 3 or more contributions to be a committer: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access |
| 13:00 |
sandbergja |
Interesting that they could very well have been "this software is critical to the environment, we're going to lock it down", but instead they said "this software is critical to the environment, we need as many committers as possible" |
| 13:02 |
terranm |
That has definite pros and cons. |
| 13:04 |
sandbergja |
for sure |
| 13:05 |
terranm |
My mind is very fuzzy, but wasn't there something pretty critical in the past few years where someone did some benign commits that got accepted into a project and then slipped in an intentional security problem? |
| 13:06 |
sandbergja |
Yes :-( https://en.wikipedia.org/wiki/XZ_Utils_backdoor |
| 13:07 |
Dyrcona |
terranm: There have been a couple, but sandbergja posted one of the most recent, infamous ones. It boiled down to the developer being harrassed into it. |
| 13:10 |
terranm |
:( |
| 13:11 |
Dyrcona |
"After a period of pressure on the founder and head maintainer to hand over the control of the project via apparent sock puppetry," From what I understand, that hardly does it justice. |
| 13:14 |
Dyrcona |
Back to LLVM: It requires 2 other committers to approve the access; one is granted commit-after-approval before getting full commit privilege, and all code is subject to code review. We should have such procedures, but nothing new would ever get in. |
| 13:15 |
Dyrcona |
And they mean ALL code is subject to code review: https://llvm.org/docs/CodeReview.html |
| 13:17 |
Dyrcona |
sandbergja: Is there a code review gathering today? |
| 13:19 |
sandbergja |
Dyrcona: yep |
| 13:21 |
Dyrcona |
Thanks! I shall endeavor to be there. |
| 13:22 |
sandbergja |
Dyrcona++ |
| 13:23 |
sandbergja |
Thanks for providing the angular 21 test server too! |
| 13:23 |
Dyrcona |
You're most welcome. I want to see us migrate to Angular 21 for 3.17. |
| 13:25 |
terranm |
Dyrcona++ |
| 13:25 |
Dyrcona |
sandbergja++ terannm++ |
| 13:44 |
terranm |
Hearing no objections so far to me assigning bugs with needswork/needsrebase tags back to their developers, I shall begin. Some of them had developers that are no longer in the development community so I'll leave those alone. |
| 13:52 |
sandbergja |
terranm++ |
| 13:56 |
terranm |
(And my apologies to anyone who finds this really annoying, just trying to help!) |
| 14:07 |
mmorgan |
terranm++ |
| 15:02 |
sandbergja |
claiming 1512 |
| 15:06 |
Dyrcona |
For everyone who was in the code review meeting, and anyone else, really: I have reinstalled the Angular 21 branch without the --configuration=production option on the Angular code. The vm was also assigned more resources after the crash. Hopefully, it will stay up. |
| 15:07 |
sandbergja |
Dyrcona++ |
| 15:28 |
pinesol |
News from commits: LP#885270: stamp upgrade script <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4ad96114f5ee05bc629f4dad889266889cb5994a> |
| 15:28 |
pinesol |
News from commits: LP#885270: Add address ownership reassignment to prevent user purge failures <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=47f4284e016732f943f6e75c07cf28f28790c1c9> |
| 16:28 |
Dyrcona |
ooh. my laptop is thrashing. I should probably close a few Chrome tabs. |
| 16:35 |
|
Dave_OCLN joined #evergreen |
| 16:43 |
Dyrcona |
sandbergja: Is there something else that I have to do to get the language picker menu to show up? I've done everything from the docker except the environment.ts step because I thought that was supposed to be unnecessary with bug 2082036. |
| 16:43 |
pinesol |
Launchpad bug 2082036 in Evergreen "Cannot add languages to the Angular language picker or translation dialog from the tarball" [Undecided,Confirmed] https://launchpad.net/bugs/2082036 - Assigned to Jason Stephenson (jstephenson) |
| 16:43 |
Dyrcona |
I set staff_client to true for cs-CZ and ar-JO. Maybe I'll disable the latter. I might not have set it up correctly. |
| 16:46 |
Dyrcona |
Ah ha! The menu is appearing now. |
| 16:47 |
Dyrcona |
now, I get a 404 for the cs-CZ staff client... |
| 16:47 |
terranm |
Huzzah! |
| 16:47 |
terranm |
Oh. I huzzahed too soon. |
| 16:48 |
|
jihpringle joined #evergreen |
| 16:49 |
Dyrcona |
OK. I think the problem is a bad edit to eg_vhost.conf. |
| 16:50 |
Dyrcona |
Well, that fixed the 404 but everything is still in English. |
| 16:51 |
Dyrcona |
The AngularJS interfaces are in Czech. |
| 16:55 |
Dyrcona |
It's weird. If I switch back to English, any AngularJS interface that I've not visited in Czech appears in English. If I go to an interface that I viewed in Czech, it's still in Czech. Angular doesn't seem to work at all with the translations in my set up. I probably broke something. |
| 16:56 |
Dyrcona |
I'll wipe the vm and try again fresh tomorrow. |
| 17:02 |
terranm |
sandbergja: are you here right now? |
| 19:59 |
pinesol |
News from commits: LP#2086738: Don't send excessive calls for shelving locations when Expand All in... <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=aded0447cf65d5001cfa68a1a0a396491ff0ab81> |
| 19:59 |
pinesol |
News from commits: LP#2100096: follow-up: provide a reasonable default value <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b6ef024017acf87c87791156ab2d645537e1dd5a> |
