| Time |
Nick |
Message |
| 06:10 |
pinesol_dev |
News from commits: LP#2080881: Old Link Checker used for AngJS pages <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=eef69b52e7cc93660a2fe188b7eef0799b4b4928> |
| 06:30 |
pinesol |
News from commits: LP#2080881: Old Link Checker used for AngJS pages <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=eef69b52e7cc93660a2fe188b7eef0799b4b4928> |
| 09:10 |
Bmagic |
sorry for the duplicates |
| 09:11 |
Bmagic |
dev is beating prod |
| 09:11 |
Bmagic |
@coffee [someone] |
| 09:11 |
pinesol_dev |
Bmagic: You probably want hard-boiled eggs. |
| 09:11 |
* pinesol |
brews and pours a cup of Ethiopia Sidamo Guji, and sends it sliding down the bar to jweston_ |
| 09:36 |
csharp_ |
@coffee pinesol_dev |
| 09:36 |
pinesol_dev |
csharp_: You probably want hard-boiled eggs. |
| 09:36 |
* pinesol |
brews and pours a cup of S.O. India Sitara, and sends it sliding down the bar to pinesol_dev |
| 09:36 |
csharp_ |
pinesol_dev: says you |
| 09:36 |
pinesol_dev |
csharp_: There is no Angular only XUL |
| 09:38 |
csharp_ |
FYI, PINES is live on 3.16.3 - we're a bit concerned about some slower-than-expected loading in some UIs which I'm currently attributing to new PCRUD perm infrastructure |
| 10:06 |
Bmagic |
csharp_++ # upgrading to the future |
| 10:07 |
Bmagic |
I've noticed when switching from an Angular interface over to an AngularJS interface, it's slow. but if you say in AngularJS with each page load, it's fast. But when you want to use an interface on the Angular side, it's slow |
| 10:07 |
Bmagic |
switching back and forth (via the nav menu) can be painful, but then fast when staying on one side of the fence or the other |
| 10:12 |
Bmagic |
Dycrona: let me know if I can help with the python3 business |
| 10:12 |
Bmagic |
oh he's not here, probably off today |
| 11:16 |
Bmagic |
do we have a wiki page explaining our Launchpad etiquette? |
| 11:16 |
Bmagic |
like, when to assign yourself, marking milestones, what each thing means, etc? |
| 11:23 |
|
sandbergja joined #evergreen |
| 11:24 |
sandbergja |
scottangel: you around? |
| 12:54 |
|
sandbergja joined #evergreen |
| 13:41 |
|
sandbergja joined #evergreen |
| 14:28 |
|
smayo joined #evergreen |
| 15:38 |
csharp_ |
Bmagic++ |
| 15:40 |
csharp_ |
Bmagic: re: your question about bug docs: https://wiki.evergreen-ils.org/doku.php?id=dev:bug_wrangler:faq |
| 15:42 |
sandbergja |
csharp_++ |
| 15:49 |
abneiman |
Noting that there will be a merge pause tomorrow (2/17) evening starting at 11pm ET |
| 16:09 |
sandbergja |
abneiman++ |
| 16:29 |
Bmagic |
taking 1511 |
| 16:34 |
sandbergja |
Bmagic: regarding bug 2125838: without the patch, building a generic non-dev docker image took me 28:23.58 minutes. With the patch, and throwing NO_CPAN_TEST=1 throughout install_evergreen.yml, it took 24:42.38 minutes. |
| 16:34 |
pinesol |
Launchpad bug 2125838 in Evergreen "Add an option to install prerequisites without running tests for CPAN packages" [Undecided,New] https://launchpad.net/bugs/2125838 |
| 16:34 |
Bmagic |
I was about to look at that myself! |
| 16:35 |
sandbergja |
not exactly night and day, and there is of course a lot of variation just due to the network calls. But still seems signifant and in the correct direction... |
| 16:35 |
Bmagic |
I'll see if my test is similar. I'm assuming you made the changes to vars.yml and install_evergreen.yml for the cherry pick and the new var? |
| 16:35 |
sandbergja |
yeah |
| 16:36 |
sandbergja |
that would be great to repeat the test! thanks for taking it for a spin! |
| 16:36 |
Bmagic |
pretty cool, 4 minutes and 20 seconds is pretty good. Plus, on the tarball build, the overall time should be lower (because we're not downloading the repo) |
| 16:54 |
sandbergja |
Bmagic, I realized I need to push a second commit to that branch (should not interfere with your testing). It was not actually helping with github actions performance as I had it. |
| 16:55 |
sandbergja |
(that was one of my main motivations: give people quicker feedback on their pull requests, and don't get too close to the limit on the github actions free tier) |
| 16:58 |
pinesol_dev |
News from commits: LP#1376427 stamp upgrade script <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1434c7d91fa3ce6edbab5c4f3828f09d27a09336> |
| 16:58 |
pinesol_dev |
News from commits: LP#1376427 Docs: New fields in Holdings Import Profile <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=75284eaaad5fad2d6d0323359298ae6650cf203b> |
| 16:58 |
pinesol_dev |
News from commits: LP#1376427 Add Age Protection etc to Holdings Import Profile <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9ed40aa6048b228798793d70e9bcbd17eb70a166> |
| 16:59 |
sandbergja |
Now it actually makes a difference in github actions: 11 minutes before (https://github.com/sandbergja/Evergreen/actions/runs/22078330864/job/63798207516) and 5 and a half minutes after (https://github.com/sandbergja/Evergreen/actions/runs/22078516174/job/63798760445) |
| 17:01 |
pinesol |
News from commits: LP#1376427 stamp upgrade script <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1434c7d91fa3ce6edbab5c4f3828f09d27a09336> |
| 17:01 |
pinesol |
News from commits: LP#1376427 Docs: New fields in Holdings Import Profile <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=75284eaaad5fad2d6d0323359298ae6650cf203b> |
| 17:01 |
pinesol |
News from commits: LP#1376427 Add Age Protection etc to Holdings Import Profile <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9ed40aa6048b228798793d70e9bcbd17eb70a166> |
| 17:30 |
Bmagic |
sandbergja: https://github.com/mcoia/eg-docker/commit/6f6896720cef61d682827d0d5ef20d05460e0838 |
| 17:30 |
pinesol_dev |
News from commits: LP#2137671 Misleading Basket Count on OPAC search results <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=30a863df059d623ded19a71301956c506a392620> |
| 17:31 |
sandbergja |
Bmagic++ |
| 17:31 |
pinesol |
News from commits: LP#2137671 Misleading Basket Count on OPAC search results <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=30a863df059d623ded19a71301956c506a392620> |
| 17:32 |
sandbergja |
nice! I like having it configurable |
| 17:32 |
Bmagic |
just curious how that compares to what you came up with |
| 17:33 |
sandbergja |
I added an env: \n NO_CPAN_TEST: 1 |
| 17:33 |
sandbergja |
(with appropriate indentation) |
| 17:33 |
sandbergja |
to the steps |
| 17:33 |
Bmagic |
got a branch I can see? |
| 17:35 |
sandbergja |
https://github.com/mcoia/eg-docker/compare/master...sandbergja:eg-docker:with-no-cpan-test |
| 17:35 |
sandbergja |
I guess it was environment, not env |
| 17:36 |
Bmagic |
hmmm, that makes it tougher to incorporate it into vars.yml I think |
| 17:36 |
sandbergja |
i just threw it wherever it seemed to mention Makefile.install haha |
| 17:36 |
Bmagic |
OpenSRF might benefit from the same type of option |
| 17:37 |
Bmagic |
I wonder if we'd ever not* want this option in the docker context. Probably not |
| 17:38 |
Bmagic |
I know I'm not going to want the build to be slower when I'm working with dockerhub or any other image. I'm leaning towards the environment approach, and eliminating it as an option |
| 17:41 |
sandbergja |
I can't think of a reason. Running the tests for our dependencies sounds nice, but I don't think that a test failure blocks the process or anything, you would have to review the Make output to even know there was a problem with one of the dependencies... |
| 17:42 |
Bmagic |
ok, my two builds finished with the cpan test patch winning by 5.7 minutes |
| 17:43 |
sandbergja |
woo hoo! |
| 17:43 |
Bmagic |
I installed enhanced concerto, in hindsight, I should have tweaked that option to speed up the overall build time. With Tests: 33m29s, without: 25m34s |
| 17:44 |
Bmagic |
I'll sign off and merge, if you want to contribute your style patch to eg-docker? |
| 17:45 |
Bmagic |
be sure and hit all three build types |
| 17:45 |
sandbergja |
Bmagic: thank you! sounds like a plan |
| 17:46 |
Bmagic |
sandbergja: how do you feel if I squash your two commits into a single? |
| 17:46 |
sandbergja |
Bmagic: go for it! |
| 17:47 |
Bmagic |
seems like it's really just one commit |
| 17:47 |
sandbergja |
that saves me the embarassment of my first commit not quite working haha |
| 17:48 |
sandbergja |
Bmagic: what if I throw the environment variable in at the playbook level, rather than for individual tasks? That might be a little less cluttered than my original approach |
| 17:48 |
Bmagic |
seems harmless, sure |
| 17:50 |
Bmagic |
hmmm, we should include the new option in the install instructions |
| 17:52 |
sandbergja |
good point. Do you want me to throw something together or do you want to? |
| 17:52 |
Bmagic |
it'd save me the colab branch if you did it |
| 17:52 |
Bmagic |
using the existing branch |
| 17:53 |
sandbergja |
gotcha |
| 17:53 |
Bmagic |
I'm looking at server_upgrade.adoc |
| 17:53 |
Bmagic |
and server_installation.adoc |
| 17:58 |
sandbergja |
Bmagic++ |
| 17:58 |
sandbergja |
pushed |
| 17:58 |
sandbergja |
rather, i pushed the docs as a 3rd commit in that branch |
| 19:47 |
|
pinesol joined #evergreen |
| 20:14 |
pinesol_dev |
News from commits: LP#2125838: add an option to install prereqs without running cpan tests <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6d042a2576f79b90e4cb966e5a946b831bcaf2fc> |
| 20:33 |
pinesol |
News from commits: LP#2125838: add an option to install prereqs without running cpan tests <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6d042a2576f79b90e4cb966e5a946b831bcaf2fc> |
| 23:29 |
pinesol_dev |
News from commits: LP#2125838: follow-up: fix pgtap github action <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bf3bfca1341670816c31f4439afbc195316c3916> |
| 23:33 |
pinesol |
News from commits: LP#2125838: follow-up: fix pgtap github action <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bf3bfca1341670816c31f4439afbc195316c3916> |
| 23:56 |
|
sandbergja joined #evergreen |
