| Time |
Nick |
Message |
| 07:15 |
|
sandbergja joined #evergreen |
| 07:26 |
pinesol |
News from commits: LP#2139366: Sort parts in staff client place hold interface <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=307627e43017a240a0645379087891907f4254b4> |
| 07:56 |
pinesol |
News from commits: LP#2138969: fix query generation for certain Fielder grids <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4e4536c8cbc4d056ab87c4c0304d65cf1c9963e9> |
| 07:56 |
pinesol |
News from commits: LP#2139299: Angular Reporter searching, changing 'string' to <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=03bf8ae29f0a55cf488030c34f15d3f34a0e7bc9> |
| 07:56 |
pinesol |
News from commits: LP#2130749: Reorder fields list in Angular Circulation Patron Search <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=46245aa480f50c3bb4c95a095fa50afe89f511bd> |
| 07:56 |
pinesol |
News from commits: LP#2130749: Adds Username to Checkbox Text in Angular Patron Search <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7488faeafb60506fa3f82f185de59d916e8cf394> |
| 08:26 |
pinesol |
News from commits: LP#2120189: restore First Contiguous Non-Space Characters reports transform <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b50bb9c8cd086b2b305e20681874cf9a00a1403b> |
| 08:26 |
pinesol |
News from commits: LP#2116743: Run Angular unit tests in GitHub actions <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=93f7f299f3ed3710764115d775a326d75e516a6e> |
| 08:59 |
|
mmorgan joined #evergreen |
| 09:00 |
|
Dyrcona joined #evergreen |
| 09:37 |
|
sandbergja joined #evergreen |
| 09:53 |
Dyrcona |
So, I am getting this message while trying to use open-ils.actor.user.delete in a live test: Can't use an undefined value as an ARRAY reference at /usr/local/share/perl/5.40.1/OpenILS/Application/Actor.pm line 4253. |
| 09:53 |
Dyrcona |
It looks like the attempt to run actor.usr_delete is failing. |
| 09:58 |
Dyrcona |
Ah ha! There's a problem with the code I'm testing. |
| 09:59 |
Dyrcona |
And maybe it is how I input the values of the settings, not the code itself. |
| 10:06 |
Dyrcona |
Heh. bugs in the test. : |
| 10:19 |
Dyrcona |
How do I set an org_unit_setting to true with Perl? |
| 10:19 |
Dyrcona |
I'll try 't', but bet it will fail. |
| 10:25 |
Dyrcona |
The tests all seem to set them to 1, but that failed for me because Rogan's code is doing a cast a to a BOOLEAN. |
| 10:26 |
Rogan |
what are you looking at? |
| 10:27 |
Dyrcona |
I'm adding Perl tests to Lp 1861239 |
| 10:27 |
pinesol |
Launchpad bug 1861239 in Evergreen "Aged transactions can be de-anonymized using post code and birth year" [Wishlist,Confirmed] https://launchpad.net/bugs/1861239 - Assigned to Jason Stephenson (jstephenson) |
| 10:27 |
Rogan |
ah, that explains the lack of recent memory |
| 10:27 |
Dyrcona |
Apparently, I can't set a JSON true value via Perl. |
| 10:27 |
Rogan |
huh, that's surprising |
| 10:28 |
Dyrcona |
I think there's a urility function somewhere, OpenSRF maybe. I'm gonna try that if I can find it. |
| 10:28 |
Dyrcona |
This is specifically with open-ils.actor.org_unit.settings.update. |
| 10:33 |
Dyrcona |
I don't think the OpenSRF:Utils::JSON module is going to work, but I'll give it a whirl. |
| 10:35 |
Dyrcona |
Oh, maybe the "true" subroutine will work. I'll give it a shot. |
| 10:37 |
Dyrcona |
OK, that worked, but the user delete function still blows up. |
| 10:38 |
Dyrcona |
Base schema has more issues. |
| 10:38 |
Dyrcona |
Upgrade script worked. |
| 10:48 |
sandbergja |
Dyrcona, regarding a JSON true value via Perl, I came across this from berick recently: https://github.com/evergreen-library-system/Evergreen/blob/b50bb9c8cd086b2b305e20681874cf9a00a1403b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/Settings.pm#L515-L519 |
| 10:51 |
Dyrcona |
sandbergja: Thanks, but I figured out something that works: OpenSRF::Utils::JSON->true |
| 10:56 |
Dyrcona |
This is why we should have tests... |
| 11:00 |
Dyrcona |
Awesome sauce. My tests and a fresh install are working. Guess the tests worked in the sense that they found issues with the schema code. |
| 11:00 |
Dyrcona |
Now to add tests for an ou that doesn't have the settings turned on. |
| 11:14 |
Dyrcona |
Maybe I should do tests for an org set to only redact birth year. I could see that being the most common setting: keep post code, but not birth year. |
| 11:16 |
|
sandbergja joined #evergreen |
| 11:25 |
sandbergja |
gmcharlt: thanks for your interest in reviewing bug 1741162 -- as you requested, I am sending you a reminder ping |
| 11:25 |
pinesol |
Launchpad bug 1741162 in Evergreen "Remove Dojo from added content JavaScript" [Undecided,New] https://launchpad.net/bugs/1741162 |
| 11:25 |
Dyrcona |
Only 7 of the 23 tests are actually testing this branch. |
| 11:26 |
Dyrcona |
I could add a couple more to see if the circulations are actually checked in, but... |
| 11:27 |
Dyrcona |
Think I'll add some tests for BR2 and BR3. Might as well exercise all of the options. |
| 11:56 |
Dyrcona |
Great. So I picked a user without a dob to test keeping only the birth year..... |
| 11:56 |
Dyrcona |
Guess I need to find another patron from BR3. |
| 11:57 |
pinesol |
News from commits: LP#1998645: (follow-up) tidy up updateInMemory* <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a93ee8d543ee20d5c7c0fa150fc3c17306c8919e> |
| 11:57 |
pinesol |
News from commits: LP#1998645: (follow-up) rename "Filter" button <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8c18db076612a1d54c417c0af944288a2e04493a> |
| 11:57 |
pinesol |
News from commits: LP#1998645: (follow-up) tweak item filter buttons <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1a0b84a064dea4333bf3390762325bcbb1950334> |
| 11:57 |
pinesol |
News from commits: LP#1998645: (follow-up) limit tag, alert, and note edits to selected items <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=49d523f9883f9df2d117200dd02eaf602474b142> |
| 11:57 |
pinesol |
News from commits: LP#1998645: Allow filtering in item editor <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=55f2dfecfde13621fa4c1b7c32f5714f1b298c26> |
| 11:58 |
Dyrcona |
Great... Neither of the patrons from BR3 with transactions have a dob. This makes BR3 uselss or I have to update one to have a dob. |
| 11:59 |
csharp_ |
@eightball is BR3 useless? |
| 11:59 |
pinesol |
csharp_: Yes! |
| 11:59 |
Dyrcona |
Ha! |
| 12:01 |
Dyrcona |
OK. User #18 from BM1 has transactions and a dob. I'll use that user. |
| 12:03 |
Dyrcona |
Awesome. 47 tests pass. |
| 12:06 |
Dyrcona |
tests++ |
| 12:07 |
|
jihpringle joined #evergreen |
| 12:32 |
|
Christineb joined #evergreen |
| 12:47 |
Dyrcona |
Tests pass when I add the new one to the live_t directory, so that's something. |
| 13:24 |
|
Lorne joined #evergreen |
| 13:27 |
Lorne |
HI, if I am trying to hide OPAC for all of the Organisation Units in Staff client > Administration > Server Administration, do I have to be logged into the top-level consortium for the changes to stick? Right now I have an admin logged into BR1, turned off all OPAC & restarted apache but OPAC still shows. |
| 13:27 |
Dyrcona |
If the user was logged in when the setting change was made, then they need to log out and log in to see the change. |
| 13:28 |
Lorne |
so if I log off the staff client, server/eg/opac/home will stop showing a page? |
| 13:29 |
Dyrcona |
If that's what the setting does, then yes. I don't know exactly what setting you're talking about or what it does, but generally if user Y changes a setting while user X is logged in, X will not see the change until their next login. |
| 13:30 |
Lorne |
I can see the OPAC toggle off in staff client but the OPAC page still shows. I am trying to turn off OPAC at Staff client > Administration > Server Administration > Organisation Units |
| 13:31 |
Lorne |
"OPAC Visible" toggle |
| 13:31 |
Dyrcona |
That tuns the org unit on/off in the OPAC, not the OPAC on/off for that unit. |
| 13:32 |
Lorne |
Oh, so it really means "visible to OPAC". Gotcha |
| 13:32 |
Dyrcona |
I don't think there is a way to turn the OPAC off for a unit. |
| 13:33 |
Lorne |
++ Dyrcona |
| 13:35 |
* Dyrcona |
grabs 1509\ |
| 13:51 |
|
Lorne joined #evergreen |
| 13:57 |
pinesol |
News from commits: LP#1861239: Stamp DB Upgrade <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f70aef27d4050f642dbbbe5a890c117d0cae5073> |
| 13:57 |
pinesol |
News from commits: LP#1861239: Add Perl live test for functionality <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d91ba5d4f411d3514909185401fe464da07d9fd7> |
| 13:57 |
pinesol |
News from commits: LP#1861239: Fix Thinko in base schema <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5dd2da323e561a109cd3af9c28ed41591672a3cd> |
| 13:57 |
pinesol |
News from commits: LP#1861239: Fix syntax error in 950.data.seed-values.sql <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bff28d142f911d92a7d02d9d6bceba49d856b6e7> |
| 13:57 |
pinesol |
News from commits: LP#1861239: Improve release note formatting <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=09b2c4448c998904fe260c7ac6f9d09179c145e8> |
| 13:57 |
pinesol |
News from commits: LP#1861239: Optionally drop post code or birth year in aged transactions <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b97416c2022f95bd6856a6123d2f870d0610a58d> |
| 14:58 |
Dyrcona |
typos-- |
| 15:06 |
Dyrcona |
Firmware update for the laptop. Why not install it, now? |
| 15:19 |
|
Dyrcona joined #evergreen |
| 16:11 |
|
Lorne joined #evergreen |
| 16:38 |
|
jihpringle joined #evergreen |
| 17:14 |
|
mmorgan left #evergreen |
| 17:28 |
pinesol |
News from commits: Docs: Updates to permissions docs <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=afc3341c2800cb76b8f122898476fc5acca2d8f2> |
| 17:49 |
|
jihpringle joined #evergreen |
| 17:50 |
|
Lorne joined #evergreen |
