| Time |
Nick |
Message |
| 06:56 |
|
collum joined #evergreen |
| 08:32 |
|
mmorgan joined #evergreen |
| 10:14 |
pinesol |
News from commits: LP#2131687 Holdings editor radio button UI syncs across fields <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ab25d16a5eb3cade543756341c8639cb947b88e3> |
| 10:28 |
|
kmlussier joined #evergreen |
| 10:29 |
kmlussier |
Good morning #evergreen! |
| 10:29 |
kmlussier |
@coffee [someone] |
| 10:29 |
* pinesol |
brews and pours a cup of Kenya AA Nyeri Tatu, and sends it sliding down the bar to jeff |
| 10:29 |
kmlussier |
@tea [someone] |
| 10:29 |
* pinesol |
brews and pours a pot of Wild Snow Sprout Tea, and sends it sliding down the bar to collum (http://ratetea.com/tea/wild-tea-qi/wild-snow-sprout-tea/6447/) |
| 10:31 |
berick |
@coffee kmlussier |
| 10:31 |
* pinesol |
brews and pours a cup of Bonsai Blend Espresso, and sends it sliding down the bar to kmlussier |
| 10:45 |
* mmorgan |
doesn't remember ever seeing pinesol serve up Wild Snow Sprout Tea or Bonsai Blend Espresso before! |
| 10:53 |
|
sandbergja joined #evergreen |
| 10:55 |
|
Dyrcona joined #evergreen |
| 10:58 |
kmlussier |
Ooh, Espresso! Thanks berick! |
| 11:06 |
|
Christineb joined #evergreen |
| 11:19 |
Dyrcona |
gmcharlt++ For Lp 2132541 |
| 11:19 |
pinesol |
Launchpad bug 2132541 in Evergreen "Added content handler for cover images from ChiliFresh" [Wishlist,Confirmed] https://launchpad.net/bugs/2132541 - Assigned to Jason Stephenson (jstephenson) |
| 11:20 |
Dyrcona |
@tea |
| 11:20 |
* pinesol |
brews and pours a pot of Wild Snow Sprout Tea, and sends it sliding down the bar to Dyrcona (http://ratetea.com/tea/wild-tea-qi/wild-snow-sprout-tea/6447/) |
| 11:22 |
Dyrcona |
That sounds interesting, but I don't usually drink green tea. |
| 11:23 |
kmlussier |
gmcharlt++ Dyrcona++ We'll be starting our free trial of Chilifresh next week! |
| 11:28 |
|
jihpringle joined #evergreen |
| 11:28 |
Dyrcona |
kmlussier: I've just reviewed the diff and I like what I see so far. I'm going to apply to my dev server and give it a whirl before lunch. |
| 11:44 |
Dyrcona |
gmcharlt: Am I supposed to put our account id or something in the chilifresh_generic field? The comment isn't very clear about that. |
| 11:48 |
* Dyrcona |
tries with it empty. |
| 11:49 |
gmcharlt |
Dyrcona: yeah, empty is a valid value |
| 11:51 |
gmcharlt |
the one case I know of where the generic parameter gets set is a case where ChiliFresh is explicitly supplying a fallback image |
| 11:51 |
gmcharlt |
*gets set with a visible effect |
| 11:51 |
Dyrcona |
OK. |
| 11:52 |
Dyrcona |
That what it says, but "to identify the site to Chilifresh for other purposes" made me think I should put some kind of id or API key in the field. |
| 11:53 |
gmcharlt |
yeah, that bit was some last minute speculation |
| 11:54 |
Dyrcona |
Well, here goes, I'm ready to put the module in place and flip the switches. I assume restart settings service and Apache is all that's needed. |
| 11:54 |
gmcharlt |
I do have a question out to them about how they refer to the "generic" parameter when they speak with their customers; hopefully that will lead to some clarificaiton |
| 11:54 |
gmcharlt |
confirmed, you shouldn't need more than that |
| 12:03 |
Dyrcona |
Meh. I'm still getting 404 from the Evergreen cover images. |
| 12:03 |
Dyrcona |
It worked two weeks ago with Content Cafe, so I'm not sure what's wrong locally. |
| 12:07 |
Dyrcona |
Wait a minute... This looks like the old code is still running. I probably need to clear my browser cache or something. |
| 12:11 |
Dyrcona |
Maybe it's the eg_template_cache? But, I can't find that because of how Ubuntu messes with /tmp. |
| 12:12 |
Dyrcona |
Ah, found it. <sarcasm> Thanks, systemd!</sarcasm> |
| 12:15 |
Dyrcona |
Oh, wait. I probably need to comment out the old Chilifresh variables in eg_vhost.conf, then wipe out the template cache, and then restart Apache. |
| 12:15 |
gmcharlt |
shouldn't matter - the Chilifresh stuff in eg_vhost.conf doesn't affect cover images, it's purely for their other added content that is brought in via Javascript |
| 12:20 |
Dyrcona |
Oh, now you tell me. :) |
| 12:20 |
Dyrcona |
I thought that was for covers, too. |
| 12:20 |
Dyrcona |
Anyway, I'm still getting 404 on these URLs: https://dev.cwmars.org/opac/extras/ac/jacket/large/r/2325403 |
| 12:21 |
Dyrcona |
The permissions are good. I've checked that 6 times since yesterday, including twice today. |
| 12:22 |
gmcharlt |
I'll spin it up on my dev system; one moment |
| 12:23 |
Dyrcona |
Oh. I notice that the ratings under entries have disappeared since I removed the old Chilifresh code... |
| 12:29 |
Dyrcona |
I wonder if something isn't set up on the Chilifresh side, but I filled everything in AFAIK. |
| 12:29 |
* Dyrcona |
breaks for a bite to eat. |
| 12:30 |
gmcharlt |
one thing you can try is a curl of https://content.chilifresh.com/?isbn=1419811053,012569675247,(OCOLC)000000059284201&size=M from that dev box to see if it's returning the image |
| 12:30 |
gmcharlt |
otherwise, it's all working for me with that record's IDs the MARC |
| 12:31 |
gmcharlt |
also, just realized that there's a stray warn that should removed before the patch gets merged, but it can help for debugging: look for "fetch ChiliFresh URL" in the Apache error log |
| 12:32 |
gmcharlt |
OH |
| 12:32 |
gmcharlt |
missing from the instructions: set the added content base_url to https://content.chilifresh.com/ |
| 12:35 |
gmcharlt |
force-pushed to the working branch to remove the extra warn and to clarify that base_url needs to be set |
| 12:45 |
Dyrcona |
OK. I base_url is likely the problem. I was able to get cover images with cURL when I tried last week. |
| 12:46 |
Dyrcona |
A force push makes trying the changes more difficult since I've already cherry-picked in the branch I'm testing. I'll just set base_url and see what happens. |
| 12:50 |
Dyrcona |
gmcharlt++ That was it. I set base_url and it works! |
| 13:01 |
csharp_ |
Dyrcona: whoooo |
| 13:01 |
csharp_ |
gmcharlt++ |
| 13:04 |
Dyrcona |
gmcharlt: I'm going to signoff on your commit and add another. I think opensrf.xml could stand to have the module and base_url settings added in the list, so that setup is as simple as uncommenting two lines. |
| 13:05 |
gmcharlt |
Dyrcona: sounds good, thanks! |
| 13:05 |
gmcharlt |
Dyrcona:++ |
| 13:16 |
Dyrcona |
Huh. Our opensrf.xml has a commented out list of module and base_url settings for the added content modules, but the one from main doesn't. |
| 13:18 |
Dyrcona |
That might be useful, so I guess I'll add that list rather than what I thought I was going to do: just adding Chilifresh. |
| 14:17 |
|
sandbergja joined #evergreen |
| 14:22 |
sandbergja |
Would anyone be able to review bug 1741162? I'd like to remove more dojo from the OPAC, but without a review on this, I don't have any feedback on if this is a good approach, and am feeling frustrated that such work might just sit forever without a review (especially since the originally posted branch sat for 7 years without review) |
| 14:22 |
pinesol |
Launchpad bug 1741162 in Evergreen "Remove Dojo from added content JavaScript" [Undecided,New] https://launchpad.net/bugs/1741162 |
| 14:23 |
sandbergja |
(also probably feeling a little salty that some of the work on that will be wasted due to bug 2132549, but that's above all of our paygrades :-) ) |
| 14:23 |
pinesol |
Launchpad bug 2132549 in Evergreen "Remove ContentCafe added content handler" [Medium,Confirmed] https://launchpad.net/bugs/2132549 |
| 14:25 |
gmcharlt |
sandbergja: I'm sure for a mere $50 million, you could keep ContentCafe and B&T going! ;) |
| 14:25 |
sandbergja |
heh |
| 14:31 |
gmcharlt |
sandbergja: more to your point, yes, I can; please remind me after next week if you don't hear that I've reviewed it |
| 14:32 |
sandbergja |
gmcharlt++ # thanks -- I very much appreciate it! |
| 17:11 |
|
mmorgan left #evergreen |
| 17:41 |
|
kmlussier left #evergreen |
