| Time |
Nick |
Message |
| 01:08 |
|
smayo joined #evergreen |
| 08:46 |
|
mmorgan joined #evergreen |
| 09:04 |
|
Dyrcona joined #evergreen |
| 09:20 |
|
smayo joined #evergreen |
| 09:25 |
Dyrcona |
berick: Do we really need Perl-compatible regexes for the barcode check in oils_auth.c? |
| 09:27 |
Dyrcona |
The PCRE2 interface is more complicated than that of PCRE. |
| 09:41 |
berick |
Dyrcona: heh, you tell me. my 2006 goggles are on the fritz |
| 09:56 |
Dyrcona |
:) |
| 09:56 |
Dyrcona |
I'm trying it with PCRE2. |
| 10:01 |
Dyrcona |
Looking at it, the interface isn't more complicated, it's just different. |
| 10:21 |
Dyrcona |
Oof... I dropped my change for checking libdbi with my latest change on the test vm. |
| 10:24 |
Dyrcona |
Yay! Configure works. |
| 10:37 |
Dyrcona |
Wow! More changes. |
| 10:39 |
|
sandbergja joined #evergreen |
| 10:40 |
Dyrcona |
So, I might open another bug, or maybe just lump all this into the trixie bug. |
| 10:41 |
Dyrcona |
Interestingly, two of the bugs aren't really caused by gcc 14.2. They were bugs anyway, but just didn't bite us yet. |
| 11:30 |
|
Christineb joined #evergreen |
| 11:30 |
Dyrcona |
double the typos. double the fun. |
| 11:34 |
Dyrcona |
Errors when --load-all-sample is used on trixie with Pg 17. |
| 11:37 |
Dyrcona |
Ok. I can't login with a patron barcode. Have to find out why. |
| 11:44 |
Dyrcona |
No useful error messages of course. |
| 11:45 |
Dyrcona |
OK. I can apparently login as staff with a username, so it's the barcode regex changes that broke, as I suspected. |
| 11:46 |
|
sandbergja joined #evergreen |
| 11:48 |
pinesol |
News from commits: LP2116126: Update patron name display in note dialog component to prioritize preferre... <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f5d25aa1665efd4333e6215544c068c8959d0074> |
| 12:03 |
Dyrcona |
OK. The pcre2_match is working. it returns 1, so a patron should be able to login with a barcode. |
| 12:03 |
Dyrcona |
Does anyone know of any issues with main and logging in? |
| 12:04 |
Dyrcona |
I wonder if the db errors prevented passwords from being set, but I did successfully login as admin via srfsh. |
| 12:06 |
Dyrcona |
Passwords are there..... |
| 12:07 |
Dyrcona |
Grr. Why does it always seem to be a problem with something that I didn't change. |
| 12:12 |
Dyrcona |
Yeah, just LOGIN_FAILED. Nothing useful. |
| 12:27 |
Dyrcona |
OK. Some mumbo jumbo about the info on the concerto logins page not working. When I changed a patron's password to something that I know what it is, it worked. |
| 12:46 |
|
collum joined #evergreen |
| 14:04 |
Dyrcona |
We should stop supporting installation on Debian 10 "Buster." It is EOL since June of 2024. |
| 14:24 |
Dyrcona |
Tests are failing on Debian trixie. |
| 14:32 |
Dyrcona |
I think I might add a follow up on the pcre2 commit to log the error from pcre2_match. We can log it, so why not? |
| 14:32 |
|
sandbergja joined #evergreen |
| 14:40 |
Dyrcona |
Ugh.... I love it when all I do is reload the database and restart services and the failing tests all suddenly pass. |
| 14:41 |
Dyrcona |
Who knew that mucking with 1 user's password would break so much? |
| 14:57 |
Dyrcona |
I love how tests just seem to randomly fail. |
| 15:16 |
sandbergja |
it would be much nicer if our perl live tests that require a very specific database state could be responsible for setting up that state themselves. Rather than just hoping for the best. |
| 15:19 |
sandbergja |
it's a bit annoying that for some tests, you can't run them twice in a row; you have to reload the database before each run. Makes it pretty time consuming to see if your changes broke anything haha |
| 16:04 |
Dyrcona |
Well, it's also annoying when 1 fails on a clean database; you reload it; it passes; reload again; it fails. |
| 16:06 |
Dyrcona |
I think I had a bunch of test failures on my first run because I had the wrong branch checked out when I built the database. |
| 16:07 |
Dyrcona |
After that the tests passed 2 out of 3 tries. |
| 16:11 |
Dyrcona |
I am testing the trixie branch on jammy. |
| 16:34 |
Dyrcona |
Yeah, first time running the perl live tests after a database reload and a bunch of them fail. I bet after a second reload, they all work. |
| 16:34 |
Dyrcona |
Well, 2 of them failed: cover uploader and remote patron api. I did do autogen.sh -u, so maybe my apache config is broken? |
| 16:34 |
Dyrcona |
Everything has to be "just so." |
| 16:35 |
Dyrcona |
Huh.. nginx not running. |
| 16:39 |
Dyrcona |
hrm.. Apache was still trying to use port 80.... Guess I didn't restart it properly.... |
| 16:39 |
Dyrcona |
Too many moving pieces. |
| 16:41 |
Dyrcona |
Everything has to be done in the correct order. |
| 16:44 |
Dyrcona |
Yeah, now the Perl live test all pass. The pgtap and static perl tests already passed. |
| 16:46 |
Dyrcona |
That's enough for today. |
| 17:02 |
|
JBoyer joined #evergreen |
| 17:06 |
|
mmorgan left #evergreen |
| 18:47 |
|
JBoyer_ joined #evergreen |
