| Time |
Nick |
Message |
| 02:31 |
|
smayo joined #evergreen |
| 06:52 |
|
smayo joined #evergreen |
| 06:54 |
|
collum joined #evergreen |
| 08:47 |
|
mmorgan joined #evergreen |
| 09:01 |
|
Dyrcona joined #evergreen |
| 09:44 |
Dyrcona |
Ugh... I did something in Chrome that magnified my Google Doc way out of proportion, and I can't figure out how to undo it. The Chrome Zoom says it is at 100% and so is the Zoom in the doc. |
| 09:44 |
Dyrcona |
Closing the tab and reopening the doc fixed it. |
| 09:45 |
Dyrcona |
I think my my palm was on the touchpad while I was trying to scroll and resized the tab view. I'm surprised the browser Zoom was unaffected. Maybe it's a Gnome thing? |
| 09:55 |
|
redavis joined #evergreen |
| 10:01 |
|
mmorgan1 joined #evergreen |
| 10:24 |
Dyrcona |
Hm... SIP reports a successful login, but below that the Evergreen login failed for the sip user. |
| 10:27 |
Dyrcona |
Of course, I would pick an account that doesn't exist in the database but is there in the configuration. |
| 10:28 |
Dyrcona |
SIP filters are not working for me. I wonder if I set it up wrong? |
| 10:28 |
|
stompro joined #evergreen |
| 10:33 |
Dyrcona |
I added the filters in the implementation_config of the institution as shown in the example. I restarted SIPServer, but it's not redacting the field. |
| 10:33 |
Dyrcona |
OK. Maybe my SIPServer is too old on this system. |
| 10:34 |
Dyrcona |
Bingo. |
| 10:42 |
Dyrcona |
I was missing the one commit that I was trying to test. :) |
| 10:43 |
Dyrcona |
That also means this virtual machine is older than I thought. |
| 10:51 |
|
sandbergja joined #evergreen |
| 10:53 |
sandbergja |
eeevil: your fix for bug 2125510 has some ng lint issues, could you please fix them (see https://github.com/evergreen-library-system/Evergreen/actions/runs/18142067027/job/51635123330)? Thank you! |
| 10:53 |
pinesol |
Launchpad bug 2125510 in Evergreen "TOTP Authentication Needs a Text Version" [Wishlist,Fix committed] https://launchpad.net/bugs/2125510 |
| 11:03 |
eeevil |
sandbergja: if you can tell me how to turn off all that for those files, sure. I do not want type matching in the html, I do not want const in the ts, and 3 is from the spec. (I'll add a semicolon if it's even marginally semantically useful, though) |
| 11:04 |
eeevil |
(I have never seen any documentation nor a written style guide for lint, btw. If it's there, that's cool. but ... I've never run across it) |
| 11:04 |
eeevil |
(and I strongly disagree with some of the "error" conditions, fwiw) |
| 11:06 |
sandbergja |
all the basic rules are documented here: https://eslint.org/docs/latest/rules/ |
| 11:06 |
sandbergja |
feel free to make a pr to the configuration if you think other rules would serve the project better |
| 11:07 |
|
Christineb joined #evergreen |
| 11:07 |
sandbergja |
<!-- eslint-disable --> at the top of a template file if you just want to opt out completely |
| 11:08 |
sandbergja |
irc won't let me send the ts version hahaha |
| 11:08 |
sandbergja |
but you can search for eslint-disable |
| 11:09 |
sandbergja |
why do you dislike const by the way? |
| 11:11 |
eeevil |
const is ... ok. it's eqeqeq that's egregious |
| 11:12 |
eeevil |
but const isn't helpful here, nor true. we /will/ be modifying the object behind that variable |
| 11:20 |
eeevil |
wow... you can't actually search for disable declarations, only get a small scrolling dropdown. how fun. |
| 11:20 |
sandbergja |
...but that's not what const means. it means that we won't be reassigning the variable |
| 11:21 |
eeevil |
but we WILL be |
| 11:21 |
eeevil |
(or, we certainly CAN) |
| 11:21 |
sandbergja |
then why not use let? |
| 11:36 |
eeevil |
but ... why use let instead of var? anyway, there doesn't seem to be a way to lint specific files, so I'm just https://xkcd.com/303/ |
| 11:42 |
redavis |
wherein we all decide what's really best is to go find a renaissance fair(re) and never return. |
| 11:52 |
Dyrcona |
redavis++ |
| 12:21 |
eeevil |
redavis: indeed |
| 12:23 |
redavis |
Unrelated. Apparently, I am about to have a new job. mighta shed a wee tear. |
| 12:27 |
* Dyrcona |
has a sad.... |
| 12:27 |
redavis |
You do? |
| 12:30 |
Dyrcona |
redavis: You'll be missed. |
| 12:31 |
redavis |
Aww <3, but I'm going to try to hang around a little. I'm a little too invested in EG to go too quietly into that good night (of youth services). |
| 12:32 |
redavis |
But, also, thank you. A lot. |
| 12:33 |
Dyrcona |
Thank you! redavis++ |
| 12:34 |
redavis |
I haven't received a formal offer yet, but have heard from most of my references and am now being asked to fill out employment eligibility forms. |
| 12:37 |
* eeevil |
loves complicating code to make the linter happy! |
| 12:37 |
eeevil |
redavis: oh, you don' think we'll let you just ... LEAVE ... do you?! ;) |
| 12:38 |
redavis |
I think you would, yes. I will not go, however. Not completely. ;) |
| 12:38 |
eeevil |
heh |
| 12:38 |
Dyrcona |
:) |
| 12:39 |
redavis |
Still fingers crossed for the conference. My hotel reservation is made to keep it front of mind. |
| 12:44 |
pinesol |
News from commits: eslint <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d2774e0006fb9dea3180ac81580a9ed7671e0147> |
| 13:09 |
sandbergja |
redavis++ |
| 13:10 |
sandbergja |
congratulations!! it will be nice to keep seeing you around |
| 13:12 |
redavis |
Thank you! and also, thank you ;-). No formal offer yet. I might have forgotten that I'm a criminial or something. It could all evaporate into the mist, but the odds are getting slimmer and slimmer of that happening. |
| 13:25 |
* Dyrcona |
signs our for a bit. |
| 13:29 |
* redavis |
is also gonna head out. |
| 15:48 |
|
Dyrcona joined #evergreen |
| 15:52 |
Dyrcona |
Exception: OpenSRF::DomainObject::oilsMethodException 2025-10-01T15:51:02 OpenSRF::AppRequest /usr/local/share/perl/5.34.0/OpenSRF/AppSession.pm:1171 <500> *** Call to [open-ils.vandelay.bib_queue.create] failed for session [1759348262.87266443642.749363926], thread trace [1]: |
| 15:52 |
Dyrcona |
Can't use an undefined value as an ARRAY reference at /usr/local/share/perl/5.34.0/OpenILS/Application/Vandelay.pm line 136. |
| 15:52 |
Dyrcona |
We really should check that there is a value, and it an array reference before trying to dereference it. |
| 15:53 |
Dyrcona |
Line 136: if ($e->search_vandelay_bib_queue( {name => $name, owner => $owner, queue_type => $type})->[0]) |
| 16:05 |
Dyrcona |
Did anyone test the background import manager? |
| 16:08 |
csharp_ |
Dyrcona: we're using the background import manager - haven't heard of problems lately |
| 16:09 |
csharp_ |
(3.14.3-ish) |
| 16:12 |
csharp_ |
looking at nvm with an eye on how we're installing nodejs: https://github.com/nvm-sh/nvm |
| 16:12 |
csharp_ |
was looking for a sane way to not have to hard code the version number in our Makefile.install |
| 16:12 |
csharp_ |
with nvm, you should be able to "nvm install --lts" and get the latest nodejs LTS version |
| 16:13 |
csharp_ |
kinda dumb that you have to leverage another program to do that :-/ |
| 16:15 |
csharp_ |
also looking at adding variables for Makefile.install to be able to "make --pg_version=17 postgres_server_ubuntu_jammy" or whatever |
| 16:16 |
csharp_ |
or even just make --pg_version=17 postgres_server and have the Makefile get the OS for you |
| 16:16 |
Dyrcona |
csharp_: I'm getting errors from the background importer on 3.15.4 where the issues are assumptions in the Perl code. Also this is Perl 5.34. |
| 16:16 |
csharp_ |
so. many. rabbit holes |
| 16:16 |
csharp_ |
Dyrcona: yeah, we're on Ubuntu 22.04/Perl 5.34.0 too |
| 16:16 |
Dyrcona |
csharp_: We should probably revisit our build system sometime and do a total overhaul/refactor. |
| 16:17 |
csharp_ |
ALL THE (hack-a-way) TOPICS! |
| 16:18 |
Dyrcona |
Hmm. Maybe it is working now, but the latest Perl thing was: Can't call method "isa" on unblessed reference at /openils/bin/background_import_mgr.pl line 182. |
| 16:18 |
csharp_ |
the more I look at our build process, the more I want to change things - I guess it's like my house |
| 16:19 |
csharp_ |
hmmm |
| 16:19 |
Dyrcona |
Which looks like it would have happened if the call to create a queue returned an error instead of a new queue. |
| 16:20 |
Dyrcona |
csharp_: I think we can fix the build process without throwing it all away if we decide to stick with autotools. We could go with a different build system/process. |
| 16:23 |
Dyrcona |
Yeah, it's failing to create the queue: [2025-10-01 16:22:02] open-ils.vandelay [ERR :1706027:EX.pm:66:175935012117060475] Exception: OpenSRF::DomainObject::oilsMethodException 2025-10-01T16:22:02 OpenSRF::Utils::Logger /usr/local/share/perl/5.34.0/OpenSRF/Utils/Logger.pm:243 <500> INSERT error -- please see the error log for more details |
| 16:23 |
Dyrcona |
I doubt the Pg error log will be helpful because I'm not sure Pg is logging the errors. |
| 16:24 |
Dyrcona |
Whaddaya know. Something useful: 2025-10-01 16:24:02.958 EDT [1705087] evergreen evergreen ERROR: invalid input value for enum vandelay.bib_queue_queue_type: "authority" at character 151 |
| 16:26 |
csharp_ |
yeah, that sounded familiar somehow |
| 16:26 |
Dyrcona |
I think the staff can manually enter the queue type, right? |
| 16:26 |
Dyrcona |
That's what it looks like from the erro. |
| 16:26 |
Dyrcona |
error. |
| 16:27 |
Dyrcona |
<rhetorical>How do I examine a SQL type in PostgreSQL?</rhetorical> |
| 16:27 |
csharp_ |
\dT+ |
| 16:27 |
Dyrcona |
csharp_++ I was just about to paste that, myself. :) |
| 16:28 |
csharp_ |
hah |
| 16:28 |
Dyrcona |
Apparently we're missing the type? |
| 16:29 |
csharp_ |
TIL about ENUM |
| 16:30 |
Dyrcona |
And apparently, ENUMs down't show up as types..... |
| 16:31 |
csharp_ |
Dyrcona: looks like it's an authority queue trying to be a bib queue? |
| 16:31 |
Dyrcona |
Oh.. Helps to spell the type correctly: "queue" is in there twice. |
| 16:31 |
csharp_ |
because there's also vandelay.authority_queue_queue_type |
| 16:31 |
csharp_ |
and "authority" is the only value |
| 16:31 |
Dyrcona |
Yeah... ENUMS ..... |
| 16:32 |
Dyrcona |
This looks like potential user error. |
| 16:32 |
csharp_ |
@blame that user |
| 16:32 |
pinesol |
csharp_: that user is why we can never have nice things! |
| 16:32 |
Dyrcona |
pinesol: True dat! |
| 16:32 |
pinesol |
Dyrcona: Have you tried throwing it across the room? |
| 16:32 |
csharp_ |
might want something in the UI that enforces the required values though |
| 16:33 |
Dyrcona |
Not sure it would fix the problem, but it might make me feel better. |
| 16:33 |
Dyrcona |
Yeah, the UI should not allow nonsense. |
| 16:33 |
Dyrcona |
But, then, I guess nothing would get in the database, would it? :P |
| 16:33 |
csharp_ |
less work for admins, less confusing to the user: win/win |
| 16:34 |
csharp_ |
Dyrcona++ |
| 16:34 |
* csharp_ |
can't hear win/win without thinking about The Office where Michael adds a third "win" for himself when he's able to resolve the conflict |
| 16:36 |
Dyrcona |
I'm going to report these errors on Launchpad. |
| 16:36 |
Dyrcona |
The Perl errors that is. |
| 16:36 |
Dyrcona |
I have patches, but I'll wait until tomorrow to add them. |
| 16:43 |
Dyrcona |
Lp 2126602 |
| 16:43 |
pinesol |
Launchpad bug 2126602 in Evergreen "Perl errors from background vandelay import" [Undecided,New] https://launchpad.net/bugs/2126602 |
| 16:46 |
Dyrcona |
Rust would solve some of these issues because it would not compile code like that. |
| 16:50 |
Dyrcona |
I think there's a bug somewhere. I like the info for the one that's failing with enum error, and it says it's an authority import. |
| 16:50 |
Dyrcona |
s/like/look at/ |
| 17:13 |
Bmagic |
Dyrcona++ |
| 18:14 |
pinesol |
News from commits: LP2023794 Validation for required dates in fm-editor <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d9f57ffad8908f0860a73c2a0af06a931e75b5ef> |
| 18:43 |
|
stompro_home joined #evergreen |
| 19:48 |
|
gmcharlt joined #evergreen |
| 19:48 |
|
eeevil joined #evergreen |
| 20:12 |
|
stompro joined #evergreen |
| 22:52 |
|
smayo joined #evergreen |
