| Time |
Nick |
Message |
| 00:55 |
|
book` joined #evergreen |
| 00:55 |
|
smayo joined #evergreen |
| 08:24 |
|
jmurray-isl joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 08:41 |
|
sandbergja joined #evergreen |
| 08:58 |
|
Dyrcona joined #evergreen |
| 09:40 |
eeevil |
smayo: re the eg-tree followup branch, is that meant as an implicit signoff on the first two commits? if so, I'll add you signoff to the commits and merge |
| 10:22 |
pinesol |
News from commits: LP2045911: Remove Account from EDI FTP Login <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c3051aeced16d6561bfa498cfbfcc3a70693bb49> |
| 10:22 |
pinesol |
News from commits: LP#1729889 Mark deprecated passwd field as virtual <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=061e6d071f24f9a5e443502021692c9d9cc9111e> |
| 10:38 |
Dyrcona |
OK. I think I have a solution for Lp 2125430 : I'm going to add a new function to purge the auditor tables and run it after purge_data and the last update in actor.usr_delete. |
| 10:38 |
pinesol |
Launchpad bug 2125430 in Evergreen 3.15 "Personally Identifiable Information and Other Unpurged Data Left After a User is Deleted" [Undecided,Confirmed] https://launchpad.net/bugs/2125430 |
| 10:52 |
|
Christineb joined #evergreen |
| 10:53 |
pinesol |
News from commits: LP2114839 Separate OPAC advanced search form rows <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=663a95fdb2466a963be184c879700ebad597fa0a> |
| 10:53 |
pinesol |
News from commits: LP#2109382: Angular Reporter right join support <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=eff9dfd1eed7f32e1fc10f6fcb31fbbe42442b84> |
| 11:00 |
|
sandbergja joined #evergreen |
| 11:05 |
Dyrcona |
Hrm. I'm going to refactor some code out of actor.usr_purge_data into actor.usr_delete and that might mess up some existing scripts that people have. I'll write a bigger release note including that information. We could also do a different version of this for 3.14 and 3.15 that doesn't make that change. |
| 11:14 |
Dyrcona |
Grr. Can't change names of input parameters with create or replace function..... |
| 11:23 |
pinesol |
News from commits: LP#2113981: Handle blank notification info <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=65ac67e0b7371f5807573c458df6368c8eca6e08> |
| 11:25 |
eeevil |
jeffdavis: do you recall OTTOYH if you're still using https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=a4f2a629571a181360068272efd8cef3f44c5b65 ? ... it looks perfectly sane to me, doesn't blow up anything |
| 11:26 |
eeevil |
(if it's not clear, I'm currently on a mission to whack all the moles with old PRs) |
| 11:27 |
eeevil |
(and some with new-ish PRs) |
| 11:27 |
mmorgan |
eeevil++ |
| 11:28 |
sandbergja |
eeevil++ |
| 11:33 |
* eeevil |
idly wonders why action.hold_request_reset_reason_entry exists when action.unfulfilled_hold_list is right there, with the same structural purpose ... oh well |
| 11:35 |
Dyrcona |
Perhaps someone didn't know about one when the other was created, or didn't know what the one did? |
| 11:40 |
Dyrcona |
It sure is taking a long time to delete this staff account on my test database. |
| 11:40 |
Dyrcona |
Twenty-two minutes so far. |
| 11:45 |
eeevil |
Dyrcona: it's common for new features to reimplement existing wheels in EG, yes |
| 11:49 |
Dyrcona |
Twenty-nine minutes and 36 seconds to delete this staff account. They must have had a lot of data. |
| 12:33 |
jeffdavis |
eeevil: no, doesn't look like we're using it (which surprises me, I thought we were) |
| 12:35 |
eeevil |
jeffdavis: ah! thanks. one mole I can avoid whacking. I'll mark it as wontfix for now, but if it turns out you do need it, please revive it and I'll push your branch in |
| 12:37 |
jeffdavis |
eeevil++ |
| 12:39 |
Dyrcona |
eeevil++ |
| 12:40 |
Dyrcona |
Looks like my changes to actor.usr_delete and actor.usr_purge_data are working. |
| 12:47 |
eeevil |
grabbing 1486 |
| 12:53 |
pinesol |
News from commits: Stamping upgrade script <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=747da794c4a8dafa79e99aff96b2a94af0bb69f7> |
| 12:53 |
pinesol |
News from commits: LP2107581 (follow-up): adjust seed data, add a live test <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=cc2c28fcf1d0fc09671bceef0a192681c5c18999> |
| 12:53 |
pinesol |
News from commits: LP#2107581: Fix constraint on action.hold_request_reason_entry <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=68932c33507bee240d990822c12af25fcbb8e796> |
| 12:53 |
pinesol |
News from commits: LP#2099920: attempt to fix hold targeter failures and quiet the logs <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4c3717efc01bb220eff4964aa21908fd0fd31bfb> |
| 12:57 |
Dyrcona |
Thinks this could use a pgtap test. |
| 13:12 |
Dyrcona |
There is a purge user live test that does not need to be changed. |
| 14:24 |
Dyrcona |
I'm getting errors when doing --load-all-sampe with eg_db_conf on a 3.15.5 branch today. I don't feel like investigating right now, but it is probably worth looking into later |
| 14:30 |
Dyrcona |
OK. Looks like I have a test that hits the main points of PII. |
| 15:16 |
Dyrcona |
Should I include a data update beside the functions update to remove the data from the auditor.actor_usr_history and auditor.actor_usr_address_history tables or should I put that in the release note? |
| 15:19 |
jeffdavis |
I'd vote for a data update. |
| 15:19 |
JBoyer |
Since they could potentially run for a very long time and aren't actually related to the process of upgrading the database themselves, maybe the cleanup should be output via \qecho like the symspell sideload stuff is |
| 15:21 |
Dyrcona |
Well, they run pretty quick on my database with 286,025 and 164,024 rows affected. |
| 15:23 |
Dyrcona |
The \qecho idea is interesting. I could do that in addition to the release note entry. |
| 15:24 |
Dyrcona |
I usually remove those from my custom upgrades to avoid the output clutter, but someone could also remove the \qecho to run the deletes. |
| 15:24 |
Dyrcona |
I think there are only 2 that matter. |
| 15:25 |
Dyrcona |
We also purge our auditor tables periodically. Some sites may not do that. |
| 15:26 |
Dyrcona |
jeffdavis++ JBoyer++ I think I'll go with the \qecho suggestion. |
| 15:57 |
Dyrcona |
Hrm. I should probably add a more technical release note for sites that may have custom scripts using database functions.... |
| 15:57 |
Dyrcona |
I could possibly copy the commit message for most of it. |
| 15:58 |
Dyrcona |
Should that go under API or Administration? |
| 16:00 |
Dyrcona |
@decide api or administration |
| 16:00 |
pinesol |
Dyrcona: go with api |
| 16:00 |
Dyrcona |
What about architecture? Are these defined anywhere? |
| 16:07 |
Dyrcona |
Upgrade Notes looks like a better heading. |
| 16:08 |
Dyrcona |
How do things get added to upgrade notes? I assume it's a manual process. |
| 16:08 |
mmorgan |
Upgrade Notes sounds appropriate. Not sure how they get there, though! |
| 16:11 |
Dyrcona |
Looking at create_release_notes.sh, which is only run for big releases, it looks like upgrade notes is a manual process. The other sections get added by code. |
| 16:15 |
Dyrcona |
I think I'll add a block in the current release note that is title "For Upgrade Notes." |
| 16:20 |
Dyrcona |
Well, that works for me. I hope it works for whoever puts the release notes together. |
| 16:22 |
Dyrcona |
mmorgan++ |
| 16:54 |
Dyrcona |
Well, that's it for me. Have a great weekend everyone! |
| 17:05 |
|
mmorgan left #evergreen |
| 17:44 |
eeevil |
smayo: so, the lastClickedTree stuff did not get into rel_3_15, apparently. it was in 3.14 and main, though. it's in 3.15 now! |
| 17:49 |
eeevil |
(probably release branch timing issues? anyway, it's there) |
| 17:49 |
eeevil |
smayo++ |
| 17:54 |
pinesol |
News from commits: LP#2107891: eg-tree label and checkbox uniform behavior <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=264f91baf0c7a8a689f1c073ecd68314584d70be> |
| 17:54 |
pinesol |
News from commits: LP#2107891: Simplify Reporter's org tree logic <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a65a9b791e781850ed6f0ae8867cc17418f127d3> |
| 17:54 |
pinesol |
News from commits: LP#2107891: eg-tree range selection improvements <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2ca9fe26fef4d1652dad36ab3b55591c9617bd2b> |
