| Time |
Nick |
Message |
| 08:29 |
|
mmorgan joined #evergreen |
| 09:00 |
|
jvwoolf joined #evergreen |
| 09:05 |
|
jvwoolf joined #evergreen |
| 09:21 |
|
dguarrac joined #evergreen |
| 09:24 |
|
Dyrcona joined #evergreen |
| 09:55 |
|
redavis joined #evergreen |
| 10:22 |
eeevil |
jeffdavis: great catch on the "pkey IS NOT NULL" thing. thanks! |
| 10:38 |
|
mdriscoll joined #evergreen |
| 11:18 |
|
Christineb joined #evergreen |
| 11:33 |
|
jihpringle joined #evergreen |
| 11:41 |
sleary |
Bmagic I just cherry-picked all the 2106666 commits into a fresh branch on main and I don't see the conflict :( |
| 11:41 |
sleary |
I will be happy to help resolve it, I just can't get to where you are |
| 11:41 |
Bmagic |
dang |
| 11:41 |
Bmagic |
I triple checked, let me try on a different machine |
| 11:43 |
Bmagic |
confirmed again. Try this: git checkout rel_3_15; git fetch --all; git pull; git cherry-pick 74c3bb72a4; git cherry-pick 74f928bf4c; git cherry-pick ec62e38d69 |
| 11:43 |
Bmagic |
should fail on that last one |
| 11:43 |
sleary |
k |
| 11:46 |
Bmagic |
I should have given you more full-proof steps ensuring that you're definitely on vanilla 3.15. This should do it: git checkout -b testing_blake origin/rel_3_15 (followed by the cherry-picks) |
| 11:46 |
sleary |
OK, there we go, rel_3_15 is not main :) |
| 11:46 |
sleary |
rebase coming up |
| 11:46 |
Bmagic |
ty! |
| 11:46 |
Bmagic |
sleary++ |
| 11:48 |
sleary |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2106666-color-mode-with-windows7-support-rebase |
| 11:48 |
Bmagic |
holy smokes that was fast |
| 11:49 |
sleary |
I know these stylesheets too well :( |
| 12:10 |
phasefx |
Bmagic: abneiman: I wrote something simpler and more targeted than pg_diff, and nothing is actually missing. Counts for rows in each table are off by 1 with the test data; going to double-check that |
| 12:13 |
Bmagic |
sleary: maybe I should've just pushed to the real branches rather than making signoff branches |
| 12:17 |
Bmagic |
ok, it's on main now |
| 12:17 |
sleary |
Bmagic++ |
| 12:17 |
sleary |
thanks for testing that |
| 12:20 |
Bmagic |
no problem, I'm doing 3.14 and 3.15 too, and I'll post on LP in a minute |
| 12:22 |
abneiman |
Bmagic++ sleary++ |
| 12:28 |
Dyrcona |
Windows 7, really? |
| 12:30 |
sleary |
Dyrcona in some very small libraries, yes. |
| 12:31 |
sleary |
Unfortunately it was not a small usability issue; it was "the entire thing is unusable" |
| 12:31 |
Dyrcona |
Don't care... Won't fix. Upgrade to a supported O/S. |
| 12:32 |
pinesol |
News from commits: LP2106666 .btn-default should match .btn-normal <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f414172d5ad5a0fd2129158fc552be2fd0afc73f> |
| 12:32 |
pinesol |
News from commits: LP2106666 Remove hard-coded colors in AngularJS <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2ed81b1ed10beaa44077889d46d4dcca488e2073> |
| 12:32 |
pinesol |
News from commits: LP2106666 AngularJS component stylesheet changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0f39c3ff4c957b030eb20ce1229fd9bcd7983d0f> |
| 12:32 |
pinesol |
News from commits: LP2106666 Split light and dark files for AngularJS <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b62ef1c9ed9ed439a0d0a51070f24dbabbc3a81e> |
| 12:32 |
pinesol |
News from commits: LP2106666 Angular component stylesheet changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=93883ea355f0a886bdca49548372984668238a1f> |
| 12:32 |
pinesol |
News from commits: LP2106666 Split light and dark files; assets/css move <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ed0c20c522ab9a2d1e4ef78eabd2eb03c654c474> |
| 12:32 |
pinesol |
News from commits: LP2106666 Windows7 support for light/dark mode <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a6cb1bfe53482036ab7741ab7235be2629f8c4df> |
| 12:32 |
Dyrcona |
That's my pedantic side.... Fix it anyway. |
| 12:32 |
Dyrcona |
And, there it is... :) |
| 12:33 |
sleary |
I tend to agree, but also acknowledge that the current funding situation is going to make that harder for people who were already in such dire straits that they are still on Windows 7. |
| 12:33 |
sleary |
It is a developer experience downgrade in favor of an essential user experience win, so we'll deal. |
| 12:34 |
Dyrcona |
Sure. Not really worth the discussion. |
| 12:34 |
Dyrcona |
sleary++ |
| 12:34 |
mmorgan |
sleary++ |
| 12:38 |
|
jihpringle joined #evergreen |
| 12:40 |
|
smayo joined #evergreen |
| 12:42 |
jeffdavis |
sleary++ |
| 12:45 |
phasefx |
Bmagic: abneiman: and my off-by-1 rows came from the database snapshot capturing some of my testing. I think we're good! |
| 12:45 |
abneiman |
@phasefx++ |
| 12:45 |
pinesol |
abneiman: git diff origin/hamster |
| 12:46 |
abneiman |
phasefx++ |
| 12:46 |
phasefx |
slack has ruined us |
| 12:46 |
abneiman |
indeed :sob: |
| 12:46 |
jeffdavis |
pinesol is kinda saucy about it |
| 12:46 |
pinesol |
jeffdavis: excuse me while I start planning my escape to a non-extradition nation |
| 12:47 |
abneiman |
honestly, pinesol, same girl |
| 12:47 |
* jeffdavis |
omits jokes about politics |
| 12:47 |
Bmagic |
phasefx++ |
| 12:47 |
phasefx |
abneiman: Bmagic: I celebrated too soon. email.login.issuer and email.login.digits exist in an upgraded db but not a pristine one |
| 12:47 |
* abneiman |
has no such restraint |
| 12:47 |
abneiman |
phasefx: s'ok there's still time to work stuff out |
| 12:48 |
phasefx |
I'm going to redo the snapshot, make sure I rule out changes introduced from testing |
| 12:48 |
Bmagic |
what you're doing is pretty close to the logic that make_concerto_from_evergreen_db.pl does |
| 12:48 |
phasefx |
but there are definitely things off |
| 12:49 |
phasefx |
circ.void_overdue_on_longoverdue in a pristine db, but not in an upgraded one |
| 12:49 |
Bmagic |
do you run this type of test for each release? And this one is giving different results from previous releases? |
| 12:51 |
phasefx |
who me? no, I haven't been doing this previously, though I played with the idea a long time ago |
| 13:02 |
|
Dyrcona joined #evergreen |
| 13:05 |
csharp_ |
@dunno add user opensr does not exist |
| 13:05 |
pinesol |
csharp_: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 13:06 |
csharp_ |
@dunno add user opensr does not exist |
| 13:06 |
pinesol |
csharp_: The operation succeeded. Dunno #96 added. |
| 13:06 |
csharp_ |
pinesol: also, I don't know you either |
| 13:06 |
pinesol |
csharp_: https://i.imgur.com/m8EySrW.gifv |
| 13:10 |
phasefx |
Bmagic: abneiman: okay, it's not horrible, but there are a few things. I have to leave for the day, but if no one beats me to it, I can fix things over the weekend: https://controlc.com/d6ddd0fb |
| 13:11 |
abneiman |
phasefx++ |
| 14:01 |
Dyrcona |
@who knows too much about action triggers |
| 14:01 |
pinesol |
Rogan knows too much about action triggers. |
| 14:39 |
abneiman |
probably true, tbh |
| 14:46 |
Dyrcona |
:) |
| 14:47 |
Dyrcona |
I know more about it than I did yesterday, mostly by trying things on a test system and seeing what happens. |
| 15:37 |
Dyrcona |
I picked the wrong day to test of a change in a script... |
| 15:37 |
Dyrcona |
19,756 events and rising. |
| 17:11 |
|
jvwoolf1 joined #evergreen |
| 17:11 |
|
mmorgan left #evergreen |
| 17:19 |
|
jvwoolf1 left #evergreen |
| 19:03 |
|
jihpringle joined #evergreen |
