| Time |
Nick |
Message |
| 07:25 |
|
redavis joined #evergreen |
| 08:03 |
|
cbrown joined #evergreen |
| 08:04 |
|
BDorsey joined #evergreen |
| 08:45 |
|
mmorgan joined #evergreen |
| 08:57 |
|
kworstell-isl joined #evergreen |
| 09:07 |
|
dguarrac joined #evergreen |
| 10:22 |
|
Dyrcona joined #evergreen |
| 11:13 |
|
Christineb joined #evergreen |
| 12:03 |
|
jihpringle joined #evergreen |
| 13:36 |
|
BDorsey joined #evergreen |
| 14:01 |
|
BDorsey joined #evergreen |
| 14:19 |
|
kworstell-isl joined #evergreen |
| 15:02 |
redavis |
Bmagic, yes. He's going to review and, if nothing breaks terribly, commit those. |
| 15:02 |
Bmagic |
redavis: continue here |
| 15:02 |
Bmagic |
haha |
| 15:02 |
Bmagic |
ok, sounds good. I'm off the hook this time |
| 15:03 |
pinesol |
News from commits: LP1980978: Improve SIP2 Patron Status Field <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=aaec02cde39ff6ff0922f334af3f68526ceb8685> |
| 15:03 |
redavis |
lol, speaking of! |
| 15:03 |
Bmagic |
IKR |
| 15:07 |
redavis |
Bmagic - added to https://wiki.evergreen-ils.org/doku.php?id=faqs:evergreen_roadmap:3.14#roadmap_for_evergreen_314 |
| 15:07 |
Bmagic |
yoda best |
| 15:08 |
redavis |
noice! thx :D |
| 15:08 |
Bmagic |
grogu best |
| 15:09 |
redavis |
lol, gonna get "lunch" and then update that roadmap page as it has PROGRESSED. |
| 15:43 |
Bmagic |
so, back to search. A quoted search for "salem witch trials" |
| 15:43 |
Bmagic |
https://evergreen.cfcc.edu/eg/opac/results?query=%22salem+witch+trials%22&qtype=title&fi%3Asearch_format=&locg=1 |
| 15:44 |
Bmagic |
compared to keyword: |
| 15:44 |
Bmagic |
https://evergreen.cfcc.edu/eg/opac/results?query=%22salem+witch+trials%22&qtype=keyword&fi%3Asearch_format=&locg=1&detail_record_view=0&sort= |
| 15:44 |
Bmagic |
the keyword search has zero results |
| 15:44 |
Bmagic |
WTF? Wouldn't the Keyword results be all of the Title resutls and then some? |
| 15:45 |
Bmagic |
the quote marks make all the difference |
| 15:58 |
Dyrcona |
Yeah, quotes matter. |
| 15:58 |
Bmagic |
right, but regardless of the quotes, do you see my point? |
| 15:58 |
Dyrcona |
Also, the trials were like a momentary social contagion, and some of the least interesting things to happen in Salem, MA. Did you know that they burned President Madison in effigy during the War of 1812? |
| 15:59 |
Bmagic |
lol, ok |
| 16:00 |
Dyrcona |
Well, I just was popping to complain about doing a database upgrade with permissions when we already have a different permission with the same ID. I'm not thinking about search, but yeah, it can get weird. |
| 16:01 |
Bmagic |
the two links are the same search, the only difference being keyword vs. title. And keyword results with zilch |
| 16:01 |
Dyrcona |
Yeah. Have you tried removing the quotes from the keyword search? |
| 16:01 |
Bmagic |
my comment about the quotes, is: it seems that the quotes are the bug |
| 16:02 |
Bmagic |
yep, removing the quotes for keyword makes it result with stuff |
| 16:03 |
Dyrcona |
I think the quotes turn it into a literal search, but keyword should include titles, so if titles come back with quotes, then logically they should come back with keyword. You should get at least the same number of results. Hey, but, I'm no expert. |
| 16:03 |
Bmagic |
And the other question I had last week is outstanding: search using "Starts with" (as opposed to "Contains) - is* yielding different results for staff compared to patron. Just wondering what the design idea was there. I'm starting to think that the "Starts with" feature is broken on the patron side |
| 16:04 |
Dyrcona |
eeevil or phasefx would know more about the original intent than I. |
| 16:04 |
Bmagic |
I think they are out today. Maybe I'll send it to the mailing list |
| 16:06 |
Dyrcona |
Ugh... forgot the new prerequisites.... |
| 16:06 |
Bmagic |
Dyrcona++ # I just ran into that myself |
| 16:06 |
Bmagic |
install postgres-server-ubuntu-jammy-10 |
| 16:07 |
Dyrcona |
MFA. Am I right? :) |
| 16:07 |
Bmagic |
seed data didn't install for me due to lack of Base64 module |
| 16:07 |
Dyrcona |
No, not that, the new prereqs for MFA. I think I also need to install them on the server. |
| 16:07 |
Dyrcona |
Well, the VM and the database server. |
| 16:08 |
Dyrcona |
Also, don't install Pg 10. It's dead. |
| 16:09 |
Dyrcona |
I'm missing MIME::Base 32. |
| 16:09 |
Bmagic |
Base 32, that's it |
| 16:09 |
Bmagic |
are you installing the bucket patch per chance :) |
| 16:09 |
Dyrcona |
Yeah, well. It's IRC. |
| 16:10 |
Dyrcona |
Well, that, but also MFA on this machine. It hasn't been updated since the 4th. |
| 16:10 |
Dyrcona |
So, everything new as well. |
| 16:10 |
Bmagic |
the other issue I'm having with the branch is the hard coded ID number for the permission.perm_list INSERTS |
| 16:11 |
Bmagic |
I increased them all by 2 and I'm still getting a conflict |
| 16:11 |
Dyrcona |
This will be a good chance to double check if the database reqs for MFA were actually split out. I tested it on a machine that has services and db on 1. |
| 16:11 |
Dyrcona |
Bmagic: delete the id column and the numbers. Let Pg decide. |
| 16:11 |
Bmagic |
yeah, I could do that, but the patch is calling it out for some reason |
| 16:12 |
Bmagic |
I didn't want to deviate the patch to far from OG |
| 16:12 |
Bmagic |
probably for the oils_i18n_gettext |
| 16:12 |
Dyrcona |
We should never reference permissions by id in code. We should always use 'code' column. |
| 16:12 |
Bmagic |
for sure |
| 16:12 |
Dyrcona |
Oh, well, that, yeah.... |
| 16:13 |
* Dyrcona |
mumbles about doing translations in the database.... |
| 16:13 |
Dyrcona |
I'm not worried about that right now. I just want the system to "work." |
| 16:16 |
Dyrcona |
Looks like I need Pass::OTP also. |
| 16:19 |
Dyrcona |
The MFA db update is going to be interesting the 3.14 db upgrade since the alter type has to come before the transaction for the rest of MFA. I know we've had to move somethings outside of the main transaction before, but they usually end up at the bottom because you can't alter a table with pending updates. |
| 16:21 |
Dyrcona |
Bmagic: You could select max(id) from permission.perm_list, and start with that ID in your local upgrade. Just be sure to set the sequence value at the end. |
| 16:21 |
Dyrcona |
Or, that id + 1. |
| 16:22 |
Bmagic |
I'm installing concerto from scratch. Not upgrading existing |
| 16:23 |
Dyrcona |
So, a db upgrade conflicts with concerto data? That's just wrong. What was the permission id again? |
| 16:23 |
Bmagic |
657 |
| 16:24 |
Bmagic |
I edited it so that the patch starts at 659 |
| 16:24 |
Bmagic |
and moved all the rest of the ID's up by 2 |
| 16:24 |
Dyrcona |
Huh.. I think that's the one that conflict for me. |
| 16:24 |
Dyrcona |
conflicts.... |
| 16:25 |
Bmagic |
in your case, you'd be running the XXXX upgrade script |
| 16:25 |
Bmagic |
which has the ID's hardcoded too? |
| 16:25 |
Bmagic |
just checked, yes. YYYY script |
| 16:25 |
Dyrcona |
In my case, I'm running 1433..... I ran the XXXX on a pg 3.13 database. |
| 16:26 |
Dyrcona |
Do you have TRANSFER_CONTAINER as the 657 permission in your database? |
| 16:26 |
Dyrcona |
Hey, no. I bet you don't..... |
| 16:27 |
Bmagic |
( 657, 'REMOVE_USER_MFA', oils_i18n_gettext(657, |
| 16:27 |
Dyrcona |
All right. My problem is that I ran the upgrades out of order. |
| 16:28 |
Bmagic |
did MFA get merged into main? |
| 16:28 |
Dyrcona |
Yeah, I did it on Wed Sep 11. |
| 16:29 |
Dyrcona |
So, the IDs in the Angular record buckets scripts need changed. |
| 16:29 |
Bmagic |
that patch soaked up ID 657 |
| 16:29 |
Bmagic |
yep :) |
| 16:30 |
Dyrcona |
Bmagic++ |
| 16:31 |
Bmagic |
I believe all of the numbers need bumped by 2 |
| 16:31 |
Dyrcona |
I'll take care of that while I'm working on testing it. Looks like I won't get to push it today, but the deadline is tomorrow.... |
| 16:31 |
Bmagic |
plenty of time :) |
| 16:31 |
Bmagic |
also: there is a small issue with the numbers on the first INSERT in 950 seed data. The ID number column doesn't agree with the i18 ID number |
| 16:32 |
Dyrcona |
Ok, I'll check that. Think I'll reload my test database. I think I have a dump after I updated it on 9/4. |
| 16:33 |
Bmagic |
Dyrcona++ |
| 16:33 |
Dyrcona |
No, but I have a dump from 9/1, so close enough. I just need to make a custom db upgrade from a different branch. |
| 16:34 |
Dyrcona |
I'll make a new branch to test it while I'm at it. |
| 16:34 |
Bmagic |
love me some branch |
| 16:34 |
Dyrcona |
might as well eliminate the junk I added while groping with this issue. |
| 16:35 |
Bmagic |
database? delete. filesystem? delete. OS? delete. interact with the CPU directly. The only way to eliminate errors |
| 16:36 |
Dyrcona |
toggle switches on the front of the machine and no display..... |
| 16:36 |
Dyrcona |
Or, just touch the exposed leads with hot wires... |
| 16:36 |
Bmagic |
That's the real turing test |
| 16:37 |
Bmagic |
We've been doing it wrong all along. |
| 16:38 |
Dyrcona |
This will be a better dry run for building the beta next week, anyway. The database that I'm loading is closer to 3.13.4. |
| 16:38 |
Dyrcona |
Mechanical computers are where it's at. |
| 16:39 |
Bmagic |
You already switch all the switches? Dang you're fast |
| 16:41 |
Dyrcona |
42! |
| 16:41 |
Bmagic |
Sam Rockwell rocks |
| 16:45 |
Dyrcona |
I haven't seen that one, just the old BBC version, and read the book. |
| 16:45 |
Dyrcona |
books... |
| 16:45 |
Dyrcona |
I'll have to check that one out. |
| 16:46 |
Dyrcona |
I always imagined Trillian not looking like Zooey Deschanel..... |
| 16:48 |
Dyrcona |
All right. Time to cherry-pick into my new test branch. It's main with our custom templates....There is a conflict in the AngularJS splash page, 'cause we have moved things around. |
| 16:48 |
Dyrcona |
I'm going to practice adding someone else's sign off in a batch as well as my own. |
| 16:53 |
Dyrcona |
Not too bad. Use '-e' to run the editor, add the Signed-off-by:, copy, then paste for every other commit. |
| 16:59 |
redavis |
Dyrcona++ |
| 17:00 |
Dyrcona |
Well, look at that. It's time to go.... |
| 17:01 |
Dyrcona |
Catch y'all tomorrow! |
| 17:01 |
mmorgan |
Bmagic: FWIW keyword search in our opac returns results with or without quotes. 240 hits with, 330 hits without. |
| 17:02 |
Bmagic |
mmorgan: with quotes, title results vs. keyword results is what I'm after |
| 17:03 |
Bmagic |
I tried yours, it seems to be working |
| 17:04 |
mmorgan |
Bmagic: Yep, with quotes: title results 110, keyword results 240 |
| 17:04 |
Bmagic |
or at least, the number of keyword results is higher than title with the quoted string |
| 17:08 |
* mmorgan |
needs to run. Back tomorrow! |
| 17:08 |
|
mmorgan left #evergreen |
