| Time |
Nick |
Message |
| 00:12 |
|
abneiman joined #evergreen |
| 07:32 |
|
kworstell-isl joined #evergreen |
| 08:02 |
|
BDorsey joined #evergreen |
| 08:11 |
|
collum joined #evergreen |
| 08:23 |
|
Dyrcona joined #evergreen |
| 08:31 |
|
ian1 joined #evergreen |
| 08:32 |
|
cbrown joined #evergreen |
| 08:37 |
|
dguarrac joined #evergreen |
| 08:42 |
|
redavis joined #evergreen |
| 08:45 |
|
mmorgan joined #evergreen |
| 09:50 |
eeevil |
berick: your au.id-as-user-identifier makes sense ... I'm trying to remember if there's some security-based reason we don't already support that, and I can't. are you thinking it'll just be a new peer to the username and barcode .init and .login param objects, and/or just try it as a third type if passed via the identifier key? |
| 09:52 |
eeevil |
(and a peer method to .init.barcode, too, I guess?) |
| 10:13 |
ian1 |
I just created my first working branch and I want to connect it to a launchpad bug and open it up to review. Whats the standard practice for this? Or where are the docs? lol |
| 10:18 |
mmorgan |
ian1: The new developers working group page has links to some good getting started documentation: https://wiki.evergreen-ils.org/doku.php?id=newdevs:start |
| 10:18 |
mmorgan |
Here's a page linked from there on pushing your branch and updating Launchpad: https://wiki.evergreen-ils.org/doku.php?id=newdevs:git:create |
| 10:18 |
Dyrcona |
ian1: Many of us create the Lp bug first, then we can stick the bug # in the branch name and commit messages. |
| 10:24 |
ian1 |
I did that part. Here is the branch name: user/ianskelskey/lp2075362_duplicate_aria_title |
| 10:24 |
ian1 |
And the bug lives here: https://bugs.launchpad.net/evergreen/+bug/2075362 |
| 10:24 |
pinesol |
Launchpad bug 2075362 in Evergreen "Buttons and links with duplicate aria-label and title attributes are read twice by screenreaders" [Undecided,New] - Assigned to Ian Skelskey (iskelskey) |
| 10:26 |
Dyrcona |
Ok. cool. So, you add a comment on the bug with your branch name and any other comments you want to make, like "here's a branch that fixes the issue". It's useful to add the gitweb link, too, for those of us who are lazy and want to look at that code without pulling it/checking it out: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ianskelskey/lp2075362_duplicate_aria_title |
| 10:27 |
Dyrcona |
You can add the pullrequest tag if you think it is ready to go. |
| 10:29 |
Dyrcona |
One suggestion is we generally like a bit more information in the commit message. |
| 10:30 |
ian1 |
Makes sense to me. The good news is that I just followed the suggested solution from the bug description verbatim so at least its documented somehow. |
| 10:31 |
ian1 |
How do I add a pullrequest tag? |
| 10:32 |
mmorgan |
ian1: Just below the bug description are the Tags, Should be an edit button. Add pullrequest to existing tags, if any, then click the green check to save. |
| 10:33 |
Dyrcona |
Do you see an exclamation mark in a yellow circle next to the Tags on the bug? If not, are you logged in to Launchpad? |
| 10:33 |
* mmorgan |
has been known to miss the "save" part :) |
| 10:36 |
Dyrcona |
Is there official documentation or a wiki page about the Release-Note: tag in a commit message? I swear I've seen something but I can't find it now. |
| 10:39 |
Dyrcona |
OK. Found what I'm looking for on the dev:git page. |
| 10:40 |
Dyrcona |
Now, to write a Pgtap regression test. |
| 10:52 |
ian1 |
Sorry. Stepped away for a bit. I dont see the edit button or the exclamation marks but I am logged into launchpad |
| 11:00 |
|
mmorgan1 joined #evergreen |
| 11:07 |
|
ian1 joined #evergreen |
| 11:28 |
|
Christineb joined #evergreen |
| 11:55 |
|
kworstell_isl joined #evergreen |
| 12:00 |
berick |
eeevil: thanks for reviewing. i was thinking specifically of the single-call "open-ils.auth.login" version, but adding support for the .init version can be done as well. |
| 12:00 |
berick |
for open-ils.auth.login, I think it will need a new parameter. i don't see a way to leverage the existing "identifier" param, unfortunately |
| 12:01 |
|
jihpringle joined #evergreen |
| 12:06 |
eeevil |
I agree a new, say, "usrid" property in the arg hash would be most explicit ... and, I can get behind the idea of "don't try to guess whether it's a usrid in the identifier property", too. not that there will likely be overlap with barcodes, but there's not much of a use case to support the logic complication -- nobody's likely to make a web form that says "just type any of the three" |
| 12:07 |
berick |
yeah, exactly |
| 12:07 |
eeevil |
(I think having an .init.usrid a la .init.barcode and .init.username would be good/simple, though) |
| 12:09 |
* berick |
nods |
| 13:06 |
|
ian1 joined #evergreen |
| 14:00 |
|
ian1 joined #evergreen |
| 15:04 |
|
ian1 joined #evergreen |
| 17:31 |
|
mmorgan left #evergreen |
