| Time |
Nick |
Message |
| 01:01 |
|
rlefaive joined #evergreen |
| 01:55 |
|
yammyham joined #evergreen |
| 04:19 |
|
rlefaive joined #evergreen |
| 07:50 |
|
collum joined #evergreen |
| 08:20 |
|
cbrown-isl joined #evergreen |
| 09:28 |
|
kworstell-isl joined #evergreen |
| 09:31 |
|
sleary joined #evergreen |
| 10:33 |
pinesol |
News from commits: LP2060316 Printer setting warning colors and icons <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=544a9d817bbbbd051776d32fe320a75369fc702a> |
| 10:33 |
pinesol |
News from commits: LP2065326 Use "search" input type in staff catalog <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5e150d5f310da28675d6feecac21a08c2819108d> |
| 10:33 |
pinesol |
News from commits: LP2059046 Active tab color should match background <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c5313c0233737d98a69a8345c742b4a782809a0f> |
| 11:05 |
eeevil |
so, ISTM that different linting runs may be producing different results? this is concerning to me :( |
| 11:09 |
eeevil |
for instance, Bmagic added a lint commit to his acq signoff branch. I squashed that into the main code commit, because lint fixes (to me, and I'd be easily swayed on this) are basically just coding style changes -- space/tab normalization, indentation levels, brace requirements, const'ing of variables, etc -- and except for some things like == vs === (which, btw, I think we should /not/ force and instead trust the human) should /never/ change the |
| 11:09 |
eeevil |
behavior |
| 11:10 |
eeevil |
the effects of Bmagic's commit are /definitely/ inside the squashed acq commit. so, that commit should not have been able to introduce more linting issues! but apparently it has? |
| 11:11 |
eeevil |
the only reason I can image that being the case is that the lint rules are different in different dev's environments |
| 11:12 |
eeevil |
*imagine, not image |
| 11:12 |
eeevil |
now, admittedly, I do not have a great imagination when it comes to the linting infrastructure we've put in place. anyone have other theories? |
| 11:20 |
berick |
i could imagine local variations in node_modules having an effect |
| 11:22 |
berick |
the lint rules are committed, so i would not expect those to vary, except for maybe un-rebased branches |
| 11:25 |
berick |
on the topic of linting, I'm fully in favor of development-time linting, but applying batch lint repairs after the fact to tick a box is making me twitchy. |
| 11:26 |
berick |
kind of defeats the purpose |
| 11:26 |
berick |
(well, for some of the rules) |
| 11:30 |
berick |
imma send a dev email |
| 11:35 |
Bmagic |
I'll admit that I trusted the lint tool to do the right thing, I've seen others use it. I was comfortable committing it's changes because I've been in enough screen sharing sessions to feel confident that "ng lint --fix" is "fine". I was weary at first, again, repetition made me feel better. |
| 11:36 |
Bmagic |
It's another magic thing like "Evergreen/build/i18n/scripts/update_pofiles -l translation-export -e Evergreen" that touches a lot* of files |
| 11:37 |
berick |
Bmagic: did you run 'ng lint' again after running 'ng lint --fix' ? it doesn't fix everythying |
| 11:37 |
Bmagic |
no! Shoot! Maybe that's the issue? |
| 11:37 |
berick |
yes that would explain eeevil's question |
| 11:38 |
berick |
lint --fix just does mostly cosmetic stuff |
| 11:38 |
Bmagic |
dang, well, I guess I learned the lesson the hard way |
| 11:39 |
Bmagic |
so it would seem, ng lint is needed (on main) and that takes care of it? |
| 11:39 |
berick |
yeah, main is all jacked up now re: linting ;) |
| 11:40 |
Bmagic |
is it as simple as "ng lint" && git commit? |
| 11:40 |
berick |
oh, no |
| 11:40 |
berick |
they have to be manually repaired |
| 11:40 |
sleary |
no, it requires attention to each of the errors |
| 11:41 |
Bmagic |
how the heck! |
| 11:41 |
sleary |
you *can* add eslint-ignore comments to the relevant sections if you want to kick the can down the road, but we will have to find those and deal with them eventually |
| 11:42 |
Bmagic |
so "--fix" edited the code in such a way that it breaks our own lint? |
| 11:42 |
sleary |
no |
| 11:42 |
berick |
Bmagic: --fix fixed a certain percentage of the errors |
| 11:43 |
sleary |
--fix is step one, ng lint + manual correction is step two |
| 11:44 |
Bmagic |
ok, so, the errors pre-dates me, and the misunderstanding was that eeevil thought I manually linted the errors away? When really, I just ran --fix. I wasn't aware of any manual process I was suppose to undergo! |
| 11:47 |
berick |
Bmagic: sounds likely, yes |
| 11:49 |
Bmagic |
I just rant ng lint, 250 problems (248 errors, 2 warnings), I'd love to lint a hand, lol. I would like to learn how I can help with this process if anyone wants to hold my hand |
| 11:51 |
berick |
Bmagic: i think a lot of this stuff will require the original coder or someone very fimiliar w/ the code to fix. each (non-cosmetic) error could impact the functionality of the code. |
| 11:52 |
Bmagic |
I see, yes, that's a problem |
| 11:53 |
Bmagic |
in that case, I wasn't* suppose to manually fix stuff, but rather bring it to someone's attention? |
| 12:03 |
berick |
Bmagic: ideally, coding and linting happen at the same time and it's a non-issue, but since we have a backlog of code that's crashing against our new lint rules, we're all just doing what we can :) |
| 12:04 |
|
jihpringle joined #evergreen |
| 12:05 |
Bmagic |
I feel responsible :( - but I think I'm understanding that I shouldn't |
| 12:34 |
|
JBoyer joined #evergreen |
| 12:35 |
berick |
Bmagic: nah, don't worry about it, we're in uncharted terriroty |
| 13:15 |
berick |
Bmagic: i'm about to share a working branch with lints disabled for origin/main if you wanna review / merge |
| 13:15 |
berick |
well, affected files in main |
| 13:22 |
sleary |
berick++ |
| 13:25 |
berick |
also on mail list: working/user/berick/eg-3.13-partial-eslint-disable |
| 13:31 |
sleary |
I can probably fix the Libary and Location groups errors after lunch. |
| 13:34 |
berick |
merged. thanks sleary |
| 13:35 |
Bmagic |
berick++ |
| 13:36 |
Bmagic |
I added another 50 ng lint results on that spreadsheet because I was curious |
| 14:04 |
pinesol |
News from commits: Apply nglint-disable to affected files <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6ae13d1ff0c71506f5ef3ff0c5d11e065bb84a63> |
| 14:10 |
|
redavis joined #evergreen |
| 14:12 |
|
Christineb joined #evergreen |
| 14:43 |
eeevil |
berick++ |
| 15:00 |
berick |
grabbing 0411 |
| 15:01 |
berick |
heh, i mean 1411 |
| 15:04 |
pinesol |
News from commits: LP1920247 i18n for Back and Next buttons in browse <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=673a2979cd3ad277492db4e7fc7f4492ca6f7fc9> |
| 15:32 |
eeevil |
berick++ |
| 15:34 |
pinesol |
News from commits: LP2043418 i18n for "Receive on Scan" in Acquisitions <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=102c791d7875642bb46e4852e665ba1daafc15e4> |
| 15:34 |
pinesol |
News from commits: LP1993823 Angular Reports stamping DB upgrade <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=acfd0b8a2fa59c25ba33d4d7b3097773048298d3> |
| 15:34 |
pinesol |
News from commits: LP1993823 Propogate upgrade seed data to 950 seed file <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a1d0436509b138529230ab6722b62bf3bd737458> |
| 15:34 |
pinesol |
News from commits: LP1993823 Disable linting for newly affected files <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ea65caecf0dfb4dfb579c318922373754bcda494> |
| 15:34 |
pinesol |
News from commits: LP1993823 Angular compile error fix <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4816011fec48995f32d44c80b21128731cb3cf5f> |
| 15:34 |
pinesol |
News from commits: LP1993823 Silence some harmless console errors <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=eb9d25607898835d4d71299888439e97f49fe5f1> |
| 15:34 |
pinesol |
News from commits: LP1993823 Fix paired report + schedule creation issue <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=20d4b7b019b58bb6580d7e3976cdd3d5a5a3340b> |
| 15:34 |
pinesol |
News from commits: LP1993823 Angular reports ng lint --fix <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bd61f91fea380a58f8c0c4b457354d2355dbfd5b> |
| 15:34 |
pinesol |
News from commits: LP#1993823: Add Angular Reporter release note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=abb4a6d209dd211525e8256efc65d782ef334282> |
| 15:34 |
pinesol |
News from commits: LP#1993823: Reporter configuration <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0271260d46003602e5cd816aee32b5077de5fcd3> |
| 15:34 |
pinesol |
News from commits: LP#1993823: Full Reporter - Angular port <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c3fca79d7a4bca29875222ee115ab4892cfdc4dd> |
| 15:34 |
pinesol |
News from commits: LP#1993823: Infrastrucure polishing for Reports <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bcc140561d96794cccfe23c4e46e4ad9b161e9df> |
| 15:34 |
pinesol |
News from commits: LP#1993823: Reports infrastructure: eg-tree rewrite <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=accc9ca1e1ba8e3bf2abae36d9b650d684a655d1> |
| 15:34 |
pinesol |
News from commits: LP#1993823: Reports ifrastructure: Grid A11Y <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5cb319c4e51389df35143bc0a37baca324e224e0> |
| 15:39 |
sleary |
berick++ eeevil++ |
| 16:05 |
|
BAMkubasa joined #evergreen |
| 16:08 |
BAMkubasa |
Anyone able to point me to a license for Evergreen? I searched the web and documentation and found licensing for the documentation and links to copyleft and mentions of GNU GPL, but wasn't sure if there's a specific place Evergreen's licensing is laid out. |
| 16:15 |
jeffdavis |
BAMkubasa: The license (GPLv2) is included directly in the Evergreen source code in a file called LICENSE.txt: https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=LICENSE.txt;hb=HEAD |
| 16:16 |
BAMkubasa |
jeffdavisThanks! |
| 16:34 |
pinesol |
News from commits: LP#2055089: stamp DB update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ad573632d14921c7f9e02fde313824d7e076b395> |
| 16:34 |
pinesol |
News from commits: LP2055089 Add missing shipment notification permissions <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=497eed50f5f50c0dcdcc0e21895410ec930a0f3b> |
| 16:34 |
pinesol |
News from commits: LP#1901930: stamp DB update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7f3a629f38b2d82d8d70a865e80559c16eebdf9d> |
| 16:34 |
pinesol |
News from commits: LP1901930 SIP Mediator Bootstrap 5 layout repairs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bccad7fb38a17874848fe417e9e7cb2d8bccf659> |
| 16:34 |
pinesol |
News from commits: LP1901930 Seed data SQL syntax repairs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=63ba050d138d8336877c5c03547d856084fd8f5d> |
| 16:34 |
pinesol |
News from commits: LP1901930 SIP Mediator Account Migration Script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=98b006c1fb1c54fa7da0c75eab68e8008e0a6454> |
| 16:34 |
pinesol |
News from commits: LP1901930 Move SIP Filters Into open-ils.sip. <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=62fef298654641c58454c3345f145afa85a4401f> |
| 16:34 |
pinesol |
News from commits: LP1901930 More hold type; seed data repairs, etc. <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8a6245a35ec601e36c16101eabf0dc1fac0efaf0> |
| 16:34 |
pinesol |
News from commits: LP1901930 Support renewal on checkout SIP operation <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8971a2dacf5f8229444422a3cd12ada771de536f> |
| 16:34 |
pinesol |
News from commits: LP1901930 Fixes SIP checkin current location evaulation <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4527ae6181c8e9e7e8ef2a851e6d9669fa0c17ba> |
| 16:34 |
pinesol |
News from commits: LP1901930 Forces SIP mediator log XID, docs, and tidying <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=dee3cecb1c824e023847d74743c48cd77b77eebd> |
| 16:34 |
pinesol |
News from commits: LP1901930 SIP2Mediator ng lint-ifying <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a709b226fc35022c033b799ad1360ae51dd3f970> |
| 16:34 |
pinesol |
News from commits: LP1901930 SIP2Mediator merge cleanup <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6e241e8805b0003e04f454f7aced8fce3d84cec0> |
| 16:34 |
pinesol |
News from commits: LP1901930 filter UI; love it <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8abceb984067d49dbdf43f056fc3425f7107a15b> |
| 16:35 |
pinesol |
News from commits: LP1901930 filter configs backend <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c75cfd5c945291eb90c85ccda5782d39547c6b36> |
| 16:35 |
pinesol |
News from commits: LP1901930 toward filters <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e569c51c3cc06f1e35f1e5a0fa751d4f6ea2b78d> |
| 16:35 |
pinesol |
News from commits: LP1901930 Add some missing SIP fields; repairs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6bb11980239104a799b4b75bef33a6e48b581729> |
| 16:35 |
pinesol |
News from commits: LP1901930 block card message option; refactoring <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1ce5f5ddfb3d0efd7fbe7e3f60ca65acf6479238> |
| 16:35 |
pinesol |
News from commits: LP1901930 Add some missing SIP fields <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ee4e9ab36516ee0904b593cb71cd2c89159fd7c6> |
| 16:35 |
pinesol |
News from commits: LP1901930 Support optional ACS Resend messages <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c169d0e20899d69762fbe3d2fab28962e6bf0fa3> |
| 16:54 |
Bmagic |
berick++ #reports!!!!!!!!! |
| 17:04 |
pinesol |
News from commits: LP#2037564: Selfcheck cover art without ISBNS not shown <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2ae5bc4a42f540342ce8e9571ca00a0fe70121a4> |
| 17:04 |
pinesol |
News from commits: LP#2062023: stamp DB update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2099e01cc234abda5da1d6a80ad4c39a90698c96> |
| 17:04 |
pinesol |
News from commits: LP#2062023 PATRON_BARRED.override permission missing in seed data <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=578f02a5fe10c16b5eeb2f45f2e5be5cdca6a415> |
| 17:04 |
pinesol |
News from commits: LP2060153: Store remote file for EDI message sent via SFTP <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=388e4da72991ea866690cd55dfaced522489d3e8> |
| 17:20 |
|
rlefaive joined #evergreen |
| 23:07 |
Bmagic |
gmcharlt_++ |
