| Time |
Nick |
Message |
| 00:12 |
|
phasefx joined #evergreen |
| 00:53 |
|
akilsdonk joined #evergreen |
| 08:12 |
|
BDorsey joined #evergreen |
| 08:26 |
|
redavis joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 09:00 |
|
Dyrcona joined #evergreen |
| 09:08 |
|
dguarrac joined #evergreen |
| 09:39 |
* Dyrcona |
fires up 5 4GB VMs on a machine with 16GB of RAM... :) |
| 09:40 |
Dyrcona |
"Pg16" sounds like a movie rating, not the name of a virtual machine. |
| 09:44 |
Dyrcona |
git: "Please tell me who you are." |
| 09:48 |
csharp_ |
Dyrcona++ |
| 09:51 |
Dyrcona |
git fetch --all shows some interesting things to test later. |
| 10:17 |
Dyrcona |
live_t/37-carousels.t (Wstat: 65280 Tests: 2 Failed: 1) |
| 10:24 |
Dyrcona |
huh. This time it worked.... |
| 10:30 |
berick |
conf deadline... i'd be happy to talk about redis, but I think people would rather hear from someone else at this point. |
| 10:30 |
berick |
maybe a short on some rust stuff i'm doing |
| 10:31 |
* Dyrcona |
has put Rust on the back burner while doing stuff with PHP to emulate Aspen. |
| 10:33 |
Dyrcona |
Also, I'm working on Lp 1835953, and I think I need to modify some Angular code..... I'll possibly have questions. |
| 10:33 |
pinesol |
Launchpad bug 1835953 in Evergreen "Circulation auto renewal remaining should not be nullable" [Medium,In progress] https://launchpad.net/bugs/1835953 - Assigned to Jason Stephenson (jstephenson) |
| 10:34 |
Dyrcona |
When adding a circ duration rule, I want to default the max renewals and max auto renewals to 0 instead of empty. |
| 10:36 |
Dyrcona |
Is that interface generated on the fly or something? |
| 10:38 |
Dyrcona |
Oh! found it: BasicAdminPageComponent |
| 10:39 |
Dyrcona |
Maybe I'll have to add a new route or something? |
| 10:40 |
Dyrcona |
I hope I don't have to do much more than that..... |
| 10:46 |
Dyrcona |
Looks like I can't do that, but I don't know yet how fieldOptions is used, if at all. |
| 10:48 |
Dyrcona |
Looks like it's used by src/app/share/fm-editor/fm-editor.component.ts |
| 10:52 |
* Dyrcona |
wonders what happens if I set fieldOptions min.... |
| 10:58 |
Dyrcona |
Maybe isRequired: true would be better? |
| 10:59 |
|
sandbergja joined #evergreen |
| 11:00 |
jeff |
Hrm. Yeah, looks like the conference proposal deadline is "end of day" today. |
| 11:02 |
* Dyrcona |
should bug mantis1 about the upgrade panel for the conference that she was setting up. |
| 11:03 |
* Dyrcona |
gives fieldOptions: {max_renewals:{min:0},max_auto_renewals:{min:0}} a shot. |
| 11:03 |
* Dyrcona |
is moderately disturbed by the lack of quoting. |
| 11:08 |
dluch |
I have a Course Reserves question--how do folks handle setting up circ policies for a library that has course reserves of different lengths (1-day, library use only, 2-hour, etc.)? Different Shelving Locations? |
| 11:09 |
Dyrcona |
What's the proper syntx: ng build --watch ? |
| 11:09 |
berick |
Dyrcona: that's the one |
| 11:10 |
Dyrcona |
berick++ |
| 11:10 |
Dyrcona |
I have a syntax error. I forgot a comma.... |
| 11:13 |
Dyrcona |
ugh. Delete word includes apostrophes/single quotes...... more syntax errors. |
| 11:20 |
Dyrcona |
Well. min didn't make a difference unless I need to clear cache. |
| 11:21 |
Dyrcona |
Huh. That still lets me go below 0. |
| 11:23 |
sandbergja |
dluch: at my previous library, we just had separate circmods (called TwoHours, ThreeDays, OneWeek, NonCirc, etc.) |
| 11:24 |
sandbergja |
all the reserves were shelved together, with spine labels indicating how long they checked out for, so shelving location wouldn't have worked |
| 11:24 |
dluch |
sandbergja++ Thank you! |
| 11:29 |
Dyrcona |
The fieldOptions don't seem to make a difference... |
| 11:38 |
|
Dyrcona left #evergreen |
| 11:39 |
|
Dyrcona joined #evergreen |
| 11:39 |
Dyrcona |
@blame My fat fingers |
| 11:39 |
pinesol |
Dyrcona: Dyrcona's fat fingers - what a bunch a bastards! |
| 11:39 |
Dyrcona |
@band add The Fat Finger Trio |
| 11:39 |
pinesol |
Dyrcona: Band 'The Fat Finger Trio' added to list |
| 11:41 |
Dyrcona |
So, I've added field options to a rote for config.rule_circ_duration but it doesn't seem to be doing anything. I can set values lower than min and even null in the editor. If I save it with null values, it says it failed to create the rule, but I'm not warned that max_renewals and max_auto_renewals are required. |
| 11:42 |
Dyrcona |
s/rote/route/ |
| 11:42 |
|
Christineb joined #evergreen |
| 11:47 |
Dyrcona |
Specifically, I added this patch: https://pastebin.com/ep7BT3Mv |
| 11:54 |
Dyrcona |
Is this interface supposed to fail silently? |
| 11:54 |
Dyrcona |
I mean, other than just saying the entry failed to be created? |
| 11:56 |
* Dyrcona |
mucks wtih fieldOrder to see if that works. |
| 12:00 |
Dyrcona |
Nope. |
| 12:02 |
sandbergja |
Dyrcona: are max_renewals and max_auto_renewals marked as required in the IDL? It should pick up the required status from there, and prevent the user from saving the form without the required fields filled out |
| 12:03 |
Dyrcona |
sandbergja: I'll update the IDL, too, but I'm trying a full ng build becasue maybe my --watch wasn't set up just right. |
| 12:03 |
sandbergja |
sounds good |
| 12:06 |
Dyrcona |
It seeme to be working now after a full install and a "Clear cache and hard reload" |
| 12:06 |
sandbergja |
woohoo! |
| 12:06 |
Dyrcona |
I was clearing the cache before. |
| 12:08 |
Dyrcona |
The min doesn't work. I can still go below 0. |
| 12:09 |
Dyrcona |
I think I'll try updating the IDL and removing the angualr changes after lunch. If just updating the IDL works, then I may just leave it at that. |
| 12:09 |
sandbergja |
I really like the "Disable cache" checkbox on the devtools network tab when doing angular client dev, fwiw |
| 12:09 |
|
jihpringle joined #evergreen |
| 12:09 |
Dyrcona |
I messed up a link for the --watch, I think. |
| 12:22 |
|
jihpringle joined #evergreen |
| 12:23 |
|
mantis1 joined #evergreen |
| 12:27 |
Dyrcona |
sandbergja++ |
| 12:28 |
Dyrcona |
I went ahead and backed out my Angular change and updated the IDL. Making the fields required in the IDL works. |
| 12:30 |
Dyrcona |
i wonder if I should make that change for circ and aged circ as well? |
| 12:30 |
Dyrcona |
I suspect we have a lot of required fields that aren't labeled as such in the IDL. |
| 12:39 |
Dyrcona |
yeahp, we do. :) |
| 13:31 |
* Dyrcona |
wonders what else he should look at for Lp 1835953 |
| 13:31 |
pinesol |
Launchpad bug 1835953 in Evergreen "Circulation auto renewal remaining should not be nullable" [Medium,In progress] https://launchpad.net/bugs/1835953 - Assigned to Jason Stephenson (jstephenson) |
| 13:33 |
Bmagic |
what prevents staff from creating a new staff account with Global Administrator permissions? |
| 13:34 |
Dyrcona |
I don't know. What? |
| 13:34 |
Dyrcona |
:) |
| 13:34 |
Bmagic |
lol, knock knock |
| 13:36 |
* Dyrcona |
logs in as brm1townsend to see if anythying does. |
| 13:37 |
Dyrcona |
Except... how do I make a new account? |
| 13:37 |
Dyrcona |
D'oh! Register patron. |
| 13:39 |
Dyrcona |
Bmagic: When registering a patron/account, it comes down to the group perms that the user doing the registration has. you can only assign a profile for a group that you're allowed to. |
| 13:40 |
Bmagic |
and that's governed by server administration -> permission groups -> choose one -> "Application Permission: " |
| 13:40 |
Bmagic |
example: "group_application.user.staff.admin.global_admin" |
| 13:41 |
Bmagic |
(that was a question) |
| 13:41 |
Dyrcona |
I don't mess with permissions in the client usually. Only the db, but basically yes. |
| 13:42 |
Dyrcona |
As a circulator in concerto, I'm not able to edit the permissions of a patron that I just created. |
| 13:43 |
Bmagic |
this stuff: "group_application.user.staff.admin.global_admin" has never made sense to me. I just take it as "that's the way Evergreen wants it" - but grepping the code, I'm not seeing where it's referenced other than the seed data. |
| 13:44 |
Dyrcona |
Bmagic: it might also depend on your local permission setup. |
| 13:44 |
Bmagic |
we're using basically vanilla in this example |
| 13:47 |
Dyrcona |
I'm pretty sure the group_application.. permissions are used to control what user groups you can assign when creating new users, etc. |
| 13:51 |
Bmagic |
I was thinking that too, on a concerto machine, I logged in with a circ admin account, and the dropdown menu for patron registration was restricted to only the patron tree. That's what I would expect. Same for the secondary groups model |
| 13:52 |
Bmagic |
I trying to figure out how* that tree is restricted. I think I figured it out. Each permission group (vanilla or created) is assigned a unique value like "group_application.user.staff.admin.global_admin" - which is then referenced as it's own permission in permission.perm_list |
| 13:53 |
Bmagic |
in the case of all of the patron permission group definitions: they don't have anything for "Application permission" - and Evergreen allows any* staff account to assign those permission groups in the registration form |
| 13:54 |
Dyrcona |
Bmagic: Yeah, it's the application_perm filed, IIRC. |
| 13:55 |
Dyrcona |
It should not be blank in an ideal situation. Concerto has something for each group in the permission.grp_tree table. |
| 13:55 |
Bmagic |
but if you want to assign one of those other permission groups, your account (the one you're using) needs to have a permission that matches the string value for the permission group's property mentioned in application_perm |
| 13:56 |
Dyrcona |
You have to have the permission for that group. |
| 13:56 |
Bmagic |
makes sense now! |
| 13:57 |
Dyrcona |
You can totally prevent the creation of certain user groups in the client by assigning an application perm that doesn't exist as a permission. The only way to assign such group permissions is in the database. |
| 13:59 |
Bmagic |
yep! |
| 14:20 |
Dyrcona |
Guess I'll clean up my wip branch, add a release note, push to a new branch in the working repo, and update the bug with a pull request. |
| 14:38 |
mmorgan |
Dyrcona: re: your work on 1835953, how does it handle the situation where a checkout was never renewable at all? We don't want to tell patrons we tried to renew something that was never renewable in the first place. |
| 15:09 |
mantis1 |
in step 12.3, is the command eg_db_config --load-all-sample ? |
| 15:09 |
mantis1 |
https://evergreen-ils.org/documentation/install/README_3_12.html#_creating_the_evergreen_database_and_schema |
| 15:11 |
mantis1 |
ah it's ./eg_db_config .... |
| 15:11 |
jeffdavis |
mantis1: you would do something like this: perl Open-ILS/src/support-scripts/eg_db_config --update-config --service all --create-database --create-schema --load-all-sample --create-offline --user <user> --password <password> --hostname <hostname> --port <port> --database <dbname> --admin-user <admin-user> --admin-pass <admin-pass> |
| 15:12 |
jeffdavis |
that is, include --load-all-sample along with all the other options at the time you are running eg_db_config to create the db/schema and update config |
| 15:12 |
mantis1 |
jeffdavis++ |
| 15:12 |
mantis1 |
we'll give it a shot |
| 15:41 |
Dyrcona |
Open-ILS/src/support-scripts/eg_db_config --create-database --create-schema --user evergreen --password evergreen --hostname localhost --port 5432 --database evergreen --admin-user admin --admin-pass demo123 --load-all-sample |
| 15:41 |
Dyrcona |
That's what I run just to reload the database. |
| 15:48 |
|
sandbergja joined #evergreen |
| 16:02 |
|
jihpringle joined #evergreen |
| 16:04 |
|
mantis1 left #evergreen |
| 16:10 |
|
sandbergja joined #evergreen |
| 16:19 |
|
jihpringle joined #evergreen |
| 17:07 |
|
mmorgan left #evergreen |
