| Time |
Nick |
Message |
| 00:29 |
|
Stompro joined #evergreen |
| 07:14 |
|
collum joined #evergreen |
| 07:39 |
|
redavis joined #evergreen |
| 08:11 |
|
BDorsey joined #evergreen |
| 08:11 |
|
sleary joined #evergreen |
| 08:35 |
|
mmorgan joined #evergreen |
| 09:03 |
|
Dyrcona joined #evergreen |
| 09:13 |
|
dguarrac joined #evergreen |
| 09:28 |
|
mantis1 joined #evergreen |
| 09:38 |
* Dyrcona |
prepares to switch his main test database from pg 15 to pg 16. |
| 09:58 |
|
sleary joined #evergreen |
| 10:02 |
|
Rogan joined #evergreen |
| 10:05 |
|
jihpringle joined #evergreen |
| 10:49 |
Bmagic |
anyone having issues using OCLC z39.50 target? |
| 10:51 |
|
Rogan joined #evergreen |
| 11:00 |
|
jihpringle joined #evergreen |
| 11:01 |
|
sandbergja joined #evergreen |
| 11:07 |
Dyrcona |
Bmagic: I am not aware of issues with OCLC z39.50 at the moment. |
| 11:13 |
Bmagic |
ty, I think we figured out that the cataloger was using the wrong creds |
| 11:13 |
Bmagic |
I asked here because we saw an emerging pattern of questions from several folks |
| 11:47 |
* Dyrcona |
makes a note to spell check commit messages when writing them. |
| 12:23 |
|
sandbergja joined #evergreen |
| 12:30 |
|
jihpringle joined #evergreen |
| 12:57 |
|
jvwoolf joined #evergreen |
| 12:58 |
|
sleary joined #evergreen |
| 12:58 |
|
phasefx joined #evergreen |
| 13:07 |
|
jihpringle joined #evergreen |
| 13:17 |
|
sleary joined #evergreen |
| 13:47 |
|
mdriscoll joined #evergreen |
| 13:52 |
jvwoolf |
Good afternoon! Is there anybody who has both "Truncate fines to max fine amount" and "Cap Max Fine at Item Price" YAOUSes (YOUSi?) enabled? |
| 14:16 |
Dyrcona |
I had a look and we don't have either set. |
| 14:28 |
mmorgan |
jvwoolf: We don't have either set either. |
| 14:28 |
mmorgan |
That doesn't sound quite right, but you get the idea. |
| 14:29 |
mmorgan |
We are (almost) a fine free +6 at this point, though. :) |
| 14:29 |
mmorgan |
021 |
| 14:29 |
jvwoolf |
mmorgan: I got you ;) |
| 14:30 |
jvwoolf |
Dyrcona++ mmorgan++ |
| 14:30 |
jvwoolf |
Thanks for checking |
| 14:30 |
mmorgan |
Sorry! Literal cat on keyboard moment! |
| 14:30 |
jvwoolf |
mmorgan: That's awesome! We're mostly fine free now too! |
| 14:30 |
mmorgan |
Should have read: We are (almost) a fine free consortium at this point |
| 14:30 |
jvwoolf |
Also, hi kitty :-D |
| 14:31 |
jvwoolf |
I was wondering what +6 meant LOL |
| 14:31 |
mmorgan |
She's already gone :-D |
| 14:31 |
jvwoolf |
She left as mysteriously as she came LOL |
| 14:32 |
mmorgan |
=^..^= |
| 14:33 |
|
shulabear joined #evergreen |
| 14:34 |
Dyrcona |
:) |
| 14:55 |
Bmagic |
5 minute warning |
| 14:58 |
Bmagic |
2 minutes |
| 14:58 |
jeff |
need to go brave the icy roads. i look forward to seeing the meeting results when i return! |
| 14:58 |
Bmagic |
jeff++ # good luck out there |
| 14:59 |
shulabear |
jeff++ |
| 14:59 |
Bmagic |
30 seconds |
| 14:59 |
Bmagic |
10 |
| 14:59 |
Bmagic |
3 |
| 15:00 |
|
terranm joined #evergreen |
| 15:00 |
Bmagic |
#startmeeting 2024-01-09 - Developer Meeting |
| 15:00 |
pinesol |
Meeting started Tue Jan 9 15:00:02 2024 US/Eastern. The chair is Bmagic. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:00 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 15:00 |
pinesol |
The meeting name has been set to '2024_01_09___developer_meeting' |
| 15:00 |
Bmagic |
#info Agenda at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2024-01-09 |
| 15:00 |
Bmagic |
#topic Introductions |
| 15:00 |
Bmagic |
#info Bmagic = Blake GH, MOBIUS |
| 15:00 |
Dyrcona |
#info Dyrcona = Jason Stephenson, C/W MARS |
| 15:00 |
|
gmcharlt94 joined #evergreen |
| 15:00 |
shulabear |
#info shulabear = Shula Link, GCHRL in PINES |
| 15:00 |
Bmagic |
feel free to introduce yourselves |
| 15:00 |
mmorgan |
#info mmorgan = Michele Morgan, NOBLE |
| 15:00 |
Stompro |
#info Stompro = Josh Stompro, LARL & NWRL |
| 15:00 |
GalenCharlton |
GalenCharlton = Galen Charlton, Equinox |
| 15:01 |
|
smorrison joined #evergreen |
| 15:01 |
sleary |
#info sleary = Stephanie Leary, Equinox |
| 15:01 |
berick |
#info berick Bill Erickson, KCLS |
| 15:01 |
Bmagic |
This is probably going to be a short meeting |
| 15:01 |
terranm |
#info terranm = Terran McCanna, PINES |
| 15:02 |
Bmagic |
#topic Action Items from Last Meeting |
| 15:02 |
Dyrcona |
We could talk about releases some more. |
| 15:02 |
Bmagic |
#info mmorgan will explore moving LP stats to community site and automating same |
| 15:02 |
JBoyer |
#info JBoyer = Jason Boyer, EOLI |
| 15:02 |
eeevil |
#info eeevil = Mike Rylander, EOLI |
| 15:02 |
sandbergja |
#info sandbergja = Jane Sandberg, PUL and independent |
| 15:03 |
mmorgan |
No significant updates yet. |
| 15:03 |
* mmorgan |
is looking at some Launchpad API scripts that Dyrcona shared. |
| 15:03 |
Bmagic |
ok, no prob |
| 15:03 |
abneiman |
#info abneiman = Andrea Buntz Neiman, Equinox |
| 15:03 |
mmorgan |
Dyrcona++ |
| 15:03 |
Bmagic |
#action mmorgan will explore moving LP stats to community site and automating same |
| 15:03 |
Bmagic |
#info sandbergja will see if gh actions can run the pgtap tests |
| 15:04 |
sandbergja |
no progress on pgtap in github actions |
| 15:04 |
|
collum joined #evergreen |
| 15:04 |
Bmagic |
#action sandbergja will see if gh actions can run the pgtap tests |
| 15:04 |
Bmagic |
#info Dyrcona will summarize release coordination discussion and followup on the development mailing list. |
| 15:04 |
Dyrcona |
#info Done! |
| 15:04 |
Bmagic |
suhweet |
| 15:04 |
collum |
#info collum = Garry Collum, KCPL |
| 15:04 |
Bmagic |
anyone have anything for OpenSRF? |
| 15:05 |
Bmagic |
or Evergreen or Hatch? |
| 15:05 |
GalenCharlton |
I do |
| 15:05 |
Bmagic |
which? |
| 15:05 |
GalenCharlton |
re OpenSRF, I've identified some bugfixes and minor enhancements that I intend to cut 3.3.x (maybe a final 3.2.x) release for |
| 15:05 |
Bmagic |
#topic OpenSRF |
| 15:06 |
GalenCharlton |
I will also be putting RediSRF through some more paces (read: throw all the kitchen sinks at it) in preparation for cutting 4.0-alpha or beta in the next few weeks |
| 15:07 |
berick |
GalenCharlton++ |
| 15:07 |
GalenCharlton |
but upshot: if anybody has any favorite bugfixes for the XMPP OpenSRF, please call them out to me |
| 15:07 |
Bmagic |
GalenCharlton: thanks! |
| 15:07 |
GalenCharlton |
there is also one new bug for OpenSRF that I want to call out for feedback |
| 15:07 |
Bmagic |
GalenCharlton: typing your nick is, eh, different feeling |
| 15:08 |
GalenCharlton |
(yeah, I need to re-set-up Quassel for myself) |
| 15:08 |
GalenCharlton |
namely, https://bugs.launchpad.net/opensrf/+bug/2047707 - track browser and tab for staff interface logging |
| 15:08 |
pinesol |
Launchpad bug 2047707 in OpenSRF "track browser and tab for staff interface logging" [Wishlist,New] |
| 15:08 |
GalenCharlton |
upshot of that one: will help us deal with runaway pcrud explosions and general load monitoring |
| 15:09 |
Bmagic |
interesting! |
| 15:10 |
Bmagic |
I have a VM setup to test the redis branch(es), I really need to get back to that |
| 15:10 |
eeevil |
GalenCharlton: since the agenda is otherwise thin, I have a question about that! |
| 15:10 |
GalenCharlton |
eeevil: go for it |
| 15:11 |
eeevil |
do you imagine being able to make it a hard client requirement (think: soft API key) or just (for now) some extra info a client /should/ pass so we can know who's who? |
| 15:12 |
GalenCharlton |
I was thinking soft to start (especially since I don't really want to require it for any AJAX that the OPAC might do) |
| 15:13 |
GalenCharlton |
but it doesn't seem like it would be difficult to mandate it for staff-side methods if we wish (via a flag on the method signature, presumably) |
| 15:14 |
eeevil |
get outta my head! ;) |
| 15:14 |
eeevil |
I was thinking about something along those lines, yes. down the road. |
| 15:15 |
Bmagic |
There's a bug somewhere having to do with closing the tab, causing the pcrud wall-o-requests |
| 15:15 |
GalenCharlton |
ayup |
| 15:16 |
GalenCharlton |
and while I _also_ have some thoughts on ameliorating that from the Angular and AngularJS code, the ability to detect that a specific browser is spamming requests and doing a block (or even just a forced WS connection reset) would be very useful |
| 15:17 |
Bmagic |
coolio! Anyone here want to chime in on testing redis and/or adding comments on the tab-tracking proposal bug |
| 15:18 |
Bmagic |
I suppose we can move on now |
| 15:18 |
Bmagic |
#topic Documentation |
| 15:18 |
Bmagic |
dluch won't make it today. abneiman, any update? |
| 15:19 |
abneiman |
#info DIG met last week and discussed plans for 2024, including documenting things from 3.12 that are needed |
| 15:19 |
Bmagic |
abneiman++ |
| 15:19 |
abneiman |
#info We are also working with an intern who is reviewing Evergreen Indiana documentation & revising it for inclusion in main |
| 15:20 |
terranm |
abneiman++ |
| 15:20 |
abneiman |
#info and this bug from sandbergja could use a little love & would make some DIGgers very happy lp1930099 |
| 15:20 |
abneiman |
er bug 1930099 |
| 15:20 |
pinesol |
Launchpad bug 1930099 in Evergreen "generate_docs.pl should be able to run on Windows" [Medium,Confirmed] https://launchpad.net/bugs/1930099 |
| 15:21 |
abneiman |
there we go |
| 15:21 |
abneiman |
thus concludes my off the cuff DIG update |
| 15:21 |
Bmagic |
oh yeah! I'm interested in that one too. I considered some code to make that work a couple of years ago when she reported that bug |
| 15:21 |
Bmagic |
#info Next DIG Meeting: Thursday, February 1 |
| 15:21 |
abneiman |
Jane posted a recent branch for review |
| 15:21 |
abneiman |
sandbergja++ |
| 15:21 |
Bmagic |
sandbergja++ |
| 15:22 |
sandbergja |
happy to zoom with anybody on a windows box who wants to give it a try, btw |
| 15:22 |
mmorgan |
GalenCharlton++ abneiman++ sandbergja++ |
| 15:22 |
Bmagic |
sandbergja: sweet! |
| 15:22 |
Bmagic |
incoming paste bomb |
| 15:23 |
Bmagic |
#topic Launchpad Status (as of noon Eastern) |
| 15:23 |
Bmagic |
#info Open Bugs - 3076 |
| 15:23 |
Bmagic |
#info Pullrequests - 95 |
| 15:23 |
Bmagic |
#info Signedoff - 5 |
| 15:23 |
Bmagic |
#topic Launchpad Status since last meeting |
| 15:23 |
Bmagic |
#info Bugs Added - 58 |
| 15:23 |
Bmagic |
#info Pullrequest tag Added - 29 |
| 15:23 |
Bmagic |
#info Signedoff tag Added - 10 |
| 15:23 |
Bmagic |
#info Fix Committed - 14 |
| 15:23 |
Bmagic |
#topic New Business - The Voluntary Product Accessibility Template / Accessibility Conformance Report on the OPAC is available, and new Launchpad bugs have been filed for all the issues noted in the report |
| 15:23 |
Bmagic |
#link https://wiki.evergreen-ils.org/doku.php?id=accessibility:vpat |
| 15:24 |
sleary |
some of those are pretty bite-sized, if anyone wants to tackle them |
| 15:24 |
sleary |
I've linked to the accessibility dev guide where I could |
| 15:25 |
sleary |
I was working from VERY terse comments from the report, so let me know if I have not totally fleshed out the explanation of the problems or recommended solutions |
| 15:26 |
Bmagic |
sleary++ |
| 15:26 |
sandbergja |
sleary++ |
| 15:26 |
mmorgan |
sleary++ |
| 15:26 |
abneiman |
sleary++ |
| 15:27 |
shulabear |
sleary++ |
| 15:27 |
Bmagic |
Dyrcona: you mentioned at the beginning that you might want to open a discussion? |
| 15:27 |
terranm |
sleary++ |
| 15:27 |
Bmagic |
#topic talk about releases some more |
| 15:28 |
GalenCharlton |
if folks are amenable, I would also like to discuss my release note proposal here |
| 15:28 |
Bmagic |
plenty of time! Go for it |
| 15:29 |
GalenCharlton |
so, as I mentioned, I would like to propose that, for the cases where a fix can be adequately described by a one-liner, to include those in commit messages with a structured tag such as Release-note |
| 15:30 |
GalenCharlton |
idea is that they can be gathered up by the script that starts the initial notes for each release |
| 15:30 |
GalenCharlton |
and save time (including, I must say, time spent dealing with merge conflicts on miscellaneous.adoc - they're trivial, but do add up) |
| 15:30 |
GalenCharlton |
for anything that is bigger, docs/RELEASE_NOTES_NEXT should still be sed |
| 15:30 |
Dyrcona |
:) I was about to mention miscellaneous.adoc.... |
| 15:31 |
GalenCharlton |
main advantages I see: patch authors have to write _something_ in a commit message anyway |
| 15:31 |
Dyrcona |
I think this should apply to bug fixes only. New features require actual release notes. |
| 15:31 |
GalenCharlton |
and patch reviewers (and especially committers) have plenty of opportunity to tweak wording |
| 15:32 |
GalenCharlton |
so since folks are _right there_, hopefully this can be maintainable |
| 15:32 |
|
mantis1 left #evergreen |
| 15:32 |
GalenCharlton |
(and personally, I'm happy to commit as a comitter, as it were, to providing them for any patches that I review or merge) |
| 15:33 |
abneiman |
commit as a committer to commit commit messages... |
| 15:33 |
GalenCharlton |
abneiman++ |
| 15:33 |
eeevil |
+1, and also +1 to a commit message template that sets stuff up how we want them to look at pick-to-main time |
| 15:33 |
Bmagic |
I'm all for using "Release-note" - an easy enough thing to start with. And it's not required, or sometimes doesn't make sense, depending. Omitting is is still fine. But having the general etiquette is nice |
| 15:33 |
abneiman |
in all seriousness I am +1(0000) to GalenCharlton 's proposal with Dyrcona 's caveat of "actual features need actual release notes" |
| 15:33 |
Dyrcona |
I'm OK with this for bug fixes. There was some discussion of adding a commit message template to the repository. is that still being floated? |
| 15:34 |
sandbergja |
how would the commit tag work if a bug fix includes multiple commits? |
| 15:34 |
Stompro |
+1 - seems like a nice time saver. |
| 15:34 |
GalenCharlton |
as far as bug fixes only vs new features - I think it will work out that way in practice. I think a "literally must fit in a single line" should cover it, but if a new feature is truly tiny enough, no need to belabor it |
| 15:34 |
eeevil |
sandbergja: the "main"-est commit would carry the tag, I think |
| 15:34 |
GalenCharlton |
well, any commit in the series should do |
| 15:35 |
GalenCharlton |
I think the scripting that grabs these tags doesn't need to care whether its the first or last patch in a series; just (eventually) complain if _none_ of the patches for a given bug have an entry |
| 15:36 |
eeevil |
but, again, in practice if it's that small of a fix needing only 1 line, it probably should be 1 commit |
| 15:36 |
sandbergja |
makes sense |
| 15:36 |
Bmagic |
GalenCharlton++ gmcharlt++ |
| 15:36 |
GalenCharlton |
(and also, this is just to _start_ the release notes; there would still be human review) |
| 15:36 |
eeevil |
+1 |
| 15:37 |
GalenCharlton |
Dyrcona: re commit message templates - yes, I think we should do that |
| 15:37 |
GalenCharlton |
(and thanks to Josh Stompro for the suggestion!) |
| 15:38 |
Bmagic |
we really do need something* to get these release notes wrangled for streamlining the releases. This is a great step forward |
| 15:38 |
shulabear |
+1 |
| 15:38 |
sandbergja |
FWIW: at PUL, we maintain a gitmessage, and it includes all of our teams and frequent collaborators: https://github.com/pulibrary/pul-it-handbook/blob/main/gitmessage.md |
| 15:38 |
GalenCharlton |
sandbergja++ |
| 15:39 |
Bmagic |
GalenCharlton: would you like an action item for writing/committing the git voodoo to generate said release note file? |
| 15:39 |
sandbergja |
so adding somebody to a commit is just a case of uncommenting a line in the gitmessage. I could picture something like that for Signedoff-by lines |
| 15:39 |
GalenCharlton |
(though I will take this moment to shake my fist at the only-50-characters for the first line convention) |
| 15:39 |
Dyrcona |
Well, we don't always follow that convention anyway. |
| 15:39 |
GalenCharlton |
well, git commit --amend -s I think handles the signed-off lines better |
| 15:39 |
GalenCharlton |
Bmagic: I'll take two action items, actually |
| 15:40 |
Bmagic |
There's a convention? (lol) |
| 15:40 |
GalenCharlton |
first, open an LP bug and propose a git commit message template there |
| 15:40 |
Dyrcona |
sandbergja++ Nice gitmessage. |
| 15:40 |
GalenCharlton |
second: update the release note script to look for the release-note tags |
| 15:41 |
Bmagic |
#action GalenCharlton will open LP bug with the official proposal for git commit message release-note |
| 15:41 |
GalenCharlton |
actually, let's see |
| 15:41 |
GalenCharlton |
also a third: write up the release-notes convention for the dev wiki somehwere |
| 15:41 |
Bmagic |
#action GalenCharlton update the release note script to look for the release-note tags |
| 15:42 |
Bmagic |
#action GalenCharlton write up the release-notes convention for the dev wiki somehwere |
| 15:42 |
Bmagic |
how's that? |
| 15:42 |
Dyrcona |
Well, thats a lot to throw at 1 person. |
| 15:43 |
Bmagic |
you want to grab one or two? |
| 15:43 |
Bmagic |
anyone else for that matter? |
| 15:44 |
Stompro |
I can write something up for the wiki. |
| 15:44 |
Bmagic |
Stompro++ |
| 15:44 |
shulabear |
stompro++ |
| 15:44 |
Bmagic |
I don't know if the meetingbot can delete action items |
| 15:44 |
|
jvwoolf left #evergreen |
| 15:45 |
Bmagic |
but I'll make a repeat for Stompro, and we'll all just have to remember that Josh stole it |
| 15:45 |
Dyrcona |
We can delete strike them in the agenda of the next meeting or edit them. |
| 15:45 |
GalenCharlton |
@ action GalenCharlton will forget about the wiki... ;) |
| 15:45 |
pinesol |
GalenCharlton: WORKSFORME WONTFIX |
| 15:45 |
terranm |
lol |
| 15:46 |
Bmagic |
#action Stompro write up the release-notes convention for the dev wiki somehwere (stolen action from GalenCharlton) |
| 15:46 |
shulabear |
lol |
| 15:47 |
JBoyer |
On the commit template topic I had hoped there was a way to make it "automagical" as part of the repo but that hope has been dashed because it's explicitly not supported. It can be included, but actually turning it on will always be a manual process (once). |
| 15:48 |
Bmagic |
There's another 11 minutes and change. I feel like we left Dyrcona dry. Dyrcona: would you like to comment on the release work R&D you've been doing? |
| 15:48 |
JBoyer |
not supported as in it's considered a security issue, so there goes my hope of building in a bunch of fancy git hooks to make sure things like template usage and lint passing and so on too. :) |
| 15:48 |
GalenCharlton |
curl https://evergreen-ils.org/set-up-clone.sh | bash |
| 15:48 |
* GalenCharlton |
runs away |
| 15:49 |
shulabear |
lol |
| 15:49 |
Bmagic |
::starts seeing nicks getting mysteriously logged off:: |
| 15:49 |
Dyrcona |
JBoyer: We can commit a .gitmessage, but the user has to configure it to be used locally. |
| 15:50 |
Dyrcona |
Bmagic: I'm not doing much R&D. I just have a couple of scripts to simplify setting up a git branch for a custom release with DB upgrade. I think in the long run we should make-release up into smaller scripts that as a whole are more flexible to use. |
| 15:51 |
Bmagic |
dividing and conquering sounds feasible to me |
| 15:51 |
Bmagic |
ansible is a thing |
| 15:51 |
Dyrcona |
i dropped a verb in that second sentence: We should split it up. I've not actually started on that. |
| 15:52 |
Dyrcona |
Ansible is a thing, but I don't know if that should be the standard way to install Evergreen. |
| 15:52 |
sandbergja |
JBoyer: there are also packages like this -- https://github.com/toplenboren/simple-git-hooks -- which does what you described as long as you have run `npm install` |
| 15:52 |
JBoyer |
re: ansible = standard: 100% not. |
| 15:52 |
Bmagic |
I was thinking more like ansible driving the make-release stuffs |
| 15:53 |
JBoyer |
sandbergja, I saw reference to that, but that's a flavor of magic I don't much like either. |
| 15:53 |
Dyrcona |
Well, make-release just builds a tarball, and if you do autotools "correctly" it should be as simple as typing "make release." |
| 15:54 |
Dyrcona |
Well, make-release does more than "just build a tarball." |
| 15:54 |
Bmagic |
I think what we have now is pretty good, just throwing out ideas |
| 15:54 |
Bmagic |
5 minutes left, anyone want to add? |
| 15:54 |
Dyrcona |
yeah, I hesitate to add ansible to the packager requirements. |
| 15:56 |
|
terranm6 joined #evergreen |
| 15:56 |
Bmagic |
#topic Announcements |
| 15:56 |
Bmagic |
#info Next Meeting is Tuesday, February 13th |
| 15:56 |
Bmagic |
#endmeeting |
| 15:56 |
pinesol |
Meeting ended Tue Jan 9 15:56:38 2024 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 15:56 |
pinesol |
Minutes: http://evergreen-ils.org/meetings/evergreen/2024/evergreen.2024-01-09-15.00.html |
| 15:56 |
pinesol |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2024/evergreen.2024-01-09-15.00.txt |
| 15:56 |
pinesol |
Log: http://evergreen-ils.org/meetings/evergreen/2024/evergreen.2024-01-09-15.00.log.html |
| 15:56 |
sandbergja |
Bmagic++ |
| 15:56 |
shulabear |
bmagic++ |
| 15:56 |
Dyrcona |
Bmagic++ gmcharlt++ abneiman++ |
| 15:56 |
mmorgan |
Bmagic++ |
| 15:56 |
Stompro |
Bmagic++ thanks for running the meeting. |
| 15:57 |
GalenCharlton |
Bmagic++ |
| 15:57 |
JBoyer |
Bmagic++ |
| 15:57 |
terranm6 |
Bmagic++ |
| 15:58 |
Bmagic |
thank you, thank you. I'd like to thank my mom and dad. And my plushie for getting me to this point! |
| 15:58 |
Dyrcona |
:) |
| 15:58 |
GalenCharlton |
Bmagic_Plushie++ |
| 15:58 |
Dyrcona |
I'd like to see make release be automated enogh that it could almost run unattended. |
| 15:58 |
GalenCharlton |
yeah, that would be good |
| 15:59 |
Bmagic |
Dyrcona: I think automation is paramount these days. Anything that can be, should be IMO |
| 15:59 |
Dyrcona |
I have this: https://gist.github.com/Dyrcona/933dd1a2e9035fdc48162dbcfcb51a2d |
| 16:00 |
Dyrcona |
and this that I use: https://gist.github.com/Dyrcona/00bd6b6290b6fbbb579c7f93b360ab0d |
| 16:00 |
Dyrcona |
I use them to set up git branches for our custom upgrades in git. |
| 16:00 |
Dyrcona |
redundant much? ;) |
| 16:06 |
Bmagic |
Dyrcona++ |
| 16:25 |
Stompro |
Should the commit template idea be it's own LP ticket? |
| 16:26 |
Dyrcona |
That was suggested in the meeting and gmcharlt was assigned an action for it. I almost volunteered to take that one, but it seems rather easy. |
| 16:26 |
Stompro |
oops, missed that. |
| 16:27 |
Dyrcona |
Apparently, we can add a .gitmessage or whatever, but we can't force people to use it. |
| 16:27 |
Dyrcona |
They have to configure it locally. |
| 16:28 |
Stompro |
I'll add it to the quick start at https://wiki.evergreen-ils.org/doku.php?id=dev:git#quick_start_for_evergreen_contributors |
| 16:28 |
Stompro |
When it is ready. |
| 16:30 |
Stompro |
That page has Thomas Berezansky and Dan Scott as git admins :-) |
| 16:31 |
Dyrcona |
Well, that page needs updating. It's gmcharlt and myself now. I'll fix it. |
| 16:31 |
Stompro |
I can do it also. |
| 16:32 |
Dyrcona |
I just experimented with .gitmessage. Even if you add it locally, you still have to do the git config step to use it. |
| 16:33 |
Dyrcona |
looks like you beat me to it. :) |
| 16:33 |
Dyrcona |
Stompro++ |
| 16:33 |
Stompro |
I gave you 10 seconds... and then I did it. |
| 16:34 |
Dyrcona |
I noticed the change when I hit the Edit button for the section of the document. |
| 16:34 |
Stompro |
I'm a patient person after all. |
| 16:34 |
Dyrcona |
:) |
| 16:37 |
Dyrcona |
While we're at it, the commit message template should contain a blank Signed-off-by: line. |
| 16:39 |
Stompro |
Why? Doesn't commit -s handle that? |
| 16:42 |
Stompro |
Goodnight everyone. |
| 16:42 |
Dyrcona |
It does. I was just playing with it in an empty repo. |
| 16:43 |
Dyrcona |
I should play with -F. If you use -F or -m, the commit message setting is bypassed. |
| 16:44 |
Dyrcona |
Catch you later, Stompro! |
| 16:44 |
Dyrcona |
I might as well sign out. See you all again tomorrow! |
| 17:09 |
|
mmorgan left #evergreen |
| 20:31 |
|
sleary joined #evergreen |
