| Time |
Nick |
Message |
| 03:12 |
|
troy joined #evergreen |
| 07:02 |
|
sleary joined #evergreen |
| 07:51 |
|
eglogbot joined #evergreen |
| 07:51 |
|
Topic for #evergreen is now Welcome to #evergreen (https://evergreen-ils.org). This channel is publicly logged. Logs for today: http://irc.evergreen-ils.org/evergreen/today |
| 07:54 |
|
BDorsey joined #evergreen |
| 08:06 |
|
sandbergja joined #evergreen |
| 08:25 |
|
Stompro joined #evergreen |
| 08:32 |
|
mmorgan joined #evergreen |
| 08:39 |
|
dguarrac joined #evergreen |
| 08:40 |
|
redavis joined #evergreen |
| 09:01 |
|
sleary joined #evergreen |
| 09:06 |
|
Dyrcona joined #evergreen |
| 09:57 |
|
sleary joined #evergreen |
| 10:02 |
|
terranm joined #evergreen |
| 10:04 |
|
kmlussier joined #evergreen |
| 10:07 |
|
jonadab joined #evergreen |
| 10:23 |
kmlussier |
Release_Team++ abneiman++ mmorgan++ terranm++ rfrasur++ collum++ sandbergja++ |
| 10:26 |
Dyrcona |
Hrm... OpenSRF 3.2.3 doesn't have a prerequisite target for Ubuntu Jammy.... |
| 10:27 |
pinesol |
News from commits: DOCS: LP#1871211 Follow-up eg_vhost.conf <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ded2dd7815a9d3bcf0305c1b55dd53ee3f7ae4f4> |
| 10:27 |
Dyrcona |
It probably should. |
| 10:29 |
|
sandbergja joined #evergreen |
| 10:30 |
sandbergja |
Dyrcona++ # thanks for taking a look at that live test |
| 10:32 |
berick |
sandbergja++ # branches, redis, and more! |
| 10:32 |
Bmagic |
sandbergja, abneiman, terranm, colum : Would you mind if I back ported this Docs commit to rel_3_12? ded2dd7815a9d3bcf0305c1b55dd53ee3f7ae4f4 |
| 10:33 |
sandbergja |
+1 from me |
| 10:33 |
Bmagic |
I lost 4 hours because this wasn't in the docs, lol |
| 10:41 |
Bmagic |
pushed |
| 10:45 |
Bmagic |
I stumbled on this gem: https://wiki.evergreen-ils.org/doku.php?id=dev:evergreen:release_checklist |
| 10:49 |
kmlussier |
Last updated in 2016 by me. I knew that page looked familiar. We seem to have a habit of creating wiki pages with a lot of good information that are never put in a place where people can find them. |
| 10:51 |
sleary |
indeed |
| 10:56 |
|
Rogan joined #evergreen |
| 10:59 |
* Dyrcona |
should alias suod and subo.... |
| 11:00 |
Bmagic |
Dyrcona++ # haha |
| 11:11 |
|
briank joined #evergreen |
| 11:12 |
eeevil |
not to be a buzz kill, but I'm pretty strongly against defaulting origin/main to redis, esp given what I thought was the general consensus recently that we were not going to try to force The Next Version to be redis, but instead make that decision later. it's going to be a road bump for current dev and, especially and more importantly, dev that requires backporting to versions that aren't redis-capable |
| 11:13 |
eeevil |
road bump? speed bump / pot hole / spike strip |
| 11:18 |
berick |
hm, i thought we did decide to make it default for post-3.12 main. |
| 11:18 |
berick |
i could be misremembering |
| 11:19 |
berick |
in part, i think, since it would only affect new installs |
| 11:20 |
eeevil |
I thought we'd agreed that we should see what things look like after some more testing and review. |
| 11:20 |
Dyrcona |
I'm not sure what we agreed at this point. Maybe we should have that discussion on the list? |
| 11:20 |
eeevil |
where will there be more new installs than for the purpose of dev, though? |
| 11:21 |
Dyrcona |
The dev meeting is also today. |
| 11:22 |
berick |
eeevil: that also sounds logical. i'm fuzzy. in any event, while redis is not yet merged to osrf main, new eg main installs would break w/o config changes. |
| 11:24 |
eeevil |
I'm not convinced that it's as robust as the xmpp verison ... I say this with sincere and significant thanks, berick, you just put back in a feature critical to making the transition reasonably smooth for any non-trivial topologies. |
| 11:25 |
berick |
should just be the one commit to go back to xmpp default. |
| 11:25 |
* berick |
checks |
| 11:27 |
eeevil |
NOTE: I realize that I'm nearly hoisting myself on my on petard, here, because I need to carve out time to really dig into the code so I can 1) convince myself it's ready and 2) not leave all of it inside berick's head ... but, it IS mostly inside berick's head, today. |
| 11:28 |
eeevil |
s/on/own/ also I need more caffeine |
| 11:29 |
berick |
oh yeah i'm good w/ a cautious approach. progress++ |
| 11:33 |
berick |
https://github.com/evergreen-library-system/Evergreen/compare/a21e7869bc..69a695db4f |
| 11:33 |
berick |
yeah we can merge those 2 commits to get main back to default xmpp |
| 11:34 |
berick |
better link: https://github.com/evergreen-library-system/Evergreen/compare/a21e7869bc...69a695db4f |
| 11:35 |
* berick |
will have to miss most/all of today's dev meeting |
| 11:36 |
eeevil |
those are the 3.12 versions, I assume? ah, yes, in rel_2_13 |
| 11:37 |
eeevil |
since I came to complain ;) , I'm happy to pick them into main. are there objections? |
| 11:38 |
eeevil |
man... my fingers are not moving in the right order today. rel_3_12 |
| 11:41 |
eeevil |
it's close to lunch time, so I'll leave the question open for a while. but, ping Dyrcona and sandbergja (in particular) |
| 11:52 |
csharp_ |
eeevil: I'm good for what my opinion is worth |
| 11:55 |
csharp_ |
I've lightly tested it on my puny server |
| 11:55 |
csharp_ |
@band add Irregular Expressions |
| 11:55 |
pinesol |
csharp_: Band 'Irregular Expressions' added to list |
| 12:02 |
sleary |
can I still target bug fixes to 3.12 or is that bad manners at this point? |
| 12:03 |
eeevil |
csharp_: it's worth One Full Commit Bit, as it happens, sir! |
| 12:04 |
berick |
something, something Commit Bitcoin |
| 12:04 |
eeevil |
sleary: targeting bug fixes to the various impacted versions should always be fair game, I think |
| 12:05 |
sleary |
eeevil++ |
| 12:05 |
sleary |
terranm may of course wield the Mallet of Loving Correction if necessary ;) |
| 12:06 |
berick |
heh |
| 12:07 |
terranm |
sleary yes, go ahead and continue targeting bug fixes to 3.12, just not new features |
| 12:11 |
kmlussier |
@band add Mallet of Loving Correction |
| 12:11 |
pinesol |
kmlussier: Band 'Mallet of Loving Correction' added to list |
| 12:11 |
|
Christineb joined #evergreen |
| 12:58 |
|
jihpringle joined #evergreen |
| 13:20 |
|
sleary2 joined #evergreen |
| 13:45 |
|
sleary joined #evergreen |
| 13:59 |
|
smayo joined #evergreen |
| 14:07 |
|
jihpringle joined #evergreen |
| 14:45 |
Bmagic |
14 minutes |
| 14:48 |
|
shulabear joined #evergreen |
| 14:48 |
Bmagic |
Morphous is fighting Neo! |
| 14:50 |
Bmagic |
10 minutes |
| 14:54 |
|
smayo joined #evergreen |
| 14:54 |
Bmagic |
5 |
| 14:55 |
* csharp_ |
bites nails in anticipation |
| 14:55 |
* csharp_ |
wipes sweat from brow but keeps typing |
| 14:55 |
smayo |
The suspense |
| 14:56 |
* shulabear |
shivers with anticip... |
| 14:58 |
|
collum joined #evergreen |
| 14:59 |
Bmagic |
60 seconds |
| 14:59 |
shulabear |
....pation. |
| 14:59 |
csharp_ |
shulabear++ # commitment |
| 14:59 |
Bmagic |
lol |
| 15:00 |
Bmagic |
#startmeeting 2023-11-14 - Developer Meeting |
| 15:00 |
pinesol |
Meeting started Tue Nov 14 15:00:01 2023 US/Eastern. The chair is Bmagic. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:00 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 15:00 |
pinesol |
The meeting name has been set to '2023_11_14___developer_meeting' |
| 15:00 |
Bmagic |
#info Agenda at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2023-11-14 |
| 15:00 |
Bmagic |
#topic Introductions |
| 15:00 |
Bmagic |
#info Bmagic = Blake GH, MOBIUS |
| 15:00 |
Dyrcona |
#info Dyrcona = Jason Stephenson, C/W MARS |
| 15:00 |
shulabear |
#info shulabear = Shula Link, GCHRL in PINES |
| 15:00 |
mmorgan |
#info mmorgan = Michele Morgan, NOBLE |
| 15:00 |
csharp_ |
#info csharp_ = Chris Sharp, GPLS |
| 15:00 |
terranm |
#info terranm = Terran McCanna, PINES |
| 15:00 |
Stompro |
#info Stompro = Josh Stompro, LARL |
| 15:00 |
jeff |
#info jeff = Jeff Godin, Traverse Area District Library (TADL) |
| 15:00 |
collum |
#info collum = Garry Collum, KCPL |
| 15:00 |
sleary |
#info sleary = Stephanie Leary, Equinox |
| 15:00 |
smayo |
#info smayo = Steven Mayo, PINES |
| 15:01 |
Bmagic |
#topic Action Items from Last Meeting |
| 15:01 |
JBoyer |
#info JBoyer = Jason Boyer, EOLI |
| 15:01 |
Bmagic |
#info jeff will write tutorial "Retrieve a user's setting and do something based on its value" |
| 15:02 |
Bmagic |
#info jeff will make tutorial: "Add missing field to print template" |
| 15:02 |
Bmagic |
go ahead jeff, what's up? |
| 15:02 |
abneiman |
#infor abneiman = Andrea Buntz Neiman, EOLI |
| 15:03 |
jeff |
nothing to report, still happy to do soon when I make the time, if anyone feels incredibly motivated and in possession of free time feel free to let me know. :-) |
| 15:03 |
Bmagic |
#action jeff will make tutorial: "Add missing field to print template" |
| 15:03 |
Bmagic |
#action jeff will write tutorial "Retrieve a user's setting and do something based on its value"#action jeff will write tutorial "Retrieve a user's setting and do something based on its value" |
| 15:03 |
Bmagic |
whoops |
| 15:03 |
Bmagic |
I wonder what that will do |
| 15:03 |
eeevil |
#info eeevil = Mike Rylander, eoli |
| 15:04 |
sandbergja |
#info sandbergja = Jane Sandberg, PUL/independent |
| 15:04 |
Bmagic |
#info mmorgan will explore moving LP stats to community site and automating same |
| 15:04 |
* mmorgan |
has nothing to report this month, busy with the release. |
| 15:04 |
phasefx |
#info phasefx = Jason Etheridge, EOLI |
| 15:04 |
Bmagic |
no problem, carrying forward |
| 15:04 |
Bmagic |
#action mmorgan will explore moving LP stats to community site and automating same |
| 15:04 |
Bmagic |
#info sandbergja will write tutorial: "Do a database call (Galen’s cat counter)"#info sandbergja will write tutorial: "Do a database call (Galen’s cat counter)" |
| 15:04 |
Bmagic |
#info sandbergja will go over the Nightwatch test reorg with folks at the Monday at 2pm ET meeting or another time as available |
| 15:05 |
Bmagic |
go ahead sandbergja |
| 15:05 |
sandbergja |
kinda fidddling with my partial draft for the tutorial |
| 15:05 |
sandbergja |
probably need to check back with me next time :-) |
| 15:05 |
Bmagic |
no problem |
| 15:05 |
sleary |
sandbergja I looked at what you sent me a while back and it's looking great |
| 15:05 |
sandbergja |
we didn't get around to moving the nightwatch tests, but we got them working! |
| 15:05 |
sandbergja |
sleary++ # thanks for the review! |
| 15:05 |
terranm |
sandbergja++ |
| 15:05 |
Bmagic |
#action sandbergja will write tutorial: "Do a database call (Galen’s cat counter)" |
| 15:05 |
smayo |
sandbergja++ |
| 15:05 |
shulabear |
sandbergja++ |
| 15:06 |
Bmagic |
sandbergja++ mmorgan++ jeff++ |
| 15:06 |
Bmagic |
The agenda is sparse, anyone want to talk about the blank ones? |
| 15:07 |
abneiman |
yes |
| 15:07 |
Bmagic |
abneiman which |
| 15:07 |
abneiman |
Evergreen release! |
| 15:07 |
terranm |
Tomorrow at 3pm Eastern in the New Devs time slot we'll be walking through the build of 3.12 beta |
| 15:07 |
Bmagic |
#topic Evergreen release |
| 15:07 |
abneiman |
I tried to edit the doc but can't multitask |
| 15:07 |
abneiman |
yes, what terranm says |
| 15:08 |
abneiman |
also, FBF stats here: https://wiki.evergreen-ils.org/doku.php?id=dev:bug_squashing:2023-11 |
| 15:08 |
abneiman |
all_yall++ |
| 15:08 |
terranm |
https://wiki.evergreen-ils.org/doku.php?id=newdevs:meetings:agenda-2023-11 |
| 15:08 |
Bmagic |
I refreshed and I see new stuff |
| 15:08 |
abneiman |
and terranm++ sandbergja++ and mmorgan++ for many lovely merges |
| 15:08 |
Bmagic |
#link https://wiki.evergreen-ils.org/doku.php?id=dev:bug_squashing:2023-11 |
| 15:09 |
abneiman |
though there is a test conflict to talk about below in the agenda |
| 15:09 |
Bmagic |
terranm++ sandbergja++ mmorgan++ |
| 15:09 |
terranm |
3.12 (currently) has an even 100 patches committed |
| 15:09 |
sleary |
terranm++ sandbergja++ mmorgan++ |
| 15:09 |
shulabear |
terranm++ mmorgan++ sandbergja++ |
| 15:09 |
Bmagic |
haha, we should stop so we can have that cool number |
| 15:09 |
sleary |
almost all the accessibility bugs that had good branches have been committed; it's pretty great |
| 15:10 |
terranm |
There are a few more small bug fixes that I may squeeze in to ruin that good number |
| 15:10 |
sandbergja |
csharp++ eevil++ berick++ # also were in on the committing frenzy |
| 15:10 |
abneiman |
anyway that's all, we are frozen as far as features go and lookng good for an early December release |
| 15:10 |
sleary |
csharp++ eevil++ berick++ |
| 15:10 |
Bmagic |
terranm: that just means we have to make 200 |
| 15:11 |
terranm |
lol |
| 15:11 |
Bmagic |
101 is good too because: Disney |
| 15:11 |
terranm |
Well, we have over 3000 LP tickets to choose from |
| 15:11 |
abneiman |
info: New Devs Release Building Party tomorrow here --> https://wiki.evergreen-ils.org/doku.php?id=newdevs:meetings:agenda-2023-11 |
| 15:11 |
abneiman |
lemme try that again |
| 15:11 |
Bmagic |
sure |
| 15:11 |
abneiman |
#info: New Devs Release Building Party tomorrow here --> https://wiki.evergreen-ils.org/doku.php?id=newdevs:meetings:agenda-2023-11 |
| 15:12 |
Bmagic |
that should make it into the meeting notes |
| 15:12 |
abneiman |
yay, computers |
| 15:12 |
sleary |
I think Launchpad will need a thorough cleaning-out once we get rid of the last Dojo and AngularJS interfaces |
| 15:12 |
abneiman |
sleary I cannot wait for that day |
| 15:12 |
Bmagic |
wouldn't that be sweet!? |
| 15:13 |
terranm |
I am chomping at the bit |
| 15:13 |
sandbergja |
There are some tickets that have an opensrf/evergreen pair, in which the evergreen one has been merged but the opensrf version still needs a review, merge, and release |
| 15:13 |
* eeevil |
plans to live long enough to watch the bodies of his old dojo bugs float downstream |
| 15:13 |
Bmagic |
We probably never thought we'd be using Dojo in 2023 |
| 15:13 |
terranm |
Pictures eeevil with a long white beard |
| 15:14 |
Bmagic |
anything else on Evergreen release topic? |
| 15:14 |
csharp_ |
eeevil++ |
| 15:14 |
abneiman |
not from me |
| 15:14 |
Bmagic |
#topic Documentation |
| 15:14 |
Bmagic |
dluch is out today, anyone want to fill in? |
| 15:15 |
abneiman |
I believe there are currently zero uncommitted docs PRa |
| 15:15 |
abneiman |
PRs |
| 15:15 |
abneiman |
so that is a fun stat |
| 15:15 |
sandbergja |
woohoo! |
| 15:16 |
Bmagic |
wowsa!~ |
| 15:16 |
sandbergja |
abneiman++ |
| 15:16 |
Bmagic |
abneiman++ |
| 15:16 |
mmorgan |
abneiman++ |
| 15:16 |
shulabear |
abneiman++ |
| 15:16 |
Bmagic |
that's probably a good note to end that topic with |
| 15:16 |
csharp_ |
so when are we free to commit to main again? after tomorrow? |
| 15:17 |
csharp_ |
oh sorry - off topic |
| 15:17 |
sandbergja |
any time you want charp_ |
| 15:17 |
Bmagic |
#info zero uncommitted docs PRa |
| 15:17 |
Bmagic |
#topic Launchpad Status (as of noon Eastern) |
| 15:17 |
Bmagic |
inc paste |
| 15:17 |
csharp_ |
k - just didn't want to step on the release team's toes |
| 15:17 |
sandbergja |
we already started up a rel_3_12 branch |
| 15:17 |
Bmagic |
#info Open Bugs - 3138 |
| 15:17 |
Bmagic |
#info Pullrequests - 85 |
| 15:17 |
Bmagic |
#info Signedoff - 4 |
| 15:17 |
csharp_ |
sandbergja: awesome! thanks! |
| 15:17 |
Bmagic |
#topic Launchpad Status since last meeting#topic Launchpad Status since last meeting |
| 15:17 |
Bmagic |
lol |
| 15:18 |
Bmagic |
#topic Launchpad Status since last meeting |
| 15:18 |
Bmagic |
#info Bugs Added - 88 |
| 15:18 |
Bmagic |
#info Pullrequest tag Added - 19 |
| 15:18 |
Bmagic |
#info Signedoff tag Added - 8 |
| 15:18 |
Bmagic |
#info Fix Committed - 12 |
| 15:18 |
csharp_ |
sandbergja: sometimes that's not done until the beta is actually created - good that you went ahead with it |
| 15:18 |
mmorgan |
Bmagic: Fix Committed = 102! |
| 15:19 |
mmorgan |
Signedoff 78, pullrequested 90. |
| 15:20 |
terranm |
bugsquashers++ |
| 15:20 |
mmorgan |
bugsquashers++ |
| 15:21 |
abneiman |
mmorgan++ # correcting the record! |
| 15:21 |
Bmagic |
mmorgan++ |
| 15:22 |
Bmagic |
#topic New Business - Getting `ng lint` rolling again (bug 1850473) - Jane |
| 15:22 |
pinesol |
Launchpad bug 1850473 in Evergreen "Discussion item: make sure we are using the very best angular linting rules" [Low,Confirmed] https://launchpad.net/bugs/1850473 - Assigned to Galen Charlton (gmc) |
| 15:22 |
Bmagic |
#link https://bugs.launchpad.net/evergreen/+bug/1850473 |
| 15:22 |
eeevil |
I have a question/topic that I didn't get onto the agenda, while we're gathered (when it's time for "any other topics?") |
| 15:22 |
Bmagic |
eeevil: no prob, I just started one, so maybe after this section? |
| 15:23 |
sandbergja |
ooh, yes! We used to have an automated friend called ng lint. It would catch formatting issues and let you know about common gotchas of where bugs could hide |
| 15:23 |
eeevil |
Bmagic: on your mark, sir. |
| 15:23 |
sandbergja |
I think I messed it up at one point |
| 15:23 |
sandbergja |
so now it always just says that everything's fine |
| 15:23 |
Bmagic |
sandbergja: interesting |
| 15:23 |
terranm |
"Nothing to see here" |
| 15:24 |
sandbergja |
I want to turn it back on, and it was suggested on that ticket that we do it... now |
| 15:24 |
sandbergja |
after feature freeze for 3.12 |
| 15:24 |
Bmagic |
do we know what the problem is? |
| 15:24 |
sandbergja |
So, this PR would basically touch every new file that has changed since ng lint stopped working, making the changes that it would have complained about previously |
| 15:25 |
sandbergja |
Yeah, there was a part of it (tslint) that was deprecated in favor of eslint. We migrated, but apparently migrated without any rules enabled hahaha |
| 15:25 |
sandbergja |
or very few, at least |
| 15:26 |
Bmagic |
sandbergja: that bug seems to be assigned to gmcharlt, did you want it? |
| 15:27 |
sandbergja |
I think so, as long as: people are okay with it getting pullrequested, reviewed, and merged in a short timeframe |
| 15:27 |
Bmagic |
you're wanting to get it on rel_3_12? |
| 15:28 |
Bmagic |
lol, I see the last few comments... ok |
| 15:28 |
sandbergja |
The sooner the better, as far as I'm concerned. Because the longer we wait, the harder it will be to implement |
| 15:28 |
sandbergja |
So I guess I'm checking for concerns, alternative timing proposal, and/or commitments to review and merge |
| 15:28 |
sandbergja |
berick++ for reviewing it previously, by the way |
| 15:29 |
Bmagic |
What are the implications of merging? I suppose it could break the release? |
| 15:29 |
sandbergja |
just causing a ton of merge conflicts on outstanding PRs, I think |
| 15:29 |
sleary |
it will break all the other outstanding branches |
| 15:30 |
sleary |
although as eeevil pointed out in the comments, git should be able to deal with most of the conflicts |
| 15:30 |
Bmagic |
I see, so all devs need to be aware, and expect to get asked to deal with their code after the merge, like fast? |
| 15:30 |
JBoyer |
And, with all of the recent activity, we're likely at a low point in branches affected, so now's as good a time as any. |
| 15:31 |
eeevil |
well, at least be prepared to get a rebase request |
| 15:31 |
Bmagic |
JBoyer: right! |
| 15:31 |
sleary |
winter break rebase party? :) |
| 15:31 |
Bmagic |
It sounds like we need to do it during a period such as this, so lets? |
| 15:31 |
abneiman |
ain't no party like a rebase party |
| 15:32 |
shulabear |
bmagic++ sandbergja++ |
| 15:32 |
sandbergja |
Cool, I'll re-do my PR -- stay tuned. Thanks, all! |
| 15:32 |
Bmagic |
sandbergja: you wanna lead the endeavour? |
| 15:32 |
sleary |
sandbergja I'll coordinate with you on the axe rules |
| 15:32 |
sandbergja |
sleary++ # sounds good! |
| 15:33 |
terranm |
There are only 88 outstanding pullrequests right now, which is much lower than normal |
| 15:33 |
Bmagic |
sandbergja++ sleary++ |
| 15:33 |
sleary |
sandbergja++ # thanks for staying on top of linting! |
| 15:33 |
Bmagic |
thanks again sandbergja! next.... |
| 15:33 |
Bmagic |
#topic New Business - Test failures, including at least one critical regression (bug 2043437) - Jane |
| 15:33 |
pinesol |
Launchpad bug 2043437 in Evergreen "Three test failures on rel_3_12 and main" [Critical,New] https://launchpad.net/bugs/2043437 |
| 15:34 |
Bmagic |
#link https://bugs.launchpad.net/evergreen/+bug/2043437 |
| 15:34 |
sandbergja |
oh god, I have a bunch in a row :-D |
| 15:34 |
Bmagic |
yes, yes you do |
| 15:34 |
sandbergja |
we have 3 failing tests, one of which points to a major problem |
| 15:34 |
sandbergja |
tests++ # catching that before we released it to users! |
| 15:35 |
sandbergja |
specifically, the holdings view doesn't load (maybe just a missing import or something) |
| 15:35 |
terranm |
sandbergja++ tests++ |
| 15:35 |
sandbergja |
I feel pretty strongly we should take care of those before building a beta. |
| 15:35 |
mmorgan |
+1 |
| 15:35 |
sandbergja |
But I don't know that I'll have much time to look into them |
| 15:36 |
sandbergja |
Dyrcona already started looking at the perl one, and posted some notes |
| 15:37 |
Dyrcona |
When I said that I don't know how to fix the syntax error, I should have said that it's not obvious to me what's wrong. |
| 15:37 |
Bmagic |
the course reserves issue is fine because the test is bad, so we're looking at the holdingsView.spec.ts issue, and the query issue |
| 15:37 |
sleary |
we should fix the bad test since the problem is obvious, but yes |
| 15:38 |
Bmagic |
agreed on fixing the test. Should each of the three things be it's own bug so folks can claim them? |
| 15:38 |
Dyrcona |
Well, we could use a collab branch to avoid separate bugs, but I'll let the consensus decide. |
| 15:40 |
Bmagic |
I assume this pause is because everyone is reading the bug |
| 15:40 |
sandbergja |
:-) |
| 15:41 |
Bmagic |
Dyrcona: that query works on two of my test systems |
| 15:42 |
Dyrcona |
Bmagic: It blew up for me on a 3.12 vm with stock concerto and Pg 15. I tried the function by itself with different parameters. |
| 15:43 |
Bmagic |
Just the query? Not integrated in Evergreen? |
| 15:43 |
Dyrcona |
Different parameters, I mean interger array and string that should have matched. |
| 15:43 |
Dyrcona |
Just the function by itself, as well as the query I pasted. |
| 15:43 |
Dyrcona |
The query comes from the error output of the test. |
| 15:44 |
JBoyer |
Fun thing: it worked for me on eg3.11 / pg15 and broke on 3.11 / pg14. |
| 15:44 |
Bmagic |
ok, yes, it breaks on newer versions of the database |
| 15:44 |
Bmagic |
bugsquash machine throws the error |
| 15:44 |
sandbergja |
JBoyer++ |
| 15:44 |
sandbergja |
Bmagic++ |
| 15:44 |
sandbergja |
Dyrcona++ |
| 15:45 |
sandbergja |
that seems like a very good clue |
| 15:45 |
JBoyer |
I suspect it's potentially a matter of db age. the 3.11 system where it worked has been upgraded for years, the one where it failed was built fresh today. I'm not sure the pg versions matter |
| 15:45 |
Dyrcona |
I thought it might be Pg version dependent, but didn't take the time to try it on other versions. |
| 15:45 |
Bmagic |
well, I guess we can all hammer on it, first one to merge wins! |
| 15:45 |
Bmagic |
JBoyer: I was thinking it had to do with Evergreen's DB upgrade's. Not PG version |
| 15:46 |
Dyrcona |
JBoyer: You could compare the old database's implementation of pg_int_wrapper with the stock one in 3.12. A git blame might also help... |
| 15:46 |
Bmagic |
let's move this to post-meeting |
| 15:46 |
Dyrcona |
JBoyer: Gotcha. |
| 15:46 |
JBoyer |
Bmagic, +1 |
| 15:47 |
Bmagic |
#topic New Business - How can we get computers running our tests regularly again? - Jane |
| 15:47 |
eeevil |
I'll also look at the search one, later |
| 15:47 |
sandbergja |
#info for anybody wanting to run the tests, or try it out: https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa#types_of_tests |
| 15:47 |
Bmagic |
sandbergja++ |
| 15:47 |
mmorgan |
sandbergja++ |
| 15:48 |
sandbergja |
I am just feeling fired up about tests, and wanted to see if there's capacity for getting buildbot running them automatically for us, or some new solution |
| 15:48 |
Bmagic |
sandbergja: where's the buildbot now? (I've never known where that lives and who's in charge of it) |
| 15:49 |
shulabear |
sandbergja++ |
| 15:49 |
sandbergja |
no clue. Was it an EOLI server? |
| 15:49 |
abneiman |
phasefx, wasn't buildbot your project once upon a time? |
| 15:50 |
phasefx |
Dan Scott |
| 15:50 |
JBoyer |
The original buildbot was retired ages ago, back when it could still build eg on Fedora. The more recent qa tester that dropped the results in here was more recently retired from our equipment also, because I have a lot going on and it was having trouble that pushed it to the bottom of the list. |
| 15:50 |
phasefx |
but it was on the same server as the live tester |
| 15:50 |
abneiman |
ahh, the long longago |
| 15:51 |
abneiman |
I was thinking of live tester, right, thanks phasefx |
| 15:51 |
JBoyer |
Until there's time to dig myself out it may be worth exploring what GH actions can do for us |
| 15:51 |
JBoyer |
Provided it doesn't require setting up payments or anything like that. |
| 15:52 |
Bmagic |
sandbergja had something building something on GH a couple years ago? Maybe that was docs |
| 15:52 |
sandbergja |
docs and ng lint |
| 15:52 |
sandbergja |
the ng lint always passes, for reasons mentioned above hahaha |
| 15:52 |
Bmagic |
haha |
| 15:52 |
Bmagic |
not sure if we've arrived at anything I can put down as action |
| 15:53 |
sandbergja |
I can investigate getting more tests into gh actions, if there aren't concerns with tying ourselves more to that platform |
| 15:53 |
Bmagic |
#action sandbergja will investigate getting more tests into gh actions |
| 15:53 |
JBoyer |
It doesn't have to be the projects definitive home to provide a useful function, even if temporarily, |
| 15:54 |
Bmagic |
almost out of time |
| 15:54 |
Bmagic |
#topic Keep an eye out for Angular 17 / Bootstrap 5.3 upgrade blockers and note them on bug 2043490 - Stephanie |
| 15:54 |
pinesol |
Launchpad bug 2043490 in Evergreen "Angular 17 + Bootstrap 5.3 Upgrade" [Wishlist,New] https://launchpad.net/bugs/2043490 |
| 15:54 |
kmlussier |
sandbergja++ tests++ |
| 15:54 |
JBoyer |
(so long as it's still easy to run tests locally) |
| 15:54 |
Bmagic |
#link https://bugs.launchpad.net/evergreen/+bug/2043490 |
| 15:54 |
Bmagic |
sleary: go for it |
| 15:54 |
sleary |
ah! So, I went ahead and opened a bug for the next big Angular/Bootstrap upgrade, which should be less painful than the last one |
| 15:55 |
Bmagic |
sleary++ |
| 15:55 |
Bmagic |
#topic Other (eeevil) |
| 15:55 |
sleary |
I haven't looked too closely into what's involved on the Angular side, so I wanted to ask you all to keep an eye on that as you skim your news, and add comments to that bug if you find any potential blockers other than the ng-bootstrap accordion issue listed |
| 15:55 |
sandbergja |
sleary++ |
| 15:55 |
|
smayo joined #evergreen |
| 15:55 |
eeevil |
#info I've requested we keep XMPP as the default OpenSRF transport in EG main for the time being. There's no redis release of OpenSRF yet, so support is only in a side branch, and having redis be the default will make dev (especially backport-focused dev, like bug fixes) more painful because you can't just switch branches and test the code. Also, I'm not convinced that it's deeply understood by more folks than berick, and that puts a lot of pressure |
| 15:55 |
eeevil |
on him to Fix All The Things if Things need Fixing. I'm asking here for any strong objections to applying the 2 existing commits that will make that so, as it is now for rel_3_12. Barring any, I'll pick those commits into main and life will be a little simpler for all the not-testing-redis cases, for now. |
| 15:56 |
eeevil |
(separately, I think I know where the search test failure is coming from, and I'll poke at it early tomorrow) |
| 15:57 |
Bmagic |
eeevil: and when we've all installed and tested redis, then make it default? |
| 15:58 |
eeevil |
Bmagic: well, and when more-than-Bill can help work on it, ideally, but yes. "when it and we are ready" |
| 15:58 |
eeevil |
it's not something we should force Right Now, IMNSHO. but, hopefully, soon |
| 15:58 |
eeevil |
for a definition of soon somewhere between "months" and "geologic time" |
| 15:58 |
jeff |
+1 for reverting especially in light of us not having an OpenSRF 4 release that supports redis yet, and revisit / re-consensus at a near-future date |
| 15:59 |
Bmagic |
I think everyone was super excited at the hack-away and we all wanted it. But IIRC, the change to Evergreen was non-breaking |
| 15:59 |
Bmagic |
it was a few commented out config lines? |
| 15:59 |
eeevil |
and now I become a pumpkin! |
| 15:59 |
Bmagic |
eeevil++ |
| 16:00 |
jeff |
eeevil: on a related note, OpenSRF 4 before Evergreen 3.12 release, so that experimental redis support can be experimented with by using two released (and not branch/dev) versions? |
| 16:00 |
jeff |
(any objections to that last, I think I was asking) |
| 16:00 |
Bmagic |
not sure where that leaves it. Anyone object to keeping Evergreen main XMPP. I think we're keeping XMPP on Evergreen main for the time being. Just so we're clear |
| 16:01 |
eeevil |
Bmagic: that's not true today, in main. redis is the default right now |
| 16:01 |
eeevil |
as of yesterday |
| 16:01 |
eeevil |
I want to revert to xmpp, yes |
| 16:01 |
Bmagic |
got it, ok, revert is on the table - anyone want to put in their 2 cents? |
| 16:02 |
eeevil |
pumpkin time, though. sorry. I'll apply the patches, or not, based on consensus! |
| 16:02 |
Bmagic |
lata |
| 16:02 |
JBoyer |
+1 to defaulting main back to XMPP while still including the commented-out redis bits so it's easy to switch if you know what you're doing |
| 16:02 |
Bmagic |
thanks JBoyer! |
| 16:03 |
Bmagic |
sounds like a revert then. No problem. eeevil will do the honors it sounded like |
| 16:03 |
Bmagic |
#topic Announcements |
| 16:03 |
Bmagic |
#info Next Meeting is Tuesday, December 12th |
| 16:03 |
Bmagic |
#endmeeting |
| 16:03 |
pinesol |
Meeting ended Tue Nov 14 16:03:20 2023 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 16:03 |
pinesol |
Minutes: http://evergreen-ils.org/meetings/evergreen/2023/evergreen.2023-11-14-15.00.html |
| 16:03 |
pinesol |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2023/evergreen.2023-11-14-15.00.txt |
| 16:03 |
pinesol |
Log: http://evergreen-ils.org/meetings/evergreen/2023/evergreen.2023-11-14-15.00.log.html |
| 16:03 |
terranm |
Bmagic++ |
| 16:03 |
scottangel |
Bmagic++ |
| 16:03 |
mmorgan |
Bmagic++ |
| 16:03 |
JBoyer |
Bmagic, not a revert, just applying the top two commits on rel_3_12 (as of earlier today anyway) to main |
| 16:03 |
JBoyer |
and Bmagic++ |
| 16:03 |
Bmagic |
JBoyer: cool |
| 16:04 |
Bmagic |
Thanks all! |
| 16:04 |
Dyrcona |
query_int_wrapper() blows up for me on a 3.7 database on Pg 10. |
| 16:04 |
Dyrcona |
Bmagic++ |
| 16:06 |
eeevil |
Dyrcona: FWIW, and AFAICT, it's the '()' that's being calculated in the perl, not the function itself. I suspect the on_reserve() filter logic triggering that somehow, but I haven't looked ... yet. **is a pumpkin now** |
| 16:06 |
|
jihpringle joined #evergreen |
| 16:06 |
shulabear |
bmagic++ |
| 16:10 |
Bmagic |
Dycona: that's strange. Worked for me on 3.9.1 and 3.11.1, but not busquash main |
| 16:11 |
Dyrcona |
Bmagic: Are you talking about the function itself or the search test? I suspect the function has been broken since 0940, but doesn't look like it is used much. |
| 16:12 |
Bmagic |
copy/paste the query I mean |
| 16:13 |
Dyrcona |
I get a syntax error any time/any where I run the function. |
| 16:14 |
JBoyer |
yeah, query_int_wrapper does so little I'm surprised we even have it (syntax escaping simplicity if I had to guess) but sometimes passing '()' as the second param is accepted and sometimes it's a syntax error, which is weird. |
| 16:14 |
JBoyer |
It likely never should be just '()' though, which is what eeevil is referring to as an issue in the perl. |
| 16:15 |
Dyrcona |
Yeah, the whole query works on my 3.7 database, but calling the function with the same parameters doesn't. |
| 16:15 |
JBoyer |
oh, I didn't realize that. |
| 16:15 |
JBoyer |
stranger still |
| 16:20 |
Dyrcona |
select query_int_wrapper(vlist, '()') from metabib.record_attr_vector_list where source =2; <- Blows up for me, even though record 2 is in metabib.record_attr_vector_list |
| 16:20 |
Dyrcona |
Can we just replace it with the code from the function? |
| 16:22 |
Dyrcona |
select vlist @@ '()'::query_int from metabib.record_attr_vector_list where source = 2; Also produces a syntax error at the text value '() |
| 16:23 |
eeevil |
I wish I weren't orange right now ... TL;DR: no, we can't (without testing that we don't need it anymore -- and there were reasons) |
| 16:24 |
Dyrcona |
eeevil: It's used in only 1 place AFAICT. |
| 16:24 |
Dyrcona |
I've tried a few variations: '{}' also fails but null works. |
| 16:25 |
eeevil |
Dyrcona: yes, and that 1 place is important. more later, though |
| 16:26 |
Dyrcona |
Well, I was thinking of just using the code the function runs and not the function.... Maybe the Perl should pass null instead of an empty array when there's nothing to compare to? |
| 16:26 |
eeevil |
the function is needed. for reasons. will explain later |
| 16:26 |
* kmlussier |
refocused her attention to IRC just when eeevil said he was orange and is now more confused than ever. |
| 16:26 |
Dyrcona |
OK. |
| 16:34 |
Dyrcona |
I suppose we'll have to look into this more some other time.. |
| 16:45 |
eeevil |
I'm transforming back into pure eeevil, leaving my pumpkin state behind! |
| 16:45 |
eeevil |
and, https://bugs.launchpad.net/evergreen/+bug/1438136/comments/12 |
| 16:45 |
pinesol |
Launchpad bug 1438136 in Evergreen 2.8 "OPAC searching significantly slowed by adding format filters" [High,Fix released] |
| 16:45 |
eeevil |
that's why we have query_int_wrapper, and what we need to test before we stop trying to use it. |
| 16:45 |
eeevil |
HOWERVER |
| 16:46 |
eeevil |
that's not the problem here, regardless. the problem here is that we should never be sending an effectively-empty query_int (that is, and int array query "thing") to the database |
| 16:47 |
eeevil |
that clause is a question of the data, but the question being asked is empty in this case. we need to elide the clause altogether |
| 16:48 |
eeevil |
which we normally do (you don't always see a query_int clause either direct or via query_int_wrapper), but something is convincing us to generate an empty query_int at the perl level |
| 16:49 |
eeevil |
I suspect an interaction with the new on_reserve() filter, but mostly because it's new and not because I can point to a problem with it |
| 16:54 |
Dyrcona |
Well, that's somewhere to start. I was thinking of resorting to git bisect. I can take a look tomorrow morning, probably. |
| 16:55 |
Dyrcona |
Anyway.... I'll turn into a pumpkin now..... |
| 17:11 |
|
kmlussier left #evergreen |
| 17:16 |
|
mmorgan left #evergreen |
| 17:29 |
pinesol |
News from commits: LP2041431 EG 3.12 Docs for OpenSRF+Redis configs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4110464fdc104dad109de6694eb741797bb199c9> |
| 17:29 |
pinesol |
News from commits: LP2041431 EG opensrf_core.example for Redis; defaults to Ejab. <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9c2bb90b59d85fc438ff3f6270f823d80e2a30af> |
| 17:31 |
|
sleary joined #evergreen |
| 18:17 |
eeevil |
^- that's me, making XMPP the default on the main branch, for now |
| 18:20 |
|
Rogan joined #evergreen |
| 18:29 |
pinesol |
News from commits: LP1920230 Localize staffcat items, holds, copy count <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1b2cca5225dcf4a5f419f275a162e30e43cf29fb> |
| 18:41 |
|
sandbergja joined #evergreen |
| 18:54 |
|
csharp_ joined #evergreen |
| 18:57 |
|
jihpringle joined #evergreen |
| 18:59 |
pinesol |
News from commits: LP1947906 Remove spellcheck="false" on MARC inputs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=68564c4e7029ceae0ca2f52c7b87c082b7bfb676> |
| 19:29 |
pinesol |
News from commits: LP2043424 Button for clipboard dialog action <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bff2a297d79797b529d366d2f88cce0d93aa4419> |
| 19:29 |
pinesol |
News from commits: LP2043134 Fix match set expression form button size <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f2db0cb826e991f1b8f935ab1b79b6c0613bed5d> |
| 19:29 |
pinesol |
News from commits: LP2023579 - Fix for renaming new statistical catergories editor <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9f036f4f2e2b4e26ccf5ff89cd39d1efe4a8dc2e> |
| 19:29 |
pinesol |
News from commits: LP2023579 - Fix for renaming new statistical catergories editor <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=00146ac6de99b6b23e8877b8879cf2f2fcb2da0f> |
| 19:29 |
pinesol |
News from commits: LP2043421 ARIA labels for date, datetime selects <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3c7134cc686a947308c7f74ec3e46700a1e5ce53> |
| 19:59 |
pinesol |
News from commits: LP2015163 Force MARC fixed field layout refresh <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a75ff5fd1d238eb6641b88c8b0a576a295d71bb8> |
| 20:10 |
|
sleary joined #evergreen |
| 20:25 |
|
akilsdonk joined #evergreen |
| 21:34 |
|
sleary joined #evergreen |
| 23:23 |
|
sleary joined #evergreen |
