| Time |
Nick |
Message |
| 09:01 |
|
sleary joined #evergreen |
| 09:49 |
|
terranm joined #evergreen |
| 10:00 |
|
sleary joined #evergreen |
| 10:22 |
csharp_ |
claiming 1389 |
| 10:43 |
pinesol |
News from commits: LP#2016188: avoid EDIWriter error when PO ordering agency has no mailing address <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=de72a3dda6b2931adbb91ea7b65982f3b9dd6146> |
| 10:43 |
pinesol |
News from commits: LP#1930753: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c274805fec8aaaa76063b274a7ddc1292ad75f77> |
| 10:43 |
pinesol |
News from commits: LP1930753 ACQ provider buyer san override option <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8b46f813dcc9c13c8c2e645fd920e5b79d83bebd> |
| 10:43 |
csharp_ |
berick++ jeffdavis++ #EDI fixes |
| 11:02 |
|
sandbergja joined #evergreen |
| 11:04 |
|
briank joined #evergreen |
| 11:38 |
|
terranm2 joined #evergreen |
| 11:43 |
pinesol |
News from commits: LP2040186 Survey Q&A button colors and input labels <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4edae0c4be27d2e4adb822542696ad546b9c02e3> |
| 12:13 |
pinesol |
News from commits: LP2037685 - Staff Catalog: Default Search and Preferred Library settings are deleted... <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bcbb33a5fa97aff70f81f27cd16b0e18144323f6> |
| 12:18 |
abneiman |
anyone have some test love to show to https://bugs.launchpad.net/evergreen/+bug/1999158 ?? It's a needed a11y fix and is currently on https://terran-main.gapines.org/ |
| 12:18 |
pinesol |
Launchpad bug 1999158 in Evergreen 3.11 "Labels for eg-org-select combobox" [Medium,Confirmed] |
| 12:33 |
|
eby joined #evergreen |
| 14:05 |
|
terranm joined #evergreen |
| 15:00 |
|
sandbergja joined #evergreen |
| 15:02 |
JBoyer |
terranm++ This week really didn't end up working out for me at all but it looks like some good stuff has been done. |
| 16:04 |
terranm |
sandbergja and I are both working on getting more of the tested things committed too, so I think 3.12 is going to have a lot of stuff in it |
| 16:27 |
abneiman |
terranm++ sandbergja++ |
| 16:27 |
abneiman |
I've also put bugs (pun absolutely intended) in some other committer ears, too |
| 16:38 |
sleary |
terranm do you know if bug 1934018 is still on one of the testing servers? I think it was on the spreadsheet but got lost in the shuffle |
| 16:38 |
pinesol |
Launchpad bug 1934018 in Evergreen "Angular Staff Catalogue: More Link Missing from Facets" [High,Confirmed] https://launchpad.net/bugs/1934018 |
| 16:39 |
|
jweston joined #evergreen |
| 16:41 |
terranm |
sleary no, it's not on one of them right now |
| 16:44 |
pinesol |
News from commits: LP2035535: Add accessibility tests to nightwatch <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=74a240914ca86fa06d169b3928e57352156b7171> |
| 16:44 |
pinesol |
News from commits: LP#2033067 The "prev" and "next" navigation buttons in carousels are not translated. <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=632aca33848e7415d5b008c000c8cc432bbd6e54> |
| 16:44 |
pinesol |
News from commits: LP1908568: double-click item to open editor <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8fba1be55ba291c2deb44604ed0fb8dc2539875f> |
| 17:00 |
berick |
grabbing 1390 |
| 17:14 |
pinesol |
News from commits: LP#2035389: Don't use locg to determine whether course reserves links display in... <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e4288874c5ba6bbf6004f8fba038549d4d58d511> |
| 17:14 |
pinesol |
News from commits: LP#2037128: release note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f5ea0711e36254d03bfab8bb49f141320192f8e4> |
| 17:14 |
pinesol |
News from commits: LP#2037128 Print Selected Rows on Grids <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6c1b8246d39e02aca7cdee0cd66d794a8eea53dc> |
| 17:14 |
pinesol |
News from commits: LP1993815 DB Stamp: Ang Custom Org Trees <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b3958d4c4fcd6c3442193c30884840e3803767f4> |
| 17:14 |
pinesol |
News from commits: LP1993815 Comment out debug console messages <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=32f70ad1d323747925381c08ed7302b9f0077447> |
| 17:14 |
pinesol |
News from commits: LP1993815 follow-up: button styling <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=df5a2dd33334f25940e00ce15b3fc3f7d66e8072> |
| 17:14 |
pinesol |
News from commits: LP1993825 follow-up: fix incorrect aria-label and add more instructions <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c70961428f1cc02f7737c4553edc7a0452fb0e0a> |
| 17:14 |
pinesol |
News from commits: LP1993825 angular custom ou tree interface <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=367df842f905503be2d50e2a45f5c47e024942b8> |
| 17:14 |
pinesol |
News from commits: ARIA for eg-tree <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=809032def4cf905b5845218e4a2645fefe277ec8> |
| 17:14 |
pinesol |
News from commits: Icons and ARIA for buttons <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=201180fddf3e5dd292c14a81ae35c70733029db6> |
| 17:14 |
pinesol |
News from commits: LP1993825 angular custom ou tree interface <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=25662c7476496f69b004a44b315b639995a639e2> |
| 17:14 |
pinesol |
News from commits: LP1993825 angular custom ou tree interface <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ce215e58c3c64b0b7a34e06f13c23702d5b14fe6> |
| 17:21 |
jeffdavis |
So many commits! :D |
| 17:23 |
sleary |
I think we forgot to squash custom OU trees :D |
| 17:23 |
terranm |
:) |
| 17:42 |
sandbergja |
Claiming 1391 |
| 17:44 |
pinesol |
News from commits: LP2016343 Updated aria-describedby for item table <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=72bb8b5b063326095036523a995f064b8dc233d9> |
| 17:44 |
pinesol |
News from commits: LP2016343 aria-describedby for item table links <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=76040618b7d5ad4aa3dabe12fe927faf58e68244> |
| 17:44 |
pinesol |
News from commits: LP1187993 Space out suggestion term and class <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=38f1e347587e90bead53065775cfe05afeaeb4a6> |
| 17:44 |
pinesol |
News from commits: lp1187993: Replace dojo autocomplete with accessible autocomplete <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8d150e9c44dc5b850aaa51d7d77c623f07ac8b56> |
| 17:44 |
sleary |
sandbergja++ that autosuggest bug was the oldest open accessibility bug by FAR |
| 17:44 |
terranm |
woo! |
| 17:45 |
terranm |
Only 3,110 Launchpad tickets to go.... |
| 17:45 |
sleary |
:D |
| 17:46 |
sandbergja |
we can do it! |
| 17:46 |
sandbergja |
sleary++ |
| 17:46 |
sandbergja |
terranm++ |
| 17:47 |
sandbergja |
berick++ |
| 17:48 |
terranm |
sandbergja++ |
| 17:49 |
sandbergja |
Just typed `git checkout rel_3_100` by mistake hahaha |
| 17:50 |
sleary |
nooooooo |
| 17:57 |
sleary |
what's the best status for an old i18n bug that got fixed by something else? invalid, wontfix...? |
| 17:57 |
sleary |
or duplicate, I guess |
| 18:00 |
sandbergja |
I like duplicate for those personally |
| 18:02 |
sleary |
sandbergja++ |
| 18:02 |
|
Rogan joined #evergreen |
| 18:05 |
sandbergja |
Is there a best practice for upgrade scripts that update big long template strings (in this case, action_trigger.event_definition.template)? It seems good not to overwrite any customizations folks may have made to the template, but UPDATE action_trigger.event_definition SET template = HUGE_STRING WHERE template = HUGE_STRING_THAT_IS_ONLY_A_LITTLE_DIFFERENT seems verbose and unclear... |
| 18:06 |
sandbergja |
(bug 1909585 is the one I had in mind with this question) |
| 18:06 |
pinesol |
Launchpad bug 1909585 in Evergreen "Download CSV for Lists doesn't include full title" [Medium,Confirmed] https://launchpad.net/bugs/1909585 |
| 18:08 |
sleary |
if Rogan is around, that's an excellent question for him |
| 18:14 |
pinesol |
News from commits: LP1818912: stamp upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=110c6485248bad77f59fe762da8d4142d4d05d59> |
| 18:14 |
pinesol |
News from commits: LP#1818912: Single Day Emergency Closings Fail to Update Due Dates <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e1f0dead227d749d99e0aacbcbf13e65940932bf> |
| 18:24 |
sandbergja |
I reached 200 bugs reported by me in launchpad today! |
| 18:24 |
sandbergja |
I wonder who has reported the most. |
| 18:26 |
terranm |
Wow! |
| 18:27 |
terranm |
I have 154 |
| 18:30 |
sleary |
only 32... |
| 18:30 |
* sleary |
rolls up sleeves |
| 18:30 |
sandbergja |
:-D |
| 18:32 |
terranm |
sleary++ to be fair, you've also fixed most of the ones you've reported, so... |
| 18:33 |
sleary |
terranm I think I've fixed more than I've opened, which I will try to maintain |
| 18:34 |
sleary |
I will try to keep a closer eye on the i18n tag. Some of those are embarrassingly small. |
| 18:44 |
sandbergja |
Hey Evergreeners: a note that the release team decided to push the feature freeze deadline to Monday (the 13th). So please continue pushing great features until end of day (however you and your timezone define that) Monday. |
| 18:44 |
pinesol |
News from commits: LP#2040336 Prevent Duplicate Brief Records on Double Click <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7b7cc995aaca30de4cbb3848a568698017f80d97> |
| 18:44 |
sleary |
sandbergja++ |
| 19:04 |
|
terranm92 joined #evergreen |
| 19:12 |
jeff |
sandbergja: I don't know that we have a best practice on that, but it would be good to develop one. I thikn it would result in fewer template changes being omitted / left as an exercise to the admins. |
| 19:12 |
jeff |
thoughts: |
| 19:13 |
jeff |
we should try to update stock templates without overwriting customized templates. |
| 19:14 |
pinesol |
News from commits: LP1939309 Bootstrap OPAC - Only Display Current Addresses <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=07d57f1573378fb76ae2c3f1be33da39a65e2fda> |
| 19:14 |
jeff |
updating customized templates is complicated and might be too complicated to try and attempt, but at least warning / reporting on the fact that you might want to review things would be great. |
| 19:15 |
jeff |
(that can be covered in release notes, but even better if we could call attention to it when we see it, other than "check these manually") |
| 19:15 |
jeff |
that's a slight tangent. |
| 19:16 |
jeff |
focusing on the "update stock templates automatically but try to do it in a way that doesn't require having the ENTIRE previous template in the WHERE clause of the UPDATE statement can be solved with MD5(). |
| 19:17 |
sandbergja |
oh, interesting! jeff++ |
| 19:18 |
jeff |
something like UPDATE action_trigger.event_definition SET template = 'big long string probably escaped with dollar quotes' WHERE id = 123 AND MD5(template) = '120bc18f0fedeb6d40768c19c8c5ea47'; |
| 19:18 |
jeff |
or even AND MD5(template) IN ('120bc18f0fedeb6d40768c19c8c5ea47', '5dac3fcf780014e099908195d3c993a6') |
| 19:18 |
sandbergja |
I like that a lot. |
| 19:19 |
jeff |
you can even add a comment next to the strings to identify which version of the template you're referring to. |
| 19:20 |
jeff |
most of the other approaches that I can think of involve/require us changing the schema to accommodate other techniques (which still might be a good idea down the road) |
| 19:22 |
sandbergja |
jeff++ |
| 19:30 |
jeff |
in gneral, I favor extra effort in the upgrade script to make admin/user lives easier. it's a little more friendly than "remember to check these things by hand after the upgrade". |
| 19:44 |
pinesol |
News from commits: Docs LP2038779: Carousel docs list the wrong admin screen for Carousel Library Mapping <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ee7b8ed00fa3bfbbeea5f6744196bac2e79d821e> |
| 19:45 |
|
terranm joined #evergreen |
| 19:46 |
terranm |
jeff++ for the tip on 1909585 - I'll try that! |
| 20:01 |
jeff |
since bug 2017673 has me thinking about copy alerts on this fine evening: |
| 20:01 |
pinesol |
Launchpad bug 2017673 in Evergreen "Wishlist: Copy/Item Alerts Type Default" [Wishlist,Confirmed] https://launchpad.net/bugs/2017673 |
| 20:03 |
jeff |
1) we'd been thinking of making "default item alert" an org unit setting. now that it will be a workstation setting, does a new bug to make it an org unit setting also still make sense? |
| 20:03 |
jeff |
I guess I need to refresh my memory on how you can override / default workstation settings to help me decide there also. |
| 20:05 |
jeff |
and 2) we ended up migrating legacy item alerts to a single alert type, not two identical alerts (one checkin alert, one checkout alert). I'm wondering if others did similar. |
| 20:05 |
jeff |
and if it makes sense to have a stock item alert type that isn't "checkin" or "checkout". |
| 20:06 |
jeff |
we've also been tempted to populate the old alert message column on asset.copy, either at the database level or in the IDL or in some way to better surface the content of alert messages... |
| 20:07 |
jeff |
I've probably mentioned that before. |
| 20:08 |
jeff |
I suspect that others might use copy alert messages in ways that are quite different from how we use them, since the new stock behavior is so different from what we want, or think we want. |
| 20:14 |
pinesol |
News from commits: LP1804066: Don't allow overlapping bookings <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=152c23716f4e609319c6dd511added8e600868f4> |
| 20:14 |
pinesol |
News from commits: LP#1477154-Placing holds fails unintuitively when preferred pickup location is disabl... <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=fc18c155580c7a82b2ff5b22621d27e1fb000d25> |
| 20:44 |
pinesol |
News from commits: LP2042492 ARIA labels for MARC search tab +/- icons <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5a59ae9ca9fd07dcbc76c34534b279d39c7485f4> |
| 20:44 |
pinesol |
News from commits: LP1934018 Restore 'more' link for staff cat facets <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=79f1ec3a941ce29e041253a47b6921bdcc86bf91> |
| 20:44 |
pinesol |
News from commits: LP#1919501 Button in Patron Messages interface in OPAC are not translatable <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=51a4eb9ae6f8149053914bae3bc053b9086447c3> |
