Time |
Nick |
Message |
02:10 |
|
sleary joined #evergreen |
07:08 |
|
kworstell-isl joined #evergreen |
07:40 |
|
collum joined #evergreen |
08:13 |
|
BDorsey joined #evergreen |
08:36 |
|
mmorgan joined #evergreen |
08:56 |
|
Dyrcona joined #evergreen |
08:57 |
|
mantis joined #evergreen |
09:13 |
|
rfrasur joined #evergreen |
09:26 |
|
kworstell_isl joined #evergreen |
10:00 |
|
sleary joined #evergreen |
10:34 |
sharpsie |
berick++ # CHOMP |
10:36 |
sharpsie |
ᗧ ---------- |
11:13 |
sharpsie |
@blame action triggers |
11:13 |
pinesol |
sharpsie: action triggers is why we can never have nice things! |
11:14 |
sharpsie |
@decide action or trigger |
11:14 |
pinesol |
sharpsie: go with action |
11:14 |
sharpsie |
@band add Go With Action |
11:14 |
pinesol |
sharpsie: Band 'Go With Action' added to list |
11:16 |
berick |
oddly they only play downtempo shoegaze |
11:18 |
Dyrcona |
@blame [band] |
11:18 |
pinesol |
Dyrcona: everything was going great until Sisyphean Treadmill came along |
11:18 |
Dyrcona |
@praise [band] |
11:18 |
* pinesol |
Nerf Arms Dealer can run a report without assistance |
11:19 |
Dyrcona |
@praise sharpsie |
11:19 |
* pinesol |
sharpsie goes to eleven |
11:21 |
Dyrcona |
@praise berick |
11:21 |
* pinesol |
berick LOVES the RESISTANCE! |
11:22 |
sharpsie |
@blame [band] for [praise [someone]] |
11:22 |
* pinesol |
THE OPAC crafted the perfect SHA-1 collision, breaking Git for scottangel goes to eleven |
11:22 |
berick |
almost a sentence |
11:22 |
sharpsie |
I didn't remember someone adding THE OPAC as a band name, but I'm finding that pretty funny right now |
11:23 |
berick |
@band add Angel Goes To Eleven |
11:23 |
pinesol |
berick: Band 'Angel Goes To Eleven' added to list |
11:23 |
sharpsie |
@eightball was it [someone]? |
11:23 |
pinesol |
Yes! |
11:23 |
Dyrcona |
@band search OPAC |
11:23 |
pinesol |
Dyrcona: THE OPAC |
11:23 |
sharpsie |
This Monkey's Gone to 11 |
11:23 |
berick |
heh |
11:23 |
Dyrcona |
I thought that would say who added it. |
11:23 |
Dyrcona |
@who added it? |
11:23 |
pinesol |
abneiman added it. |
11:24 |
sharpsie |
@eightball will we ever know? |
11:24 |
pinesol |
sharpsie: It shall be. |
11:30 |
|
Christineb joined #evergreen |
12:07 |
jeff |
csharp added it, 2020-08-04 |
12:08 |
Dyrcona |
jeff: Did you check the database or the IRC logs? |
12:09 |
jeff |
yes. |
12:09 |
jeff |
for context: http://irc.evergreen-ils.org/evergreen/2020-08-04#i_452959 |
12:09 |
Dyrcona |
:) |
12:47 |
sharpsie |
huh - I guess I thought it was funny then too :-) |
12:49 |
Dyrcona |
sharpsie: Is this your new nick, or are you just playing around with it for a few days? |
14:20 |
mmorgan |
berick++ |
14:23 |
Bmagic |
when adding a table or column to Evergreen, do we need to edit the corresponding stuff in: perlmods/lib/OpenILS/Application/Storage/CDBI ? I thought the fm_IDL.xml was the glue/map for all tables/columns? |
14:24 |
Dyrcona |
Bmagic: If you want to get at it through Storage/Publisher, you do. |
14:31 |
Bmagic |
interesting. I'm not sure this patch makes a call using that stack. does CStoreEditor go there? I'm not seeing it |
14:31 |
berick |
Bmagic: no |
14:31 |
berick |
only open-ils.storage |
14:31 |
Dyrcona |
open-ils.storage uses it directly. Some backend calls use open-ils.storage internally. |
14:32 |
Bmagic |
ok that's helpful |
14:32 |
Dyrcona |
I would probably add it anyway, but I'm sure we've added some new fields and forgotten to add them to storage and things still work. |
14:33 |
Bmagic |
Right, it's sparsly populated. Which is why I questioned adding stuff there. It seemed like it only needed to be defined for a nuanced reason |
14:34 |
Bmagic |
I'm reviewing https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=a21d4371adb25b772943f7e1944e7a420998c921 |
14:36 |
Dyrcona |
Just glancing at it, that commit messages needs to be edited. I can't tell what it is trying to do. It focuses too much on how, not enough on what or why. |
14:37 |
Dyrcona |
Bmagic: Is there a Lp bug for that? |
14:39 |
Bmagic |
I'm 99% sure this patch doesn't need to edit CDBI/* nor Driver/Pg/* |
14:39 |
Bmagic |
Dyrcona: it's not ready for LP yet |
14:39 |
Bmagic |
and yeah, among other things, the commit message won't be that |
14:42 |
Dyrcona |
it probably doesn't since it is the only code using the new objects/fields. I would, however, recommend adding them to storage for future adaptation. |
14:44 |
Bmagic |
ok, seems reasonable |
14:44 |
Dyrcona |
That said, I'm most likely guilty of having added fields, etc., without messing with storage. |
14:45 |
Dyrcona |
it's an easy thing to forget. |
14:48 |
Bmagic |
There's a lot missing. If we ever wanted to mirror reality |
14:49 |
Dyrcona |
I'm not surprised. Maybe it isn't worth adding this to storage? |
14:49 |
|
sleary joined #evergreen |
14:50 |
Dyrcona |
I should start working on that email about some possibilities for the future. We could clean things like this up along the way. |
14:54 |
|
mmorgan1 joined #evergreen |
15:01 |
|
mantis left #evergreen |
15:19 |
sharpsie |
Dyrcona: gonna wear the nick for a while to see how it feels :-) |
15:19 |
Dyrcona |
sharpsie++ |
15:31 |
Dyrcona |
sharpsie: FWIW, I think it's a cool nick. |
15:50 |
sharpsie |
Dyrcona: thanks! |
15:50 |
* sharpsie |
blushes |
15:50 |
sharpsie |
I always liked denials (dbs's alt nick) because it was a pun on his name |
15:52 |
Dyrcona |
Yeahp. |
17:03 |
|
bgillap joined #evergreen |
17:10 |
|
mmorgan1 left #evergreen |