| Time |
Nick |
Message |
| 08:00 |
|
rfrasur joined #evergreen |
| 08:41 |
|
mmorgan joined #evergreen |
| 08:56 |
|
Dyrcona joined #evergreen |
| 10:28 |
pinesol |
News from commits: LP1889916 SMS Carrier does not include region in borrower edit screen <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e0d8247cb29b95b037c0c11aeaaaad9c1606e8a7> |
| 10:39 |
|
Stompro joined #evergreen |
| 10:46 |
Stompro |
EDI questions for you all, we had a split order, where B&T shipped 1 of 2 items, and then shipped the other one 3 weeks later. When Evergreen processed each of the EDI invoices, it picked the same line item detail record for each one. So one of the items still says backordered even though we have physically received both items. I looked for a related bug report but couldn't find one. |
| 10:51 |
|
rfrasur_ joined #evergreen |
| 10:53 |
|
rfrasur__ joined #evergreen |
| 10:54 |
|
rfrasur joined #evergreen |
| 11:55 |
|
dtmoore joined #evergreen |
| 12:38 |
Dyrcona |
mmorgan: Can I ask you two questions in private? They're Evergreen and Comcat-related. |
| 12:38 |
mmorgan |
Dyrcona: Sure! |
| 13:02 |
Dyrcona |
mmorgan++ # Thanks for answering my questions about specific auto-renewal policy and a specific comcat item from a CW MARS library! |
| 14:21 |
|
mmorgan1 joined #evergreen |
| 14:22 |
Stompro |
I found the answer to my EDI question, Bug #1933859 |
| 14:22 |
pinesol |
Launchpad bug 1933859 in Evergreen "Invoices with mixed status line item details can leave hanging encumbrances" [Undecided,Confirmed] https://launchpad.net/bugs/1933859 |
| 15:47 |
|
sleary joined #evergreen |
| 16:11 |
Stompro |
Is there a way to re-process an edi message from acq.edi_message data? |
| 16:15 |
Stompro |
It looks like edi_fetcher.pl does have some options for reading local data. |
| 16:19 |
|
rfrasur joined #evergreen |
| 16:59 |
|
sandbergja joined #evergreen |
| 16:59 |
|
mmorgan1 left #evergreen |
| 16:59 |
sandbergja |
sleary++ # your comment on bug 2015592 |
| 16:59 |
pinesol |
Launchpad bug 2015592 in Evergreen "In web client, indicate when a link opens in a new tab" [Undecided,New] https://launchpad.net/bugs/2015592 |
| 17:01 |
sleary |
sandbergja Thank you for filing the new accessibility bugs! And for looking into bug 1187993 ; that one has haunted me but my time has mostly been committed elsewhere :( |
| 17:01 |
pinesol |
Launchpad bug 1187993 in Evergreen "Auto suggest causes significant accessibility issues for using basic search in some browsers" [High,Confirmed] https://launchpad.net/bugs/1187993 - Assigned to Jane Sandberg (sandbergja) |
| 17:03 |
sandbergja |
ooh yeah.:-) . I'm studying for an accessibility certification exam, and using Evergreen as a guinea pig as I'm studying. :-) |
| 17:03 |
sleary |
ooooh, let me know how it goes! |
| 17:04 |
sandbergja |
will do! |
| 17:06 |
sleary |
I left the reading list out of my Spotlight since it wasn't dev-focused, but if you have access to books published by Smashing Magazine, Heydon Pickering has three on accessible components, and Adam Silver's Form Design Patterns is great. |
| 17:08 |
sandbergja |
Thank you! Good to know! I will take a look. |
| 17:09 |
sleary |
Also, this week I learned there is a whole book about ARIA! Although they use divs instead of buttons to toggle things in their examples and it's driving me nuts. But other than that, it's very good. https://pressbooks.library.torontomu.ca/wafd/ |
| 17:28 |
|
rfrasur_ joined #evergreen |
| 17:34 |
Bmagic |
getting a compile error from ng build for file prompt.component.ts: closeAndClear(value?: any) |
| 17:41 |
sandbergja |
What branch is this on, Bmagic? |
| 17:44 |
Bmagic |
I was just hunting down the commit. I thought it was on master because the last time that file was edited was 2021... but I think it's part of a patch that has old commits |
| 17:45 |
Bmagic |
found it: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=blobdiff;f=Open-ILS/src/eg2/src/app/share/dialog/prompt.component.ts;h=4db0896b6fcdf663bc5f9df02591362bb4108439;hp=a5d8ecab9019530d710682fd2e535ed56281776e;hb=e365c462ea6aad5bc228a2234614f50eda9a66cf;hpb=4ea37d23be0456f950b9ce3a9a05a3e798688147 |
| 17:45 |
Bmagic |
is that syntactically sound? |
| 17:46 |
Bmagic |
it's part of this patch: https://bugs.launchpad.net/evergreen/+bug/1981712 |
| 17:46 |
pinesol |
Launchpad bug 1981712 in Evergreen "wishlist: SIP redaction" [Wishlist,Confirmed] - Assigned to Jason Etheridge (phasefx) |
| 17:51 |
sandbergja |
it sure seems like it would be fine... Could there have been a merge conflict gone wrong? I noticed that it doesn't cherry-pick cleanly onto master, since another method got added to that class in the meantime. |
| 17:54 |
Bmagic |
I'll admit, I had to do some merge conflict resolution, that's probably where it went off |
| 17:54 |
sandbergja |
I'm able to get an error like that if the preceding ngOnInit is missing a curly brace at the end, fwiw |
| 17:56 |
sandbergja |
Good luck git spelunking! |
| 17:56 |
Bmagic |
ty! |
| 17:57 |
Bmagic |
sandbergja++ |
