| Time |
Nick |
Message |
| 07:49 |
|
BDorsey joined #evergreen |
| 08:07 |
|
collum joined #evergreen |
| 08:09 |
|
kworstell-isl joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:38 |
|
Dyrcona joined #evergreen |
| 08:55 |
|
rfrasur joined #evergreen |
| 09:15 |
mmorgan |
Recycling this from yesterday: Is there a trick to running ng lint that I'm missing? I'm looking at bug 1988321 where sandbergja notes that the branch in comment 1 doesn't pass ng lint, but I don't see a failure. |
| 09:15 |
pinesol |
Launchpad bug 1988321 in Evergreen "cover image uploader generic error even with success" [Undecided,Confirmed] https://launchpad.net/bugs/1988321 |
| 09:16 |
Dyrcona |
mmorgan: Are looking at collum's branch or csharp_'s? |
| 09:17 |
Dyrcona |
Are [you] looking at.... |
| 09:18 |
mmorgan |
Dyrcona: I ran ng lint on both phasefx's branch and csharp_'s branch. |
| 09:19 |
mmorgan |
On master built on 2/3/23 |
| 09:19 |
Dyrcona |
Maybe the branch was not the cause of the ng lint failure. I don't know if I'll have time to take a look, and I don't really know much about Angular at this point. |
| 09:20 |
Dyrcona |
I doubt that there is any trick to running ng lint, though. |
| 09:32 |
mmorgan |
Dyrcona: Ok, thanks! |
| 09:32 |
mmorgan |
Dyrcona++ |
| 10:35 |
csharp_ |
just filed bug 2006749 - Library Settings Editor is broken |
| 10:35 |
pinesol |
Launchpad bug 2006749 in Evergreen "Angular Library Settings Editor view perms check is broken" [High,New] https://launchpad.net/bugs/2006749 |
| 10:36 |
csharp_ |
return undef unless ou_ancestor_setting_perm_check($orgid, $coust, $auth) always returns undef because it appears that the params being passed are in the wrong order |
| 10:36 |
csharp_ |
they are positional, right? |
| 10:36 |
Dyrcona |
Yeah. They are. |
| 10:37 |
Dyrcona |
Perl doesn't support named parameters outside of some arry/hash tricks. |
| 10:37 |
Dyrcona |
a/arry/array/ |
| 10:38 |
csharp_ |
I'm confused about how $e is passed in some of the other subs in that file - is it one that is somehow named? |
| 10:38 |
csharp_ |
I haven't done much with passing CStoreEditor objects around |
| 10:38 |
Dyrcona |
What file is that? |
| 10:38 |
csharp_ |
AppUtils.pm |
| 10:38 |
csharp_ |
OpenILS/Application/AppUtils.pm |
| 10:39 |
Dyrcona |
What line are you specifically talking about with the error above? |
| 10:40 |
csharp_ |
line 1300 is where the sub that calls the other sub is |
| 10:40 |
csharp_ |
1321 is the call |
| 10:41 |
csharp_ |
the sub it's calling is just below |
| 10:41 |
csharp_ |
@who all lives in a Yellow Sub? |
| 10:41 |
pinesol |
jmurray-isl all lives in a Yellow Sub. |
| 10:41 |
Dyrcona |
I'll take a look in a minute. Usually $e is either passed into the sub or if it's null, a new one is created in AppUtils.pm. |
| 10:41 |
csharp_ |
ok - thank you! |
| 10:41 |
* csharp_ |
goes off in search of unsweet tea |
| 10:41 |
Dyrcona |
I'm assuming this is with 3.10? |
| 10:42 |
csharp_ |
Dyrcona: yes, but it's in master too |
| 10:42 |
csharp_ |
it supports the Angular-ized Library Settings Editor |
| 10:42 |
Dyrcona |
OK. I gathered. |
| 10:46 |
|
rfrasur joined #evergreen |
| 10:58 |
|
dguarrac joined #evergreen |
| 11:08 |
Dyrcona |
csharp_: yeah, line 1321 has a couple of things wrong with it. |
| 11:10 |
Dyrcona |
I'll make a branch before lunch. |
| 11:12 |
csharp_ |
Dyrcona: that's excellent - thank you |
| 11:13 |
Dyrcona |
csharp_: Do you know if 3.9 is affected? (I can check, but it would save me some time.) |
| 11:14 |
csharp_ |
I'll look |
| 11:15 |
|
Christineb joined #evergreen |
| 11:15 |
Dyrcona |
I think I would have rearranged the order of the arguments, too. I would have $auth before $e, but I won't change that now. |
| 11:18 |
csharp_ |
Dyrcona: just 3.10+ looks like |
| 11:19 |
Dyrcona |
OK. Thanks! |
| 11:19 |
csharp_ |
that was surprisingly hard to figure out - release notes were no help unless I'm utterly missing something |
| 11:19 |
csharp_ |
resorted to git blame and looking up the bug number - bug 1839341 |
| 11:19 |
pinesol |
Launchpad bug 1839341 in Evergreen "Port Local Admin Org Unit Settings UI to Angular" [Wishlist,Fix released] https://launchpad.net/bugs/1839341 |
| 11:20 |
csharp_ |
I'll link that on the new bug for reference |
| 11:20 |
Dyrcona |
OK. I was about to git blame the file, but now I don't have to. :) |
| 11:27 |
Dyrcona |
csharp_: working/user/dyrcona/lp2006749-fix-apputils-perm-check |
| 11:27 |
csharp_ |
Dyrcona: awesome - I'll try it now |
| 11:27 |
* Dyrcona |
has to get used to typing bug numbers that start with 2..... |
| 11:28 |
|
jihpringle joined #evergreen |
| 11:29 |
* mmorgan |
doesn't see that the angularization of the ou setting interface made it into release notes either :-( |
| 11:33 |
csharp_ |
hummmm still not showing up :-/ |
| 11:33 |
csharp_ |
I'll work on it |
| 11:33 |
csharp_ |
mmorgan: noticed that - unfortunate :-/ |
| 11:34 |
|
rfrasur joined #evergreen |
| 11:38 |
Dyrcona |
csharp_: Something else wrong with that line that I missed. It should $coust->view_perm and not $coust. It might also have to be $coust->view_perm->id. |
| 11:38 |
Dyrcona |
You want me to change it and force push or do you want to add a commit on top and push to a collab branch? |
| 11:41 |
Dyrcona |
Yeah, I think it needs to $coust->view_perm->id.... |
| 11:42 |
Dyrcona |
Apparently I can't "be" today.... |
| 11:42 |
Dyrcona |
b |
| 11:42 |
Dyrcona |
oops. wrong window... :) |
| 11:44 |
Dyrcona |
csharp_: I force pushed the changes. |
| 11:50 |
Dyrcona |
No, id isn't correct, either.... |
| 11:50 |
* Dyrcona |
grumbles... |
| 11:52 |
Dyrcona |
Right. It uses the code. |
| 11:54 |
Dyrcona |
csharp_: I force pushed the branch again, and this time it should work. If it doesn't then there is more going on. |
| 11:55 |
|
rfrasur joined #evergreen |
| 11:55 |
Dyrcona |
Public debugging... |
| 11:56 |
mmorgan |
:) |
| 11:57 |
|
rfrasur_ joined #evergreen |
| 11:59 |
|
kworstell_isl joined #evergreen |
| 12:00 |
|
kworstell_isl joined #evergreen |
| 12:00 |
Dyrcona |
I hope csharp_ comes back to the channel before spending a lot of time on it. |
| 12:01 |
Dyrcona |
I'll ask jamundson to have a look at this on our training/test server. |
| 12:08 |
|
rfrasur joined #evergreen |
| 12:26 |
|
jihpringle joined #evergreen |
| 12:47 |
* Dyrcona |
has been having weird things happen lately. Yesterday, it was the strange ghost cursor on an Ubuntu 22.04 laptop. Today it is man dumping core on Ubuntu 20.04. |
| 13:11 |
|
jihpringle joined #evergreen |
| 13:11 |
berick |
@ana man dumping core |
| 13:11 |
pinesol |
berick: Impugn, romanced |
| 13:12 |
Dyrcona |
:) |
| 13:13 |
csharp_ |
Dyrcona: I'll look now - thanks |
| 13:17 |
csharp_ |
Dyrcona: it works! |
| 13:17 |
csharp_ |
Dyrcona++ |
| 13:17 |
Dyrcona |
Huzzah! |
| 13:17 |
Dyrcona |
csharp_++ |
| 13:17 |
mmorgan |
Dyrcona++ |
| 13:17 |
csharp_ |
there's a similar issue with history not showing too, which I'll try to pinpoint |
| 13:17 |
mmorgan |
csharp_++ |
| 13:19 |
Dyrcona |
@ana man segmentation fault |
| 13:19 |
pinesol |
Dyrcona: Safe, momental taunting |
| 13:19 |
JBoyer |
Dyrcona++ csharp_++ |
| 13:21 |
csharp_ |
and I see that it's the same issue - trying to fix now |
| 13:32 |
csharp_ |
Dyrcona: updating the bug with this, but I signed off on your fix and pushed a branch with my subsequent one: user/csharp/lp2006749-fix-apputils-perm-check |
| 13:32 |
Dyrcona |
Cool! I'll have a look in a minute. |
| 13:33 |
* Dyrcona |
is updating VMs today. |
| 13:41 |
Dyrcona |
That ou_ancestor_setting_log subroutine still looks a bit off to me. It doesn't do anything without an $auth argument, unlike the other. |
| 13:42 |
Dyrcona |
csharp_: Have your tried that second one in a case where you don't have the permission? Does it fail gracefully? |
| 13:48 |
csharp_ |
not yet - lemme check |
| 14:01 |
|
jihpringle joined #evergreen |
| 14:19 |
|
kworstell_isl_ joined #evergreen |
| 14:31 |
csharp_ |
Dyrcona: got waylaid - I'll do some testing when I can |
| 14:32 |
|
sleary joined #evergreen |
| 14:34 |
Dyrcona |
OK. That function looks like it is missing some pieces, and they were missing before you touched it. I could be wrong, though. I often am wrong. |
| 14:52 |
|
kworstell-isl joined #evergreen |
| 16:42 |
|
sleary joined #evergreen |
| 17:08 |
|
mmorgan left #evergreen |
