| Time |
Nick |
Message |
| 07:06 |
|
kworstell-isl joined #evergreen |
| 07:51 |
|
BDorsey joined #evergreen |
| 07:58 |
|
kworstell-isl joined #evergreen |
| 08:12 |
|
mantis1 joined #evergreen |
| 08:35 |
|
mmorgan joined #evergreen |
| 08:43 |
|
collum joined #evergreen |
| 08:48 |
|
Dyrcona joined #evergreen |
| 09:22 |
|
Christineb joined #evergreen |
| 09:35 |
|
jvwoolf joined #evergreen |
| 09:52 |
|
sleary joined #evergreen |
| 10:21 |
csharp_ |
looking at bug 1913811... |
| 10:21 |
pinesol |
Launchpad bug 1913811 in Evergreen 3.5 "Too many parallel open-ils.actor.user.itemsout.notices requests" [High,Fix released] https://launchpad.net/bugs/1913811 |
| 10:21 |
csharp_ |
even after applying jeffdavis's fix, we're still seeing the perm calls with null authtoken |
| 10:22 |
csharp_ |
I am but a simple caveman, but looking at https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/web/js/ui/default/staff/services/auth.js;h=358c036c9a5d171f55506ec3a484a5005217cd06;hb=HEAD#l381 |
| 10:22 |
csharp_ |
couldn't we just wrap something there in and if block that checks for the existence of an authtoken before doing the two million calls? |
| 10:23 |
csharp_ |
*an if block, not and |
| 10:23 |
csharp_ |
this is the service itself, so whatever happens there would affect all perm calls in angjs |
| 10:24 |
berick |
csharp_: yes |
| 10:25 |
Dyrcona |
I was just thinking that it should be the caller's responsibility to check, but something like `if (! egAuth.token()) return null;` should help. |
| 10:26 |
csharp_ |
awesome - that's what I would probably do |
| 10:26 |
csharp_ |
I agree that the caller should care |
| 10:26 |
Dyrcona |
Well, do both...belt AND suspenders. :) |
| 10:26 |
csharp_ |
but since calls are getting that far, seems like a sane failsafe |
| 10:26 |
csharp_ |
exactly |
| 10:26 |
rhamby |
there is an empathy joke of some kind to make there but I don't care enough |
| 10:27 |
Dyrcona |
Ha! |
| 10:27 |
Dyrcona |
rhamby++ |
| 10:27 |
csharp_ |
rhamby++ |
| 10:28 |
Dyrcona |
csharp_: I don't expect my pseudocode to actually work, by the way. |
| 10:28 |
csharp_ |
speaking of not caring enough, this is close to deprecated code anyway |
| 10:28 |
csharp_ |
Dyrcona: understood |
| 10:29 |
csharp_ |
if (!egAuth.token()) { |
| 10:29 |
csharp_ |
return; |
| 10:29 |
csharp_ |
} |
| 10:29 |
csharp_ |
that's what I was going to try - my JS chops are not great though :-) |
| 10:30 |
csharp_ |
I want it to be like perl and it just isn't |
| 10:30 |
Dyrcona |
That might work, too, assuming egAuth doesn't hang on to an invalid token. |
| 10:30 |
csharp_ |
the calls have "null" in the place of the authtoken when the messages get to the server logs |
| 10:31 |
Dyrcona |
That's right. So maybe `if (egAuth.token() === null) {return null;}`? |
| 10:32 |
Dyrcona |
My JS chops aren't what they used to be. |
| 10:40 |
csharp_ |
more belt and suspenders logic: if (!egAuth.token || egAuth.token() === null) |
| 10:41 |
csharp_ |
might be redundant since I'm not firm on JS truthiness |
| 10:41 |
csharp_ |
from the lazy admin perspective, I'm trying to be off tomorrow and don't want to have to babysit PINES all day :-) |
| 10:43 |
csharp_ |
speaking of, it's happening right now on 3 of 6 PINES app servers! |
| 10:43 |
csharp_ |
yay |
| 10:44 |
Dyrcona |
This seems like something that happens when users don't log out, right? They just walk away and let the client timeout? |
| 10:48 |
csharp_ |
yes |
| 10:48 |
Dyrcona |
null is also treated as false, so the not logic ought to just do it. |
| 10:48 |
csharp_ |
however, I can see that the new acq UIs are contributing to the issues with thousands of concurrent perm calls |
| 10:48 |
* Dyrcona |
looked it up. |
| 10:48 |
csharp_ |
Dyrcona++ # thanks |
| 10:49 |
Dyrcona |
The new acq UIs are probably something else. We're talking about Angular in that case, right? |
| 10:52 |
csharp_ |
yep |
| 11:19 |
|
kworstell_isl joined #evergreen |
| 11:30 |
|
rfrasur joined #evergreen |
| 11:47 |
|
jihpringle joined #evergreen |
| 11:52 |
csharp_ |
@quote random |
| 11:52 |
pinesol |
csharp_: Quote #136: "< Dyrcona> Come! Witness the heat death of the universe." (added by csharp at 09:51 AM, January 06, 2016) |
| 11:52 |
csharp_ |
@blame [band] for [quote random] |
| 11:52 |
pinesol |
csharp_: Carrollton High School Trojan Marching Band is the SPY! for Quote #65: "< paxed> #evergreen: wrong questions answered correctly." (added by csharp at 02:27 PM, August 13, 2013) |
| 11:53 |
csharp_ |
I forgot I added the CHS band to the band list |
| 11:53 |
* csharp_ |
blows sad note on trombone |
| 11:55 |
Dyrcona |
*wah-wah-wah* |
| 11:57 |
berick |
heh |
| 12:01 |
Dyrcona |
I sometimes hear the "price is wrong" music in my head from The Price is Right when things fail. |
| 12:02 |
Dyrcona |
And, oddly enough, I heard the Windows shut down chime in my head as I started to doze off on the couch over Christmas break. |
| 12:02 |
Dyrcona |
My life apparently has a soundtrack. |
| 12:06 |
csharp_ |
I got about halfway through the netflix documentary about the mathematician who systematized price guessing for that show - need to get back to that |
| 12:07 |
csharp_ |
"Perfect Bid" is the name - it was escaping me |
| 12:09 |
berick |
Dyrcona: oddly chilling. that would make me question if I was entirely organic |
| 12:09 |
Dyrcona |
berick++ |
| 12:09 |
* Dyrcona |
shudders to think he might actually run Windows. |
| 12:10 |
csharp_ |
@quote add < Dyrcona> And, oddly enough, I heard the Windows shut down chime in my head as I started to doze off on the couch over Christmas break. |
| 12:10 |
pinesol |
csharp_: The operation succeeded. Quote #234 added. |
| 12:10 |
berick |
that really would be the worst part |
| 12:11 |
Dyrcona |
Yeah. If it /has/ to be a proprietary O/S, then I'd prefer QNX. |
| 12:12 |
csharp_ |
https://youtu.be/FxIUs-pQBjk?t=46 |
| 12:14 |
csharp_ |
I remember wanting to add Super Mario sounds to the staff client - the coin sound when patrons pay, etc. |
| 12:15 |
csharp_ |
the level-up sound when a hold is successfully placed, maybe |
| 12:15 |
Dyrcona |
Stuff like that is cute for a while, but it can get old pretty quickly. |
| 12:16 |
csharp_ |
kinda like the star trek red alert sound? :-D |
| 12:16 |
Dyrcona |
It |
| 12:16 |
Dyrcona |
's good that one is jarring though. It gets staff attention. |
| 12:18 |
mmorgan |
Only the first few times, though :-/ |
| 12:18 |
Dyrcona |
Well, then you've got bigger issues.... |
| 12:19 |
mmorgan |
Indeed. |
| 12:19 |
Dyrcona |
I used to use an IRC client, KIRC I think, that would play that sound and throw up a dialog, "Danger, captain! Dork at the helm." whenever you chose a command that didn't make sense in the current context. It should have just grayed out the menu items. |
| 12:22 |
jeff |
Dennis Nedry: sympathetic character? maybe. role model? certainly not. |
| 12:26 |
Dyrcona |
:) |
| 12:26 |
Dyrcona |
@ana dennis nedry |
| 12:26 |
pinesol |
Dyrcona: Deny in nerds |
| 12:27 |
Dyrcona |
I thought of Sinned Nerdy, but OK. |
| 12:34 |
|
collum joined #evergreen |
| 12:53 |
|
collum joined #evergreen |
| 13:02 |
miker |
jeff: re LP 1829295, without wading into the bug itself, a big +1 to a YAOUS for respecting closed dates (and, you can just delete the row from config.org_setting_type, probably through the UI as the admin user!) |
| 13:02 |
pinesol |
Launchpad bug 1829295 in Evergreen "Shelf expire date doesn't respect closed dates" [Wishlist,Confirmed] https://launchpad.net/bugs/1829295 |
| 13:15 |
jeff |
miker: thanks for the feedback! i may have only half-followed you, though. which org unit setting type are you referring to? |
| 13:55 |
Dyrcona |
"Smart" quotes in MARC.....That seems to be what's causing problems with record sizes. |
| 13:55 |
|
mantis1 joined #evergreen |
| 13:56 |
rhamby |
smart_quotes-- |
| 13:56 |
sleary |
ugh |
| 13:57 |
Dyrcona |
Spcecifically the curved apostrophe. My editor shows it as \200\235 (octal notation, I think, might be decimal). |
| 13:58 |
Dyrcona |
I guess I'll update the bug.... |
| 13:58 |
Dyrcona |
I wonder if that's UTF-8 or Windows-[mumble]? |
| 14:02 |
sleary |
Windows, I think. https://ask.metafilter.com/62656/Eliminating-odd-characters-from-web-site#942991 |
| 14:03 |
Dyrcona |
sleary++ |
| 14:03 |
Dyrcona |
I'm leaning towards Windows and "copy and paste" cataloging. I was just converting from octal to see what the value is to look it up in UTF-8. |
| 14:05 |
sleary |
Quotes and apostrophes copied from Word in Windows used to truncate content in WordPress constantly. Good times. |
| 14:06 |
Dyrcona |
They truncate MARC records, too, because one of the characters in the sequence is the MARC End of Record character. I specifically use code to look for End of Field followed by End of Record to avoid this. |
| 14:07 |
Dyrcona |
Looks like our Perl MARC code doesn't calculate a proper record length, but those characters shouldn't be in a MARC record in the first place. |
| 14:07 |
rhamby |
utf16-- |
| 14:08 |
Dyrcona |
Heh. If only everything was big endian UTF-32....drive manufacturers would be happy.... :) |
| 14:16 |
mmorgan |
@quote get 232 |
| 14:16 |
pinesol |
mmorgan: Quote #232: "<mmorgan> Smart quotes are kinda like smart TVs in that neither are all that smart" (added by Dyrcona at 04:47 PM, October 19, 2022) |
| 14:17 |
Dyrcona |
mmorgan++ |
| 14:18 |
Dyrcona |
There's a bug in the CPAN RT for MARC::Batch or MARC::Record (maybe on Github, too), and I don't think the solution actually works. |
| 14:23 |
Dyrcona |
I thought tsbere had a proposed solution this one: https://rt.cpan.org/Public/Bug/Display.html?id=70169 |
| 14:28 |
|
jihpringle joined #evergreen |
| 14:32 |
Dyrcona |
I have been told that this can happen if people copy and paste from Amazon when cataloging. |
| 14:55 |
|
jihpringle joined #evergreen |
| 14:57 |
Dyrcona |
i should probably add a fix for these characters to my preprocess program for vendor records. |
| 14:57 |
miker |
jeff: pardon the delay. I mean the one you're proposing to create on that bug (or ... am I crossing the jeff-streams? |
| 15:16 |
jeff |
Ah. I think I missed the joke originally. You're saying I can create that setting and immediately delete it from existence? :-) |
| 15:18 |
rhamby |
Drycona: regarding the copy and pasting into records from Amazon and the like - it most definitely happens |
| 15:19 |
Dyrcona |
Yeahp. GNU Emacs also says the file of bad records is UTF-16 when I open it. |
| 15:20 |
* Dyrcona |
wonders if pinesol has any dry kona in the coffee database. |
| 15:24 |
|
sleary joined #evergreen |
| 15:26 |
Dyrcona |
It seems odd to me that a program using MARC::Record->new_from_usmarc can read these records, modify them, and write them out without issue, but another program using the same Perl module blows up. I suspect the writing out leads to a bad length in the LDR. |
| 15:32 |
Dyrcona |
oh! |
| 15:33 |
Dyrcona |
The original records display just fine in GNU Emacs..... They get mangled going through Perl. |
| 15:34 |
Dyrcona |
I see the curly apostrophes and quotes, and Emacs says the coding system is multi-byte UTF-8. Something has a double encoding problem with these characters. |
| 15:35 |
Dyrcona |
I wonder if I'll even be able to fix this in a reasonable manner? |
| 15:36 |
Dyrcona |
Perl's Unicode support is so broken.... |
| 15:42 |
Dyrcona |
See... this is what I dislike about Unicode in Perl (particularly with MARC): one time I encode/decode the records and it works. Next time, the records come out garbled. Mebbe I should reread the Unicode FAQ and double check the MARC code to know what's really going on here. |
| 16:33 |
pinesol |
News from commits: Docs: global flags docs fixes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3f7b48566d3f34e07c5b7ba5b27ed23d97abd4b4> |
| 16:44 |
|
jvwoolf left #evergreen |
| 17:00 |
|
mmorgan left #evergreen |
| 17:03 |
pinesol |
News from commits: Docs: 3.10 Antora update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3beab57e78f63b6a3dc3996d6e6464ed8323d4dd> |
| 18:29 |
|
jihpringle joined #evergreen |
| 19:17 |
|
JBoyer joined #evergreen |
