Time |
Nick |
Message |
07:46 |
|
BDorsey joined #evergreen |
07:46 |
|
kworstell-isl joined #evergreen |
08:32 |
|
rfrasur joined #evergreen |
08:34 |
|
jmurray-isl joined #evergreen |
08:38 |
|
Dyrcona joined #evergreen |
08:38 |
|
mmorgan joined #evergreen |
08:52 |
Dyrcona |
Covers from Content Cafe seem to be working in production, but not on my training/dev environment. The username and password are set in eg_vhost.conf. I wonder what I missed? |
08:55 |
Dyrcona |
Hm... It's just the carousel. |
08:56 |
Dyrcona |
And, looks like it is just those titles. |
08:59 |
|
collum joined #evergreen |
09:10 |
mmorgan |
Dyrcona: Have you tried clearing added content cache for one of the titles? Maybe the blankness got cached. |
09:38 |
Dyrcona |
mmorgan: No, I didn't, but I ran the refresh carousel script and I'm getting better results. It turns out that it was originally full of video games. |
09:38 |
Dyrcona |
The database was reloaded from produciton over the weekend. |
09:51 |
Dyrcona |
So, a totally different question: If I want to stop the AngularJS staff client login from redirecting to eg2, it looks like I have to comment out line 150 of Open-ILS/web/js/ui/default/staff/services/auth.js? (I guess I can try that and see what happens.) |
09:58 |
Dyrcona |
Or, just revert commit c6468303741e59a58b86f8584a7c68ffb29962e4. |
09:59 |
* mmorgan |
was just going to suggest that :) |
10:00 |
csharp_ |
@ana just revert commit c6468303741e59a58b86f8584a7c68ffb29962e4 |
10:00 |
pinesol |
csharp_: Jet scum trim vector |
10:00 |
mmorgan |
:-D |
10:01 |
Dyrcona |
@ana was just going to suggest that |
10:01 |
pinesol |
Dyrcona: Toughest swot gags as jutting |
10:02 |
Dyrcona |
pinesol: That's poetry. |
10:02 |
pinesol |
Dyrcona: Have you run autogen.sh? |
10:13 |
csharp_ |
Dyrcona: Vogon poetry, more like |
10:15 |
mmorgan |
csharp_++ |
10:15 |
* mmorgan |
has never been able to purge that from my brain. Oh freddled gruntbuggly... |
10:16 |
Dyrcona |
:) |
10:17 |
csharp_ |
mmorgan: same |
10:17 |
Dyrcona |
"I think that I shall never see a poem as lovely as a tree...." |
10:20 |
scottangel |
How do you set a field mapper object field to NULL? I've tried using undef but it doesn't seem to work. Any ideas? |
10:20 |
berick |
scottangel: which language? |
10:20 |
scottangel |
perl |
10:20 |
Dyrcona |
undef should work in Perl. |
10:21 |
berick |
thing.clear_id() # for example |
10:21 |
berick |
clear_* is your friend |
10:21 |
Dyrcona |
or, yeah.... berick++ |
10:21 |
scottangel |
Ok, I'll give it a go! thanks guys |
10:21 |
* Dyrcona |
checks something.... undef is probably wrong. |
10:24 |
Dyrcona |
Yeahp, I was wrong undef doesn't work because of this line in Fieldmapper::AUTOLOAD: $self->[$pos] = $new_val if (defined $new_val); |
10:25 |
scottangel |
Ah!!! I knew there was something I was missing. Thanks Dyrcona, I'm not loosing my mind afterall. |
10:26 |
scottangel |
berick++ |
10:26 |
scottangel |
Dyrcona++ |
10:38 |
|
dguarrac joined #evergreen |
11:04 |
Dyrcona |
Has anyone else noticed that the Angular staff search doesn't use cached search results? I can run the same query multiple times and never get results. In the patron OPAC, if I wait until the search query finishes in the database and do the search again, I get results. Is this intentional or a bug? |
11:07 |
berick |
Dyrcona: can't explain what you're seeing, but the TS code in question is certainly trying to use the cache (passses the 'docache' parameter). |
11:10 |
Dyrcona |
berick: OK. Maybe my timing is off for trying again. |
11:16 |
* Dyrcona |
does a keyword search for "used" because that's what was in a recent ticket. |
11:17 |
Dyrcona |
Search going for 6 minutes so far. |
11:19 |
Dyrcona |
Nope. Query finished after about 7 minutes 15 seconds. I hit "Reload" in the staff search and no results pop up. I check the db and a new query has started. |
11:23 |
Dyrcona |
berick: `grep -R -i docache Open-ILS/src/eg2` turns up nothing for me. |
11:25 |
berick |
it's just a "true" |
11:26 |
berick |
https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/share/catalog/catalog.service.ts#L162 |
11:27 |
berick |
BTW, not sure if the backend will cache anything for a search that times out |
11:28 |
Dyrcona |
Well, it seems to work in the OPAC most of the time. |
11:29 |
Dyrcona |
I'll have to compare the two in more depth later. |
11:29 |
* Dyrcona |
is testing some search fixes on production data. |
11:31 |
Dyrcona |
It might be this particular search is way too broad given our data, but this has been consistent with other searches, IIRC. |
11:32 |
Dyrcona |
This search isn't returning results in the OPAC, either, and it gives up almost immediately. |
11:33 |
Dyrcona |
The query doesn't run nearly as long in the database now, either. |
11:35 |
Dyrcona |
Title search for "used" returns results almost right away. |
11:56 |
|
jvwoolf joined #evergreen |
12:06 |
miker |
not here, but staff search never uses the cache. else newly added records wouldn't show up |
12:16 |
miker |
in the olden days, the #staff modifier would force skipping the cache. I think that still works? but docache probably overrides that heuristic |
12:20 |
Dyrcona |
Well, I've done some more fiddling around with that bug and comparing produciton with my test system with search patches. I get results in production regardless of filters, etc. On the test system, I either have to change to a title search or limit by library to get results. |
12:20 |
Dyrcona |
I suppose it is just my test database being slower than production. |
12:26 |
|
dguarrac joined #evergreen |
12:34 |
|
collum joined #evergreen |
12:47 |
|
collum joined #evergreen |
13:15 |
|
Christineb joined #evergreen |
13:20 |
|
mantis1 joined #evergreen |
14:54 |
|
sleary joined #evergreen |
15:01 |
|
Guest74 joined #evergreen |
15:49 |
Dyrcona |
Staff search seems to hang when the search times out. But, again, maybe that's just my environment... |
15:56 |
sleary |
scottangel I brought up your comments about new developer documentation (which I completely agree with!) in the New Devs meeting just now, and it should be on that group's agenda for January. Let's put our heads together and come up with a list of the things we'd like to add to https://wiki.evergreen-ils.org/doku.php?id=newdevs:resources. |
16:03 |
scottangel |
This is fantastic! I got caught up cleaning up my next commit I didn't even notice there was a meeting. But yea, I'm all for helping out and giving my 2 cents on how it is for me and what I stuggle with. |
16:05 |
Dyrcona |
Adding facets can slow search. You'd almost expect it to be quicker, but sometimes, it isn't. |
16:07 |
|
sleary joined #evergreen |
16:31 |
Dyrcona |
"Time to go." |
16:38 |
|
jvwoolf left #evergreen |
16:47 |
|
sleary joined #evergreen |
17:03 |
|
mmorgan left #evergreen |