Time |
Nick |
Message |
07:48 |
|
collum joined #evergreen |
08:02 |
|
rfrasur joined #evergreen |
08:04 |
|
BDorsey joined #evergreen |
08:29 |
|
Dyrcona joined #evergreen |
08:33 |
|
mantis1 joined #evergreen |
08:38 |
Dyrcona |
So, fun. Looks like some patrons renew their circulations between 2:00 and 4:30 AM while the autorenewals are still running. If they time it right, they'll get an email saying that their item could not be autorenewed because it was out of renewals. |
08:41 |
|
mmorgan joined #evergreen |
08:41 |
mantis1 |
Dyrcona: :-X |
08:42 |
mantis1 |
can't imagine needing to renew something that early |
08:43 |
|
kworstell-isl joined #evergreen |
08:43 |
* mmorgan |
thinks we have a lot of night owls that do their library business overnight. Lots of holds get placed in the wee hours. |
08:43 |
Dyrcona |
Yeah, what mmorgan said. :) |
08:44 |
|
kworstell-isl joined #evergreen |
08:47 |
Dyrcona |
Looks like we had 5 yesterday morning and 16 this morning. |
08:47 |
Dyrcona |
I wonder, too, if some of these could overlap with the autorenewals and the patrons end up wasting a renewal. |
08:48 |
Dyrcona |
I suppose I look for "duplicate" renewals. |
08:57 |
Dyrcona |
OK. Checking for 11/22, Monday, and this morning, I don't find any non-opac renewals for the same target_copy as the opac_renewal, so renewals are not being wasted. |
09:01 |
mmorgan |
I think that makes sense. If the patron's renewal succeeds, then the autorenewal won't proceed because that circ is now closed. |
09:02 |
Dyrcona |
Yeah. What I was mainly concerned about was a case where the autorenewal succeeded and the patron did the opac renewal right after. |
09:02 |
* mmorgan |
nods |
09:02 |
Dyrcona |
I'm checking the days since 11/22 and so far I still don't find any. |
09:04 |
Dyrcona |
I'm also arbitrarily stopping at 4:30 AM. I've seen autorenewals run longer than that in the past. |
09:11 |
|
Stompro joined #evergreen |
10:14 |
|
collum joined #evergreen |
10:24 |
mantis1 |
got a hook declined error when pushing a branch to the working repo |
10:27 |
Dyrcona |
mantis1: Did you use the full user/gmonti/{branch} name when you pushed? |
10:27 |
Dyrcona |
or collab/gmonti/.... |
10:28 |
mantis1 |
ah I got a typo |
10:28 |
mantis1 |
that was it was |
10:28 |
mantis1 |
thank you! |
10:28 |
Dyrcona |
OK. |
10:28 |
mmorgan |
typos-- |
10:29 |
Dyrcona |
typos-- |
10:29 |
Dyrcona |
I name my working branches for what they'll be called on the working repo: collab/dyrcona/lp1997098-support-postgresql-15 |
10:30 |
Dyrcona |
This way I can type `git push working HEAD` with the branch checked out. |
10:31 |
mmorgan |
Dyrcona++ |
10:35 |
Dyrcona |
Speaking of git, it would be nice if there were a feature to leave a series of cherry-picks in progress, switch branches, and come back to it later, but I guess I can just cherry-pick each commit individually. |
10:43 |
Dyrcona |
hmmm.... I wonder if GNU Emacs can open files on Google Drive if I've mounted the Google Drive via Nautilus..... |
10:48 |
|
jvwoolf joined #evergreen |
10:51 |
Dyrcona |
Well, sort of..... I can open the directory in /run/user/1000/gvfs/google-drive.... but the contents look like gibberish. :) |
10:52 |
Dyrcona |
It needs to go through gvfs to translate the filenames. |
10:52 |
Dyrcona |
Maybe there's an extension for that? |
10:55 |
Dyrcona |
LibreOffice can save a document to Google Drive and Google Docs can open it. |
10:58 |
Dyrcona |
GNU Emacs can open files on Google Drive if I use the File menu and the GUI open dialog, not the usual key combination.... |
10:58 |
Dyrcona |
Doesn't look like it can save files to Google Drive, though. |
10:59 |
Dyrcona |
OK. Enough fooling around, back to cherry-picking. |
10:59 |
Dyrcona |
:) |
11:00 |
mmorgan |
Exploring! :) |
11:00 |
Dyrcona |
Yeah, but it's relevant. I dumped a list of the commits that I want to cherry-pick to a file and I wanted to put the file on Google Drive. |
11:03 |
Dyrcona |
Hmm... Things are more complicated than they may at first appear. I believe that these commits I'm cherry-picking are based on a PINES local branch which means that I may accidentally pull in some PINES customization... At least the first conflict appears to be related to a customization made elsewhere by PINES. |
11:04 |
Dyrcona |
So, I can expect more conflicts than usual is all. |
11:06 |
Dyrcona |
Somewhere around commit #4 or #5, it gets really complicated, which is why I want to do them 1 at a time and save the branch to come back later. |
11:14 |
Dyrcona |
Commit #6 is the one.... |
11:15 |
Dyrcona |
csharp_: Will you be fussed if I squash your "typo fix" commit to the Quipu Ecard renewal branch? I can always add you as an author/sign-off in the commit messages. |
11:20 |
Dyrcona |
That's clever. Some recommend using a Co-authored-by: line in the commit message. Maybe, when I'm done, I'll squash it all down to 1 commit, leave terranm as the main author and add csharp_ and myself as co-authors. |
11:25 |
Dyrcona |
This is interesting reading: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=451880 |
11:25 |
pinesol |
Dyrcona: Error: Could not parse data returned by Debian: |
11:27 |
Dyrcona |
OK. If Josh Triplett hasn't found the time in 12 years, guess I'm not working on it, either. :) |
11:35 |
* Dyrcona |
has 6 remotes for Evergreen and considers adding 1 more for WIP stuff......Nah. |
11:38 |
|
jihpringle joined #evergreen |
11:42 |
Dyrcona |
Think I'll tackle the 302 lines of conflict after lunch. |
11:44 |
Dyrcona |
After that, I can likely expect conflicts with every subsequent cherry-pick. |
11:44 |
Dyrcona |
The Joy of Git |
11:45 |
Dyrcona |
Maybe I should rename my conference presentation.... Is it too late? |
12:00 |
|
dguarrac joined #evergreen |
13:06 |
csharp_ |
Dyrcona: no objections - thanks! |
13:56 |
Dyrcona |
csharp_++ |
13:57 |
Dyrcona |
Now that I've resolved the large conflict, I'm not seeing as many conflicts as I expected. |
14:01 |
Dyrcona |
Hrm... Guess I only want half of it. Too bad there's no 'cherry-pick -p' like there is 'add -p'. |
14:02 |
Dyrcona |
ha! I missed that both functions were still there to remove and actually unused..... |
14:10 |
Dyrcona |
Now I've hit the part where every cherry-pick has a conflict because of the resolution of the large conflict earlier. |
14:13 |
Dyrcona |
Ooh. I have a question for Terran.... |
14:35 |
Dyrcona |
Oof. Want to undo something that I did just a bit ago, but have to redo the whole conflict resolution..... |
14:35 |
Dyrcona |
Not fun. |
14:50 |
Dyrcona |
Yuck! hard-coded profile ids.... Need settings for these.... |
14:50 |
Dyrcona |
"This is gonna run into money..." "I'm not in the book." |
14:53 |
Dyrcona |
Then there are changes that I'm not sure if they should be there/go in until I try things. |
14:57 |
Dyrcona |
Nope. Don't like that change, either. |
15:32 |
|
kworstell-isl joined #evergreen |
15:36 |
Dyrcona |
csharp_: https://pastebin.com/efnSnhCV |
15:38 |
Dyrcona |
The "fun" part will be merging these changes into our local Quipu branch, but I think we should try to compromise and get something universal into Evergreen. |
16:06 |
|
JBoyer_ joined #evergreen |
16:35 |
|
jvwoolf left #evergreen |
17:12 |
|
mmorgan left #evergreen |
17:12 |
|
jihpringle joined #evergreen |
17:41 |
|
jihpringle joined #evergreen |
19:11 |
|
jihpringle joined #evergreen |