Evergreen ILS Website

IRC log for #evergreen, 2022-11-23

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
04:40 dluch joined #evergreen
05:13 Bmagic joined #evergreen
07:33 kworstell-isl joined #evergreen
07:44 BDorsey joined #evergreen
07:55 rfrasur joined #evergreen
08:30 kmlussier joined #evergreen
08:38 mmorgan joined #evergreen
09:00 Dyrcona joined #evergreen
09:27 kmlussier Dyrcona: I just realized that the evergreen_history.txt file is in the history repo. I'm guessing my key will also need to be added there to make any changes?
09:28 Dyrcona kmlussier: That's right! I'll fix that.
09:29 mantis1 joined #evergreen
09:29 Dyrcona kmlussier: You should be able to access the history repo. It has the same permissions as the working repo.
09:30 kmlussier Great, thanks! Dyrcona++
09:30 jvwoolf joined #evergreen
09:31 mantis1 HI all.  Having a problem with keys using Windows and was curious if anyone else ran into this issue.  My keys have been updated for Evergreen permissions, but when I try to push a branch up to the community working repo, I get errors that tell me permission denied.  Dyrcona was able to confirm the format of the key is correct.  I also have it saved in my User folder under .ssh.  Not sure what else I need to do to make this work.
09:39 JBoyer mantis1, what is the push url that you're using for the working repo? You can see that at the top of the repo in .git/config
09:40 JBoyer The reason I'm asking is that if you skip the "git remote set-url --push working git@git.evergreen-ils.org:working/Evergreen.git" step on https://wiki.evergreen-ils.org/doku.php?id=dev:git it can cause problems like that.
09:42 Dyrcona JBoyer: We've verified that mantis1's keys work. When mantis1 sent the results of git remote -v that looked correct to me.
09:42 JBoyer Dyrcona++
09:43 Dyrcona It would not hurt to check the remote urls again.
09:44 Dyrcona FYI: If you want to check that a private key works, you can run this command: ssh -i /path/to/private_key git@git.evergreen-ils.org
09:44 JBoyer mantis1, could you give us the full command and local branch name you're using when trying to push?
09:46 Dyrcona If your key works, you'll get a list of the repositories on the server with the access permissions that you have.
09:47 mantis1 ran a git remote -v and everything looks correct
09:47 mantis1 got fetch and push for both origin and working
09:47 mantis1 the push command is this
09:47 mantis1 git push working lp1980136_consistent_username_opac:user/g​monti/lp1980136_consistent_username_opac
09:48 Dyrcona mantis1: Can you share the result of git remote -v so everyone else can see it? Maybe I missed something.
09:49 mantis1 sure
09:49 mantis1 git@git.evergreen-ils.org: Permission denied (publickey).
09:49 mantis1 fatal: Could not read from remote repository.
09:49 Dyrcona That's from the push, right?
09:50 Dyrcona Run `git remote -v` and paste that output.
09:51 mantis1 origin  git://git.evergreen-ils.org/Evergreen.git (fetch)
09:51 mantis1 origin  git://git.evergreen-ils.org/Evergreen.git (push)
09:51 mantis1 working git@git.evergreen-ils.org:working/Evergreen.git (fetch)
09:51 mantis1 working git@git.evergreen-ils.org:working/Evergreen.git (push)
09:51 mantis1 and yes the other error I put in there was from the push command
09:51 mantis1 I was able to successfully add the new private key via git bash, too, the other day
09:53 Dyrcona I think the issue is that the private key is not being seen by ssh, but since I don't use Windows or git-bash, I don't know how to help at this point.
09:54 mantis1 Dyrcona++ I appreciate all the help you've given me so far
09:55 JBoyer Are you able to fetch with 'git fetch --all'  ? if that works and pushing doesn't that would be interesting
09:55 Dyrcona or just `git fetch working`
09:55 mantis1 should I checkout a particular branch first?
09:56 JBoyer No, fetch just makes sure that your repository is current so you can checkout a branch later
09:56 Dyrcona Every git session should ideally start with `git fetch --all` to pick up latest changes.
09:58 mantis1 same permission issues
09:58 mantis1 git@git.evergreen-ils.org: Permission denied (publickey).
09:58 mantis1 fatal: Could not read from remote repository.
09:59 mmorgan mantis1: Do you have both id_rsa and id_rsa.pub files in C:\Users\<user>\.ssh ?
09:59 mantis1 I do
10:00 Dyrcona mantis1: Are the same for the key that you sent to gitadmins yesterday? The pub key was named differently.
10:00 kmlussier When I do git remote -v, I see the following. It's a little different from what mantis1 is showing.
10:00 kmlussier workinggit://git.evergreen-ils.org/working/Evergreen.git (fetch)
10:00 kmlussier workinggit@git.evergreen-ils.org:working/Evergreen.git (push)
10:01 kmlussier In mantis1's, there are colons
10:02 Dyrcona kmlussier: Either URL works for fetch, but git@git.evergreenils.org... is required for push. The latter uses ssh, and the former uses "git."
10:02 kmlussier Oh, wait. Sorry, there is a colon in mine too. I'll go back to what I was working on. ;_
10:02 kmlussier Dyrcona: Yes, I realized afterwards.
10:02 mantis1 Dyrcona: same keys
10:02 Dyrcona kmlussier: Not bad to have it in the logs in case someone else needs to know. :)
10:03 Dyrcona So for Linux, I know that the permissions on the files is important. The private key won't load if other users can read it or write it. Could it be the same with git bash?
10:04 mantis1 I didn't name them id_rsa and id_rsa.pub though.  Is that needed?  I submitted those some time ago but was running into the same problems so I made some new ones to see if that would clear it up somehow.
10:05 Dyrcona The name probably matters for automatically loading the keys. When you manually specified the key on ssh with -i earlier it worked.
10:06 mantis1 that's right it did
10:08 JBoyer You don't have to make new keys, you can just rename the private key to id_rsa and git/ssh will use it by default.
10:09 JBoyer You could also specify the file to use with a .ssh/config file, but rename is the quick fix (so long as you don't already have a file with that name, watch out!)
10:10 mantis1 Dyrcona: if that's the case, I have to send another pub key since I have a registered id_rsa; though I'm unsure why I was getting the same exact errors when pushing with those keys established
10:10 mantis1 I could try that
10:11 Dyrcona mantis1: If you don't use id_rsa for anything, I'd rename the new key as JBoyer suggests.
10:14 mantis1 I do actually use it for the keys in house
10:14 mantis1 I can resubmit it again if that's alright with you
10:14 JBoyer mantis1, you can use .ssh/config to default to the correct key. The "Configuring SSH" instructions on the wiki will work, but you may need to change the line that says "Host EvergreenGitServer" to "Host git.evergreen-ils.org"
10:14 Dyrcona So, you can tell ssh to also use the new key, or even just for git@git.everngree-ils.org.
10:16 JBoyer (I don't know why the wiki suggests that extra redirection around the name...)
10:19 Dyrcona Yeah, I don't either. Host git.evergreen-ils.org should work.
10:29 * Dyrcona edits the wiki
10:32 mantis1 For this line: IdentityFile=<LOCATION OF YOUR SSH KEY>
10:32 mantis1 Should it formatted like: IdentityFile=C:/Users/name/private_key_name
10:33 mantis1 just checking before I save it
10:34 Dyrcona I'm not sure. I would think that the /s would be \\.
10:35 Dyrcona Looks like \ would work: https://serverfault.com/questions/1​94567/how-do-i-tell-git-for-windows​-where-to-find-my-private-rsa-key
10:38 mantis1 aha now I'm fetching
10:38 mmorgan mantis1++
10:38 mmorgan Dyrcona++
10:38 mantis1 no idea I had to configure ssh
10:38 mantis1 hopefully the push will work
10:39 mantis1 oh my god it worked
10:39 mmorgan mantis1: I don't think I ever had to configure ssh for gitbash, but I set it up a while ago
10:39 mantis1 wow thank you all so much!
10:39 mantis1 JBoyer++
10:39 mantis1 Dyrcona++
10:39 mmorgan :-D
10:40 mmorgan mantis1: Now you can fix ALL the bugs!!
10:40 mantis1 hahaha I was also having this issue with the docs committing too
10:40 mantis1 so I'm hoping that will work, too!
10:41 JBoyer mantis1++
10:41 mantis1 thank you all so much I was stuck on this for two months
10:42 Dyrcona mantis1++
10:46 Dyrcona mantis1: I see your branch in the working repo: user/gmonti/lp1980136_consistent_username_opac -> working/user/gmonti/lp19801​36_consistent_username_opac
10:59 kmlussier 3.9-rc shows 4/21/21 as the release date in LP. I think that's supposed to be 4/21/22.
11:01 pinesol News from commits: LP1980275 Bootstrap - buttons on two lines in current hold screen <https://git.evergreen-ils.org/?p=E​vergreen.git;a=commitdiff;h=285b6a​82c10770abd4f750d887e0d89d82d36932>
11:01 pinesol News from commits: LP 1944602 Bootstrap Opac: Address alignment <https://git.evergreen-ils.org/?p=E​vergreen.git;a=commitdiff;h=b6a867​cec999c0a1c4380af590bfa69d65ee4f76>
11:03 Christineb joined #evergreen
11:05 mmorgan1 joined #evergreen
11:24 jihpringle joined #evergreen
11:31 pinesol News from commits: LP1995211: Angular styleext setting is now called style <https://git.evergreen-ils.org/?p=E​vergreen.git;a=commitdiff;h=706eed​fbc9ae2e3e03b59f83422a4e5060c3317c>
11:39 BDorsey joined #evergreen
11:59 kmlussier OK, I'm rusty at this, so I may just be doing something wrong. I cloned the history repo, made some changes to evergreen_history.txt, committed the change and then tried: git push origin add-releases-to-evergreen-history
11:59 kmlussier The error I'm getting is "remote error: access denied or repository not exported: /history.git"
12:00 kmlussier Is my command incorrect or is there an issue with my permissions to push to that repo?
12:02 * kmlussier needs to sign off to bake pies but will check back to see if anyone has any insight to offer.
12:03 kmlussier Have a Happy Thanksgiving to all the US folks and a great week to everyone else!
12:03 Dyrcona kmlussier what does git remote -v output?
12:04 kmlussier origingit://git.evergreen-ils.org/history.git (fetch)
12:04 kmlussier origingit://git.evergreen-ils.org/history.git (push)
12:04 kmlussier You know, I looked at that earlier, but I have a feeling I know what you're going to tell me now.
12:06 Dyrcona You probably do.
12:06 kmlussier OK, let me try it before I bug you again
12:06 mmorgan1 joined #evergreen
12:07 kmlussier Diving back into git after four years of staying away from it isn't like getting back on a bike.
12:09 Dyrcona Did you get it working?
12:11 kmlussier Still working on it. I'm multitasking here.
12:14 kmlussier New remote -v:
12:14 kmlussier origingit://git.evergreen-ils.org/history.git (fetch)
12:14 kmlussier origingit@git.evergreen-ils.org:history.git (push)
12:15 kmlussier If I push to origin, I get lots of denials.
12:15 kmlussier remote: FATAL: C refs/heads/add-releases-to-evergreen-history history kmlussier DENIED by fallthru
12:15 kmlussier remote: error: hook declined to update refs/heads/add-releases-to-evergreen-history
12:15 kmlussier To git.evergreen-ils.org:history.git
12:15 kmlussier ! [remote rejected] add-releases-to-evergreen-history -> add-releases-to-evergreen-history (hook declined)
12:15 kmlussier error: failed to push some refs to 'git@git.evergreen-ils.org:history.git'
12:15 kmlussier I'm sorry, there's probably a better place I could be pasting that.
12:18 Dyrcona You're trying to push a new branch. Try pushing to master.
12:19 kmlussier Dyrcona++
12:19 kmlussier Thank you for the handholding.
12:19 Dyrcona NP. The history repo is configured a little different.
12:20 Dyrcona It won't  allow pushes to anything but the master branch.
12:21 kmlussier Yeah, I actually pushed to master back before I set the push URL. I had all the pieces; just didn't do it in the right order.
12:22 kmlussier And I'm signing off for real now. Thanks again!
12:22 Dyrcona You're welcome, and drop in any time!
12:30 Dyrcona kmlussier++ # For updating the history repo and for pointing out the wrong release date of 3.9-rc.
12:33 mmorgan kmlussier++ # all while baking pies!
12:34 Dyrcona :)
13:00 csharp_ @dessert [someone]
13:00 * pinesol grabs some Key Lime Pie for dluch
13:15 Dyrcona So, for anyone who cares, I'm setting up two local test VMs with PostgreSQL 15. I'll run the tests later today to see what (if anything) breaks.
13:23 Dyrcona Has anyone ever left a server/vm set to UTC, and if so, did you encounter any noticeable issues?
13:49 kmlussier joined #evergreen
13:51 jeff I recall having issues with that recently on 3.7. I think it was the database server being left at UTC, and I don't recall of the top of my head how far I looked into if that was an issue with lib.timezone not being set somewhere, etc.
13:51 jeff I have it on my not-short list to poke at further.
13:52 kmlussier Dyrcona / mmorgan: Is this release checklist still used? https://wiki.evergreen-ils.org/doku.p​hp?id=dev:evergreen:release_checklist
13:52 kmlussier I'm just looking for a place to put a reminder to update the history repo at release time.
13:53 Dyrcona kmlussier: I don't think anyone still uses that checklist.
13:56 kmlussier Dyrcona: Is there another place documenting the release process where this reminder may be useful?
13:58 Dyrcona We've been discussing updating the release documentation/process. Right now, it's in limbo. The closest thing is still the 2.8 release process that has been sort of kept up to date: https://wiki.evergreen-ils.org/doku.ph​p?id=dev:release_process:evergreen:2.8
14:00 Dyrcona Before today, it doesn't look like anyone touched the history repository in 2 years.
14:00 kmlussier 3
14:03 Dyrcona You're right. For some reason I thought bshum's edit was from 2020.
14:05 jeffdavis regarding timezones, it's been a while since we had any servers on UTC time, but we do have libraries across multiple timezones and the timezone support built into Evergreen is meeting our needs these days
14:08 Dyrcona jeffdavis++
14:09 Dyrcona I know we fixed a bunch of issues in the past. I might set one of these vms back to UTC to try it out.
14:14 Dyrcona I've not really noticed before, but I wonder if there's a reason we setup the offline directory twice in our Apache configuration? It's done in eg.conf and again in eg_vhost.conf. I wonder if we do that for other directories?
14:33 Dyrcona So, first complete installations of Evergreen with Pg 15 completed. OPAC and staff client seem to work. Now to run the tests.
14:38 Dyrcona pgtap tests all pass.
14:49 Dyrcona Perl tests also pass.
14:58 Dyrcona Every now and then, I think the action.hold_request.phone_notify field should be changed to a Boolean, particularly when we get tickets asking why the patron's "real" phone number doesn't print on the hold slip.
16:06 Dyrcona Oof...
16:07 Dyrcona Just missed .....
16:29 Dyrcona jeff++ # I missed your comment earlier about timezones. I looked away for a moment.
17:12 mmorgan left #evergreen
17:35 mantis1 joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat