| Time |
Nick |
Message |
| 06:26 |
|
collum joined #evergreen |
| 07:23 |
pinesol |
News from commits: Lp 1943634: Fix MARC Stream Importer Temp File Creation <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a25fd7a675cc3ddca1c745352a1ddb73c4e07f82> |
| 07:37 |
|
kworstell-isl joined #evergreen |
| 07:50 |
|
BDorsey joined #evergreen |
| 08:23 |
pinesol |
News from commits: LP1995653: small create_release_notes script changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7ea8c16c9f239fbf580cc4c6a6a530de531687f2> |
| 08:29 |
|
mmorgan joined #evergreen |
| 08:42 |
|
dguarrac joined #evergreen |
| 08:53 |
pinesol |
News from commits: LP#1969994: Add Release Note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e803ba41de39921795a0db15496cbcde8dfebf7d> |
| 08:53 |
pinesol |
News from commits: LP#1969994: Stripe: Add User Database ID <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=362c534a65481d55747eaf16cee34140d277e37f> |
| 10:23 |
|
rfrasur joined #evergreen |
| 10:40 |
|
Christineb joined #evergreen |
| 11:39 |
|
JBoyer_ joined #evergreen |
| 11:55 |
|
jvwoolf joined #evergreen |
| 12:11 |
|
jihpringle joined #evergreen |
| 12:48 |
|
jvwoolf joined #evergreen |
| 13:18 |
|
collum joined #evergreen |
| 14:00 |
|
BDorsey joined #evergreen |
| 14:48 |
JBoyer |
Dev meeting coming in around 10 mins. |
| 14:51 |
|
shulabear joined #evergreen |
| 14:54 |
|
jihpringle joined #evergreen |
| 15:01 |
|
tlittle joined #evergreen |
| 15:01 |
JBoyer |
Ding, ding, ding. |
| 15:01 |
JBoyer |
#startmeeting 2022-11-15 - Developer Meeting |
| 15:01 |
pinesol |
Meeting started Tue Nov 15 15:01:13 2022 US/Eastern. The chair is JBoyer. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:01 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 15:01 |
pinesol |
The meeting name has been set to '2022_11_15___developer_meeting' |
| 15:01 |
JBoyer |
#info Agenda at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2022-11-15 |
| 15:01 |
JBoyer |
#topic Introductions |
| 15:01 |
phasefx |
#info phasefx = Jason Etheridge, EOLI |
| 15:01 |
gmcharlt |
#info gmcharlt = Galen Charlton, Equinox |
| 15:01 |
JBoyer |
#info JBoyer = Jason Boyer, Equinox |
| 15:01 |
berick |
#info berick Bill Erickson, KCLS |
| 15:01 |
mmorgan |
#info mmorgan = Michele Morgan, NOBLE |
| 15:01 |
jeffdavis |
#info jeffdavis = Jeff Davis, BC Libraries Cooperative (Sitka) |
| 15:02 |
dmoore |
#info dmoore = Dan Moore, KCLS |
| 15:03 |
miker |
#info miker = Mike Rylander, EOLI |
| 15:03 |
|
Guest3 joined #evergreen |
| 15:04 |
shulabear |
#info shulabear = Shula Link, GCHRL in PINES |
| 15:04 |
JBoyer |
Ok, others should feel free to #info-in as they arrive. |
| 15:04 |
JBoyer |
#topic Action Items from Last Meeting |
| 15:05 |
JBoyer |
#info sandbegja and others are looking into AngularJS node module security updates |
| 15:05 |
JBoyer |
#link https://bugs.launchpad.net/evergreen/+bug/1992529 |
| 15:05 |
pinesol |
Launchpad bug 1992529 in Evergreen "Upgrade insecure npm dependencies for angularjs staff client" [Medium,New] |
| 15:06 |
JBoyer |
It looks like things are going alright, terranm was able to successfully do some testing but no one involved seems to be here to expand on it. |
| 15:06 |
JBoyer |
There is a branch available that anyone comfortable poking at Angular should take a look at, if it made it in before 3.10 that would be great. |
| 15:07 |
JBoyer |
#topic Evergreen Release Updates |
| 15:07 |
JBoyer |
Any updates from the 3.10 relteam? |
| 15:07 |
gmcharlt |
yes - |
| 15:07 |
scottangel |
Well Hello Evergreen! New Dev here looking for new dev info. |
| 15:07 |
gmcharlt |
I will be cutting 3.10.0 today; it will be identiical to the release candidate with the exception of some release notes updates |
| 15:08 |
gmcharlt |
scottangel: welcome; we've started a development meeting; please stay and watch! |
| 15:08 |
gmcharlt |
and any strings |
| 15:08 |
gmcharlt |
I will also branch rel_3_10 today |
| 15:08 |
gmcharlt |
note that pushes to master since the RC was cut will be retargeted to 3.10.1 |
| 15:09 |
gmcharlt |
I'll also cut an OpenSRF release towards end of the week |
| 15:09 |
gmcharlt |
also, I want to particularly acknowledge the efforts of sandbergja, mmorgan, terranm during this release cycle |
| 15:09 |
JBoyer |
gmcharlt++ |
| 15:10 |
JBoyer |
sandbergja++ |
| 15:10 |
JBoyer |
mmorgan++ |
| 15:10 |
JBoyer |
terranm++ |
| 15:10 |
shulabear |
gmcharlt++ sandbergja++ mmorgan++ terranm++ |
| 15:10 |
berick |
sandbergja++ mmorgan++ terranm++ gmcharlt++ |
| 15:10 |
mmorgan |
gmcharlt++ |
| 15:10 |
mmorgan |
sandbergja++ |
| 15:10 |
mmorgan |
terranm++ |
| 15:11 |
JBoyer |
Thanks gmcharlt! Anything else before moving on to LP stats? (Feel free to keep the karma coming as well) |
| 15:11 |
gmcharlt |
no, that's it, other than suggesting that shooting for a 3.10.1 in short order might be good |
| 15:12 |
JBoyer |
+1 I had pushed a few things this morning thinking that they'd make it into 3.10.0, so that sounds good to me. |
| 15:12 |
JBoyer |
#topic Launchpad Status |
| 15:12 |
* JBoyer |
#info Snapshot |
| 15:12 |
JBoyer |
#info Snapshot |
| 15:12 |
JBoyer |
#info Open Bugs - 2795 |
| 15:12 |
JBoyer |
#info Pullrequests - 72 |
| 15:12 |
JBoyer |
#info Signedoff - 43 |
| 15:13 |
JBoyer |
#info Updates Since Last Meeting |
| 15:13 |
JBoyer |
#info Bugs Added - 56 |
| 15:13 |
JBoyer |
#info Pullrequest tag Added - 29 |
| 15:13 |
JBoyer |
#info Signedoff tag Added - 25 |
| 15:13 |
JBoyer |
#info Fix Committed - 67 |
| 15:13 |
JBoyer |
mmorgan++ |
| 15:13 |
JBoyer |
#topic New Business |
| 15:13 |
JBoyer |
#topic Improving QA - there are some issues that commonly recur with new patches, e.g. selectors not being scoped. Should there be a checklist to help devs/committers check for these problems? Other processes? |
| 15:14 |
jeffdavis |
This was brought up by support folks here at Sitka. |
| 15:14 |
JBoyer |
jeffdavis++ I was trying to find out who brought this up in the Wiki history and was coming up short. :) |
| 15:15 |
mmorgan |
jeffdavis++ |
| 15:15 |
JBoyer |
(we've also reached the end of my pre-prepared copy/paste script which will be obvious soon enough.) |
| 15:16 |
JBoyer |
To your question, there are a couple things I've been thinking about but haven't been able to research as thoroughly as I'd hoped. |
| 15:16 |
jeffdavis |
Some other common problems I've heard about are settings being made obsolete but not removed, new features being committed without documentation, or existing features being overlooked when a UI is rewritten. |
| 15:17 |
jeffdavis |
I don't know if devs/committers would find a checklist useful or if that's even a good way to capture this kind of stuff? |
| 15:17 |
gmcharlt |
checklists can be good as a statement of expectations, but the more than can be automated, the better |
| 15:17 |
JBoyer |
It seems like a checklist would be tricky for issues as broad as those. (documentation, perhaps, wouldn't be too bad) |
| 15:18 |
gmcharlt |
e.g., I can imagine ways to provide more support for documentation, at least at the release notes level. |
| 15:19 |
gmcharlt |
for example, if we devised as scheme where for the small enhancements that are briefly descibed, that a relase notes entry could be tagged in the commit message for later extraction, maybe that would help |
| 15:19 |
Bmagic |
#info Bmagic = Blake GH, MOBIUS |
| 15:19 |
gmcharlt |
but in any event, I think the starting point is fleshing out the list of concerns so we know what we're dealing with |
| 15:20 |
gmcharlt |
then implementing improvements where we can |
| 15:20 |
JBoyer |
I've been meaning to look more into git hooks, especially a pre-push, to maybe run some QA scripts that are packaged in the repo to at least force some forethought, even if only to make you type "y" to ignore the advice. |
| 15:20 |
JBoyer |
And a list of concerns like gmcharlt mentioned would help make that more useful. |
| 15:20 |
gmcharlt |
also, I think there would be scope for some mini-projects. E.g., "go through the list of library setting looking for ones that are no longer reference" |
| 15:21 |
|
jvwoolf joined #evergreen |
| 15:21 |
gmcharlt |
or "go through all of the TODO and FIXME comments in the code" |
| 15:21 |
berick |
agreed a list of common issues could be helpful |
| 15:21 |
gmcharlt |
or "go through the release notes for the past few years and note any deprecation announcements" |
| 15:24 |
jeffdavis |
Given our code, is it possible to automate something like testing that a shelving location selector can be scoped by org unit? |
| 15:26 |
gmcharlt |
generally speaking, yes - more unit tests for the Angular components is certainly possible |
| 15:26 |
JBoyer |
sandbergja demo'd some "e2e" testing during the hackaway that could potentially do things like that; they're Angular tests that drive the browser and verify its results. |
| 15:26 |
gmcharlt |
but that's a very concrete way of answering the question |
| 15:26 |
gmcharlt |
jeffdavis: is the question more about how to enumerate and document standing expectations for behavior? |
| 15:27 |
jeff |
If we start with a list that is suitable for use as a checklist, then we could use the start with using the checklist and potentially craft some automated lint-like checks of common issues like unscoped selectors. |
| 15:29 |
gmcharlt |
commit message templates embedding a (brief) checklist might also be a way - https://thoughtbot.com/blog/better-commit-messages-with-a-gitmessage-template |
| 15:30 |
jeffdavis |
sorry, I keep typing and deleting responses :) |
| 15:30 |
|
shulabear joined #evergreen |
| 15:30 |
jeffdavis |
a checklist is one example of a way to improve the QA part of our test/commit process, I think we're interested in any kind of solution that improves QA to avoid these kind of recurring problems |
| 15:31 |
jeffdavis |
(it is a very broad problem set for sure, and I agree that formulating a more specific list would be a great next step) |
| 15:32 |
jeffdavis |
I can do some more work with our local support folks to gather more specific examples and flesh out a list for next meeting. |
| 15:33 |
JBoyer |
jeffdavis++ |
| 15:33 |
JBoyer |
Care to #action that for the notes? |
| 15:33 |
shulabear |
jeffdavis++ |
| 15:33 |
jeffdavis |
oh no, a commitment! |
| 15:34 |
jeffdavis |
#action jeffdavis will gather more specific examples of recurring QA problems to present for discussion at the next dev meeting |
| 15:35 |
mmorgan |
It would also be great if lp bugs that report things like features lost in rewrites could get more attention :) |
| 15:36 |
gmcharlt |
while those are regressions, I wonder if an additional, more specific LP tag would be useful |
| 15:37 |
JBoyer |
mmorgan++ We could potentially plan to discuss *blocker bugs at these meetings to put them in front of more eyes. |
| 15:39 |
|
sleary joined #evergreen |
| 15:40 |
mmorgan |
Bug of the month! |
| 15:40 |
jeffdavis |
ha, I like that idea :) |
| 15:41 |
|
shulabear43 joined #evergreen |
| 15:41 |
JBoyer |
"This month we highlight a bug that has it all! Undefined variable scoping, user data loss, and red herring log entries!" |
| 15:42 |
JBoyer |
Anyway, jeffdavis++ for bringing this up, and if you feel like the checklist is ready to share before the next meeting feel free to share it on the dev lists. |
| 15:43 |
jeffdavis |
will do |
| 15:43 |
JBoyer |
#topic Community Calendar Access - Does every community calendar have at least 2 (active) admins? Do any of them need to have old accounts removed? Do any calendars need to be retired? (I'm aware of Communications, Community, Developers, and the Oversight board, though there may be others.) |
| 15:43 |
mmorgan |
jeffdavis++ |
| 15:44 |
JBoyer |
This one is from me. We've slowly been working our way through the various services cleaning up old accounts and possibly adding new ones. |
| 15:45 |
JBoyer |
In my opinion it would be ideal to have a shared @evergreen-ils.org account that's an admin/owner on all of the various calendars so there's always at least 1 active account that can always make changes if needed. |
| 15:47 |
gmcharlt |
easy enough to set up a time-controller evergreen-ils.org group |
| 15:47 |
JBoyer |
Any thoughts? Anyone know that this or that calendar is abandoned or no longer needed? |
| 15:47 |
gmcharlt |
and in general, I think keeping the Google Calendars up (or relaunching them) is probably the path of least resistance |
| 15:48 |
JBoyer |
Yeah, I'm not suggesting discarding the existing ones, I may be attributing more advanced ownership / permission options to them than they actually possess. |
| 15:49 |
gmcharlt |
yeah, though recreating them I think is an option we should consider |
| 15:50 |
JBoyer |
I think only 2 are in active use and I'm not 100% certain of that. |
| 15:50 |
|
shulabear54 joined #evergreen |
| 15:52 |
jeff |
I'd recommend creating a group on the evergreen-ils.org domain. As long as that group still exists and has the "manage permissions" permission on each calendar, the calendars will persist across the original owner being no longer a Google user, etc... regardless of the original domain/workspace that the calendar was created in. |
| 15:52 |
jeff |
And the calendar then remains the same ID, etc. |
| 15:52 |
shulabear54 |
jeff++ |
| 15:53 |
JBoyer |
jeff++ |
| 15:53 |
Bmagic |
jeff++ |
| 15:53 |
jeff |
We do this internally with a purpose-specific "calendar admin" group, after at least one instance of "only user with 'manage permissions' on a shared calendar was deleted, calendar was deleted also" event. :-) |
| 15:54 |
JBoyer |
I wasn't sure if sharing was smart enough to allow a group to be assigned to a calendar, but if so I'm fine with that over a shared Google account (which they understandably try to make very difficult to do.) |
| 15:54 |
gmcharlt |
yep |
| 15:54 |
JBoyer |
gmcharlt++ jeff++ |
| 15:54 |
jeff |
I think only very old resource calendars have domain-specific calendar IDs, most these days (including the handful of Evergreen community calendars I checked) end in @group.calendar.google.com |
| 15:54 |
JBoyer |
Sounds like a plan then. |
| 15:55 |
Bmagic |
execute! |
| 15:56 |
jeff |
I think the specific permission is spelled "Make changes and manage sharing" |
| 15:59 |
JBoyer |
I have access to create the group, I'll coordinate with the lists to see who has access to the various calendars so we can handle this out of band. |
| 15:59 |
JBoyer |
Thanks for the feedback everyone! |
| 15:59 |
JBoyer |
jeff++ gmcharlt++ |
| 16:00 |
JBoyer |
One more (important!) topic coming up |
| 16:00 |
jeff |
This is the closest "official" documentation of the "this prevents the calendar from being deleted when the owner is deleted" bit: https://support.google.com/calendar/answer/78739#zippy=%2Ctransfer-a-calendar-you-created |
| 16:00 |
JBoyer |
#topic Looking ahead to Angular 14 / Bootstrap 5 for EG 3.11 |
| 16:00 |
JBoyer |
#link https://bugs.launchpad.net/evergreen/+bug/1948693 |
| 16:00 |
pinesol |
Launchpad bug 1948693 in Evergreen "Migrate from NgbTabset to NgbNav (from ng-bootstrap)" [Medium,Confirmed] - Assigned to Stephanie Leary (stephanieleary) |
| 16:01 |
JBoyer |
berick, sorry for the lateness, but if there's anything you'd like to add it's all yours |
| 16:01 |
berick |
thanks |
| 16:01 |
berick |
a couple quick things |
| 16:01 |
berick |
I'm planning to start down the path of updating to Angular 14, Bootstrap 5, etc. |
| 16:02 |
berick |
first part is review/test/merge of bug 1948693, which now has a patch |
| 16:02 |
pinesol |
Launchpad bug 1948693 in Evergreen "Migrate from NgbTabset to NgbNav (from ng-bootstrap)" [Medium,Confirmed] https://launchpad.net/bugs/1948693 - Assigned to Stephanie Leary (stephanieleary) |
| 16:02 |
berick |
it touches lot of UI's, so my question is if I post it on a public VM somewhere can someone help me bounce through and test the UIs? |
| 16:02 |
berick |
basically making sure they load OK and tabs work OK |
| 16:03 |
berick |
i'll post a link to the LP when it's testable |
| 16:03 |
berick |
i don't need a committment, just putting that out there. |
| 16:03 |
sleary |
I would appreciate a lot of eyes on this one. Obviously I ran through them before committing, but there are a few areas where I didn't have adequate test data |
| 16:03 |
JBoyer |
I'm sure pinging the dev lists would help get some people to poke at it too. |
| 16:04 |
berick |
more generally, the Angular etc update is going to affect probably every angular dependency. |
| 16:04 |
berick |
it's not something we'll want to let linger once it's ready |
| 16:04 |
berick |
so just a heads up that i'm heading in that direction |
| 16:05 |
berick |
this is for 3.11, not 3.10 |
| 16:05 |
berick |
after 3_10 is branched, etc. |
| 16:05 |
berick |
sleary++ |
| 16:05 |
shulabear |
sleary++ |
| 16:06 |
JBoyer |
sleary++ berick++ |
| 16:06 |
berick |
that's it from me. i'll carry on in LP |
| 16:06 |
Bmagic |
I can put that patch on bugsquash |
| 16:06 |
Bmagic |
berick++ sleary++ |
| 16:06 |
berick |
Bmagic: i won't stop you! |
| 16:06 |
Bmagic |
:) |
| 16:06 |
sleary |
One thing to keep an eye out for: keyboard navigation should work, but if there are any tab panels that don't contain a focusable element (input, link, etc.) we will need to manually set the tabindex on something; otherwise you won't be able to tab your way into the panel |
| 16:07 |
sleary |
this is a... feature, let's call it... of Bootstrap tabs |
| 16:07 |
gmcharlt |
heh |
| 16:08 |
sleary |
Also, we need to look at one tab (I've lost it, but I'll go find it) that has a dropdown in the tab title. That's a no-go for accessibility and we'll need to think of some other way to present that |
| 16:09 |
sleary |
that can be a separate bug/patch though |
| 16:10 |
JBoyer |
Sounds good! |
| 16:10 |
JBoyer |
Any last minute new business before the meeting ends? |
| 16:10 |
JBoyer |
#topic Announcements |
| 16:10 |
JBoyer |
#info Next Meeting is December 13th, 2022 at noon Pacific / 3 pm Eastern |
| 16:10 |
JBoyer |
#endmeeting |
| 16:10 |
pinesol |
Meeting ended Tue Nov 15 16:10:44 2022 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 16:10 |
pinesol |
Minutes: http://evergreen-ils.org/meetings/evergreen/2022/evergreen.2022-11-15-15.01.html |
| 16:10 |
pinesol |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2022/evergreen.2022-11-15-15.01.txt |
| 16:10 |
pinesol |
Log: http://evergreen-ils.org/meetings/evergreen/2022/evergreen.2022-11-15-15.01.log.html |
| 16:10 |
JBoyer |
Thanks everybody |
| 16:10 |
miker |
JBoyer++ |
| 16:10 |
berick |
thanks JBoyer |
| 16:10 |
miker |
berick (or anyone, really): post-meeting question related to angular updates, generally. I have a branch that, in order to get working, I had to update nodejs and I got a tonne of changes in both package-lock.json ... I should /not/ commit those, correct? |
| 16:10 |
mmorgan |
JBoyer++ |
| 16:11 |
sleary |
JBoyer++ |
| 16:11 |
shulabear |
JBoyer++ |
| 16:12 |
JBoyer |
Also, scottangel feel free to ask any questions you might have now, it's basically a free-for-all when meetings aren't going on. :) |
| 16:12 |
scottangel |
Well then... One question I have is... can I help with the Bootstrap 5 conversion? I love me some bootstraps. |
| 16:13 |
* jeff |
pokes at Google Calendar a bit more... |
| 16:13 |
berick |
miker: if your patch involves updating nodejs or adding new deps, then I'd say yes to committing it |
| 16:14 |
berick |
scottangel++ # we will need lots of manual testing |
| 16:14 |
miker |
well, it /shouldn't/ require that. just a consequence of installing a new version of the node.js binaries |
| 16:14 |
miker |
and rebuilding node_modules |
| 16:14 |
scottangel |
I can help with that as well. |
| 16:17 |
berick |
miker: gotcha, yeah if your nodejs changes are not specifically related to the patch/branch, then I would avoid committing the lock file. |
| 16:17 |
berick |
it will get completely updated soon enough w/ the angular verion updates. |
| 16:19 |
miker |
right, thanks for confirming. a lot seem to be just the contents changing order, or minor version bumps and consequent hash changes. a lot of seemingly unimportant churn. but I also don't want to assume it's /actually/ unimportant |
| 16:19 |
miker |
thanls |
| 16:19 |
miker |
thanks, even |
| 16:28 |
scottangel |
Who would I 'bug' to activate my ssh key for squashing some of these bugs? I emailed gitadminevergreen-ils.org yesterday. I wasn't sure how long these things take. |
| 17:01 |
|
mmorgan left #evergreen |
| 17:05 |
|
jihpringle joined #evergreen |
| 17:10 |
|
jvwoolf left #evergreen |
| 18:07 |
gmcharlt |
rel_3_10 is now branched |
| 18:10 |
gmcharlt |
scottangel: 'tis done; check your email |
| 18:36 |
|
jihpringle joined #evergreen |
| 19:08 |
gmcharlt |
https://evergreen-ils.org/evergreen-3-10-0-released/ |
| 19:24 |
pinesol |
News from commits: wipe the release note slate clean <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7e2770d633894c3988f778fcd2412001b1d0b50f> |
| 19:24 |
pinesol |
News from commits: forward-port 3.10.0 database update script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b12f18bc9af6dc22952b228ab6a5c74fb0fc2e4a> |
| 19:24 |
pinesol |
News from commits: forward-port 3.10 release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=43fbd913d5ebd1e7cf9b0bff4c2970e0b09162b1> |
