| Time |
Nick |
Message |
| 02:03 |
|
stephengwills_ joined #evergreen |
| 07:29 |
|
rjackson_isl_hom joined #evergreen |
| 07:50 |
|
rfrasur joined #evergreen |
| 08:33 |
|
Dyrcona joined #evergreen |
| 08:55 |
Dyrcona |
bshum++ |
| 08:57 |
|
mmorgan joined #evergreen |
| 09:22 |
|
BDorsey joined #evergreen |
| 09:49 |
|
mantis1 joined #evergreen |
| 10:29 |
berick |
mmorgan: re: bug 1823225, we can't really detect at the code level a page refresh vs. a regular page load, unless there's a button/link in the page to initiate the action. |
| 10:29 |
pinesol |
Launchpad bug 1823225 in Evergreen "Web client has no way to recalculate patron penalties" [High,Confirmed] https://launchpad.net/bugs/1823225 |
| 10:30 |
berick |
we could recalc penalties every time a patron is loaded in the patron checkout page, but that would mean a lot of unnecessary api calls. maybe worth it? |
| 10:32 |
|
jvwoolf joined #evergreen |
| 10:32 |
berick |
could be done by modifing open-ils.actor.user.fleshed.retrieve to do the additional backend work without requiring another call from the client |
| 10:53 |
mmorgan |
berick: Ooh! So recalc penalties while you're getting all the patron information anyway? If I'm reading that right, it sounds ideal. |
| 10:56 |
berick |
mmorgan: right. it still adds work to the servers that is unnecessary 99% of the time, and could add a slight delay to patron retrieval, so there's a tradeoff. |
| 10:58 |
|
stephengwills_ left #evergreen |
| 10:59 |
Dyrcona |
I think the delay will vary depending on number of bills, etc. for a given patron. It won't be a fixed cost. |
| 11:01 |
mmorgan |
berick: Right. Might be worth a wishlist bug to see where the discussion goes. |
| 11:04 |
berick |
yeah, probably. better ideas may emerge. |
| 11:04 |
Dyrcona |
I was going to say something about controlling recalc with YAOUS or a flag on retrieval, but maybe it should just be all the time. We've got enough options already. |
| 11:04 |
Dyrcona |
+1 to discussion on Lp. |
| 11:04 |
Dyrcona |
mmorgan++ berick++ |
| 11:05 |
mmorgan |
In the meantime, bug 1823225 looks great and fills a needed gap! |
| 11:05 |
pinesol |
Launchpad bug 1823225 in Evergreen "Web client has no way to recalculate patron penalties" [High,Confirmed] https://launchpad.net/bugs/1823225 - Assigned to Michele Morgan (mmorgan) |
| 11:05 |
mmorgan |
berick++ |
| 11:06 |
Dyrcona |
I'm OK with just a button in the client, too. There may be times you don't want the backend to recalculate penalties when retrieving a patron, but I can't think of any off the top of my head. |
| 11:38 |
|
jihpringle joined #evergreen |
| 12:59 |
|
BDorsey joined #evergreen |
| 13:16 |
|
jihpringle joined #evergreen |
| 13:59 |
jihpringle |
dluch: the link for today's DIG meeting didn't make it into the agenda |
| 14:31 |
|
tsadok joined #evergreen |
| 16:51 |
pinesol |
News from commits: LP1823225 Patron Penalty Refresh Action <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=abf033c19050af93973a2d204378918cc6253749> |
| 17:10 |
|
mmorgan left #evergreen |
| 17:12 |
|
jvwoolf left #evergreen |
