| Time |
Nick |
Message |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:40 |
|
rfrasur joined #evergreen |
| 07:03 |
|
rjackson_isl_hom joined #evergreen |
| 07:04 |
|
JBoyer joined #evergreen |
| 07:56 |
|
collum joined #evergreen |
| 08:34 |
|
mantis1 joined #evergreen |
| 08:35 |
|
Dyrcona joined #evergreen |
| 08:40 |
|
jvwoolf joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 09:06 |
* Dyrcona |
should have been a pharmacist. Then I might be able to read my own handwriting. :) |
| 09:53 |
Dyrcona |
Redundant code is redundant. |
| 09:54 |
Dyrcona |
Refactor ALL THE THINGS!!!!! |
| 09:55 |
mmorgan |
:) |
| 10:00 |
|
rjackson_isl_hom joined #evergreen |
| 10:14 |
JBoyer |
Rewrite! |
| 10:14 |
rfrasur |
lol |
| 10:14 |
* JBoyer |
stares at empty editor |
| 10:14 |
JBoyer |
Oh no. |
| 10:14 |
Dyrcona |
JBoyer++ |
| 10:14 |
* rfrasur |
looks on soulless. |
| 10:15 |
Dyrcona |
I've been feeling that way even when the editor isn't empty. "I should refactor this so that....Nah. Not today." |
| 10:15 |
* Dyrcona |
closes file in editor. |
| 10:16 |
* Dyrcona |
hugs rfrasur. |
| 10:16 |
rfrasur |
aww, thank you. |
| 10:18 |
rfrasur |
Less angsty comment - I've been wandering through "you are here" by Thich Nhat Hanh (highly recommend) and the Anam Cara by John O'Donohue (also highly recommend) and in one of them (I have it marked, but don't want to refer back right now) there is a thread of our bodies inhabiting our souls rather than the other way around. I thought it was cool and continue to ponder it. |
| 10:19 |
jeff |
@decide [blame launchpad] or [blame my computer] |
| 10:19 |
pinesol |
jeff: go with jeff's computer stole jeff's ice cream! |
| 10:19 |
jeff |
very good. and by "ice cream", we mean "launchpad comment" |
| 10:21 |
|
Keith-isl joined #evergreen |
| 10:22 |
Dyrcona |
rfrasur++ # This is starting to sound like one of our midnight conversations at the conference, and thanks for the reading recommendations. |
| 10:23 |
csharp_ |
@dunno add I just wanted to let you know that you mean a lot to me |
| 10:23 |
pinesol |
csharp_: The operation succeeded. Dunno #70 added. |
| 10:25 |
Dyrcona |
@decide forgive payments or delete bills |
| 10:25 |
pinesol |
Dyrcona: go with delete bills |
| 10:25 |
Dyrcona |
pinesol: I don't think so, that's more work. |
| 10:25 |
pinesol |
Dyrcona: Fire BAD! Reading GOOD! |
| 10:25 |
csharp_ |
pinesol: also, you need to understand that deleting bills is also deleting HISTORY |
| 10:25 |
pinesol |
csharp_: Try restarting apache. |
| 10:26 |
Dyrcona |
Note on the forgive payments: "Jason borked an update." Eh, mebbe not. |
| 10:26 |
mmorgan |
Hah! |
| 10:26 |
csharp_ |
@who borked an update? |
| 10:26 |
pinesol |
Christineb borked an update. |
| 10:26 |
Dyrcona |
Well, I added bills when I should not have. |
| 10:26 |
csharp_ |
Dyrcona: ^^ pinesol said it, not me |
| 10:27 |
mmorgan |
Dyrcona: Void them? |
| 10:27 |
csharp_ |
void is probably the most appropriate for that situation |
| 10:27 |
Dyrcona |
mmorgan++ csharp_++ I'll void them. |
| 10:28 |
mmorgan |
Unless it's possible that some payments have been made... |
| 10:28 |
csharp_ |
Dawn explains it to staff like this "forgive means you're letting the patron off the hook for paying; void means the bills should have never existed in the first place" |
| 10:28 |
mmorgan |
(negative balances) |
| 10:29 |
Dyrcona |
Well, I added new bills after the previous bills had been paid because my fix for a previous mistake didn't check the copy status or something..... |
| 10:30 |
Dyrcona |
So, I'll void the new bills, unless I mess it up again. |
| 10:30 |
csharp_ |
wow, do I hate billing corrections |
| 10:30 |
Dyrcona |
Yeah, me, too. |
| 10:30 |
csharp_ |
also bills |
| 10:30 |
mmorgan |
Me three. |
| 10:30 |
Dyrcona |
Communication is important. This comes from a ticket where I and someone else made assumptions about what needed to be done, and those assumptions were polar opposites. |
| 10:31 |
rfrasur |
Dyrcona++ |
| 10:31 |
mmorgan |
Encouragingly, the majority of our libraries are now fine free :) |
| 10:31 |
mmorgan |
Gone are the $.02 fines!! |
| 10:31 |
Dyrcona |
Yeah, we have more going fine free. But these are LOST AND PAID items I have to fix. |
| 10:32 |
Dyrcona |
Yeah, 2 cent fines in 2022.... :) |
| 10:32 |
Dyrcona |
Anyway, I should get to it. |
| 11:05 |
Bmagic |
is there a reason that OpenSRF 3.2.1 is associated with EG 3.8 (instead of 3.2.2)? https://evergreen-ils.org/egdownloads/ |
| 11:07 |
Dyrcona |
Grr... What's with Excel and scientific notation? |
| 11:07 |
Bmagic |
excell-- |
| 11:07 |
Dyrcona |
Even the item ids are using it. |
| 11:07 |
Bmagic |
excel-- |
| 11:08 |
mmorgan |
excel LOVES scientific notation :-/ |
| 11:08 |
Bmagic |
I totally agree, It's the main reason why I quote all the barcodes/ID's in any of my spreadsheet dumps |
| 11:10 |
* mmorgan |
does the ritual: format cells - Number - Decimal places: 0 |
| 11:12 |
Dyrcona |
Well, I saved it as an OpenDocument Spreadsheet. I suppose I could have also also converted it to a CSV after formatting the cells. |
| 11:14 |
Dyrcona |
Bmagic: Yeah, I usually make sure the barcodes are formatted as text, too. |
| 11:14 |
jvwoolf |
mmorgan++ ## I know this ritual well |
| 11:14 |
Dyrcona |
Bmagic: Was OpenSRF 3.2.2 released when 3.8.0 was released? |
| 11:15 |
Dyrcona |
LibreOffice has a separate Scientific number format, but XLSX files come pre-messed up sometimes. :) |
| 11:17 |
* Dyrcona |
thinks one cannot use CStoreEditor to retrieve and flesh an object at the same time, i.e. I can't retrieve a copy by id and flesh its circulations. |
| 11:26 |
Dyrcona |
Oh, cool. I can use the date to figure out which bills to void. |
| 11:58 |
|
jihpringle joined #evergreen |
| 12:45 |
miker |
Dyrcona: I believe you can retrieve-and-flesh. the search and flesh+order_by params just need to be wrapped in an arrayref, IIRC |
| 12:45 |
* miker |
looks |
| 12:47 |
miker |
Dyrcona: see line ~87 of OpenILS/WWW/EGCatLoader/Util.pm (master-ish) |
| 12:48 |
miker |
that's search, but see OpenILS/SIP/Patron.pm around line 104 for a retrieve example |
| 12:52 |
Dyrcona |
miker: Thanks. You just saying that rings a bell. But I'm almost ready to test my script. |
| 12:57 |
Dyrcona |
Funny thing. I recently wrote a cstoreeditor search with idlist=>1, and I got an error when I wrapped the params in an arrayref. It worked without it, though. I think it depends on what you're doing. |
| 13:08 |
Dyrcona |
It's all an approximation, anyway. :) |
| 13:30 |
|
jihpringle joined #evergreen |
| 13:33 |
Dyrcona |
Hmm.. Guess it isn't possible to search auditor.asset_copy_history via cstore.... |
| 13:34 |
Dyrcona |
I'll need SQL for that. I should figure out if I really need to do that. |
| 13:37 |
Dyrcona |
I guess if I do find some copies/transactions that need fixing that way, I could just dump the ids to a file and write a script to fix just those things. |
| 14:16 |
Dyrcona |
Don't make mistakes, ever.... |
| 14:27 |
Dyrcona |
Billing is too complicated. |
| 14:34 |
mmorgan |
Making mistakes teaches you ... to not make mistakes. |
| 14:35 |
Dyrcona |
mmorgan++ |
| 14:47 |
|
JBoyer joined #evergreen |
| 15:07 |
Dyrcona |
copy.id <> ANY([ARRAY of ids]) doesn't do what I thought. :) |
| 15:08 |
Dyrcona |
Doesn't do what a NOT IN ([list]) does. |
| 15:11 |
Bmagic |
we have an issue with master 002.schema.config.sql |
| 15:12 |
Bmagic |
line 95, merged 2022-02-25 commit 17eed0d8e81 |
| 15:12 |
Bmagic |
INSERT INTO config.upgrade_log (version, applied_to) VALUES ('1311', :eg_version); -- miker/Dyrcona/jvwoolf/mmorgan |
| 15:12 |
Bmagic |
made it's way into the schema setup sql file |
| 15:14 |
Dyrcona |
Bmagic: That's supposed to be there, isn't it? |
| 15:14 |
Bmagic |
It's killing the abillity to create a fresh db |
| 15:15 |
Dyrcona |
How so? What's the error? |
| 15:15 |
Bmagic |
ERROR: syntax error at or near ":" |
| 15:15 |
Bmagic |
LINE 1: ...upgrade_log (version, applied_to) VALUES ('1311', :eg_versio... |
| 15:16 |
Bmagic |
creating rows for the upgrade_log are for upgrade sql scripts right? Not the creation scripts? |
| 15:18 |
Dyrcona |
How are you creating the new database? |
| 15:19 |
Bmagic |
perl Open-ILS/src/support-scripts/eg_db_config --update-config --service all --create-database --create-schema --create-offline --user evergreen --password databasepassword --hostname 127.0.0.1 --port 5432 --database evergreen --admin-user admin --admin-pass demo123 --load-all-sample |
| 15:19 |
Dyrcona |
Bmagic: That has worked forever and the :eg_version has been there forever. Maybe something else is broken? |
| 15:20 |
Bmagic |
git blame says that line was put there 2022-02-25 |
| 15:21 |
Dyrcona |
Bmagic: Sure, but `git log -p -- Open-ILS/src/sql/Pg/002.schema.config.sql` tells a longer story. |
| 15:21 |
mmorgan |
Bmagic: That line was edited for the most recent upgrade script, but it's not new. |
| 15:21 |
Bmagic |
stranger and stranger |
| 15:22 |
Dyrcona |
:eg_version is supposed to be set to an empty string somewhere when you do the normal setup dance. |
| 15:22 |
Bmagic |
welp, I must be having an issue elsewhere, I'll keep digging |
| 15:22 |
Dyrcona |
I'm going to do something for CW MARS, and then I can try for myself to see what happens. |
| 15:23 |
JBoyer |
I've built a pair of new databases today, but having :eg_version in any file in src/sql/Pg seems very odd to me. |
| 15:25 |
JBoyer |
But there it is, huh. |
| 15:25 |
Dyrcona |
JBoyer: It has been there for quite a while. |
| 15:26 |
* Dyrcona |
was looking at this recently while brainstorming on more release automation. |
| 15:27 |
JBoyer |
Anyway, Bmagic, eg_version is set to NULL in build-db.sh, so if anything has changed there or you're building the db in an unusual way that's something to check. |
| 15:28 |
Dyrcona |
JBoyer++ |
| 15:28 |
JBoyer |
Part of me has always been a little bothered (apparently very little, but still) that we use a client-specific feature like :variables at all. |
| 15:28 |
Dyrcona |
That's what I was going to check. |
| 15:29 |
Dyrcona |
If you build the db ins some other way then you're on your own. :) |
| 15:29 |
Bmagic |
ok, I think it's a patch I've merged |
| 15:31 |
Bmagic |
thanks for helping me talk through it. The issue ended up being something different (once I manually set the :eg_version variable) and got passed that, the real issue is at the bottom, where a patch is creating two new tables in the config schema... but it's REFERENCEing a table that doesn't exist (yet) |
| 15:32 |
Dyrcona |
Bmagic: What patch are you testing? |
| 15:32 |
Bmagic |
bug 1786524 |
| 15:32 |
pinesol |
Launchpad bug 1786524 in Evergreen "Add a support script for importing patrons" [Wishlist,New] https://launchpad.net/bugs/1786524 |
| 15:32 |
Bmagic |
I'm about to fix it and supply the commit |
| 15:33 |
mmorgan |
Whew!! |
| 15:45 |
JBoyer |
Oh, are the errors that actor.org_unit doesn't exist? |
| 15:57 |
|
jihpringle joined #evergreen |
| 15:58 |
Bmagic |
JBoyer: yepper |
| 15:59 |
Bmagic |
I moved those ALTER TABLE statements to the bottom of the actor schema sql, and I think we're good |
| 15:59 |
Bmagic |
posted to the bug |
| 16:00 |
JBoyer |
800.fkeys.sql is the most likely place for them to land in the end, but yeah, putting them anywhere after actor exists should get you going for next week. |
| 16:01 |
Bmagic |
oh, good to know |
| 16:01 |
pinesol |
News from commits: LP1964019: Change span tag to div to work around a Chrome bug <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=73ed6694dcfef2e3ee4b3dafd5987193c657624a> |
| 16:02 |
JBoyer |
There's probably a semi-reasonable argument to be made for putting *all* fkey relationships in there, but that's a discussion for another time. |
| 16:02 |
Dyrcona |
Bmagic: You could have just commented on the bug that it needs a rebase and altered the tags. |
| 16:03 |
* Dyrcona |
agrees with JBoyer on the semi-reasonable part. I wouldn't oppose such a change/commit. |
| 16:05 |
Bmagic |
Dyrcona: that thought crossed my mind, but I was too far committed at that point |
| 16:05 |
Bmagic |
invested* might be the better word |
| 16:06 |
Dyrcona |
Bmagic++ |
| 16:06 |
JBoyer |
mmorgan=+ |
| 16:06 |
JBoyer |
er, mmorgan++ |
| 16:07 |
mmorgan |
JBoyer++ |
| 16:23 |
Bmagic |
got the machine running, though I'm not seeing any org units other than CONS.... something different that I missed in a release note somewhere |
| 17:01 |
|
mmorgan left #evergreen |
| 17:09 |
|
jvwoolf left #evergreen |
| 17:45 |
|
book` joined #evergreen |
| 18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
