| Time |
Nick |
Message |
| 06:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:52 |
|
rjackson_isl_hom joined #evergreen |
| 08:30 |
|
Dyrcona joined #evergreen |
| 08:32 |
|
mmorgan joined #evergreen |
| 08:34 |
Dyrcona |
miker: We were discussing parallel ingest yesterday and the effects of symspell on it. I'm running pingest with the symspell triggers disabled and I got an error from the brows ingest. The DB host and and client machine are both using Ubuntu 20.04 and the db is Pg 10. |
| 08:35 |
Dyrcona |
I'm going to open a Lp bug even though I don't know if this is reproducible or just one of those things caused by our data. I want to let this pingest run finish because I'm timing it. |
| 08:43 |
|
mantis joined #evergreen |
| 08:49 |
Dyrcona |
Actually, I have the record id that failed, so I'll check if to see if I can figure out the cause before I open a LP bug. |
| 08:49 |
Dyrcona |
"if to see if...." I can English gud..... :) |
| 08:53 |
jeff |
since you're holding off on the lp bug and since I'm curious... what was the error? |
| 08:54 |
Dyrcona |
jeff: It's long. I'll paste it. Also, I'm not able to reproduce it on another database with "the same" data running Ubuntu 18.04. (I put the same in quotes because the record in question may not actually be identical. The 18.04 database is a couple of months older.) |
| 08:55 |
Dyrcona |
jeff: https://pastebin.com/p31vruks |
| 08:56 |
Dyrcona |
I suppose that I could try this in production to see what happens. That server is also Ubuntu 18.04 and Pg 10. |
| 08:57 |
Dyrcona |
It could be an Ubuntu 20.04 thing... |
| 08:59 |
Dyrcona |
No error in production, though production is 3.5.3 and the other two are upgraded to 3.7.2+. |
| 09:01 |
Dyrcona |
Well, it's repeatable in the database where it happened, so must be an Ubuntu 20.04 thing or something about that database/server. |
| 09:03 |
Dyrcona |
I'll try a 3.5.3 database on the same server. (It's nice having multiple copies of the same data....) |
| 09:03 |
Dyrcona |
Yeahp. Blows up there, too. |
| 09:04 |
Dyrcona |
psql (12.9 (Ubuntu 12.9-0ubuntu0.20.04.1), server 10.20 (Ubuntu 10.20-1.pgdg20.04+1)) |
| 09:04 |
Dyrcona |
The psql version is from my laptop. |
| 09:05 |
Dyrcona |
So, I *guess* we've got a bug.... |
| 09:05 |
Dyrcona |
Or Ubuntu does. |
| 09:12 |
Dyrcona |
Anyone know of a way to dump pg errors to a local file? I'll ask in #postgresql. |
| 09:13 |
|
Keith_isl joined #evergreen |
| 09:17 |
Dyrcona |
Think I'll RTFM, before I ask. It looks like the error from psql might be more useful than the one from pingest. |
| 09:18 |
Dyrcona |
Eh, no. It's the same, just less noisy. |
| 09:21 |
Dyrcona |
It also must be something about that record, because it is the only that has had this error so far. |
| 09:23 |
|
jvwoolf joined #evergreen |
| 09:24 |
Dyrcona |
So, no Lp bug for now. I'm going to see if this is a local data issue, first. |
| 09:34 |
JBoyer |
Dyrcona, something else to consider from that message is whether or not you have any local MODS or other xslt transforms. |
| 09:37 |
Dyrcona |
JBoyer: I think we do, so I'll check that. Thanks for the suggestion. |
| 09:47 |
jeff |
chopPunctuation, chopPunctuation, chopPunctuation... heh. |
| 09:49 |
Dyrcona |
Yeah, I haven't looked but I suspect a busted field in the MARC. Maybe i should dump it now before someone changes it. |
| 09:54 |
jvwoolf |
Dyrcona: Before I forget again, I wanted to say that we tested the patch in 1482757 and it worked fine. We've got it running in production now. |
| 09:54 |
jvwoolf |
Let's see if I can get that to link correctly - lp1482757 |
| 09:54 |
Dyrcona |
Lp 1482757 |
| 09:54 |
pinesol |
Launchpad bug 1482757 in Evergreen "Loading records with located URIs should not delete and recreate call_numbers" [Low,Confirmed] https://launchpad.net/bugs/1482757 |
| 09:54 |
jvwoolf |
Dyrcona++ |
| 09:54 |
Dyrcona |
For lp you need "Lp" with captial L. or you can bug # |
| 09:55 |
JBoyer |
lp 1482757 |
| 09:55 |
* JBoyer |
shakes fist at anything case-sensitive that's not a password |
| 09:55 |
Dyrcona |
jvwoolf: It works fine for me, too. It just doesn't speed things up in a noticeable way. Also, this process is still really slow on Pg 12+. |
| 09:56 |
jvwoolf |
Dyrcona: It sped up importing eresources pretty significantly for us |
| 09:56 |
Dyrcona |
So, just dumping the MARC to the screen I think I see the problem. There's a field that ends with a lot of blank spaces. |
| 09:56 |
Dyrcona |
Well, subfield.... |
| 09:57 |
jvwoolf |
Also, we removed the 30 million deleted URI call numbers and our call number reports work again. We also haven't had any drone timeouts since then, but that could be a cooincidence. |
| 09:57 |
Dyrcona |
jvwoolf: I guess, but I was looking for improvement on later Pg versions, which that patch doesn't do. If you want to sign off, feel free. |
| 09:58 |
mmorgan |
jvwoolf++ |
| 09:58 |
Dyrcona |
jvwoolf++ |
| 09:58 |
* Dyrcona |
is a bit preoccupied with other things at the moment. :/ |
| 10:00 |
jvwoolf |
Sorry about that! Just wanted to mention it before too much more time passed. |
| 10:00 |
mmorgan |
jvwoolf: That's great to hear that it's helped with your reports and speeded up importing! |
| 10:00 |
Dyrcona |
Oh, great....The record also has "smart" quotes.... |
| 10:02 |
Dyrcona |
No, it's not a problem. I just don't remember exactly what I said on the bug, and don't want to look it up right now. I'm 99% sure that I added my signoff. Which, by the way, is enough for mmorgan to push the patch if she's so inclined. :) |
| 10:03 |
Dyrcona |
So, I'll remove the excess spaces and see what happens. |
| 10:03 |
jvwoolf |
mmorgan: It was the deleting the call numbers that fixed the reports, which is separate from the patch. We had the system offline 6 hours overnight last weekend to accomplish that. |
| 10:04 |
mmorgan |
Woo! Pushing that would be a good task for a snowy Friday! It will be the first one I've looked at with an upgrade script. |
| 10:05 |
mmorgan |
jvwoolf: I don't think we saw a big improvement in speed when importing URI records, but it sounds like deleting some asset.call_number rows would help. |
| 10:06 |
mmorgan |
Sounds like a big project... |
| 10:07 |
Dyrcona |
jvwoolf: IIRC, you have a lot of deleted bibs and call numbers that go nowhere from a failed migration attempt or two. That was the reason I was given for the script to remove bibs with no copies. |
| 10:08 |
* Dyrcona |
remembers something from 8 years ago, but can't remember what he updated on a bug from last year. |
| 10:09 |
Dyrcona |
Right. Removing the spaces fixes things, so is this a bug or bad data? I think it's a bug triggered by bad data. |
| 10:09 |
* Dyrcona |
actually didn't mean to go this far today. I should be working on bootstrap customization. |
| 10:10 |
jvwoolf |
Dyrcona: I *think* those *might* be taken care of now, at least I hope so! |
| 10:10 |
Dyrcona |
jvwoolf++ |
| 10:22 |
* Dyrcona |
emails the cat. center about this record. |
| 10:27 |
Dyrcona |
I guess I might as well pursue this bug now and work on the customization after lunch. If I drop this now, I'll likely never get back to it. |
| 10:28 |
Dyrcona |
mmorgan: If you have any questions about pushing the db upgrade, feel free to ask. |
| 10:28 |
Dyrcona |
I'd wait for jvwoolf to sign off. Extra sign offs are always good. |
| 10:29 |
mmorgan |
Dyrcona: Thanks! I likely will in a bit. Yes, would love to see a signoff from jvwoolf, too! |
| 10:30 |
jvwoolf |
Dyrcona mmorgan: I'll do that now (speaking of things that won't be done if I move onto something else) |
| 10:56 |
jvwoolf |
mmorgan: I tried to push a signoff branch but got conflicts. In the interest of time, I've added my signoff as a comment on Lp 1482757 |
| 10:56 |
pinesol |
Launchpad bug 1482757 in Evergreen "Loading records with located URIs should not delete and recreate call_numbers" [Low,Confirmed] https://launchpad.net/bugs/1482757 |
| 10:57 |
mmorgan |
jvwoolf++ |
| 10:57 |
mmorgan |
Thanks! I'll take a look. |
| 11:05 |
miker |
Dyrcona: depending on exactly how the templates fit together (I don't recall exactly, but the error output looks like it's at least 2 templates per space) it may not take that many spaces/punct in a row to hit that ... about how many spaces would you say you removed? |
| 11:06 |
jeff |
(and do you have the original record that you can share?) |
| 11:16 |
Dyrcona |
miker: I can tell you exactly: 222 spaces |
| 11:16 |
Dyrcona |
So, that would be 444 templates? |
| 11:16 |
Dyrcona |
jeff: A qualified yes on sharing it. A definite yes on I still have the record. |
| 11:17 |
Dyrcona |
I should ask before I share it for reasons. |
| 11:21 |
Dyrcona |
Apparently, it's an item that no one else is likely to have. It's MARC type a (a book?) about the construction of one of our libraries. Looks to be a gift from the construction company. |
| 11:28 |
Dyrcona |
Of course the spaces don't show up in the staff client. |
| 11:29 |
Dyrcona |
The 300 field also looks a little messed up in the editor. Subfield a is just ";" |
| 11:36 |
Dyrcona |
Page count is missing. |
| 11:37 |
Dyrcona |
GIGO. |
| 11:45 |
Dyrcona |
So, it is a change in behavior with XSLT processing in Ubuntu 20.04, but not necessarily a bug. |
| 11:59 |
jeff |
hah! yes, that's an interesting record. |
| 11:59 |
jeff |
<subfield code="a">Library </subfield> |
| 11:59 |
Dyrcona |
Just to confirm: It blows up on any of the mods transforms. (mods3 gives a missing file error. I should look into that, but doesn't look like we use mods3.) marc21expand880 works, but it doesn't strip out the extra spaces. |
| 12:00 |
Dyrcona |
jeff: Yeah. that's what it looks like. |
| 12:00 |
Dyrcona |
It's obvious in the marcxml. Not so obvious elsewhere. |
| 12:01 |
Dyrcona |
I should probably use MARC::Record to fix it so that the length is updated correctly, but I should be able to just subtract 222 from the current value. |
| 12:03 |
jeff |
I have mixed feelings about trying to maintain size in a marcxml record. :-) |
| 12:04 |
jeff |
we mostly (and should always) ensure that it's updated/correct on conversion from marcxml to binary MARC format. |
| 12:04 |
Dyrcona |
Some of our vendors have strong opinions about it. |
| 12:05 |
Dyrcona |
My opinion: If you write software that depends on the size field, you're doing it wrong. |
| 12:06 |
Dyrcona |
So, I think I'm just going to fix this record and not file a bug anywhere. |
| 12:08 |
Dyrcona |
Hrm. I may not mess with the size. It says the record is only 620 bytes long, and that doesn't seem r |
| 12:08 |
Dyrcona |
oops. hit Enter instead of Delete.... :) |
| 12:13 |
Dyrcona |
Anyway, looks like the size in the header is wrong to begin with. |
| 12:13 |
Dyrcona |
It should be 1057 not 620. |
| 12:13 |
Dyrcona |
With the spaces removed, it would be 835. |
| 12:46 |
|
jihpringle joined #evergreen |
| 12:55 |
Dyrcona |
I guess I can expect to see that error again when the other ingest gets to ti. |
| 12:55 |
Dyrcona |
s/ti/it/ |
| 12:57 |
* csharp_ |
was guessing do re mi fa sol la ti... |
| 12:58 |
Dyrcona |
do! |
| 12:59 |
Dyrcona |
If I fix the record in that database, I shouldn't see the error for that record again. |
| 12:59 |
Dyrcona |
@blame Data |
| 12:59 |
pinesol |
Dyrcona: Data WILL PERISH UNDER MAXIMUM DELETION! DELETE. DELETE. DELETE! |
| 13:00 |
Dyrcona |
Heh. |
| 13:00 |
csharp_ |
pinesol++ |
| 13:07 |
|
mantis1 joined #evergreen |
| 13:09 |
jeffdavis |
sounds like pinesol has been watching Star Trek: The Next Generation |
| 13:10 |
miker |
never underestimate the ability of users to invent new ways to create error-triggering data |
| 13:18 |
Dyrcona |
If there is some data that can trigger an error, we'll likely have it. |
| 13:45 |
|
Keith-isl joined #evergreen |
| 13:54 |
csharp_ |
@quote add < miker> never underestimate the ability of users to invent new ways to create error-triggering data |
| 13:54 |
pinesol |
csharp_: The operation succeeded. Quote #224 added. |
| 13:55 |
Dyrcona |
@quote get 223 |
| 13:55 |
pinesol |
Dyrcona: Quote #223: "Dyrcona> My advice is don't mess with Evergreen too much. Just change the colors and logos." (added by csharp at 03:53 PM, February 24, 2022) |
| 13:56 |
Keith-isl |
Dyrcona I laughed too loud and for too long at that, and now my dog is looking at me to make sure I'm OK |
| 13:57 |
Dyrcona |
:) |
| 14:04 |
|
Keith_isl joined #evergreen |
| 14:16 |
|
Keith-isl joined #evergreen |
| 14:30 |
Dyrcona |
So, the little bootstrap icons are coming from font awesome? |
| 14:31 |
Dyrcona |
Are the bootstrap icons also available, or would those have to be added separately? Also, how would I be able to tell? |
| 15:13 |
Dyrcona |
Well, looks like the browse ingest finished with no other errors, so it was just that one record. The other ingests are still chugging away. |
| 15:13 |
* mmorgan |
claims 1311 |
| 15:14 |
Dyrcona |
mmorgan++ |
| 15:23 |
mmorgan |
Whew! Dyrcona, would you mind taking a look? |
| 15:39 |
pinesol |
News from commits: LP#1482757: stamp upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e35463f5591bff73eb23b984f3cc449e5922a889> |
| 15:39 |
pinesol |
News from commits: LP#1482757: Speed Up the Delete of Orphaned URIs in upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=300acbf91ea60ddd3fc9e76eecb6aac7f64e98fe> |
| 15:39 |
pinesol |
News from commits: LP#1482757: Delete URIs and call numbers when all 856 fields are removed <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=60a20d54c5e690bb927a56f84b86c76d7181ce22> |
| 15:39 |
pinesol |
News from commits: LP#1482757: Amend upgrade script to remove existing orphaned URIs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9299ba72c2bf94a6ea34b8b7ed21eee1f5875f62> |
| 15:39 |
pinesol |
News from commits: LP#1482757: Remove 'orphaned_uri_list' and 'NOT cn.deleted' criteria <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c22457a92e3e9b44d0aaa5d9e94e00f58b08a7d7> |
| 15:39 |
pinesol |
News from commits: LP#1482757: Be sure to remove all orphaned URI <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=892a7bf054f511ddf3b9fd3fa855d8b500ce25c0> |
| 15:39 |
pinesol |
News from commits: LP#1482757: More careful Located URI remapping <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=22b4abd1ddf06acae25b4dcfb2adb9b56e0e2846> |
| 15:46 |
|
jihpringle joined #evergreen |
| 15:48 |
berick |
mmorgan++ |
| 15:49 |
csharp_ |
mmorgan++ |
| 15:53 |
JBoyer |
mmorgan++ |
| 15:58 |
Dyrcona |
mmorgan++ # The latest commit looks good! |
| 15:58 |
mmorgan |
Dyrcona++ # Thanks for the eyes, and the tips! |
| 15:59 |
Dyrcona |
You're welcome. Been there, made the same mistakes. |
| 16:00 |
Dyrcona |
Now, to see if I've botched these bootstrap changes or not.... |
| 16:00 |
Dyrcona |
502 bad gateway.... Bet I've got the wrong ports again. |
| 16:01 |
Dyrcona |
Uh, no. somethings else: bad mutex.... |
| 16:02 |
Dyrcona |
OK. Forgot to restart apache2 after starting OSRF serviices... |
| 16:03 |
Dyrcona |
And the OPAC looks broken... |
| 16:03 |
|
jvwoolf joined #evergreen |
| 16:06 |
Dyrcona |
I probably have a broken tags somewhere. Probably forgot a double quote... |
| 16:08 |
Dyrcona |
Yeap.... have a : instead of ". |
| 16:09 |
pinesol |
News from commits: LP#1482757: stamp upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6320dc8b23380faafa5e1fb621424cf695ef9174> |
| 16:09 |
pinesol |
News from commits: LP1957840 Typo fix in mcrp class in fm_IDL.xml <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=42583567a482e74669c52b40108d57834a3abae8> |
| 16:11 |
Dyrcona |
Ok, so where's that second commit message coming from, 'cause it doesn't look new. |
| 16:12 |
mmorgan |
Dyrcona: That was my first push back on 2/11 |
| 16:13 |
Dyrcona |
Yeah. I just wonder why it's showing up now.... |
| 16:13 |
* Dyrcona |
shrugs. |
| 16:14 |
Dyrcona |
Fixed my typo, and it is still broken, just not so much. |
| 16:15 |
Dyrcona |
OK, another of the same typo. |
| 16:16 |
Dyrcona |
Home keys..... Use the home keys..... |
| 16:17 |
Dyrcona |
"Paprika! That will fix it." |
| 16:18 |
Dyrcona |
I just have to figure out why the proper logo isn't showing up, and why it still looks like it is in the navbar. I think that latter is a style issu. |
| 16:22 |
Dyrcona |
Guess I'll squash these little fixes out later... |
| 16:27 |
Dyrcona |
OK. I think I need to update the Apache configuration on my test vm to handle our library URLs correctly. |
| 16:27 |
Dyrcona |
But, that will have to wait for Monday. |
| 16:35 |
Dyrcona |
Have a good weekend, everyone! |
| 17:09 |
|
jihpringle joined #evergreen |
| 17:12 |
|
JBoyer joined #evergreen |
| 17:12 |
|
mmorgan left #evergreen |
| 17:49 |
|
jvwoolf left #evergreen |
| 18:02 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live//archive/2022-02/2022-02-25_16:00:02/test.42.html> |
