| Time |
Nick |
Message |
| 00:56 |
|
jvwoolf joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:24 |
|
ejk joined #evergreen |
| 06:37 |
|
troy joined #evergreen |
| 07:33 |
|
rjackson_isl_hom joined #evergreen |
| 07:49 |
|
rjackson_isl_hom joined #evergreen |
| 07:56 |
|
Dyrcona joined #evergreen |
| 08:07 |
|
collum joined #evergreen |
| 08:42 |
|
mantis joined #evergreen |
| 09:00 |
|
rfrasur joined #evergreen |
| 09:11 |
Dyrcona |
The trouble with picking up the next day is remembering exactly where you left off the day before. |
| 09:13 |
Dyrcona |
I was somewhere in the twisty maze of functions related to authority.propagate_changes(). |
| 09:18 |
Dyrcona |
Function overloading seems like a great idea, until you have totally different implementations depending on the arguments. |
| 09:18 |
Dyrcona |
Well, OK. I should have looked before commenting. The overloaded version calls the main version after filling in the missing bits. :) |
| 09:20 |
|
jvwoolf joined #evergreen |
| 09:30 |
|
mmorgan joined #evergreen |
| 09:45 |
Dyrcona |
Hrm..... When I run vandelay.merge_record_xml with the same arguments from authority.propagate_changes() it gives the same output on Pg 10, 11, and 14, after I've made a fix to authority.generate_overlay_template() even though the latter function produces different output. |
| 09:46 |
Dyrcona |
However, authority.propagate_changes() appears to fail when run as part of the test. |
| 09:47 |
Bmagic |
Function Overloaded is fodder for one of our Bands IMO |
| 09:48 |
Bmagic |
"Function Overloaded - missing bits be damned" |
| 09:48 |
Bmagic |
Or maybe drop "ed" and it's just Function Overload |
| 09:50 |
Dyrcona |
Information Overload... :) |
| 09:51 |
Bmagic |
surely we've already added that* |
| 09:51 |
Dyrcona |
So, authority.propagate_changes seems to work if I run it manually but not when fired by a trigger.... This is weird. |
| 09:51 |
Dyrcona |
@band add Information Overload |
| 09:51 |
pinesol |
Dyrcona: Band 'Information Overload' added to list |
| 09:51 |
Dyrcona |
@band search Information |
| 09:51 |
pinesol |
Dyrcona: Information Overload |
| 09:52 |
Dyrcona |
@band add Function Overload |
| 09:52 |
pinesol |
Dyrcona: Band 'Function Overload' added to list |
| 09:52 |
* Dyrcona |
tries to fire the trigger manually, again. |
| 09:53 |
|
jvwoolf1 joined #evergreen |
| 09:55 |
Dyrcona |
Ah wait a minute.... It's being called with a single argument from the trigger, which relies on authority bib linking to work, so authority bib linking must be what's broken, now. |
| 09:55 |
Dyrcona |
The two argument version where you supply the authority and bib ids works. |
| 09:56 |
Dyrcona |
@blame Function Overload |
| 09:56 |
pinesol |
Dyrcona: Function Overload tests their code on the LIVE SERVERS, then blames the user. SAD! |
| 09:56 |
Dyrcona |
@blame [band] |
| 09:56 |
pinesol |
Dyrcona: The EOLI Folk stole Dyrcona's ice cream! |
| 09:57 |
Dyrcona |
@blame XML |
| 09:57 |
pinesol |
Dyrcona: XML is the SPY! |
| 10:00 |
Dyrcona |
This isn't just a rabbit hole. It's the whole warren. |
| 10:06 |
rhamby |
I think this accusation that anyone here stole the ice cream is just ridi... wait was it pistachio? |
| 10:07 |
Dyrcona |
Heh. |
| 10:09 |
Bmagic |
haha |
| 10:10 |
Dyrcona |
Grr. authority bib linking seems to work. |
| 10:18 |
Dyrcona |
Grr. Still doesn't work if run from the trigger. |
| 10:21 |
Dyrcona |
If I manually run 'select authority.propagate_changes(999999100);' it works. |
| 10:21 |
Dyrcona |
Is the trigger even there? |
| 10:24 |
Dyrcona |
Aight, so something else in authority.indexing_ingest_or_delete() is still broken. |
| 10:27 |
Bmagic |
I guess we're going to have to use Polaris |
| 10:28 |
Dyrcona |
Heh. |
| 10:28 |
Dyrcona |
I hope not. |
| 10:28 |
Bmagic |
Our future is in your hands |
| 10:28 |
Dyrcona |
So, it turns out that the authority.record_entry is not getting set. |
| 10:28 |
Dyrcona |
grr... authority.record_entry.heading |
| 10:29 |
Bmagic |
I put a bunch of time into these tables a couple months ago (and triggers,etc) |
| 10:30 |
Bmagic |
wrote up the a long document about it https://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=docs/modules/cataloging/pages/authorities_advanced.adoc;h=23e44116ac3228530b6449af43d0d8b3e58a4100;hb=ce1560e4dd80ff4d13488aefe907e733974c6c17 |
| 10:33 |
Dyrcona |
Well, I suspect that we're running into another relative XPath issue. |
| 10:33 |
Bmagic |
I don't think it would help explain why that column isn't getting set |
| 10:33 |
Bmagic |
That sounds like a bingo |
| 10:34 |
csharp_ |
@band add Soo Open Surf |
| 10:34 |
pinesol |
csharp_: Band 'Soo Open Surf' added to list |
| 10:35 |
Dyrcona |
Bmagic: I'll settle for a yahtzee. |
| 10:35 |
Bmagic |
:) |
| 10:35 |
csharp_ |
Bmagic: I keep meaning to get back to that and since I'm intentionallly finding reasons not to look at authorities, I just haven't yet :-) |
| 10:35 |
Bmagic |
hahahaha, totally understandable |
| 10:36 |
csharp_ |
@blame my procrastinating brain |
| 10:36 |
pinesol |
csharp_: csharp_'s procrastinating brain HAXORED csharp_'s SERVERZ!!!! |
| 10:36 |
Bmagic |
I get the feeling that most* of our community takes that approach for Authorities. Which might explain why the code is in the state that it's in :) |
| 10:36 |
Dyrcona |
@band add Procrastination Brain |
| 10:36 |
pinesol |
Dyrcona: Band 'Procrastination Brain' added to list |
| 10:37 |
Dyrcona |
Well, a) in the age of keyword search, I think authorities are obsolete, and b) there are worse places in the Perl code. |
| 10:38 |
Bmagic |
Don't say that thing about Authorities being obsolete too loudly around an academic cataloger.. |
| 10:38 |
Bmagic |
But if you do, let me know ahead of time so I can make popcorn |
| 10:39 |
Dyrcona |
Bmagic: Noted. |
| 10:39 |
Dyrcona |
How long has it been since I opined that c) we do too much in the database? :) |
| 10:39 |
Bmagic |
But, but, but, Postgres is awesome! |
| 10:41 |
Bmagic |
I get upset when I can't use ~ for string comparison on other SQL servers like MariaDB. I think to myself "what!!!!???? I have to write a whole bunch of nested functions.... Forget it, I'm deleting the database" |
| 10:45 |
Dyrcona |
Heh. |
| 10:46 |
Dyrcona |
Like I said earlier it's a rabbit warren of twisty functions, many very much alike. |
| 10:49 |
Dyrcona |
Oops. |
| 10:49 |
Dyrcona |
Killed the wrong window. :( |
| 10:49 |
Bmagic |
https://www.killedthewrongwindow.com/ I'll race you to purchasing that domain |
| 11:25 |
|
jihpringle joined #evergreen |
| 11:28 |
Dyrcona |
This is trickier than it seem. I suspect I have a fix that is wrong. |
| 12:17 |
jonadab |
Bmagic: There are worse options than Polaris. We could all be doing everything in massive Excel spreadsheets. |
| 12:18 |
Bmagic |
jonadab: I kidd, I kidd |
| 12:19 |
jonadab |
Yeah, I got that. |
| 12:29 |
Bmagic |
:) |
| 12:34 |
|
collum joined #evergreen |
| 13:04 |
|
collum joined #evergreen |
| 13:15 |
|
jihpringle15 joined #evergreen |
| 13:27 |
csharp_ |
yeah - decent authorities handling is considered must-have by universities here |
| 13:30 |
Dyrcona |
So, ./@code isn't working as XPath in Pg 11+... |
| 13:32 |
Dyrcona |
//*/@code seems to work. |
| 13:33 |
Dyrcona |
Oh. I see why. We're unknowingly relying on a bug.... |
| 13:35 |
Dyrcona |
Ah, wait a minute..... |
| 13:42 |
Dyrcona |
Unfortunately, I think my fix is still relying on a bug... |
| 13:49 |
Dyrcona |
Yeah, it's bothering me that ./* gives different results on Pg 10 versus Pg11+ |
| 13:50 |
Dyrcona |
I've got code that "works," but I'm pretty sure that part of it is not "correct." |
| 13:50 |
Dyrcona |
XPath is terrible. |
| 13:50 |
csharp_ |
XML is kinda terrible too? |
| 13:59 |
Dyrcona |
Well, XML was a huge mistake. I think the best definition of XML is a method to bloat files so that they can more quickly fill your disks. |
| 13:59 |
Dyrcona |
I've heard of people trying to working multi-gigabyte XML files. |
| 13:59 |
Dyrcona |
s/working/work with/ |
| 14:00 |
Dyrcona |
So xpath('./*[contains("'||acsaf.sf_list||'",@code)]',tag_node::xml) does what we want on Pg 10 and earlier. it returns: <subfield xmlns="http://www.loc.gov/MARC21/slim" code="a">Doe, Jane</subfield> |
| 14:00 |
Dyrcona |
On Pg11+, it includes the parent node. |
| 14:03 |
Dyrcona |
sf_node ends up looking like tag_node.... |
| 14:07 |
Dyrcona |
Using //*[contains.... almost works, but it returns the nodes twice! |
| 14:07 |
Dyrcona |
So, the results are doubled "a doe jane a doe jane" |
| 14:11 |
|
sandbergja joined #evergreen |
| 14:16 |
Dyrcona |
The fact that ./subfield doesn't work bothers me. |
| 14:31 |
Dyrcona |
I can't tell if my connection froze or if this version of the function causes an infinite loop.... |
| 14:31 |
Dyrcona |
Ok, the connection froze. |
| 14:32 |
Dyrcona |
I suppose I should switch to a local VM. The connection freezes are a real pain. |
| 14:49 |
sandbergja |
claiming 1308 |
| 14:57 |
|
Dyrcona joined #evergreen |
| 15:08 |
pinesol |
Showing latest 5 of 14 commits to Evergreen... |
| 15:08 |
pinesol |
[evergreen|Galen Charlton] LP#1855780: add grid config settings - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3ac25b2> |
| 15:08 |
pinesol |
[evergreen|Galen Charlton] LP#1855780: add release notes entry - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=24e1f36> |
| 15:08 |
pinesol |
[evergreen|Jane Sandberg] lp1855780 remove unnecessary whitespace - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1eeb051> |
| 15:08 |
pinesol |
[evergreen|Jane Sandberg] lp1855780 preload values for comboboxes in angular event definition editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9d73f51> |
| 15:08 |
pinesol |
[evergreen|Jane Sandberg] lp1855780 stamp upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=654b02f> |
| 15:18 |
|
jihpringle joined #evergreen |
| 15:27 |
csharp_ |
JBoyer++ |
| 15:35 |
|
nfBurton joined #evergreen |
| 16:00 |
|
mmorgan left #evergreen |
| 16:16 |
Dyrcona |
OMG this is ugly, but it works: oils_xpath('//*/*[contains("'||acsaf.sf_list||'",@code)]',tag_node) |
| 16:30 |
Bmagic |
Dyrcona++ |
| 16:41 |
|
jvwoolf1 left #evergreen |
| 16:41 |
Dyrcona |
Great. A test now fails on Pg10 that used to pass. |
| 16:45 |
Dyrcona |
live_t/0847.auth_overlay_generator.pg relies on undefined behavior. It assumes that the XML code will always generate the same thing, and it changes from Pg10 and beyond. |
| 16:46 |
Bmagic |
well, that's not what we want |
| 16:50 |
Dyrcona |
I think my "fixes" may have broken that one, but when I run authority.generate_overlay_template on some releases, I get embedded newlines that are converted to entities, and on other releases they are not there. Also, there are more entities now that I've changed the xpath so it "works" on all current Pg releases. I think we should drop that test. |
| 16:50 |
Bmagic |
hmm, I'm not familiar with that. |
| 16:52 |
Dyrcona |
That test is designed to test the output of the authority.generate_overlay_template function, and the function's behavior changes depending on Pg release. |
| 16:53 |
Dyrcona |
And, actually, it looks like on Pg versions < 12, it varies by the XPath used. |
| 16:54 |
Dyrcona |
I guess Heisenberg is a PostgreSQL developer. |
| 16:55 |
jeffdavis |
The more I work with ILSes, the more I think card catalogs are a neat idea. |
| 16:56 |
jeffdavis |
(I'm sure people who actually remember maintaining card catalogs feel differently.) |
| 16:57 |
Dyrcona |
jeffdavis++ |
| 16:57 |
Dyrcona |
Nothing wrong with paper... |
| 16:57 |
Dyrcona |
So, I've made some "progress." |
| 16:58 |
* Dyrcona |
checks out for the day. |
| 17:56 |
pinesol |
[evergreen|Bill Erickson] LP1739277 Angular org selector style callback - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d51454b> |
| 17:56 |
pinesol |
[evergreen|Kyle Huckins] lp1739277 OrgSelect Class Callback Holdings Implementation - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=625c862> |
| 17:56 |
pinesol |
[evergreen|Kyle Huckins] Docs: lp1739277 Release Notes for Org Selector Styling - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8046fb4> |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:21 |
gmcharlt |
for one thing, card catalogs had ink smudges with semaantic content: https://twitter.com/ruthbrarian/status/1461083016470708226 |
| 18:43 |
|
alynn26_away joined #evergreen |
