Evergreen ILS Website

IRC log for #evergreen, 2021-09-20

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
00:30 eby joined #evergreen
00:41 degraafk joined #evergreen
06:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-20_04:00:03/test.49.html>
07:15 collum joined #evergreen
07:21 rjackson_isl_hom joined #evergreen
08:18 mantis joined #evergreen
08:28 Stompro joined #evergreen
08:36 mmorgan joined #evergreen
08:41 mantis1 joined #evergreen
08:43 terranm joined #evergreen
08:44 terranm Good morning and happy Bug Squashing Week!
08:46 Dyrcona joined #evergreen
08:46 mmorgan Good morning!
08:47 Dyrcona Good morning!
08:53 rfrasur joined #evergreen
08:55 csharp_ Good Morning-uh!
09:00 Bmagic @coffee [someone]
09:00 * pinesol brews and pours a cup of Fair Trade Organic Ethiopia Yirgacheffe, and sends it sliding down the bar to denials
09:08 csharp_ @someone [coffee]
09:08 * pinesol (someone [<channel>]) -- Returns a random nick from <channel>. <channel> is only necessary if the message isn't sent in the channel itself.
09:09 csharp_ @blame [someone] for [quote random]
09:09 pinesol csharp_: troy tests their code on the LIVE SERVERS, then blames the user. SAD! for Quote #114: "<Dyrcona> If TCP/IP were standardized like most library standards, we'd all be using AOL/CompuServe." (added by berick at 02:43 PM, May 04, 2015)
09:10 Bmagic Good ol' TCP/IP
09:10 csharp_ @ana Good ol' TCP/IP
09:10 pinesol csharp_: Good! Top clip
09:12 Bmagic This message is brought to you by: TCP/IP, a thankless wire maestro
09:19 pinesol [evergreen|Jason Etheridge] lp1859502 fix A/T ApplyPatronPenalty reactor - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=bade77f>
09:35 alynn26 joined #evergreen
09:53 jvwoolf joined #evergreen
10:04 rfrasur terranm, I'm not seeing carousels on your terran-master opac.  Do I need to go in and set them up?
10:04 terranm Yes, there aren't any set up yet
10:04 rfrasur Okie
10:05 tlittle joined #evergreen
10:15 pinesol [evergreen|Josh Stompro] LP#1821804 - Cloned patron address set to pending - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a9b3b6d>
10:29 pinesol [evergreen|Josh Stompro] LP1866667 - Clear current_copy when pickup_lib is changed and waiting for capture - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fc1d5fa>
10:49 pinesol [evergreen|Dan Briem] LP#1929587 Place hold button in staff client - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=db183ff>
10:59 derekz joined #evergreen
10:59 pinesol [evergreen|Tiffany Little] LP1906826: Changes column header for purchase order in line item search - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=92b1880>
11:23 pinesol [evergreen|Bill Erickson] LP1928359 Add item circ info to Item Table - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=61310ed>
11:23 pinesol [evergreen|Galen Charlton] LP#1928359: add release notes entry - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7287028>
11:29 pinesol [evergreen|Jessica Woolford] LP1786971 z39.50 using TCN instead of ID - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=5542ce5>
11:29 pinesol [evergreen|Terran McCanna] LP1786971 z39.50 add TCN to overlay popups as well - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=9eec45d>
11:29 pinesol [evergreen|Bill Erickson] LP1786971 TCN fetching and maintenance tweaks - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=25c3a9b>
11:30 pinesol [evergreen|Terran McCanna] LP1786971 z39.50 incorporate Bill's changes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=72ab990>
11:35 pinesol [evergreen|Jason Boyer] LP1908614: Show the Age Hold Protection name in the staff catalog - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a429b83>
11:36 csharp_ phasefx: I'm getting deadlocks when running the upgrade script for bug 1846354 - gonna troubleshoot as much as I can
11:36 pinesol Launchpad bug 1846354 in Evergreen "wishlist: Consolidate patron notes, alerts, and messages" [Wishlist,New] https://launchpad.net/bugs/1846354 - Assigned to Chris Sharp (chrissharp123)
11:36 phasefx csharp_: roger roger, thanks
11:38 csharp_ phasefx: looks like ALTER TABLE actor.usr DROP COLUMN alert_message CASCADE; is where it's dying
11:41 Christineb joined #evergreen
11:41 csharp_ phasefx: https://pastebin.com/JrAQs7mD from our log
11:44 csharp_ huh - not sure why action.hold_retarget_permit_test is involved, but that's probably a clue...
11:46 pinesol [evergreen|Dan Briem] LP#1917338 Angular: Holdings view column picker missing OPAC visible? - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=8129903>
11:46 csharp_ trying again with the hold targeter dead (didn't realize it was also running)
11:46 phasefx it's funny, those assertions/tests aren't really needed, but were added because the spec said to, and somehow they're blocking things.. I think
11:46 phasefx maybe comment them out?
11:46 csharp_ it will take about 25 minutes to get to that point in the process - I'll let you know whether it works now
11:47 phasefx csharp_++
11:47 csharp_ then I'll try commenting those out if it's still borken
11:55 phasefx just confirming that it doesn't happen in the simple case of upgrading concerto on a dev system
11:57 * gmcharlt claims 1285
11:58 gmcharlt rather, 1286
12:02 pinesol [evergreen|Jeff Davis] LP#1922273: staff catalog: put is_simple filter options at top of list - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f7356f1>
12:02 pinesol [evergreen|Jeff Davis] LP#1922273: use a setting to determine which advanced search filters are displayed in staff catalog - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=e3e6478>
12:02 pinesol [evergreen|Galen Charlton] LP#1922273: (follow-up) adjust positioning of filters - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=cc1466b>
12:02 pinesol [evergreen|Galen Charlton] LP#1922273: add release note - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2643d55>
12:02 pinesol [evergreen|Galen Charlton] LP#1922273: stamp DB update - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c5e31dc>
12:11 jihpringle joined #evergreen
12:14 pinesol [evergreen|Terran McCanna] LP1906855 Show Covers in My Account - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b565ef0>
12:14 pinesol [evergreen|Terran McCanna] LP1906855 Additional CSS for mobile display - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7b00cdb>
12:14 pinesol [evergreen|Galen Charlton] LP#1906855: add release notes entry - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f007d47>
12:26 jvwoolf joined #evergreen
12:27 * gmcharlt claims 1287
12:30 pinesol [evergreen|Rogan Hamby] LP#1904593: new library setting for My Account URL - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c92a336>
12:30 pinesol [evergreen|Galen Charlton] LP#1904593: added release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a912e61>
12:30 pinesol [evergreen|Galen Charlton] LP#1904593: stamp DB update - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fa826d2>
12:30 csharp_ phasefx: so far it looks like it was caused by the hold targeter
12:30 csharp_ @blame The Hold Targeter
12:30 pinesol csharp_: everything was going great until The Hold Targeter came along
12:31 mmorgan :)
12:31 phasefx good to hear <crosses fingers>
12:32 jvwoolf left #evergreen
12:33 JBoyer Does anyone know if Kyle Huckins still works with Evergreen for Catalyte? I knew a dev or two was going to be moving on to other projects, but Google doesn't like searching irc.evergreen-ils.org so that's no help.
12:33 Dyrcona csharp_: Don't do that. Don't run db upgrades while any part of Evergreen or OpenSRF services are running.
12:33 JBoyer Context: I was looking at a couple angular patches he's worked on, didn't know if they were orhpaned.
12:37 terranm JBoyer: I'm pretty sure he was moved onto non-Evergreen projects
12:40 csharp_ Dyrcona: yeah - I didn't realize the crons were still enabled
12:41 csharp_ phasefx: success - PINES staff will test how it went
12:42 phasefx yay!
12:45 Dyrcona @karma csharp_
12:45 pinesol Dyrcona: Karma for "csharp_" has been increased 10 times and decreased 0 times for a total karma of 10.
12:45 Dyrcona @karma csharp
12:45 pinesol Dyrcona: Karma for "csharp" has been increased 2 times and decreased 0 times for a total karma of 2.
12:45 Bmagic lol
12:45 Dyrcona csharp_++ phasefx++
12:45 Bmagic the ghost is more popular
12:45 Dyrcona :)
12:46 * Dyrcona had network issues where a test database server resides, so I'm waiting on a database reload to finish before I can do much today.
12:51 Stompro tlittle, are you the responsible party for Tiffany's Test server?  I was trying to test Bug #1919465, but I'm getting an error about the server side print template not existing.
12:51 pinesol Launchpad bug 1919465 in Evergreen "Port holds pull list to Angular / Wide Holds API" [Undecided,New] https://launchpad.net/bugs/1919465
12:54 Stompro No active template found 'hold_pull_list', but under server admin -> Print Templates, it does exist and is active.
12:56 jvwoolf joined #evergreen
13:12 collum joined #evergreen
13:16 jvwoolf I couldn't find this documented anywhere -if a hold is activated after being suspended, does the expiration date go back to what it was before it was suspended, or does the expiration interval start over?
13:17 mmorgan jvwoolf: When a hold is suspended, the expiration date is removed. Not positive what happens when it's activated.
13:18 jvwoolf mmorgan: I did see that is was removed when it's suspended. I guess I can do some testing around what happens when it'
13:18 jvwoolf s activated
13:19 jvwoolf Ichy enter finger :)
13:19 jvwoolf Itchy, even
13:20 collum joined #evergreen
13:22 mmorgan jvwoolf: Just tried it. The hold gets a new interval when it's activated.
13:22 jvwoolf mmorgan++
13:22 jvwoolf Thanks for testing!
13:22 mmorgan yw!
13:24 Dyrcona jvwoolf: The expiration date is not changed when the auto thaw happens, so it remains unset. See line 293 of Open-ILS/src/perlmods/lib/OpenILS/App​lication/Storage/Publisher/action.pm
13:25 jvwoolf Dyrcona: Interesting. When I thaw a hold in the client, the expiration date does set.
13:26 jvwoolf Having unset expiration date for active holds is not ideal IMHO
13:31 jvwoolf But based on bug #1836807 I guess I'm in the minority?
13:31 pinesol Launchpad bug 1836807 in Evergreen "Expiration date remains null if a captured hold is released" [Undecided,New] https://launchpad.net/bugs/1836807
13:34 Dyrcona jvwoolf: Could be. Holds with null expire date don't expire.
13:35 jvwoolf Right, but it also doesn't seem ideal to have no way of clearing those holds out
13:36 jvwoolf I guess we have Hopeless Holds now to catch them, and probably not a huge number
13:36 pinesol [evergreen|Adam Bowling] LP1937875: Remove GitHub reference from package.js - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d5f3afe>
13:36 jvwoolf Could accumulate over time though if libraries aren't paying attention to them
13:37 Dyrcona We have over a million such holds, but the majority are fulfilled or cancelled. Looks like we have about 48,000 "open" holds with a null expire date. (I put "open" in quotes because I didn't do as thorough of a query as I might have.)
13:39 * mmorgan sees the suspended holds without expiration date as more of an issue. They also accumulate, and there's no way to clear them out, Hopeless Holds doesn't address those.
13:40 Dyrcona mmorgan: Are you talking about frozen holds with a null thaw_date, or reactivated holds with no expire_date being an issue?
13:41 Dyrcona Or both, or something else?
13:42 Dyrcona I'm going to double check on a fairly static database to see if I am right about activated holds not getting the expire date reset.
13:44 mmorgan Dyrcona: Frozen holds with a null thaw date.
13:45 Dyrcona It looks like the expire_date might not get set if the hold is activated by the patron in the OPAC, but I didn't look in the actual hold update code to see if there is a check for that.
13:45 Dyrcona mmorgan: Well, I've always seen that as a deliberate choice by the patron to manually manage when they want to activate their holds.
13:45 csharp_ Bmagic++ # authority docs
13:45 mmorgan Dyrcona: True, but sometimes patrons cease to be engaged, and those get left behind.
13:46 * mmorgan runs out for a bit.
13:48 Bmagic csharp_++ # reading
13:56 Dyrcona Yeahp. Confirmed. I counted 155,468 holds with null expire_time and frozen = 'f' before running the thaw frozen holds script. It reported thawing 842 holds. Afterward I counted 156,310 holds with null expire_time and frozen = 'f'.
13:59 tlittle Stompro Yep, that's my test server. I'll take a look
14:02 jvwoolf Dyrcona++
14:02 jvwoolf That's good to know
14:02 Stompro tlittle, thanks, I'm also not seeing the Discard/Weed option added in the last commit for that feature.
14:04 jvwoolf So here's a question, do I open a new bug ticket for that, or amend the one I submitted about the shelf expire time getting cleared out if a hold is captured and released?
14:10 Dyrcona jvwoolf: I'd open a new bug because it is a totally different piece of code.
14:10 jvwoolf Dyrcona: Will do, thanks!
14:11 Dyrcona jvwoolf++
14:21 Dyrcona csharp_: On bug 1846354, that looks like the IDL is broken.
14:21 pinesol Launchpad bug 1846354 in Evergreen "wishlist: Consolidate patron notes, alerts, and messages" [Wishlist,New] https://launchpad.net/bugs/1846354 - Assigned to Chris Sharp (chrissharp123)
14:21 gmcharlt csharp_: re patrons notes and your latest comment, stupid quesution time, but checking that fm_IDL.xml is updated + service restart + autogen + apache reload was run?
14:24 Dyrcona Yeah, I was going to suggest the same after looking at the patch.
14:25 Dyrcona Might not hurt to run xmllint on fm_IDL.xml as a sanity check, too.
14:57 tlittle joined #evergreen
15:34 tlittle So I'm looking at the branch for the Angular print holds list, and Stompro reported earlier that he was getting console errors of "no active template found." I'm seeing that too, plus console errors of "uncaught in promise, error compiling server hosted print template." When I go to Server Admin>Print Templates, and try to select any of the
15:34 tlittle templates, I get the no active template console error. I've restarted all my services, made sure that the templates are actually in the DB, but I'm not sure what else to try to troubleshoot. Any ideas?
15:38 csharp_ huh - apparently something *was* off with the IDL - working now
15:39 csharp_ Dyrcona++ gmcharlt++
15:42 csharp_ calling 1288
15:42 pinesol [evergreen|Bill Erickson] LP1928363 Item circ info for Holdings tab - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b804ec5>
15:42 pinesol [evergreen|Bill Erickson] LP1928363 Fix PCRUD permission - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=ac57030>
15:42 pinesol [evergreen|Galen Charlton] LP#1928363: add release notes entry - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3234fe6>
15:43 berick tlittle: may need to confirm server print templates are configured on your test server...
15:44 berick /etc/apache2/eg_vhost.conf should have a <Location /print_template> section, plus another bit in eg_startup
15:45 tlittle berick Well, that absolutely sounds like it would be helpful for sure. Thank you so much!
15:45 Stompro tlittle, is there an entry in the eg_vhosts.conf for the /print_templates endpoint?
15:45 tlittle Going to look for it right now
15:45 jihpringle tlittle: is this https://bugs.launchpad.net/evergreen/+bug/1919465?
15:45 pinesol Launchpad bug 1919465 in Evergreen "Port holds pull list to Angular / Wide Holds API" [Undecided,New]
15:46 tlittle jihpringle Yes, that's the one
15:46 Stompro Doh, didn't see that berick just posted that, sorry.
15:46 jihpringle it doesn't look like the follow up patches are on your server
15:46 jihpringle in comment #16
15:47 jihpringle not sure if it's an issue with the fix or the server but I don't see the Discard/Weed action for example
15:47 tlittle Ugh, drat. I do see that I missed the last commit. Will add that too. Thanks for the heads up!
15:48 jihpringle np :)
15:48 pinesol Showing latest 5 of 7 commits to Evergreen...
15:48 pinesol [evergreen|Galen Charlton] lp1846354 revisions to upgrade script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=510dc9f>
15:48 pinesol [evergreen|Jason Etheridge] lp1846354 misc fixes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2bdec19>
15:48 pinesol [evergreen|Galen Charlton] LP#1846354: update Angular new penalty dialog - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=52379c3>
15:49 pinesol [evergreen|Jason Etheridge] lp1846354 additional tweaks and fixes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=4460554>
15:49 pinesol [evergreen|Chris Sharp] LP#1846354 - stamp upgrade script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f6d7d64>
15:49 csharp_ phasefx++
15:50 csharp_ gmcharlt++
15:50 csharp_ also ddale++
15:51 * csharp_ casts his gaze onto bug 1207533
15:51 pinesol Launchpad bug 1207533 in Evergreen "Triggered event log times out for large-data sites" [Medium,Confirmed] https://launchpad.net/bugs/1207533
15:51 gmcharlt csharp++
15:51 JBoyer csharp_++
15:52 JBoyer When you gaze into the 200 million row table the 200 million row tables gazes also into you.
15:53 * csharp_ 's mind empties
15:54 Dyrcona Heh. We only keep 6 months of action trigger events.
15:55 abneiman csharp_++
16:00 tlittle jihpringle I grabbed that last commit, so you're welcome to take a look again whenever
16:01 jihpringle tlittle: awesome!
16:04 csharp_ tlittle: I keep reading your branch as "acq lipstick uploader"
16:04 csharp_ @decide lipstick or picklist
16:04 pinesol csharp_: go with picklist
16:04 tlittle Acq is very fancy
16:14 csharp_ if you like modern takes on delta blues, I can recommend Delta Kream by The Black Keys as working music
16:19 berick @band add Lipstick Uploader
16:19 pinesol berick: Band 'Lipstick Uploader' added to list
16:20 berick @who prefers [band] to The Black Keys?
16:20 pinesol bshum prefers The Hugepages to The Black Keys.
16:21 csharp_ berick: oooh - I didn't think of that as a @band name
16:22 csharp_ @who gets triggered by triggered events?
16:22 pinesol Christineb gets triggered by triggered events.
16:22 csharp_ TRIGGER WARNING!
16:22 csharp_ free for the taking as a conf presentation title
16:25 jvwoolf left #evergreen
16:30 mmorgan left #evergreen
17:22 Bmagic haha
17:23 * gmcharlt claims 1289
17:26 Stompro joined #evergreen
17:27 pinesol Showing latest 5 of 7 commits to Evergreen...
17:27 pinesol [evergreen|Rogan Hamby] LP#1929242: add missing comma - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=68157bc>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: (follow-up) add grid config WS setting - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3a20a5b>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: (follow-up) additional tweaks - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2c1c3b6>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: edit release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a91097a>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: stamp DB update - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a81071f>
18:02 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-20_16:00:03/test.49.html>

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat