| Time |
Nick |
Message |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:17 |
|
rjackson_isl_hom joined #evergreen |
| 07:22 |
|
mantis joined #evergreen |
| 08:12 |
|
rfrasur joined #evergreen |
| 08:24 |
|
Stompro joined #evergreen |
| 08:42 |
|
mmorgan joined #evergreen |
| 09:09 |
|
terranm joined #evergreen |
| 09:12 |
|
Dyrcona joined #evergreen |
| 09:14 |
|
mmorgan1 joined #evergreen |
| 09:16 |
terranm |
terran-master is down, FYI |
| 09:22 |
|
jvwoolf joined #evergreen |
| 09:22 |
Dyrcona |
JBoyer++ # session versus local storage |
| 09:27 |
Dyrcona |
It's a bit soon to tell, but replacing that drive on the test db server seems to have improved the performance. :) |
| 09:50 |
|
terranm joined #evergreen |
| 10:13 |
|
terranm joined #evergreen |
| 10:14 |
|
terranm87 joined #evergreen |
| 10:15 |
|
terranm99 joined #evergreen |
| 10:15 |
terranm99 |
<squints at IRC for telling me I'm already logged in after it kicked me off> |
| 10:17 |
mmorgan |
99 terranm's on the wall, 99 terranm's ... |
| 10:17 |
terranm99 |
lol |
| 10:18 |
* mmorgan |
is getting punchy on Friday the 13th of Feedback Fest |
| 10:18 |
terranm99 |
rfrasur: I found an error that I made when I was resolving seed data conflicts on terran-master last night, could you please test https://bugs.launchpad.net/evergreen/+bug/1920253 again |
| 10:18 |
pinesol |
Launchpad bug 1920253 in Evergreen 3.6 "Carousel Admin Pages Grid Settings cannot be saved" [Undecided,Confirmed] |
| 10:18 |
terranm99 |
mmorgan++ same, girl, same |
| 10:19 |
terranm99 |
And I slept weird on my shoulder last night so I'm sitting here with my arm over my head like a cartoon ape |
| 10:19 |
mmorgan |
LOL! Good thing FF is not over zoom! |
| 10:20 |
terranm99 |
That'd be one way to keep people away from participating! |
| 10:22 |
|
gsams joined #evergreen |
| 10:30 |
terranm99 |
berick: I have this one installed on terran-master, and I can see the new hold pull list template is present, but when trying to print it's saying it's not there - could I have missed something when I applied it do you think? https://bugs.launchpad.net/evergreen/+bug/1919465 |
| 10:30 |
pinesol |
Launchpad bug 1919465 in Evergreen "Port holds pull list to Angular / Wide Holds API" [Undecided,New] - Assigned to Josh Stompro (u-launchpad-stompro-org) |
| 10:31 |
mmorgan |
terranm99: I was looking at your server this morning before you refreshed it and saw the same thing, fyi. |
| 10:31 |
rfrasur |
terranm99, yep. I'll get in there as soon as I get my head back into that game. |
| 10:32 |
terranm99 |
mmorgan: I thought maybe that was because I'd resolved the seed data file conflicts wrong, but it's still happening. |
| 10:33 |
rfrasur |
mmorgan, terranm99, yep. Still same error. |
| 10:33 |
berick |
terranm99: odd |
| 10:34 |
rfrasur |
It says "Create a ws/user setting type or use setLocalItem() to store the value locally." |
| 10:36 |
terranm99 |
I confirmed via SQL as well as in the admin interface that the new template is there |
| 10:36 |
berick |
yeah, i see it in your admin UI and it's active |
| 10:37 |
berick |
trying on my vm |
| 10:37 |
berick |
and it prints fine here |
| 10:37 |
berick |
hmm |
| 10:38 |
mmorgan |
terranm99: berick: Stompro's comment #5 noted that there were two references to the pull list template, maybe the wrong one was removed? https://bugs.launchpad.net/evergreen/+bug/1919465/comments/5 |
| 10:38 |
pinesol |
Launchpad bug 1919465 in Evergreen "Port holds pull list to Angular / Wide Holds API" [Undecided,New] - Assigned to Josh Stompro (u-launchpad-stompro-org) |
| 10:39 |
mmorgan |
holds_ vs hold_ |
| 10:40 |
berick |
terranm99: anything in the opensrf error logs or apache error logs? |
| 10:42 |
berick |
terranm99: Holds-For-Bib isn't printing either. I suspect the Apache config needs some love |
| 10:43 |
terranm99 |
Ah, okay, I'll check |
| 10:43 |
terranm99 |
thanks |
| 10:44 |
berick |
terranm99: https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d372c6c204fb3b835bfa8d97ee6f19622a1a6890 |
| 10:44 |
pinesol |
berick: [evergreen|Bill Erickson] LP1825851 Server managed/processed print templates - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d372c6c> |
| 10:45 |
berick |
eg_startup and eg_vhost |
| 10:48 |
Stompro |
terranm99, I tried again, but got the same thing... |
| 10:49 |
|
nfBurton joined #evergreen |
| 10:54 |
terranm99 |
berick++ Thanks, Bill, that was exactly right! Stompro - I've fixed the eg_startup and eg_vhost files so it looks like it's working now |
| 10:59 |
Dyrcona |
So many moving parts.... :) |
| 10:59 |
Stompro |
Thanks, I'll test away. |
| 10:59 |
* Dyrcona |
just loves it when he misses things like that. |
| 11:00 |
mmorgan |
terranm99++ |
| 11:00 |
mmorgan |
berick++ |
| 11:02 |
Dyrcona |
everybody++ |
| 11:07 |
tlittle |
berick That commit that you linked above for the server print templates, could the HTML: Defang be responsible for bug 1912504 ? It looks like it strips HTML out of print templates? |
| 11:07 |
pinesol |
Launchpad bug 1912504 in Evergreen "Angular print service prints tiny text" [Undecided,Confirmed] https://launchpad.net/bugs/1912504 |
| 11:10 |
berick |
tlittle: i don't think Defang would impact the font. it's only supposed to remvoe executable code (js, etc.). CSS / style attributes should be fine. |
| 11:10 |
tlittle |
Ah okay, darn. I was hoping to have happened upon a solution :) |
| 11:11 |
tlittle |
Thanks for looking! berick++ |
| 11:12 |
Stompro |
terranm99++ It is working for me, placed a couple hundred holds and a pull list with 99 items printed quite quickly. I'm going to play with the print template a little bit before I signoff. |
| 11:13 |
Stompro |
Want to make sure call number prefix/suffix and parts are working, and I don't think concerto includes those. |
| 11:16 |
|
Stompro joined #evergreen |
| 11:18 |
mmorgan |
General question, what's the process for setting the default columns in Angular grids? Specifically looking at the pull list interface on terran-master. |
| 11:18 |
berick |
mmorgan: it's done in the HTML |
| 11:19 |
berick |
if there are specific columns you would expect, note them in the LP and they can be added / tweaked. |
| 11:20 |
mmorgan |
Ok, will do that. Right now the only item info is the barcode. I'd expect location, call number (+prefix/suffix), part, author, title... |
| 11:27 |
Stompro |
I'm not seeing the part info in the angular pull list, or in the print list. The print template is using hold.p_label |
| 11:32 |
Stompro |
Hmmm, part info is only included for part type holds in the wide api? |
| 11:38 |
mmorgan |
Stompro: Not saying it's right, but I believe that's true currently. |
| 11:43 |
Stompro |
mmorgan, It makes sense... I just wasn't placing a part hold to test. I can see someone wanting that info, just because it makes it easier to find the exact copy, but I don't think it would come up all that often for us. |
| 11:44 |
Stompro |
berick, For the angular pull list, will all sorting be handled by the grid configuration? It would be good to have a default sort that matches the workstation print template. |
| 11:50 |
Dyrcona |
So, I just set up Evergreen on a Debian Stretch VM and I'm getting the default Debian home page, and I've checked that eg.conf is enabled and 000-default is disabled. |
| 11:52 |
Dyrcona |
With HTTPS, the "site cannot be reached." |
| 11:54 |
berick |
Stompro: looks like a thinko in the code. the pull list is supposed to sort by default the same as other pull lists (copy location order, etc.) but it's not getting correctly applied |
| 11:54 |
berick |
i can push a fix for that |
| 11:54 |
Dyrcona |
OK. nginx didn't like the TLSv1.3 directive in osrf-ws-http-proxy and may not have been running.. Fixing that resolved my issue. |
| 12:03 |
berick |
Stompro: patch pushed to same branch |
| 12:04 |
berick |
and LP updated |
| 12:07 |
|
jihpringle joined #evergreen |
| 12:36 |
|
mmorgan1 joined #evergreen |
| 13:30 |
terranm99 |
Stompro: I applied Bills followup patch to terran-master - probably need to clear browser cache |
| 13:38 |
|
gsams joined #evergreen |
| 13:41 |
|
gsams_ joined #evergreen |
| 13:42 |
|
gsams left #evergreen |
| 14:00 |
Stompro |
terranm99, thanks. |
| 14:00 |
|
mmorgan1 joined #evergreen |
| 14:01 |
|
alynn26 joined #evergreen |
| 14:02 |
|
rfrasur joined #evergreen |
| 14:02 |
|
Guest9836 joined #evergreen |
| 14:03 |
Dyrcona |
FYI: In case anyone else wants to try plprofiler, I had to add it to shared_preload_libraries, and the documentation is not up to date with version 4.1. |
| 14:12 |
Stompro |
terranm99, I'm not able to see any difference in the sorting... it doesn't seem like it is sorting by copy_location_order_position to start with. Changing the grid settings for sorting also doesn't seem to have any effect. |
| 14:18 |
Stompro |
terranm99, I'm using chrome dev tools to disable my cache, and it appears like the changes are not in the js files I'm seeing. Did you re-build/minifi/whatever it's call the js files. |
| 14:20 |
terranm99 |
I ran ng build but I haven't really looked at this patch yet. What order is it supposed to default to? |
| 14:21 |
terranm99 |
When I first open it, it appears to be sorting by hold id |
| 14:31 |
terranm99 |
Yeah, I can confirm that sorting is working as I expect... double-checking what I installed... |
| 14:34 |
JBoyer |
A quick indication of how well we're knocking it out of the park this week: I uploaded a branch with a git.evergreen-ils.org window open, clicked refresh and wondered why my branch didn't appear. You lot knocked it down to 8th in the list. Round of applause! |
| 14:35 |
mmorgan |
You_lot++ |
| 14:38 |
Stompro |
terranm99, I'm seeing it sort by request timestamp, which matches up with hold id. The fix was to set the sort order to copy_location_order_position. |
| 14:38 |
Stompro |
Then Item Location/Shelving Location name, then call number. |
| 14:39 |
terranm99 |
My comment above should have been I can confirm sorting is *not* working as I expect |
| 14:47 |
terranm99 |
Stompro: I verified the file updates are in place and I ran ng build again - did that make any difference? |
| 14:50 |
Stompro |
terranm99, no, I'm still seeing it sort by request date. I'll keep poking at it. Is there a way to not minimize the js files when bulding? ng build --debug or something ? |
| 14:51 |
terranm99 |
I don't know |
| 14:55 |
mmorgan |
terranm99: Did the minimized files get copied to /openils/var/web/eg2/en-US? |
| 14:56 |
berick |
Stompro: tlittle: ng build |
| 14:56 |
berick |
without the --prod |
| 14:57 |
Stompro |
berick++ thanks |
| 15:10 |
|
Dyrcona joined #evergreen |
| 15:12 |
terranm99 |
Taking terran-master down for a few minutes |
| 15:23 |
terranm99 |
Stompro: What about now? |
| 15:30 |
rfrasur |
terranm99, is Clark Kent running on terran-master right now? |
| 15:31 |
terranm99 |
Lemme check |
| 15:32 |
* mmorgan |
pictures terranm99 in her superhero cape running in to nudge Clark, who is snoozing at his desk... |
| 15:33 |
rfrasur |
mmorgan++ |
| 15:33 |
terranm99 |
mmorgan++ I'm not running anywhere at this point. Stumbling, maybe! |
| 15:33 |
terranm99 |
It should be running now |
| 15:34 |
rfrasur |
Yep!! |
| 15:35 |
Stompro |
terranm99, did you reset the db? |
| 15:36 |
terranm99 |
Yes, I clobbered everything |
| 15:41 |
Stompro |
terranm99, looks promising, not in request date order anymore. |
| 15:42 |
terranm99 |
Oh good. |
| 15:53 |
terranm99 |
We're now tied for most signoffs during a Feedback Fest or Bug Squashing Week ever (58) |
| 15:55 |
Dyrcona |
That's cool. |
| 15:55 |
alynn26 |
That is so cool |
| 16:04 |
Stompro |
berick, For the pull list, is the sort hard coded? If I wanted to add in the CN prefix and suffix in the sort would that just need to be a local change? |
| 16:11 |
mmorgan |
If anyone would like to test lp 1939730 on terran-master, I've enabled Course Reserves for BR1 and done the described setup to test |
| 16:11 |
pinesol |
Launchpad bug 1939730 in Evergreen "Course Materials: Course owner used as call_number.owning_lib when removing items from a Course" [Undecided,New] https://launchpad.net/bugs/1939730 |
| 16:17 |
terranm99 |
mmorgan++ |
| 16:18 |
berick |
Stompro: ah, i assumed the call number sortkey included the prefix/suffix info, but if not, then i think prefix/suffix should be added to the default sort |
| 16:27 |
terranm99 |
mmorgan: I can confirm that I can add then delete materials with no problems. I noticed that if I enter something into the Call Number field it doesn't appear to store it (or at least, it's not showing it in the grid - the grid just shows the original call number) - is that a different bug? |
| 16:28 |
mmorgan |
terranm99: I noticed that, too. I think that's a different bug, I'm not sure it's been reported yet. If you refresh the page, or go back to it, the changed call number shows up. |
| 16:29 |
mmorgan |
If it helps to see the current behavior where it fails, I can do the setup on one of the other test servers. |
| 16:30 |
terranm99 |
Ah! Yes, refreshing does make it show up |
| 16:30 |
terranm99 |
That would be great if you have time. This is the first time I've had a chance to look at this module. |
| 16:32 |
terranm99 |
There's a fix for the call number refresh that was signed off on - https://bugs.launchpad.net/evergreen/+bug/1907974 |
| 16:32 |
pinesol |
Launchpad bug 1907974 in Evergreen 3.6 "Editing call number for reserve item requires refresh" [Low,Confirmed] |
| 16:32 |
mmorgan |
Ooh! Yay! |
| 16:33 |
terranm99 |
Stepping away for a few minutes but I'll look again when I get back |
| 16:44 |
pinesol |
[evergreen|Galen Charlton] LP#1912852: add jump-on-one-hit support to Angular staff catalog - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=efdf28d> |
| 16:47 |
mmorgan |
terranm99: I did the setup on festivus. For the Aardvarks course, the two attached barcodes were originally BR2 items. |
| 16:52 |
terranm99 |
checking now... |
| 17:01 |
terranm99 |
mmorgan I'm not seeing the reported error on festivus - what am I doing wrong? I'm logged in as a BR1 workstation and adding a BR2 item and I'm able to delete it |
| 17:01 |
mmorgan |
terranm99: The error happens at the course owned by CONS, History of Indonesia. |
| 17:02 |
terranm99 |
Oh sorry, I was looking at the Aardvarks course |
| 17:02 |
mmorgan |
The problem with the other scenario is that the item that originally belonged to BR3, belongs to BR1 after it's removed from the course. |
| 17:03 |
mmorgan |
It's the Aardvark course where the item changes from BR2 to BR1 |
| 17:03 |
mmorgan |
Sorry I didn't mean BR3... |
| 17:04 |
terranm99 |
Okay, I confirm the error & fix for the first part - looking at the second part... |
| 17:07 |
terranm99 |
Confirming the error & fix for the second part - phew! |
| 17:07 |
mmorgan |
Yay!! |
| 17:12 |
* mmorgan |
needs to run. Awesome Feedback Fest Week!! |
| 17:12 |
mmorgan |
terranm99++ |
| 17:12 |
mmorgan |
everyone++ |
| 17:12 |
|
mmorgan left #evergreen |
| 17:12 |
terranm99 |
We now officially had the most bugs signed off during a feedback fest ever - (waves Kermit arms in the air) |
| 17:14 |
berick |
woohoo |
| 17:15 |
jihpringle |
yay!!!! |
| 17:15 |
terranm99 |
I'm logging off for the weekend now, but I'll update the final statistics on Monday! |
| 17:15 |
terranm99 |
Great job, everyone! |
| 17:24 |
pinesol |
[evergreen|Bill Erickson] LP1910452 Staff catalog Patron View button - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a6745cd> |
| 17:24 |
pinesol |
[evergreen|Bill Erickson] LP1910452 Remove staff catalog read-only OPAC Patron View - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c20936e> |
| 18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:02 |
pinesol |
[evergreen|Josh Stompro] LP#1938450 - missing pieces slip printer context set to receipt - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ffc4d88> |
| 18:02 |
* gmcharlt |
claims 1280 |
| 18:09 |
|
Stompro joined #evergreen |
| 18:10 |
pinesol |
[evergreen|Mike Rylander] LP#1895052: Allow pickup lib to control stalling - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9d48920> |
| 18:10 |
pinesol |
[evergreen|Mike Rylander] LP#1895052: Avoid foreign targets when local items exist - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1e09d5d> |
| 18:10 |
pinesol |
[evergreen|Galen Charlton] LP#1895052: stamp schema update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ef73f4b> |
| 18:10 |
pinesol |
[evergreen|Galen Charlton] LP#1895052: add a release notes entry - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d5ce3eb> |
| 18:24 |
pinesol |
[evergreen|Jane Sandberg] LP1935693: Add circulation modifier to course page - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e6c6b1a> |
| 18:24 |
pinesol |
[evergreen|Jane Sandberg] LP1935693: Improve spacing on the OPAC course materials table - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=97959c4> |
| 18:40 |
pinesol |
[evergreen|Jeff Davis] LP#1923076: ensure length of empty array is treated as a number when retrieving hold counts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e6006d5> |
| 18:40 |
pinesol |
[evergreen|Jason Stephenson] LP1923076: Add cast to int in more places - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=599ba17> |
| 18:40 |
pinesol |
[evergreen|Jason Stephenson] LP1923976: Remove some dead code - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=65fcf5c> |
| 18:40 |
pinesol |
[evergreen|Jason Stephenson] LP1923076: Add Perl live test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=518f9a2> |
