| Time |
Nick |
Message |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 08:36 |
|
Dyrcona joined #evergreen |
| 09:06 |
|
mantis joined #evergreen |
| 10:00 |
berick |
Dyrcona++ # pg profiling |
| 10:50 |
Bmagic |
is it "normal" for two duplicate rows getting created in vandelay.session_tracker? Both with the same key and queue ID number? |
| 10:52 |
Bmagic |
I guess I missed the "action_type" being "import" and "enqueue". So I guess it's normal. |
| 11:09 |
|
jvwoolf joined #evergreen |
| 13:08 |
csharp_ |
so... question for experienced EG perl devs - at what point do you decide it's better to move your script-supporting subroutines from the script itself into a shared library in the OpenILS tree? |
| 13:08 |
berick |
csharp_: one metric is if you find yourself repeating subroutines |
| 13:08 |
csharp_ |
I'm kind of creating sub after sub to the point where this is feeling kind of heavy for a script |
| 13:08 |
berick |
... accross multiple scripts |
| 13:09 |
csharp_ |
that makes sense |
| 13:10 |
Dyrcona |
I used to make a lot of Perl libraries, but not so much anymore. |
| 13:10 |
csharp_ |
I'm working on the student card branch for PINES (trying to make it generic enough for general use) and basing some of what I'm doing on your work for Ecards, berick |
| 13:10 |
Dyrcona |
I'm also not repeating as much code. |
| 13:10 |
* Dyrcona |
suspects that we're going to have code conflicts. |
| 13:11 |
Dyrcona |
Another criterion is if you *know* the code would be useful elsewhere, even if you don't have an immediate use for it, or if it is more generic than the purpose of your specific module. |
| 13:13 |
csharp_ |
yeah, that makes sense - based on this exchange I think I'm going to continue to build these within the script itself but with an eye to the idea that they may be in something like OpenILS::Application::Actor::StudentCards someday |
| 13:16 |
Dyrcona |
Right. OpenILS::Application::Cat::BibCommon is a good example of something like that. OpenILS::Application::AppUtils is a good example of generically useful routines. |
| 13:16 |
Dyrcona |
This conversation has caused me to look at what I've done with the Quipu branch so far. I think I might move some things around. |
| 13:17 |
csharp_ |
- |
| 13:17 |
csharp_ |
cool |
| 13:17 |
Dyrcona |
I put a couple of routines in AppUtils, but they probably don't belong there. |
| 13:18 |
jeffdavis |
I contributed some 3rd-party authentication stuff recently because I didn't want to deal with a bunch of bespoke auth scripts for different vendors. I used the same shared methods etc for different vendors as much as possible, because it's just easier to maintain that way. |
| 13:19 |
csharp_ |
yeah - your work was in mind when I was asking this |
| 13:19 |
csharp_ |
this is my first attempt at using shared perl methods for anything serious (that wasn't just editing someone else's work) so I'm on a steep hill :-) |
| 13:20 |
csharp_ |
so far it makes sense to do it this way though - the DBI stuff is the pits |
| 13:20 |
jeffdavis |
DBI for me would be a warning sign that I should build this into EG somehow instead. |
| 13:21 |
jeffdavis |
Student data/patron imports are so much more complex and variable than auth though... |
| 13:21 |
csharp_ |
right - I was thinking that all the time I was writing the 1.0 version of this, but I was under a lot of time pressure to just get it working |
| 13:23 |
Dyrcona |
Yeah, I'd agree that we should avoid using DBI directly in most Evergreen code. It isn't so bad in a utility script. |
| 13:48 |
|
jvwoolf joined #evergreen |
| 13:50 |
|
jvwoolf joined #evergreen |
| 13:55 |
* Dyrcona |
isn't liking the new list setup, though I understand why it was done. |
| 17:08 |
|
jvwoolf left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
