Time |
Nick |
Message |
00:31 |
|
sandbergja joined #evergreen |
02:44 |
|
sandbergja joined #evergreen |
02:54 |
|
pinesol joined #evergreen |
03:23 |
|
eglogbot joined #evergreen |
03:23 |
|
Topic for #evergreen is now Welcome to #evergreen (https://evergreen-ils.org). This channel will soon be publicly logged. |
03:23 |
jeff |
yay eglogbot. |
07:20 |
|
eglogbot joined #evergreen |
07:20 |
|
Topic for #evergreen is now Welcome to #evergreen (https://evergreen-ils.org). This channel will soon be publicly logged. |
08:14 |
|
alynn26 joined #evergreen |
08:26 |
|
rfrasur joined #evergreen |
08:45 |
|
mmorgan joined #evergreen |
09:05 |
|
Keith-isl joined #evergreen |
09:06 |
|
Keith_isl joined #evergreen |
09:38 |
|
Dyrcona joined #evergreen |
09:45 |
Dyrcona |
@karma jeff |
09:45 |
pinesol |
Dyrcona: Karma for "jeff" has been increased 5 times and decreased 0 times for a total karma of 5. |
09:45 |
Dyrcona |
jeff++ |
09:45 |
Dyrcona |
@karma |
09:45 |
pinesol |
Dyrcona: Highest karma: "JBoyer" (11), "jeffdavis" (10), "jeff" (6), "dluch" (4), and "gmcharlt_" (4). Lowest karma: "it." (-1), "marc" (-1), "evergreen" (1), "bshum" (1), and "alynn26" (1). You (Dyrcona) are ranked 6 out of 19. |
10:23 |
gmcharlt_ |
jeff++ |
10:27 |
|
collum joined #evergreen |
10:33 |
|
jvwoolf joined #evergreen |
10:35 |
|
gmonti joined #evergreen |
11:39 |
|
kip_ joined #evergreen |
11:41 |
gmcharlt |
for commiters and anybody who has been involved in the MARC-XSS-and-escaping saga: I would appreciate eyes on my pull request for user/gmcharlt/lp1930933_reveal_what_was_hidden |
11:41 |
gmcharlt |
er, bug 1930933 |
11:41 |
pinesol |
Launchpad bug 1930933 in Evergreen 3.6 "Hidden search result title" [High,Confirmed] https://launchpad.net/bugs/1930933 |
11:42 |
gmcharlt |
(noting as a potential thing we'd want to include in 3.7.1) |
11:42 |
|
troy joined #evergreen |
11:44 |
|
Dawn joined #evergreen |
11:48 |
Dyrcona |
gmcharlt: You're basically undoing the previous patch on the title fields. |
11:50 |
gmcharlt |
Dyrcona: correct, but unless I missed something during testing, that part of c31d052576 seems to have not been necessary |
11:50 |
pinesol |
gmcharlt: [evergreen|Jeff Davis] LP#1902965: HTML filter on Bootstrap OPAC search results and record display - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c31d052> |
11:52 |
gmcharlt |
(and if I _am_ missing something, arguably the normalization belongs inside html_text_attr() rather than outside it anyway |
11:53 |
|
Dawn joined #evergreen |
11:53 |
Dyrcona |
OK. I'll take a deeper look at what is going on. |
12:00 |
jeffdavis |
"><script>alert('uh oh');</script> |
12:01 |
jeffdavis |
^ that was the vulnerability that the html filter was fixing per 1902965 |
12:09 |
|
jihpringle joined #evergreen |
12:10 |
gmcharlt |
which no longer seems to be an issue even with my latest patch in place, but yeah, more eyes on testing will reveal all |
12:18 |
jeffdavis |
Just setting up a test environment for it now. |
12:21 |
|
rlefaive joined #evergreen |
12:22 |
|
plux joined #evergreen |
12:26 |
plux |
any reports of issues building 3.7 on Ubuntu 20.04 with Angular building? on my third attempt and /openils/var/web/eg2 doesn't build/get created using the tarball |
12:27 |
Dyrcona |
plux: I'm building from a git checkout on Ubunut 20.04 right now. I haven't gotten to the install yet. |
12:28 |
Dyrcona |
heh. "Ubunut." |
12:31 |
plux |
I had tried the git build as dev as well - hit different issues but many warnings and errors when I got to building Angular - was wondering if my Ubuntu vm is missing some dependency that stopped something from building - but I don't see errors on the install |
12:32 |
plux |
this is just the default code base on new Ubuntu 20 server - using concerto db - everything builds fine but staff client Administration links are broken |
12:46 |
Dyrcona |
plux: I haven't tried administration, yet, but everything else seems to be working so far. I've been editing concerto records to test gmcharlt's branch that was mentioned earlier. |
12:46 |
Dyrcona |
I'm using a default install as well of the latest master code from git. |
12:47 |
|
collum joined #evergreen |
12:48 |
jeff |
pinesol++ |
12:48 |
jeffdavis |
Looks like Freenode has banned my IRC client: https://twitter.com/IRCCloud/status/1404153550159159298 |
12:48 |
jeff |
jeffdavis: yes, again. this time it was not a "mistake", it seems. |
12:51 |
Dyrcona |
jeffdavis: Did you or someone else mention that last week? |
12:51 |
Dyrcona |
So, gmcharlt's patch seems to work and my record that was modified to show an alert in the title doesn't show an alert. |
12:51 |
jeff |
Dyrcona: they did it last week also, but it was temporary and either announced as or assumed to be a mistake. |
12:52 |
jeffdavis |
I've lost the ban message, but this time it was more directly "IRCCloud is banned," no reason given, rather than a generic message. |
13:14 |
Dyrcona |
I'll update the bug. jeffdavis, do you want to review the patch as well? |
13:15 |
degraafk |
IRCCloud had some less charitable things to say about Freenode’s takeover and rasengan decided that was enough to ban all IRCCloud users. He’s got a new BNC he wants you to use instead. |
13:19 |
jeffdavis |
Dyrcona: I'll still have a look, but definitely don't wait on my input |
13:30 |
|
eady joined #evergreen |
13:33 |
|
jvwoolf joined #evergreen |
13:37 |
Dyrcona |
jeffdavis: I pushed a signoff branch and mentioned what I did for testing. |
14:21 |
|
rhamby joined #evergreen |
14:23 |
|
jvwoolf joined #evergreen |
14:28 |
|
gmonti left #evergreen |
14:44 |
|
sandbergja joined #evergreen |
14:54 |
Dyrcona |
jeffdavis++ |
15:08 |
|
jvwoolf left #evergreen |
15:10 |
|
cmalm joined #evergreen |
15:32 |
|
cmalm joined #evergreen |
15:33 |
|
cmalm joined #evergreen |
16:23 |
|
cmalm joined #evergreen |
17:12 |
|
cmalm_ joined #evergreen |
17:13 |
|
mmorgan left #evergreen |
17:20 |
|
plux joined #evergreen |
17:28 |
|
jihpringle joined #evergreen |
18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
19:01 |
|
jonadab joined #evergreen |
19:24 |
|
kmlussier joined #evergreen |