| Time |
Nick |
Message |
| 00:27 |
|
sandbergja joined #evergreen |
| 00:28 |
|
eady joined #evergreen |
| 00:47 |
|
eady joined #evergreen |
| 02:10 |
|
miker joined #evergreen |
| 06:34 |
|
jeffdavis joined #evergreen |
| 06:34 |
|
troy__ joined #evergreen |
| 06:34 |
|
gmcharlt joined #evergreen |
| 07:26 |
|
rjackson_isl_hom joined #evergreen |
| 08:00 |
|
collum joined #evergreen |
| 08:33 |
|
rfrasur joined #evergreen |
| 08:33 |
|
Dyrcona joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:43 |
|
mantis1 joined #evergreen |
| 08:45 |
Dyrcona |
Whee! Fifty-one patch files against master, and that's after having squashed about that many commits over the past few years. |
| 08:48 |
Dyrcona |
Three-hundred and eighteen patches against rel_3_2_10, but that includes some backported stuff, such as Ubuntu 18 dependencies. |
| 08:49 |
Dyrcona |
Also, I squashed a number of things that took multiple tries to get right on 3.2 when I added them to the branch based on master. |
| 08:49 |
Dyrcona |
0048-CW-MARS-Customizations-for-rel_3_2.patch is 540,467 bytes by itself. :) |
| 08:50 |
Dyrcona |
A custom images patch is over 18MB, but that's image files. |
| 08:52 |
csharp |
sounds hard :-( |
| 08:52 |
csharp |
resolving git conflicts with (possibly deprecated) PINES customizations is one of the least satisfying parts of my job |
| 08:53 |
Dyrcona |
Sounds like a lot of changes. |
| 08:54 |
Dyrcona |
Yeahp. Since we no longer have 2 customizations, I've decided to just manage the changes in the actual templates, rather than a separate directory for master. |
| 08:56 |
Dyrcona |
It's interesting how the extent of the customization doesn't come into focus until you do something like format-patch. |
| 08:56 |
Dyrcona |
Seems like git can normally hide that from you. |
| 09:03 |
Dyrcona |
This commit, which I squashed some time ago, is the root of today's problem: Whitespace/Indentation cleanup in opensrf.xml.example. |
| 09:11 |
Dyrcona |
All right, removed the patches affecting opensrf.xml.example. Here goes.... |
| 09:12 |
Dyrcona |
I'm down to 46 patches, now, and one patch had a sizable chunk deleted. |
| 09:20 |
Dyrcona |
Hmm... I see something that I should possibly remove from the first commit, since our trick for taking a brick out of rotation seems to no longer work with nginx. |
| 09:31 |
Dyrcona |
Heh... The first commit message contains stuff that was later removed. :) |
| 09:33 |
csharp |
there's a lot of that in PINES customizations - and removals aren't always done obviously/explicitly |
| 09:34 |
|
dbwells joined #evergreen |
| 09:34 |
csharp |
I try to audit the list of customization commits every time I need to do it, but since I wasn't the author of a lot of them, I have to guess, or just leave them in |
| 09:37 |
Dyrcona |
Yeah. I'm doing this now so I won't have to later. :) |
| 09:38 |
Dyrcona |
I'm going to have similar fun with our sip configuration, which I keep in another branch. I am also removing sip-related commits from what I'm going to apply today. |
| 09:40 |
Dyrcona |
I'm down to 42 commits form the original 51. |
| 09:40 |
Dyrcona |
s/form/from/ |
| 09:41 |
Dyrcona |
Hm... Think I'll try dropping one more: Remove redundant custom code from opac/parts/misc_util.tt2 |
| 09:42 |
Dyrcona |
Careful editing of a previous patch should make that possible. |
| 09:43 |
Dyrcona |
Yeah. Looks like I can safely delete one hunk. |
| 09:47 |
Dyrcona |
Well, I guess I have the appropriate soundtrack going: "Nobody's Fault But Mine" by Led Zeppelin. :) |
| 09:48 |
Dyrcona |
The question comes up: Do I squash all of this when I'm done? |
| 09:59 |
|
dbwells joined #evergreen |
| 10:00 |
|
dbwells joined #evergreen |
| 10:01 |
* berick |
has considered squashing the whole shebang into one commit as well |
| 10:03 |
Dyrcona |
I frequently squash various commits together from time to time. |
| 10:04 |
Dyrcona |
I'm still perusing the patches to figure out how I want to apply them. I'm definitely going to apply a couple out of order and squash them into the first one. |
| 10:10 |
Dyrcona |
Meh. I'll just apply the remaining commits in order and fix it all up after. |
| 10:12 |
Dyrcona |
Oh... git am is no fun when there are conflicts. |
| 10:13 |
Dyrcona |
It doesn't put conflict markers in the file and it doesn't create a .rej file or anything useful like that.... |
| 10:14 |
Dyrcona |
Bleh..... |
| 10:18 |
Dyrcona |
Then, there are times when I think we should just do away with the customization, particularly of the OPAC. |
| 10:20 |
Dyrcona |
In the case of this one file, I'm not sure this particular change makes sense. |
| 10:21 |
Dyrcona |
The downside of squashing is it is harder to remove things later. |
| 10:24 |
Dyrcona |
And, I think there's a bug in this customization... |
| 10:26 |
Dyrcona |
No, it's just where the conflict occurs.... |
| 10:37 |
Bmagic |
JBoyer++ # antora |
| 10:46 |
Dyrcona |
Hm... Now, I wonder if the rest of that big patch file actually applied, because I'm getting conflicts with everything else that touches some of those files.... |
| 10:46 |
Dyrcona |
Grrr...... |
| 10:47 |
Dyrcona |
Maybe I should just squash it all and then start over? |
| 10:55 |
Dyrcona |
I don't understand why some of these patches don't apply. It's not like the line numbers or whitespace have changed..... |
| 10:57 |
Dyrcona |
Nope. This is worse..... |
| 10:57 |
Dyrcona |
cusomtization-- |
| 10:57 |
Dyrcona |
customization-- |
| 10:57 |
Dyrcona |
typos-- |
| 11:02 |
berick |
cusomtization sounds like a medieval ailment of the spleen |
| 11:03 |
mmorgan |
Or maybe a treatment for same |
| 11:05 |
Dyrcona |
Yeah.... |
| 11:05 |
Dyrcona |
berick++ mmorgan++ |
| 11:15 |
Dyrcona |
Well, this has been an exercise in frustration..... |
| 11:16 |
Dyrcona |
So, maybe I'll keep the custom opac directory and start over from our 3.2 branch.... |
| 11:42 |
csharp |
since every site has this problem, maybe an effort to separate form from function would be worth considering? I assume most customizations boil down to something like the JSPAC skins of old |
| 11:50 |
Dyrcona |
Well, that's what templates are supposed to do and it's the templates that I have the most trouble with. The Perl changes that I've made, no problem..... |
| 11:50 |
Dyrcona |
Configuration, too, can be an issue when you've basically replaced oils_sip.xml, etc. |
| 11:51 |
Dyrcona |
I'm going to try with git apply instead of git am see how that handles the big OPAC patch. |
| 11:52 |
Dyrcona |
I should get rej files. |
| 11:54 |
Dyrcona |
No, apparently git apply doesn't work that way, either. I'll have learn a bit more about how git am and so on work. |
| 11:54 |
Dyrcona |
After lunch, I guess. |
| 11:55 |
Dyrcona |
With git apply, if any individual patch fails, the whole patch file seems to fail. |
| 11:55 |
|
rfrasur joined #evergreen |
| 11:56 |
Dyrcona |
Apparently git am does the same. |
| 11:57 |
Dyrcona |
I'm pretty sure that git am uses apply under the hood. |
| 11:57 |
Dyrcona |
So, that explains why I had issues with my later patches to some of the OPAC files. |
| 11:57 |
Dyrcona |
Not even git can help me, now..... :( |
| 11:58 |
Dyrcona |
It looks like I'll have to go back to using the OPAC customization directory and manage the customization updates with Emacs' emerge-mode, which can be tricky, too. |
| 11:59 |
Dyrcona |
We also have staff client customization, but they seem to apply. |
| 12:00 |
Dyrcona |
They're small by comparison, and I did them 100%. The OPAC customization was mostly done by others, and I took it over. |
| 12:04 |
Dyrcona |
@monologue |
| 12:04 |
pinesol |
Dyrcona: Your current monologue is at least 15 lines long. |
| 12:04 |
Dyrcona |
@lunch |
| 12:04 |
pinesol |
Dyrcona: Does the abacus count itself? |
| 12:13 |
gmcharlt |
it does if it wants lunch |
| 12:13 |
|
jihpringle joined #evergreen |
| 12:31 |
Dyrcona |
Solution: The branch that I pulled the patches from is based on master at an earlier point, so I just apply the edited patches to that and rebase. |
| 12:49 |
Dyrcona |
Yeah, so far that works, but I haven't gotten to the rebase, yet. |
| 12:59 |
Dyrcona |
Missing patches can be an issue, too........ git reset --hard is a good command to know. :( |
| 13:01 |
Dyrcona |
git am ~/CWMARS/files/patches/master/*.patch # also works. :) |
| 13:02 |
Dyrcona |
And the rebase worked with "trailing whitespace" errors. |
| 13:23 |
csharp |
is there a dev meeting today? I have that down on my calendar for 3pm EDT |
| 13:28 |
Dyrcona |
I believe there is one on the calendar. |
| 13:48 |
* Dyrcona |
scratches his head at some of the opensrf.xml.example changes.... |
| 14:02 |
|
terranm joined #evergreen |
| 14:15 |
|
nfBurton79 joined #evergreen |
| 14:16 |
|
nfBurton11 joined #evergreen |
| 14:20 |
Dyrcona |
For oils_sip.xml, it is probably easier for me just to use ours. No point in trying to merge in the new options. We're already using the ones that we care about. :) |
| 14:24 |
|
jihpringle joined #evergreen |
| 14:26 |
Dyrcona |
rewrite Open-ILS/examples/oils_sip.xml.example (97%) |
| 14:26 |
Dyrcona |
And, that's why we can't have nice things. :P |
| 14:31 |
JBoyer |
Dev meeting coming up in ~ 30 mins |
| 14:32 |
JBoyer |
I sent a reminder to the list this morning but I don't think the list sends your own messages back to you. If no one got a reminder I'll have to double-check the address I was using. |
| 14:33 |
terranm |
JBoyer: I got it this morning |
| 14:36 |
JBoyer |
terranm++ |
| 14:37 |
Dyrcona |
680 files changed, 53642 insertions(+), 919 deletions(-) |
| 14:37 |
Dyrcona |
All in one commit, now. |
| 14:37 |
Dyrcona |
I haven't really checked my email today. |
| 14:38 |
Dyrcona |
JBoyer++ # I got the email about 10:30 AM. |
| 14:38 |
|
shulabear joined #evergreen |
| 14:58 |
|
alynn26 joined #evergreen |
| 15:01 |
JBoyer |
Time to light the lights, time to meet the developers, something, something. I don't remember the song that well. |
| 15:01 |
JBoyer |
#startmeeting 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06 |
| 15:01 |
pinesol |
Meeting started Tue Oct 6 15:01:32 2020 US/Eastern. The chair is JBoyer. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:01 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 15:01 |
|
Topic for #evergreen is now (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:01 |
pinesol |
The meeting name has been set to '2020_10_06___developer_meeting__agenda_available_at_https___wiki_evergreen_ils_org_doku_php_id_dev_meetings_2020_10_06' |
| 15:01 |
Dyrcona |
:) |
| 15:01 |
JBoyer |
#topic Introductions |
| 15:01 |
|
Topic for #evergreen is now Introductions (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:01 |
JBoyer |
Who have we here? |
| 15:01 |
phasefx |
I'm here :) |
| 15:01 |
Dyrcona |
#info Dyrcona = Jason Stephenson, CW MARS |
| 15:01 |
JBoyer |
#info JBoyer = Jason Boyer, EOLI |
| 15:02 |
phasefx |
#info phasefx = Jason Etheridge, EOLI |
| 15:02 |
jeffdavis |
#info jeffdavis = Jeff Davis, BC Libraries Coop (Sitka) |
| 15:02 |
abowling |
#info abowling = Adam Bowling, Emerald Data Networks |
| 15:02 |
dluch |
#info dluch is Debbie Luchenbill, MOBIUS (here for DIG) |
| 15:02 |
mmorgan |
#info mmorgan is Michele Morgan, NOBLE |
| 15:02 |
shulabear |
#info shulabear = Shula Link, GCHRL in GPLS |
| 15:02 |
mantis1 |
#info mantis1 = Gina Monti, Bibliomation |
| 15:02 |
dbwells |
#info dbwells = Dan Wells, Hekman Library (Calvin University) |
| 15:02 |
abneiman |
#info abneiman = Andrea Buntz Neiman, EOLI |
| 15:03 |
rfrasur |
#info rfrasur = Ruth Frasur, Indiana/lurking |
| 15:03 |
csharp |
#info csharp = Christopher J. Sharp, The Georgia Public Library Service |
| 15:03 |
alynn26 |
#info alynn26 = Lynn Floyd, Evergreen Indiana |
| 15:03 |
berick |
#info berick Bill Erickson, KCLS |
| 15:03 |
JBoyer |
If anyone joins midstream feel free to info it up. |
| 15:03 |
JBoyer |
#topic Action Items from Last Meeting |
| 15:03 |
|
Topic for #evergreen is now Action Items from Last Meeting (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:03 |
JBoyer |
#info berick and csharp to consider approaches to lp 1627373 |
| 15:03 |
csharp |
heh - nope! |
| 15:03 |
JBoyer |
I know you're both interested in seeing EDI improved; does this dev meeting reminder help or would you like to table this action item until there's more to report? |
| 15:03 |
* berick |
punts again |
| 15:03 |
pinesol |
Launchpad bug 1627373 in Evergreen "Acq: We need to fully implement EDI availability codes" [Wishlist,Confirmed] https://launchpad.net/bugs/1627373 |
| 15:04 |
csharp |
same |
| 15:04 |
mrisher |
I'm here sitting in |
| 15:04 |
dbwells |
csharp: /The/ Georgia Public Library Service ? |
| 15:04 |
csharp |
mrisher: welcome! |
| 15:04 |
gmcharlt |
#info gmcharlt = Galen Charlton, EOLI |
| 15:04 |
mrisher |
#info mrisher = Mike Risher, KCLS |
| 15:04 |
csharp |
dbwells: feeling frisky today :-) |
| 15:04 |
terranm |
#info terranm = Terran McCanna, PINES |
| 15:04 |
dbwells |
:D |
| 15:04 |
JBoyer |
Borrowing inflections from OSU, heh. |
| 15:05 |
JBoyer |
So thoughts on the Q above berick and csharp ? |
| 15:06 |
berick |
probably be good if we could pause it for a few months |
| 15:06 |
csharp |
+1 |
| 15:06 |
|
sandbergja joined #evergreen |
| 15:06 |
JBoyer |
Sounds good. We'll be happy to hear where there's more to report. :) |
| 15:07 |
JBoyer |
next previous action item was |
| 15:07 |
sandbergja |
#info sandbergja is Jane Sandberg, Linn-Benton Community College |
| 15:07 |
JBoyer |
#info gmcharlt will cut OpenSRF 3.2.1 around Evergreen point release time |
| 15:07 |
JBoyer |
And so it was, more on that very soon. |
| 15:07 |
JBoyer |
#topic OpenSRF Release Info |
| 15:07 |
|
Topic for #evergreen is now OpenSRF Release Info (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:07 |
JBoyer |
gmcharlt? |
| 15:07 |
gmcharlt |
as noted, 3.2.1 is released |
| 15:07 |
gmcharlt |
and I'd like to briefly ask what folks would like to see as dev priorities for OpenSRF 3.3 |
| 15:08 |
gmcharlt |
with SASL support being one of them, presumably |
| 15:08 |
Dyrcona |
Are Python and Java gone, yet? |
| 15:08 |
gmcharlt |
no |
| 15:08 |
Dyrcona |
Well, I'd like to see Java gone, at least. |
| 15:09 |
Dyrcona |
I *think* I had a branch somewhere... |
| 15:09 |
jeffdavis |
Python will come up under a later agenda item. |
| 15:09 |
Dyrcona |
All right. |
| 15:09 |
JBoyer |
And I have my "kind of works, for perl only" SASL changes at least moved over to my work machine, just need to finally push it up somewhere and do the rest. |
| 15:10 |
csharp |
bug 1827051 |
| 15:10 |
pinesol |
Launchpad bug 1827051 in OpenSRF "Removal of OpenSRF and Evergreen Java Libraries" [Low,New] https://launchpad.net/bugs/1827051 |
| 15:10 |
Dyrcona |
csharp++ |
| 15:11 |
Dyrcona |
I'll dust that branch off after the meeting and make sure it still works. |
| 15:11 |
Dyrcona |
Well, those branches.... |
| 15:12 |
JBoyer |
Seems like there are some good thoughts on how to make progress for 3.3. Does anyone have anything to add before moving on to Evergreen updates? |
| 15:12 |
JBoyer |
right-o |
| 15:12 |
JBoyer |
#topic Evergreen Release Info |
| 15:12 |
|
Topic for #evergreen is now Evergreen Release Info (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:13 |
JBoyer |
#info Release candidate due 2020-10-07 |
| 15:13 |
gmcharlt |
so, I put up the two points here |
| 15:13 |
gmcharlt |
and at this point, I'm curious if there's been additional testing of the Bootstrap OPAC from the betas |
| 15:14 |
gmcharlt |
and would like to identify any absolute showstoppers that should go into the -rc |
| 15:14 |
gmcharlt |
noting, also, that we're in string freeze |
| 15:14 |
csharp |
gmcharlt: it's on mine and terranm's to-do, but we haven't gotten there yet |
| 15:14 |
terranm |
I did some testing of the Bootstrap OPAC on festivus, but I'm not sure if that has the most recent version |
| 15:15 |
csharp |
(bootstrap opac) |
| 15:15 |
gmcharlt |
terranm: it does |
| 15:15 |
gmcharlt |
(AFAIR, anyway) |
| 15:16 |
terranm |
I think this bug summarizes the main issues - https://bugs.launchpad.net/evergreen/+bug/1895398 |
| 15:16 |
* mmorgan |
plans to finish up testing bug 1889128 for the rc |
| 15:16 |
pinesol |
Launchpad bug 1895398 in Evergreen "Bootstrap OPAC: follow up needed" [Undecided,New] - Assigned to Christopher Burton (cburton) |
| 15:16 |
pinesol |
Launchpad bug 1889128 in Evergreen "Angular Staff Catalog: Place Another Hold & Multi-Holds" [Undecided,Confirmed] https://launchpad.net/bugs/1889128 |
| 15:16 |
nfBurton11 |
there is a patch out there as well |
| 15:16 |
terranm |
The advanced search screen filters not working was the biggie for me |
| 15:17 |
nfBurton11 |
Yeah. That's fixed in the patch |
| 15:17 |
terranm |
nfBurton11++ |
| 15:17 |
nfBurton11 |
It was versioning on the Bootstrap that knocked it out |
| 15:17 |
terranm |
I don't think that's on festivus yet |
| 15:17 |
Bmagic |
#info Bmagic = Blake GH, MOBIUS |
| 15:18 |
nfBurton11 |
There are a number of bugs the OPAC will render obsolete. How do we proceed with those? I've been putting notes, but should they be tagged too |
| 15:18 |
Dyrcona |
#fixedinbootstrap ? |
| 15:19 |
terranm |
+1 |
| 15:19 |
gmcharlt |
comments to start, but note that "render obsolete" depends on when exactly when TPAC gets deprecated, then removed |
| 15:19 |
JBoyer |
They could perhaps have a "legacyopac" tag or similar IIF they definitely don't apply to the new opac. |
| 15:19 |
nfBurton11 |
I like that |
| 15:19 |
gmcharlt |
certainly the deprecation isn't planned before 3.7, and as folks know, there's current disagreement about scheduling renewal |
| 15:19 |
Dyrcona |
I suggested #fixedinbootstrap because I think we had #fixedinwebby before. |
| 15:19 |
JBoyer |
Yeah, the window should be small, but I certainly wouldn't expect all fixes to halt on the existing opac next week. |
| 15:19 |
abneiman |
+1 to 'legacyopac' as it can probably be applied to *cough* even older bugs :) |
| 15:20 |
gmcharlt |
(also, regarding Bootstrap, after 1895398 is dealt with, I would like to make a plea that we move away from big omnibus patches) |
| 15:20 |
Dyrcona |
:) |
| 15:20 |
alynn26 |
++ |
| 15:21 |
Dyrcona |
gmcharlt: You don't want to spend 6 hours reconciling them against master, either, huh? :) |
| 15:21 |
terranm |
+1 |
| 15:22 |
csharp |
+1 |
| 15:22 |
gmcharlt |
terranm: could you turn your comment #6 into a separate bug, please? |
| 15:22 |
terranm |
sure |
| 15:22 |
gmcharlt |
thanks |
| 15:23 |
gmcharlt |
otherwise, unless we can declare a set end point for 1895398, I can't guarantee it making it into the -rc |
| 15:23 |
Dyrcona |
+1 I'm all for smaller bugs and smaller patches. |
| 15:23 |
gmcharlt |
but providing that the branch doesn't change out from underneath me, I can make a committment to review the current pull request for 1895398 tonight for potential inclusion in the -rc |
| 15:23 |
mmorgan |
+1 |
| 15:24 |
JBoyer |
Ok, anything further for Evergreen updates? |
| 15:24 |
alynn26 |
+1 l |
| 15:24 |
JBoyer |
#topic Hatch Release Info |
| 15:24 |
|
Topic for #evergreen is now Hatch Release Info (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:24 |
JBoyer |
I don't have anything and haven't seen much change recently. |
| 15:25 |
JBoyer |
Hopefully that means it's mature and working well. |
| 15:25 |
JBoyer |
We do however, have |
| 15:25 |
JBoyer |
#topic New Business |
| 15:25 |
|
Topic for #evergreen is now New Business (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:26 |
dluch |
Wait, what about Documentation? |
| 15:26 |
JBoyer |
Ah, as I accidentally skip docs. :/ |
| 15:26 |
JBoyer |
Need ot update my script. :) |
| 15:26 |
dluch |
:-) |
| 15:26 |
JBoyer |
#topic Documentation |
| 15:26 |
|
Topic for #evergreen is now Documentation (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:26 |
dluch |
So, some exciting stuff going on with documentation: |
| 15:26 |
dluch |
on 9/8/20 gmcharlt merged Bmagic 's Antora branch to master |
| 15:27 |
dluch |
then gmcharlt is going to update the main docs page to point to the new files |
| 15:27 |
dluch |
(did that happen?) |
| 15:27 |
Bmagic |
it was :)collab |
| 15:27 |
gmcharlt |
https://eg-docs.georgialibraries.org/ has the latest and greatest |
| 15:27 |
dluch |
Cool |
| 15:27 |
gmcharlt |
and at this point, unless there are any objections, I think it would be safe to point the docs.evergreen-ils.org name to the new server |
| 15:27 |
dluch |
Also, DIG has a recommendation-slash-request that if you write new features and have docs for them, we are happy to take them and make them adocs and commit them |
| 15:28 |
rfrasur |
gmcharlt++ dluch++ DIG++ |
| 15:28 |
dluch |
+1 to that, gmcharlt! |
| 15:28 |
dluch |
gmcharlt++ Bmagic++ |
| 15:28 |
dluch |
one more thing... |
| 15:28 |
rfrasur |
and Bmagic++ # of course |
| 15:29 |
dluch |
wait, no two more things, lol |
| 15:29 |
Bmagic |
dluch++ rfrasur++ |
| 15:29 |
alynn26 |
one quick thing... THe database schema Maps need updating for 3.3 -3.5 |
| 15:29 |
gmcharlt |
JBoyer: Bmagic: I didn't pay complete attention to your conversation yesterday about the lunr bits |
| 15:29 |
Dyrcona |
dluch raises a question that just occurred to me. Had the inclusion of Antora changed what we need to do for release notes? Did I miss something about that? |
| 15:29 |
gmcharlt |
are things squared away there? |
| 15:29 |
JBoyer |
Finally, yes. |
| 15:29 |
dluch |
As the two docs committers and the facilitator of DIG, @abneiman, @sandbergja and I made an executive decision that there will be no backporting of older docs |
| 15:29 |
csharp |
gmcharlt: ping me about that - probably want a hostname change too (if we're talking about docs-testing) |
| 15:30 |
Bmagic |
yep! JBoyer++ |
| 15:30 |
gmcharlt |
csharp: no, eg-docs |
| 15:30 |
JBoyer |
After (mumble) minutes staring at it I added an @import line and the CSS was pleased. |
| 15:30 |
csharp |
oh - great! |
| 15:30 |
gmcharlt |
csharp: but yes, I'll follow up with you |
| 15:30 |
Bmagic |
I just built off Evergreen master a few minutes ago, and the site search is working once more |
| 15:30 |
csharp |
gmcharlt++ |
| 15:30 |
gmcharlt |
alynn26: indeed. we'll need to reverse-engineer what was used to produce the older schemas |
| 15:30 |
gmcharlt |
although the floor is certainly open to newer tools that might produce a more usable schema doc/sub-site |
| 15:31 |
gmcharlt |
Dyrcona: as far as release notes are concerned, they're not part of the Antora framework to date |
| 15:31 |
gmcharlt |
and are still built the same way for release |
| 15:31 |
gmcharlt |
though abneiman did adjust the 3.6 release notes to use the same style of marking headings that the rest of the docs now do |
| 15:32 |
JBoyer |
I was initially intrigued by the tool that Koha uses for their schema site, but with a many links as we have it seemed less useful when I last tried playing with it. (which has been a bit) |
| 15:32 |
Dyrcona |
OK, thanks. |
| 15:32 |
JBoyer |
dluch, I see one of your two more things, was there more you wanted to share? |
| 15:32 |
dluch |
DIG will be at the hack-a-way, with a focus on 3.6 documentation |
| 15:32 |
dluch |
That's all! |
| 15:32 |
phasefx |
a schema browser even without pretty graphics might be a win |
| 15:33 |
JBoyer |
dluch++ |
| 15:33 |
alynn26 |
phasefx++ |
| 15:33 |
abneiman |
dluch++ |
| 15:33 |
alynn26 |
dluch++ |
| 15:34 |
JBoyer |
phasefx, yeah, any graphics are pretty much a one-way ticket to a big black smear of lines going hither an yon. That's one way to fingerprint a software project I suppose. :) |
| 15:34 |
JBoyer |
Thanks for the doc updates! |
| 15:34 |
JBoyer |
#topic New Business |
| 15:34 |
|
rfrasur joined #evergreen |
| 15:34 |
|
Topic for #evergreen is now New Business (Meeting topic: 2020-10-06 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2020-10-06) |
| 15:35 |
JBoyer |
#info Next scheduled meeting is Tuesday, November 3rd, reschedule? |
| 15:35 |
JBoyer |
I'm certainly +1 to moving the next meeting in line with this first item. How about everyone else? |
| 15:36 |
gmcharlt |
+1 |
| 15:36 |
terranm |
+1 |
| 15:36 |
dbwells |
+1 |
| 15:36 |
gmcharlt |
maybe Tuesday, Nov 10 specifically? (same time) |
| 15:36 |
mantis1 |
+1 |
| 15:36 |
dbwells |
+1 to that as well |
| 15:36 |
dluch |
+1 |
| 15:36 |
jeffdavis |
oh that's US election day, +1 |
| 15:36 |
JBoyer |
Skip or nudge was going to be my next Q. |
| 15:36 |
berick |
+1 |
| 15:37 |
JBoyer |
I can do the 10th (If anyone is +1-ing that, you may need to spell that out. :) ) |
| 15:38 |
alynn26 |
+1 to the 10th |
| 15:38 |
mantis1 |
10th +1 |
| 15:38 |
terranm |
I don't see any conflicts on the community calendar for the 10th |
| 15:38 |
mmorgan |
+1 11/10 |
| 15:38 |
shulabear |
+1 |
| 15:38 |
JBoyer |
Sounds like a winner to me. |
| 15:39 |
JBoyer |
Do we have a volunteer to update the community calendar? |
| 15:39 |
terranm |
I can do it I think |
| 15:40 |
Dyrcona |
I think I can do it if terranm doesn't have permission. |
| 15:40 |
JBoyer |
#info Next meeting is 2020-11-10 at 3p Eastern / 12 p Pacific |
| 15:40 |
terranm |
Hmm, maybe I don't have permission |
| 15:40 |
JBoyer |
I know that I don't, so didn't want to forget. :) |
| 15:40 |
gmcharlt |
I've updated the calendar |
| 15:40 |
JBoyer |
gmcharlt++ |
| 15:41 |
gmcharlt |
wait, hold on, wrong calendar |
| 15:41 |
gmcharlt |
one moment |
| 15:41 |
Dyrcona |
:) |
| 15:42 |
Dyrcona |
gmcharlt++ |
| 15:42 |
gmcharlt |
ok, there we go |
| 15:42 |
JBoyer |
With that, who would like to talk about Antora CI ? (I mean, I have an idea, but go for it. :) ) |
| 15:42 |
sandbergja |
Oh, that was me! |
| 15:42 |
JBoyer |
I was mistaken! |
| 15:43 |
JBoyer |
#info Continuous integration for Antora |
| 15:43 |
sandbergja |
So, a long-standing issue with docs is that getting an environment to build the docs is tricky |
| 15:43 |
sandbergja |
especially on Windows |
| 15:43 |
sandbergja |
especially for occassional (sp?) docs contributors |
| 15:43 |
sandbergja |
with Antora, it's still complicated |
| 15:44 |
sandbergja |
although JBoyer has done a lot to simplify it |
| 15:44 |
sandbergja |
JBoyer++ |
| 15:44 |
sandbergja |
So, I made a thing: https://github.com/sandbergja/Evergreen/pull/4 |
| 15:45 |
gmcharlt |
sandbergja++ |
| 15:45 |
sandbergja |
Basically, if somebody makes a pull request to this github repo, CircleCI will build the docs with the proposed change, then a bot replies with a link to the built docs |
| 15:45 |
abneiman |
sandbergja++ |
| 15:45 |
JBoyer |
sandbergja++ |
| 15:45 |
mmorgan |
sandbergja++ |
| 15:45 |
sandbergja |
There are a lot of refinements that ought to be made, and also some discussions about whether we want to start relying on CircleCI and Github to this extent |
| 15:45 |
dluch |
sandbergja++ |
| 15:46 |
sandbergja |
We could discuss those at the hackaway perhaps? |
| 15:47 |
gmcharlt |
yeah |
| 15:47 |
* phasefx |
wants to put doc building back into the live tester as well, but really likes CI |
| 15:47 |
gmcharlt |
https://circleci.com/open-source/ <== seems promising |
| 15:47 |
Dyrcona |
Could it be integrated with gitlab? |
| 15:47 |
sandbergja |
Dyrcona: good question! |
| 15:48 |
Dyrcona |
And, I'm not looking for an answer today, but it could help us decide what to do about git. |
| 15:48 |
gmcharlt |
putting on my board hat, the main immediate caution is that we don't end up depending on a tool that would require an unexpected expenditure to keep using |
| 15:48 |
sandbergja |
That does make sense! |
| 15:48 |
sandbergja |
And CircleCI is far from the only option out there |
| 15:49 |
gmcharlt |
so that's a consideration, but services that are willing to give free services to open source projects and/or nonprofits of course are good to consider |
| 15:49 |
sandbergja |
Although not all CI services out there will build and store artifacts in a publicly accessible place |
| 15:49 |
sandbergja |
So... feel free to ask me any questions before the hackaway, and we can talk about it further then? |
| 15:50 |
JBoyer |
And on that point, while it proves they work and you can view them to verify, it's not really intended to be used from the CI output, right? |
| 15:50 |
JBoyer |
(just making sure I'm following) |
| 15:50 |
JBoyer |
The build outputs, I mean. |
| 15:50 |
sandbergja |
JBoyer: correct. It's set up more for building than testing |
| 15:51 |
JBoyer |
ok |
| 15:51 |
sandbergja |
(if I understood your question right) |
| 15:51 |
gmcharlt |
quick preview for doc writers is the primary use case, I take it? |
| 15:51 |
sandbergja |
there is an annoying issue with Antora where it always returns an exit code of 0, even if you give it a million errors :-( |
| 15:51 |
sandbergja |
gmcharlt: at this point, yes |
| 15:52 |
JBoyer |
sandbergja++ |
| 15:52 |
Dyrcona |
sandbergja++ |
| 15:52 |
sandbergja |
although I could totally see it being beneficial to run the test suites we have for code, too |
| 15:52 |
gmcharlt |
sandbergja++ |
| 15:53 |
sandbergja |
but we can get there eventually |
| 15:53 |
sandbergja |
:-) |
| 15:53 |
gmcharlt |
(sandbergja: Bmagic: JBoyer: side note - I would like to build a Git repo (or set of repos) that cover all aspects of the entire docs site) |
| 15:54 |
JBoyer |
It might be interesting to get the previous buildbot (or something like it, anyway) going again, or finding out if Evergreen would fit within someone's free plan, outside of just docs. |
| 15:54 |
JBoyer |
gmcharlt, +1 |
| 15:55 |
Bmagic |
It seems to me that the current docs server could trigger a build -> /dev/ when the repo receives a new push to X branch ? |
| 15:55 |
gmcharlt |
that wouldn't be too hard to set up |
| 15:56 |
gmcharlt |
but I think that distinct from CI of PRs in progress |
| 15:57 |
JBoyer |
We'll have to keep moving but I'm looking forward to how this moves forward in the future, sandbergja++ |
| 15:57 |
JBoyer |
#info Ubuntu 20.04, Python, Syrup |
| 15:58 |
JBoyer |
jeffdavis, was this yours or did you just happen to notice that Python was going to come up later? |
| 15:58 |
jeffdavis |
Yeah, I added it. |
| 15:59 |
jeffdavis |
We don't support 20.04 yet and IIRC changes in Python support are the big stumbling block there. |
| 16:00 |
jeffdavis |
At this point I think Syrup is the main reason we haven't dropped Python yet (which would help us get 20.04 supported), and I wonder if the inclusion of the course reserves module changes where we are with that. |
| 16:00 |
Dyrcona |
There's also a Lp bug suggesting that we update to Python 3 or drop Python support. Lp 1827055 |
| 16:00 |
pinesol |
Launchpad bug 1827055 in OpenSRF "Python binding for OpenSRF and Evergreen" [Undecided,New] https://launchpad.net/bugs/1827055 |
| 16:00 |
Dyrcona |
Well, Syrup is a whole other issue. |
| 16:01 |
Dyrcona |
AFAICT, Syrup is dead software. |
| 16:01 |
gmcharlt |
https://www.youtube.com/watch?v=Jdf5EXo6I68 |
| 16:02 |
gmcharlt |
though more seriously, have any of the sites who are still running Syrup had an opportunity to compare it with the new module? |
| 16:02 |
Bmagic |
gmcharlt++ |
| 16:02 |
csharp |
gmcharlt++ |
| 16:02 |
Dyrcona |
We don't run Syrup any longer. |
| 16:02 |
gmcharlt |
jeffdavis: do y'all still run Syrup? |
| 16:03 |
jeffdavis |
No. |
| 16:03 |
mmorgan |
NOBLE feels that it has all the building blocks we need. |
| 16:03 |
jeffdavis |
(Actually we never did, we use the old Conifer thing.) |
| 16:03 |
mmorgan |
We're still running Syrup, but ran into an issue when we upgraded to 3.4 |
| 16:04 |
JBoyer |
dbwells, did/do you use Syrup? |
| 16:04 |
dbwells |
Yes, we do. |
| 16:04 |
JBoyer |
I thought your name came up the last time it was discussed but may be misremembering. |
| 16:04 |
JBoyer |
Ah |
| 16:04 |
dbwells |
(In another meeting now, sorry...) |
| 16:04 |
JBoyer |
The time has gotten away from me a little today. |
| 16:05 |
Dyrcona |
I'm inclined to drop Python, but I feel less strongly about that than I do Java. However, someone needs to step up and maintain the Python bindings if we don't remove it. |
| 16:06 |
JBoyer |
If there are no other current active Syrup users (in-channel at least) it's difficult to tell how much impact dropping Python would have at this point, Java is easier since as I understand it it's been completely broken for some time. |
| 16:07 |
gmcharlt |
possible action item is putting out a call for Syrup users to identifty themselves (which I think Dyrcona had done a couple years ago? but wouldn't hurt to repeat) |
| 16:07 |
Dyrcona |
IIRC, Syrup doesn't actually need the Evergreen Python bindings, either. |
| 16:07 |
Dyrcona |
I could be mistaken/misremembering. |
| 16:07 |
mmorgan |
NOBLE plans to move to the new module as soon as we upgrade to 3.6 |
| 16:09 |
jeffdavis |
+1 to gmcharlt's suggestion, we can probably defer further discussion |
| 16:09 |
JBoyer |
Well, The good news is that we likely won't be dropping it in a point release, so there will be whatever functional support that there currently is through 3.6. |
| 16:09 |
abowling |
gmcharlt++ |
| 16:10 |
gmcharlt |
Dyrcona: I checked, I think it does import some osrf.* stuff from OpenSRF |
| 16:10 |
JBoyer |
So we could look at removing Java and removing / updating Python for 3.7. And yes, a quick survey of evergreen-general (or -users?) would be a good thing to have for that duscussion. |
| 16:10 |
Dyrcona |
gmcharlt: OK. I had some bad information. |
| 16:11 |
jeffdavis |
Since I opened my big mouth, I can email the lists re: Syrup. |
| 16:11 |
JBoyer |
jeffdavis++ |
| 16:11 |
abowling |
confirmed |
| 16:11 |
csharp |
jeffdavis++ |
| 16:11 |
Dyrcona |
jeffdavis++ |
| 16:11 |
abowling |
just a brief sniff of syrup.git: |
| 16:11 |
JBoyer |
#action jeffdavis to gather information re:current Syrup users |
| 16:11 |
abowling |
26 OPENSRF_AUTHENTICATE = "open-ils.auth.authenticate.complete" |
| 16:11 |
abowling |
27 OPENSRF_AUTHENTICATE_INIT = "open-ils.auth.authenticate.init" |
| 16:11 |
abowling |
28 OPENSRF_BATCH_UPDATE = "open-ils.cat.asset.copy.fleshed.batch.update" |
| 16:11 |
gmcharlt |
Dyrcona: to be fair, what it's importing seems to be client wrappers that could just be folded into Syrup itself and which should continue to work unless we take away the gateway |
| 16:12 |
csharp |
whatever the outcome, it's a sticky situation eh? |
| 16:12 |
abowling |
csharp: hi-o! |
| 16:12 |
phasefx |
ba dum dum |
| 16:12 |
Dyrcona |
:) |
| 16:12 |
jeffdavis |
I for one think it's time to stop waffling on Python support. |
| 16:12 |
csharp |
jeffdavis++ |
| 16:12 |
JBoyer |
csharp++ |
| 16:12 |
abowling |
oh. dear. god. |
| 16:12 |
JBoyer |
jeffdavis++ |
| 16:12 |
abowling |
see what you started?! |
| 16:13 |
* csharp |
high-fives jeffdavis |
| 16:13 |
jeffdavis |
:) |
| 16:13 |
gmcharlt |
JBoyer: quick, end the meeting lest the puns grow! ;) |
| 16:14 |
JBoyer |
Ok, I'm looking forward to seeing how we can get from here to supports-ubuntu-20.04. Anyone else have any further discussion? |
| 16:14 |
Dyrcona |
Do we want to continue discussion Ubuntu 20.04 or end the meeting. I think there are other things that we'll run into. |
| 16:14 |
gmcharlt |
do we know what some of those pain points are? |
| 16:14 |
Dyrcona |
Pg 12, for one. |
| 16:14 |
Dyrcona |
Pg 11, possibly, too. |
| 16:15 |
* csharp |
is installing a 20.04 VM right now to start poking at |
| 16:15 |
Dyrcona |
I have a 20.04 VM, but haven't really started looking. |
| 16:15 |
JBoyer |
Do we not use the pgdg repo on Ubuntu? I'm not saying we should ride 9.6 over a cliff but does that specifically affect 20.04 support? |
| 16:16 |
Dyrcona |
We do use the pgdg repo, but 9.6 is EOL in 1 year. Pg 13 is being released. |
| 16:17 |
JBoyer |
Ah, ok. So not 100% tied to 20.04 but still really timely. :/ |
| 16:17 |
Dyrcona |
Pg 12 is the default on 20.04. |
| 16:18 |
Dyrcona |
It bothers me that core parts of the infrastructure are falling behind, and I don't have time to keep up with everything. |
| 16:18 |
JBoyer |
Given the time and the fact that we've likely lost some folks, do you want to make this one of the major points of the 11/10 meeting (which also gives people time to look specifically into it also)? |
| 16:19 |
* JBoyer |
misses Slack's ability to edit his grammar crimes. |
| 16:20 |
csharp |
JBoyer: +1 |
| 16:20 |
csharp |
(for pushing this to 11/10) |
| 16:20 |
* abowling |
votes to pick back up on the 20.04 talk on 11/10 |
| 16:20 |
Dyrcona |
We're going to have to discuss it some time. I plan to spend most if not all of the hackaway looking at Ubuntu 20.04 and newer Pg releases. |
| 16:20 |
abowling |
Dyrcona++ |
| 16:21 |
JBoyer |
I'll go ahead and make that assumption (and setup the agenda for the next meeting today). It is an important discussion. |
| 16:21 |
JBoyer |
Dyrcona++ |
| 16:21 |
JBoyer |
Ok, with that those of you still with us are free to go! See you on the 10th. |
| 16:21 |
JBoyer |
#endmeeting |
| 16:21 |
|
Topic for #evergreen is now Welcome to the #evergreen library system channel! | We are publicly logged: http://irc.evergreen-ils.org/evergreen | Large pastes at http://paste.evergreen-ils.org | Can't speak? Make sure your nickname is registered and that you are identified to freenode services: https://freenode.net/kb/answer/registration |
| 16:21 |
pinesol |
Meeting ended Tue Oct 6 16:21:51 2020 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 16:21 |
pinesol |
Minutes: http://evergreen-ils.org/meetings/evergreen/2020/evergreen.2020-10-06-15.01.html |
| 16:21 |
pinesol |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2020/evergreen.2020-10-06-15.01.txt |
| 16:21 |
pinesol |
Log: http://evergreen-ils.org/meetings/evergreen/2020/evergreen.2020-10-06-15.01.log.html |
| 16:21 |
abowling |
In addtion to CI convo, hack-a-way seems prime territory to talk focal |
| 16:21 |
dluch |
JBoyer++ |
| 16:22 |
berick |
JBoyer++ |
| 16:22 |
Dyrcona |
JBoyer++ |
| 16:22 |
phasefx |
JBoyer++ |
| 16:22 |
abowling |
JBoyer++ |
| 16:22 |
mmorgan |
JBoyer++ |
| 16:22 |
gmcharlt |
JBoyer++ |
| 16:22 |
rfrasur |
JBoyer++ |
| 16:22 |
|
mantis1 left #evergreen |
| 16:22 |
jeffdavis |
JBoyer++ |
| 16:23 |
csharp |
JBoyer++ |
| 16:28 |
phasefx |
so, now that the meeting is over... Syrup is running on a short stack |
| 16:28 |
csharp |
phasefx++ |
| 16:28 |
JBoyer |
phasefx++ |
| 16:28 |
Bmagic |
JBoyer++ |
| 16:28 |
gmcharlt |
phasefx++ |
| 16:39 |
* Dyrcona |
calls it a day. |
| 17:03 |
jeffdavis |
My email to the -general list doesn't *not* encourage more Syrup-related puns... |
| 17:06 |
|
mmorgan left #evergreen |
| 17:11 |
gmcharlt |
jeffdavis: thank you for helping to identify all the trees we need to tap |
| 17:11 |
jeffdavis |
gmcharlt++ |
| 17:12 |
jeff |
*groan* |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:28 |
|
justdoglet joined #evergreen |
| 18:33 |
|
justdoglet left #evergreen |
| 19:45 |
|
sandbergja joined #evergreen |
