| Time |
Nick |
Message |
| 00:38 |
|
mrisher joined #evergreen |
| 00:46 |
|
JBoyer joined #evergreen |
| 00:56 |
|
collum joined #evergreen |
| 02:59 |
|
collum joined #evergreen |
| 05:28 |
|
collum joined #evergreen |
| 06:16 |
|
collum joined #evergreen |
| 07:23 |
|
rjackson_isl_hom joined #evergreen |
| 07:30 |
|
collum joined #evergreen |
| 08:07 |
|
Dyrcona joined #evergreen |
| 08:18 |
|
rfrasur joined #evergreen |
| 08:34 |
|
mantis1 joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 09:16 |
mmorgan |
abowling++ # for considering bug 1738021 |
| 09:16 |
pinesol |
Launchpad bug 1738021 in Evergreen "Wishlist: Provide functionality to change a hold from one type to another" [Wishlist,Confirmed] https://launchpad.net/bugs/1738021 - Assigned to Adam Bowling (abowling) |
| 10:53 |
csharp |
WARNING in /home/opensrf/Evergreen/Open-ILS/src/eg2/src/app/staff/admin/local/shelving_location_groups/shelving_location_groups_routing.module.ts is part of the TypeScript compilation but it's unused. |
| 10:53 |
csharp |
Add only entry points to the 'files' or 'include' properties in your tsconfig. |
| 10:53 |
csharp |
seeing that with the patch for https://bugs.launchpad.net/evergreen/+bug/1852321 installed |
| 10:53 |
pinesol |
Launchpad bug 1852321 in Evergreen "Angular: Local Admin Shelving Location Groups Port" [Wishlist,Confirmed] |
| 10:54 |
berick |
csharp: that's common for code developed for Angular 8 but now running on Ang 10 |
| 10:54 |
csharp |
ah |
| 10:54 |
berick |
requires a code tweak |
| 10:54 |
csharp |
ok - glad to know it's not a "you built it wrong" problem on my end :-) |
| 10:55 |
berick |
just looked at the code, confirmed it's needs updating |
| 10:55 |
berick |
specifcially, the 'loadChildren' stuff |
| 11:40 |
|
nfBurton joined #evergreen |
| 12:05 |
mmorgan |
Anyone have a Chrome extension for clearing cache that they recommend to their users? The one we were recommending is no longer available in the Chrome Web Store :-( |
| 12:07 |
csharp |
mmorgan: no extension, but we point them to this: https://pines.georgialibraries.org/dokuwiki/doku.php?id=admin:workstations:troubleshooting#clear_cache |
| 12:11 |
mmorgan |
csharp: Thanks. We liked the extension because it allowed setting the options once, then it just took one click to clear the cache and reload the page. |
| 12:11 |
berick |
wish the chrome 'Empty Cache & Hard Reload' option didn't require opening dev tools first :\ |
| 12:12 |
mmorgan |
Agreed! |
| 12:16 |
|
nfburton joined #evergreen |
| 12:17 |
mmorgan |
berick: I think you led me to just what I was looking for: https://chrome.google.com/webstore/detail/hard-refresh/ichmdelihgokllcnibkcpciljnggojkj/related?hl=en-US |
| 12:18 |
berick |
mmorgan: nice! let us know how it goes |
| 12:25 |
Dyrcona |
So, I tried backporting curbside to 3.2.10 and I get this with ng build --prod: ERROR in src/app/staff/nav.component.ts(48,18): error TS2339: Property 'org' does not exist on type 'StaffNavComponent'. |
| 12:25 |
Dyrcona |
I suppose I could back out the Angular patch and hope for the best. |
| 12:26 |
JBoyer |
Dyrcona, I thought there was a pre-backported version somewhere in working? Or are you seeing that error with that branch? |
| 12:26 |
Dyrcona |
JBoyer: There is, but it is out of date. I added some of the more recent changes. |
| 12:27 |
JBoyer |
Ah, right, forgot about those. |
| 12:27 |
Dyrcona |
I haven't actually checked which commit causes the above. I'll take a look after lunch. |
| 12:28 |
* Dyrcona |
has to go pick lunch up. |
| 12:33 |
Dyrcona |
Well, I found the commit, so I'll figure out what to do with it after lunch. |
| 12:37 |
|
RBecker joined #evergreen |
| 12:46 |
|
sandbergja joined #evergreen |
| 13:11 |
Dyrcona |
I think I just need to add the orgService to navcomponent.ts |
| 13:15 |
Dyrcona |
Cannot find name 'OrgService'. |
| 13:17 |
Dyrcona |
Missed the import.... |
| 13:19 |
Dyrcona |
Another layer of the onion: ERROR in src/app/staff/nav.component.ts(50,31): error TS2345: Argument of type '"circ.curbside"' is not assignable to parameter of type 'string[]'. |
| 13:22 |
Dyrcona |
Yeah, I don't get this one. |
| 13:22 |
Dyrcona |
Oh. Is it a bug in the original? |
| 13:25 |
Dyrcona |
Yeahp. Needed []. |
| 13:26 |
|
terranm joined #evergreen |
| 13:26 |
mrisher |
csharp: shelving location groups is ready for you again https://bugs.launchpad.net/evergreen/+bug/1852321 |
| 13:27 |
pinesol |
Launchpad bug 1852321 in Evergreen "Angular: Local Admin Shelving Location Groups Port" [Wishlist,Confirmed] |
| 13:31 |
pinesol |
[evergreen|Bill Erickson] LP1851882 Angular catalog recall/force/part holds - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=479402a> |
| 13:31 |
pinesol |
[evergreen|Bill Erickson] LP1851882 Relase Notes (Angular catalog hold types) - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e103b78> |
| 13:35 |
csharp |
mrisher: will take a look - thanks! |
| 13:38 |
csharp |
mrisher: loading now :-) |
| 13:38 |
csharp |
mrisher++ |
| 13:40 |
csharp |
@praise ng-build --watch |
| 13:40 |
* pinesol |
ng-build --watch is very kind and good-looking and always does what's best for the project |
| 13:43 |
Dyrcona |
@praise pg_cancel_backend |
| 13:43 |
* pinesol |
I come to praise pg_cancel_backend, not to bury them. |
| 13:43 |
Dyrcona |
Bleh. lame, pinesol. |
| 13:45 |
jeff |
pg_bury_backend |
| 13:45 |
Dyrcona |
jeff: The have that, almost: pg_terminate_backend |
| 13:46 |
Dyrcona |
It doesn't clean up the temp space, though. |
| 13:46 |
Dyrcona |
:) |
| 13:47 |
Dyrcona |
You gotta love it when someone runs a report that uses enough temp space to hold a full copy of the database. |
| 13:49 |
jeff |
Dyrcona: ah, a cartesian spring! |
| 13:49 |
Dyrcona |
jeff++ |
| 13:50 |
Dyrcona |
Cartesian Friday! |
| 13:51 |
gmcharlt |
berick: were you considering 1851882 a true wishlist item or a functional regression? |
| 13:55 |
berick |
gmcharlt: it's a regression |
| 13:56 |
gmcharlt |
OK, I'll mark the bug accordingly |
| 13:56 |
berick |
already done :) |
| 13:58 |
gmcharlt |
well, as there was no regression tag and the bug importance was wishlist, I've added the tag and changed the improtance |
| 13:59 |
berick |
ah, thanks, didn't think about the tag |
| 13:59 |
jeff |
I'll bet Tevye has thoughts on regression. |
| 14:13 |
Dyrcona |
If only Tevye were a rich man.... |
| 14:46 |
mmorgan |
csharp: Is there a reason why bug 1398107 didn't get a pullrequest? |
| 14:46 |
pinesol |
Launchpad bug 1398107 in Evergreen "No warning provided when bib records with holds are deleted" [High,Confirmed] https://launchpad.net/bugs/1398107 - Assigned to Chris Sharp (chrissharp123) |
| 14:47 |
pinesol |
[evergreen|Andrea Buntz Neiman] Docs: 3.6 release notes update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2241632> |
| 14:51 |
|
rfrasur joined #evergreen |
| 14:52 |
|
jvwoolf joined #evergreen |
| 14:57 |
nfburton |
That reminded me to putt a pullrequest tag on 1895398. If anyone has a chance to test and signoff |
| 15:04 |
csharp |
mmorgan: yes - it's busted and I haven't had a chance to get back to it |
| 15:04 |
csharp |
so not ready for a pullrequest :-) |
| 15:05 |
mmorgan |
Ok, thanks. |
| 15:05 |
* mmorgan |
was a little excited seeing a branch at all! |
| 15:05 |
mmorgan |
csharp++ |
| 15:06 |
csharp |
yeah, I put together something that I thought would work, but tlittle and I couldn't get it working |
| 15:06 |
csharp |
maybe something for the hackaway if I can find the time |
| 15:26 |
|
nfburton_ joined #evergreen |
| 15:29 |
pinesol |
[evergreen|Andrea Buntz Neiman] Docs: more 3.6 release notes updates - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=71b0f03> |
| 15:35 |
|
jvwoolf left #evergreen |
| 16:01 |
|
terranm joined #evergreen |
| 16:35 |
terranm |
berick: I'll refresh terran-master and put 1889128 on it |
| 16:36 |
berick |
thanks terranm! |
| 16:57 |
* mmorgan |
will be happy to test bug 1889128 when terran-master is refreshed. |
| 16:57 |
pinesol |
Launchpad bug 1889128 in Evergreen "Angular Staff Catalog: Place Another Hold & Multi-Holds" [Undecided,Confirmed] https://launchpad.net/bugs/1889128 |
| 17:03 |
terranm |
berick: mmorgan: it's on terran-master now - I ran into several merge conflicts so hopefully I resolved them properly |
| 17:04 |
mmorgan |
terranm++ |
| 17:06 |
terranm |
hrrm, it's working worse now, so I probably did something wrong while installing |
| 17:07 |
berick |
i can rebase it to master |
| 17:13 |
berick |
rich with conflict, this one is |
| 17:14 |
mmorgan |
terranm: in what way is it working worse? |
| 17:15 |
terranm |
mmorgan: right now it's not refreshing the screen when a new patron barcode is entered |
| 17:15 |
terranm |
berick: thanks, I'll be happy to try applying again after the rebase. |
| 17:17 |
terranm |
mmorgan: I'm going to refresh it to master again pending the rebase |
| 17:17 |
mmorgan |
ok, sounds good! |
| 17:24 |
berick |
doing some quick tests of my rebase |
| 17:25 |
|
sandbergja joined #evergreen |
| 17:28 |
berick |
terranm: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1887429-lp1889128-hold-prefs-and-multi-v2 |
| 17:40 |
* mmorgan |
needs to hang up bug squashing galoshes for the day, but will give it a test when it's available. |
| 17:40 |
berick |
mmorgan++ |
| 17:40 |
mmorgan |
berick++ |
| 17:40 |
|
mmorgan left #evergreen |
| 17:46 |
terranm |
mmorgan++ |
| 17:47 |
terranm |
berick: Okay, no merge conflicts now, but I'm getting errors when I try to place a hold: ctx_r26.holdMeta.parts is undefined |
| 17:49 |
berick |
terranm: hm, did you also apply the perl updates? |
| 17:49 |
terranm |
Oh no, I missed those... looking... |
| 17:52 |
terranm |
berick: I'm not seeing perl updates |
| 17:52 |
berick |
terranm: are you using a up-to-date master? |
| 17:53 |
berick |
i think that might be from a commit from earlier today |
| 17:53 |
berick |
the part holds stuff |
| 17:53 |
terranm |
Hmm. I ran the update-to-master script that csharp built for me right before applying this, so it should be up to date, but I may have done something wrong |
| 17:54 |
terranm |
Is this the one? https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=479402aeec518f7b9377c646a7379113604e7e21 |
| 17:54 |
pinesol |
terranm: [evergreen|Bill Erickson] LP1851882 Angular catalog recall/force/part holds - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=479402a> |
| 17:55 |
berick |
yep |
| 17:55 |
terranm |
Okay, let me add that in case the script didn't get it |
| 17:58 |
berick |
this is the change in question that would cause that error if it were not deployed: |
| 17:58 |
berick |
https://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm;h=25f26334877e426524be9fb5d94ac574a92f65f9;hp=11c29f8914083abaa4dc2480e56fbef46ad6d84d;hb=479402aeec518f7b9377c646a7379113604e7e21;hpb=2002181c83f0cab35b5a230c504b0d9bd7b0d840 |
| 17:58 |
pinesol |
berick: [evergreen|Bill Erickson] LP1851882 Angular catalog recall/force/part holds - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=479402a> |
| 17:58 |
pinesol |
berick: [evergreen|Chris Sharp] account for race condition in courses live test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2002181> |
| 18:00 |
pinesol |
News from qatests: Failed Log Output: osrfsys.log <http://testing.evergreen-ils.org/~live//archive/2020-09/2020-09-25_16:00:02/test.78.html> |
| 18:02 |
|
nfburton_ joined #evergreen |
| 18:02 |
|
nfburton__ joined #evergreen |
| 18:03 |
|
nfburton___ joined #evergreen |
| 18:06 |
terranm |
berick: yes, that was it, thanks! |
| 18:10 |
berick |
stepping away. terranm++ |
| 18:10 |
terranm |
berick: at first glance, it looks like that resolves it |
| 18:10 |
terranm |
berick++ |
| 18:10 |
terranm |
seeing spots, so I'm off now too |
| 18:13 |
|
dbwells joined #evergreen |
| 18:29 |
|
dbwells_ joined #evergreen |
| 20:56 |
|
mrisher joined #evergreen |
| 20:58 |
|
mrisher joined #evergreen |
