| Time |
Nick |
Message |
| 03:50 |
|
rhamby joined #evergreen |
| 03:50 |
|
miker joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:29 |
|
rjackson_isl_hom joined #evergreen |
| 08:02 |
|
Dyrcona joined #evergreen |
| 08:15 |
|
alynn26 joined #evergreen |
| 08:21 |
|
mantis2 joined #evergreen |
| 08:35 |
|
rfrasur joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 09:11 |
|
sandbergja joined #evergreen |
| 09:45 |
gmcharlt |
berick: csharp: do you have any objection to bug 1884787 being merged now or would you prefer to hold off until 3.5.0 is out? |
| 09:45 |
pinesol |
Launchpad bug 1884787 in Evergreen 3.4 "moment-timezone > 0.5.28 breaks Angular build" [High,Confirmed] https://launchpad.net/bugs/1884787 |
| 09:59 |
berick |
gmcharlt: I would prefer now |
| 09:59 |
gmcharlt |
berick: OK, then it shall be now |
| 10:00 |
gmcharlt |
well, five minutes from now |
| 10:00 |
berick |
gmcharlt++ |
| 10:14 |
gmcharlt |
berick: for the 3.4 and 3.3 backports I'm tempted to just pin moment-timezone to 0.5.27 and call it a day. any objections? |
| 10:15 |
berick |
gmcharlt: no objections, sound sane |
| 10:32 |
gmcharlt |
ok, updated |
| 10:33 |
pinesol |
[evergreen|Galen Charlton] LP#1884787: bump up moment and moment-timezone - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0f0651a> |
| 10:33 |
pinesol |
[evergreen|Galen Charlton] LP#1884787: update package-lock.json - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e0483db> |
| 10:33 |
pinesol |
[evergreen|Galen Charlton] LP#1884787: update Angular staff client to work with momement-timezone >= 0.5.29 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0e7c313> |
| 10:33 |
pinesol |
[evergreen|Bill Erickson] LP1884787 ng lint and unit test repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=056306f> |
| 10:35 |
Dyrcona |
Action trigger doesn't work so well when you have 1.4 million pending events of a single type. |
| 10:35 |
Dyrcona |
Or, even 1.4 million pending events. |
| 10:38 |
berick |
yeah, i'm expecting some fun times ahead w/ A/T backlog |
| 10:39 |
Dyrcona |
We have most of the events set to inactive in production, right now. |
| 10:39 |
Dyrcona |
I was messing around on training where some things haven't been done. |
| 11:15 |
mmorgan |
Dyrcona: So have events been getting created, but not processed? Or you expect to get that many created when you crank things up? |
| 11:19 |
Dyrcona |
mmorgan: Neither, actually. I enabled our daily action trigger runner so that we could test something with auto-renewals, and I didn't check what other events would fire and how many events would be created. |
| 11:26 |
mmorgan |
gotcha |
| 11:29 |
Dyrcona |
Training data is also out of date by over a month, so there will be more of some events created than normal. |
| 11:30 |
|
sandbergja joined #evergreen |
| 11:47 |
Dyrcona |
I'm a bit perplexed because I can't figure out how that came up with 1.4 million, now. I only about 71,000 when I try the delay values in SQL queries. |
| 11:49 |
jeff |
hrm. a naive usr % 6 to break up the holds pull list was giving good results, but today's for a given department was about 1/10 instead of about 1/6. Guess I should have experimented with something involving a hash function in the mix. :-) |
| 12:11 |
|
sandbergja joined #evergreen |
| 12:19 |
sandbergja |
berick: I was looking at eg2/src/app/staff/admin/basic-admin-page.component.ts, and was thinking about refactoring it to use the observables version of ActivatedRoute (e.g. this.route.data.subscribe) |
| 12:19 |
sandbergja |
Right now it is digging around in this.route.snapshot in a variety of ways |
| 12:20 |
sandbergja |
(I think I introduced some of the weirdest ways at getting at that data) |
| 12:20 |
sandbergja |
Does that seem reasonable? Are there reasons to keep using the snapshot? |
| 12:22 |
berick |
sandbergja: obvservable would be great, just beware it may a bigger job than just changing how it reacts to route changes. |
| 12:23 |
berick |
some of the components it uses under the covers may also have to be taught to handle @Input data changes |
| 12:23 |
berick |
this came up recently with https://bugs.launchpad.net/evergreen/+bug/1847800/comments/6 |
| 12:23 |
pinesol |
Launchpad bug 1847800 in Evergreen "Missing links to secondary admin pages" [High,Fix committed] |
| 12:24 |
berick |
grids and fm-editors don't watch for idlClass changes, for example |
| 12:25 |
sandbergja |
hahahaha so like all the most important stuff :-) |
| 12:25 |
berick |
one option could be to destroy and rebuild grids, fm-editors via an ngIf wrapper in the admin page |
| 12:25 |
berick |
so they are not required to react to changes |
| 12:26 |
sandbergja |
okay, I will give it a shot |
| 12:26 |
sandbergja |
berick++ |
| 12:31 |
berick |
sandbergja++ # if you get that working, we can speed up the admin page config_field links |
| 12:50 |
sandbergja |
berick: one more question about the routes |
| 12:50 |
sandbergja |
right now, this.route.data is an array of hashes |
| 12:50 |
sandbergja |
any reason that it is not just a hash? |
| 12:51 |
sandbergja |
(having to do data[0]['thing_i_want'] seems brittle and unintuitive to me) |
| 12:56 |
|
mrisher_ joined #evergreen |
| 12:56 |
|
mrisher_ joined #evergreen |
| 13:22 |
|
khuckins joined #evergreen |
| 13:30 |
|
sandbergja_ joined #evergreen |
| 13:43 |
|
jihpringle joined #evergreen |
| 14:58 |
|
miker joined #evergreen |
| 14:58 |
|
akilsdonk joined #evergreen |
| 14:58 |
|
jweston joined #evergreen |
| 14:59 |
|
drigney joined #evergreen |
| 14:59 |
|
abneiman joined #evergreen |
| 14:59 |
|
phasefx_ joined #evergreen |
| 14:59 |
|
jgoodson joined #evergreen |
| 14:59 |
|
ericar joined #evergreen |
| 14:59 |
|
lbarry joined #evergreen |
| 14:59 |
|
felicia joined #evergreen |
| 15:00 |
|
rhamby joined #evergreen |
| 15:00 |
|
jyorio joined #evergreen |
| 15:17 |
|
mrisher joined #evergreen |
| 15:54 |
|
mantis2 left #evergreen |
| 16:04 |
gmcharlt |
csharp: berick: I've put the 3.5.0-rc tarball through its paces and and confirm: |
| 16:04 |
gmcharlt |
1. successful installation |
| 16:05 |
gmcharlt |
2. functioning of AngularJS, Angular, and Dojo interfaces |
| 16:05 |
gmcharlt |
3. functioning of the new staff-side features |
| 16:06 |
gmcharlt |
4. clean version-upgade from a fresh 3.4.3 DB to 3.5.0 |
| 16:07 |
berick |
gmcharlt++ |
| 16:08 |
berick |
i'm hoping to build the final 3.5.0 tomorrow w/ today's Moment patches |
| 16:08 |
gmcharlt |
5. no apparent issues on spot checking various interfaces |
| 16:09 |
gmcharlt |
so not a full test of All The Things (tm), but nothing that blocks your building 3.5.0 tomorrow |
| 16:09 |
berick |
awesome |
| 16:12 |
|
phasefx_ joined #evergreen |
| 16:13 |
|
lisacarlucci joined #evergreen |
| 16:15 |
|
jyorio joined #evergreen |
| 17:02 |
|
rjackson_isl_hom joined #evergreen |
| 17:04 |
|
mrisher left #evergreen |
| 17:04 |
|
mrisher joined #evergreen |
| 17:45 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:02 |
|
dbwells joined #evergreen |
| 18:26 |
|
rjackson_isl_hom joined #evergreen |
| 18:30 |
Bmagic |
Double checking: it's ok to truncate metabib.browse_entry; truncate metabib.browse_entry_def_map; with a reingest after? |
| 18:31 |
Bmagic |
reverse those two sql statements probably |
| 20:29 |
|
Dyrcona joined #evergreen |
